Re: [edk2-devel] [PATCH 0/3] BaseTools,EmbeddedPkg,Maintainers.txt: Obsolete some drivers

2020-04-30 Thread Leif Lindholm
On Thu, Apr 30, 2020 at 15:43:22 +0200, Ard Biesheuvel wrote: > > > > > Thinking a bit more on this, maybe what we should do is add a template > > > > > to each file's top comment block. Draft proposal: > > > > > > > > > >    * > > > > >    * WARNING: > > > > >    * This driver fails to follow

Re: [edk2-devel] [PATCH 0/3] BaseTools,EmbeddedPkg,Maintainers.txt: Obsolete some drivers

2020-04-30 Thread Ard Biesheuvel
On 4/30/20 3:28 PM, Leif Lindholm wrote: On Thu, Apr 30, 2020 at 13:17:26 +0200, Laszlo Ersek wrote: On 04/29/20 23:47, Ard Biesheuvel wrote: On 4/29/20 11:45 PM, Leif Lindholm wrote: On Wed, Apr 29, 2020 at 22:04:08 +0200, Ard Biesheuvel wrote: I am mostly concerned about the use of MmcDxe i

Re: [edk2-devel] [PATCH 0/3] BaseTools,EmbeddedPkg,Maintainers.txt: Obsolete some drivers

2020-04-30 Thread Leif Lindholm
On Thu, Apr 30, 2020 at 13:17:26 +0200, Laszlo Ersek wrote: > On 04/29/20 23:47, Ard Biesheuvel wrote: > > On 4/29/20 11:45 PM, Leif Lindholm wrote: > >> On Wed, Apr 29, 2020 at 22:04:08 +0200, Ard Biesheuvel wrote: > > I am mostly concerned about the use of MmcDxe in new platforms. The > >

Re: [edk2-devel] [PATCH 0/3] BaseTools,EmbeddedPkg,Maintainers.txt: Obsolete some drivers

2020-04-30 Thread Laszlo Ersek
On 04/29/20 23:47, Ard Biesheuvel wrote: > On 4/29/20 11:45 PM, Leif Lindholm wrote: >> On Wed, Apr 29, 2020 at 22:04:08 +0200, Ard Biesheuvel wrote: > I am mostly concerned about the use of MmcDxe in new platforms. The > other > bits I'm not too worried about, and I think it would be f

Re: [edk2-devel] [PATCH 0/3] BaseTools,EmbeddedPkg,Maintainers.txt: Obsolete some drivers

2020-04-29 Thread Ard Biesheuvel
On 4/29/20 11:45 PM, Leif Lindholm wrote: On Wed, Apr 29, 2020 at 22:04:08 +0200, Ard Biesheuvel wrote: I am mostly concerned about the use of MmcDxe in new platforms. The other bits I'm not too worried about, and I think it would be fine to move those into Platform/ARM/VExpressPkg in edk2-platf

Re: [edk2-devel] [PATCH 0/3] BaseTools,EmbeddedPkg,Maintainers.txt: Obsolete some drivers

2020-04-29 Thread Leif Lindholm
On Wed, Apr 29, 2020 at 22:04:08 +0200, Ard Biesheuvel wrote: > > > I am mostly concerned about the use of MmcDxe in new platforms. The other > > > bits I'm not too worried about, and I think it would be fine to move those > > > into Platform/ARM/VExpressPkg in edk2-platforms, instead of hoping tha

Re: [edk2-devel] [PATCH 0/3] BaseTools,EmbeddedPkg,Maintainers.txt: Obsolete some drivers

2020-04-29 Thread Andrei Warkentin
Btw, the Raspberry Pi support has its own variant of MmcDxe and SD host drivers... the history behind that is that's the way it was in the original MSFT port circa 2016. When I had rebased that code to 2018 edk2 (still before Pete's work to upstream it here), the edk2 variant had significantly dive

Re: [edk2-devel] [PATCH 0/3] BaseTools,EmbeddedPkg,Maintainers.txt: Obsolete some drivers

2020-04-29 Thread Ard Biesheuvel
On 4/29/20 9:53 PM, Leif Lindholm wrote: On Wed, Apr 29, 2020 at 19:51:12 +0200, Ard Biesheuvel wrote: On 4/29/20 6:36 PM, Leif Lindholm wrote: We keep seeing new users (and copies) of EmbeddedPkg:s MmcDxe, which while it predates the MdeModulePkg SD/(E)MMCsupport is in effect unmaintained and

Re: [edk2-devel] [PATCH 0/3] BaseTools,EmbeddedPkg,Maintainers.txt: Obsolete some drivers

2020-04-29 Thread Leif Lindholm
On Wed, Apr 29, 2020 at 19:51:12 +0200, Ard Biesheuvel wrote: > On 4/29/20 6:36 PM, Leif Lindholm wrote: > > We keep seeing new users (and copies) of EmbeddedPkg:s MmcDxe, which > > while it predates the MdeModulePkg SD/(E)MMCsupport is in effect > > unmaintained and also duplicates core industry s

Re: [edk2-devel] [PATCH 0/3] BaseTools,EmbeddedPkg,Maintainers.txt: Obsolete some drivers

2020-04-29 Thread Ard Biesheuvel
On 4/29/20 6:36 PM, Leif Lindholm wrote: We keep seeing new users (and copies) of EmbeddedPkg:s MmcDxe, which while it predates the MdeModulePkg SD/(E)MMCsupport is in effect unmaintained and also duplicates core industry standard definitions. Since we now have GetMaintainers.py to parse Maintai

[edk2-devel] [PATCH 0/3] BaseTools,EmbeddedPkg,Maintainers.txt: Obsolete some drivers

2020-04-29 Thread Leif Lindholm
We keep seeing new users (and copies) of EmbeddedPkg:s MmcDxe, which while it predates the MdeModulePkg SD/(E)MMCsupport is in effect unmaintained and also duplicates core industry standard definitions. Since we now have GetMaintainers.py to parse Maintainers.txt for us, extend its functionality t