Re: [edk2-devel] [PATCH 0/3] use XHCI to replace EHCI

2023-09-04 Thread Yuquan Wang
On 2023-09-05 14:30, marcin.juszkiewicz wrote: Project is meant to be buildable at every commit. Your patchset breaks that rule. Oh! I get it ! I did not consider this principle when designing these patches. Thanks for your explanation : ) I am going to recheck and combine some content toge

Re: [edk2-devel] [PATCH 0/3] use XHCI to replace EHCI

2023-09-04 Thread Marcin Juszkiewicz
W dniu 5.09.2023 o 08:11, Yuquan Wang pisze: Hi, Leif On 2023-09-04 21:51,  quic_llindhol wrote: > > However, this version still breaks bisect: attempting to build at 1/3 > or 2/3 leads to: > --- > /work/git/edk2-platforms/Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf(72): > error 3000:

Re: [edk2-devel] [PATCH 0/3] use XHCI to replace EHCI

2023-09-04 Thread Yuquan Wang
Hi, Leif On 2023-09-04 21:51, quic_llindhol wrote: > > However, this version still breaks bisect: attempting to build at 1/3 > or 2/3 leads to: > --- > /work/git/edk2-platforms/Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf(72): > error 3000: PCD > [gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdPlat

Re: [edk2-devel] [PATCH 0/3] use XHCI to replace EHCI

2023-09-04 Thread Leif Lindholm
Hi Yuquan, On Mon, Sep 04, 2023 at 14:30:57 +0800, Yuquan Wang wrote: > Hi, Leif > On 2023-08-31 21:06, Leif wrote: > > I had to move one hunk (.dec change) from 2/3 to 1/3 in order to > not break bisect. > > If you're happy with the slightly modified version, I think this > is good to go in.

Re: [edk2-devel] [PATCH 0/3] use XHCI to replace EHCI

2023-09-03 Thread Yuquan Wang
Hi, Leif On 2023-08-31 21:06, Leif wrote: I had to move one hunk (.dec change) from 2/3 to 1/3 in order to not break bisect. If you're happy with the slightly modified version, I think this is good to go in. Please let me know. It' ok. In the second version of this series patches, in fact,

Re: [edk2-devel] [PATCH 0/3] use XHCI to replace EHCI

2023-08-31 Thread Ard Biesheuvel
On Thu, 31 Aug 2023 at 15:06, Leif Lindholm wrote: > > Hi, > > Apologies for the long delay reviewing this set. > > I have rebased your patches onto: > https://github.com/leiflindholm/edk2-platforms/tree/sbsa-xhci > > I had to move one hunk (.dec change) from 2/3 to 1/3 in order to > not break bis

Re: [edk2-devel] [PATCH 0/3] use XHCI to replace EHCI

2023-08-31 Thread Leif Lindholm
Hi, Apologies for the long delay reviewing this set. I have rebased your patches onto: https://github.com/leiflindholm/edk2-platforms/tree/sbsa-xhci I had to move one hunk (.dec change) from 2/3 to 1/3 in order to not break bisect. If you're happy with the slightly modified version, I think thi

Re: [edk2-devel] [PATCH 0/3] use XHCI to replace EHCI

2023-06-05 Thread Leif Lindholm
On 2023-06-05 11:51, Ard Biesheuvel wrote: On Mon, 5 Jun 2023 at 12:50, Yuquan Wang wrote: This patchset implements XHCI on sbsa-ref board to replace EHCI. As sbsa-ref does not have DRAM below 4G, it cannot utilize EHCI that only has 32-bit DMA capablity. Now this board has XHCI as an availabl

Re: [edk2-devel] [PATCH 0/3] use XHCI to replace EHCI

2023-06-05 Thread wangyuquan1236
Yes, at the third time I found I need to subscribe this channel, so I succeeded. Now, I can send the patch normally. Thanks for your guidance. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105717): https://edk2.groups.io/g/devel/message

Re: [edk2-devel] [PATCH 0/3] use XHCI to replace EHCI

2023-06-05 Thread wangyuquan1236
Sorry for my awkward operations, because I felt the email refused problem with devel@edk2.groups.io; ( devel@edk2.groups.io, ) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105716): https://edk2.groups.io/g/devel/message/105716 Mute Thi

[edk2-devel] [PATCH 0/3] use XHCI to replace EHCI

2023-06-05 Thread wangyuquan1236
This patchset implements XHCI on sbsa-ref board to replace EHCI. As sbsa-ref does not have DRAM below 4G, it cannot utilize EHCI that only has 32-bit DMA capablity. Now this board has XHCI as an available usb controller with 64-bit DMA capablity. Yuquan Wang (3): Platform/Qemu/SbsaQemu/SbsaQe

Re: [edk2-devel] [PATCH 0/3] use XHCI to replace EHCI

2023-06-05 Thread Ard Biesheuvel
On Mon, 5 Jun 2023 at 12:53, wangyuquan1236 wrote: > > Sorry for my awkward operations, because I felt the email refused problem > with devel@edk2.groups.io; Are you subscribed to the mailing list? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply

Re: [edk2-devel] [PATCH 0/3] use XHCI to replace EHCI

2023-06-05 Thread Ard Biesheuvel
On Mon, 5 Jun 2023 at 12:50, Yuquan Wang wrote: > > This patchset implements XHCI on sbsa-ref board to replace EHCI. > As sbsa-ref does not have DRAM below 4G, it cannot utilize EHCI > that only has 32-bit DMA capablity. Now this board has XHCI as > an available usb controller with 64-bit DMA capa