Re: [edk2-devel] [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external symbol issue

2024-02-22 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Thanks! Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, February 22, 2024 5:16 PM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Igor Kulchytskyy ; Nick Ramirez > Subject: RE: [PATCH 6/6] RedfishPkg/RedfishCrtLib:

Re: [edk2-devel] [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external symbol issue

2024-02-22 Thread Nickle Wang via groups.io
Hi Abner, Please check v2 patch. I add the source location of MathFtol.c Thanks, Nickle > -Original Message- > From: Chang, Abner > Sent: Wednesday, February 21, 2024 10:10 AM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Igor Kulchytskyy ; Nick Ramirez > Subject: RE: [PATCH 6/6]

Re: [edk2-devel] [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external symbol issue

2024-02-20 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] > -Original Message- > From: Nickle Wang > Sent: Tuesday, February 20, 2024 2:42 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external > symbol issue

[edk2-devel] [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external symbol issue

2024-02-19 Thread Nickle Wang via groups.io
-Fix below compiler error reported in edk2 CI. ERROR - Linker #2001 from JsonLib.lib(load.obj) : unresolved external symbol __ftol2 -The file MathFtol.c is copied from IntrinsicLib in CryptoPkg. -Add MathFtol.c to EccCheck IgnoreFiles. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor