On Thu, 14 Dec 2023 at 10:37, Mike Beaton wrote:
>
> > IOW, please don't send a v6 until the discussion comes to a conclusion.
>
> Apologies, I did _not_ see this before sending.
>
> > > - #if !defined (MDEPKG_NDEBUG)
> > > + #if defined (__CC_ARM) || defined (__GNUC__)
> >
> > No, this is not
> IOW, please don't send a v6 until the discussion comes to a conclusion.
Apologies, I did _not_ see this before sending.
> > - #if !defined (MDEPKG_NDEBUG)
> > + #if defined (__CC_ARM) || defined (__GNUC__)
>
> No, this is not going to be acceptable to me. You noted that only the
> ARM code
(cc Michael)
On Thu, 14 Dec 2023 at 08:58, Mike Beaton wrote:
>
> From: Mike Beaton
>
> The variant provided when MDEPKG_NDEBUG is defined will be optimised
> away in RELEASE builds, but by referencing the argument list, avoids
> unused variable errors from valid debug code, for example when
From: Mike Beaton
The variant provided when MDEPKG_NDEBUG is defined will be optimised
away in RELEASE builds, but by referencing the argument list, avoids
unused variable errors from valid debug code, for example when STATIC
variables are used only in DEBUG statements.
Variable EventNames in