Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector

2021-10-07 Thread Yao, Jiewen
To: Xu, Min M ; devel@edk2.groups.io; kra...@redhat.com; Yao, Jiewen Cc: Ard Biesheuvel ; Justen, Jordan L ; Erdem Aktas ; James Bottomley ; Lendacky, Thomas Subject: Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector [AMD Official Use Only] Yes, I will try to make it work

Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector

2021-09-30 Thread Brijesh Singh via groups.io
com Cc: Yao, Jiewen ; Ard Biesheuvel ; Justen, Jordan L ; Erdem Aktas ; James Bottomley ; Lendacky, Thomas Subject: Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector [AMD Official Use Only] May I ask to use the OvmfMetadata instead of the of TdxMetadata for the Guided str

Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector

2021-09-30 Thread Min Xu
; James Bottomley ; Lendacky, Thomas Subject: Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector [AMD Official Use Only] May I ask to use the OvmfMetadata instead of the of TdxMetadata for the Guided structure name label (same as what I did in SNP series patch #4). If you can

Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector

2021-09-28 Thread Brijesh Singh via groups.io
; Lendacky, Thomas Subject: RE: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector On September 28, 2021 12:43 PM, Gerd Hoffmann wrote: > Hi, > > > > Can you move the metadata changes to a separate patch please? > > Yes, the metadata changes will be in a separate patc

Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector

2021-09-28 Thread Min Xu
On September 28, 2021 12:43 PM, Gerd Hoffmann wrote: > Hi, > > > > Can you move the metadata changes to a separate patch please? > > Yes, the metadata changes will be in a separate patch in the next version. > > Can you also add a comment block documenting the format? Not only those > parts

Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector

2021-09-27 Thread Gerd Hoffmann
Hi, > > Can you move the metadata changes to a separate patch please? > Yes, the metadata changes will be in a separate patch in the next version. Can you also add a comment block documenting the format? Not only those parts which are used for TDVF, but everything? The description in

Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector

2021-09-27 Thread Min Xu
On September 27, 2021 4:43 PM, Gerd Hoffmann wrote: > Hi, > > > +_Bfv: > > + DD TDX_BFV_RAW_DATA_OFFSET > > + DD TDX_BFV_RAW_DATA_SIZE > > + DQ TDX_BFV_MEMORY_BASE > > + DQ TDX_BFV_MEMORY_SIZE > > + DD TDX_METADATA_SECTION_TYPE_BFV > > + DD TDX_METADATA_ATTRIBUTES_EXTENDMR > > Size is

Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector

2021-09-27 Thread Gerd Hoffmann
Hi, > +_Bfv: > + DD TDX_BFV_RAW_DATA_OFFSET > + DD TDX_BFV_RAW_DATA_SIZE > + DQ TDX_BFV_MEMORY_BASE > + DQ TDX_BFV_MEMORY_SIZE > + DD TDX_METADATA_SECTION_TYPE_BFV > + DD TDX_METADATA_ATTRIBUTES_EXTENDMR Size is still added twice, doesn't make sense given that they are either equal or

[edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector

2021-09-26 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Intel's Trust Domain Extensions (Intel TDX) refers to an Intel technology that extends Virtual Machines Extensions (VMX) and Multi-Key Total Memory Encryption (MKTME) with a new kind of virutal machines guest called a Trust Domain (TD). A