Re: [edk2-devel] [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3

2024-06-03 Thread Michael Kubacki
As a follow up, I created the following PR to specify the exact version of queries to use for a given CodeQL CLI release. Now that both are explicitly specified (the CLI and the query version), there should not be any mismatch in the future where we're using an older CodeQL CLI against the

Re: [edk2-devel] [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3

2024-05-20 Thread Michael D Kinney
Merged. https://github.com/tianocore/edk2/pull/5667 Mike > -Original Message- > From: Michael Kubacki > Sent: Monday, May 20, 2024 6:41 PM > To: Kinney, Michael D ; devel@edk2.groups.io; > Andrew Fish ; Leif Lindholm ; > Liming Gao > Cc: Feng, Bob C ; Joey Vagedes > ; Rebecca Cran ;

Re: [edk2-devel] [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3

2024-05-20 Thread Michael Kubacki
Just wanted to send a reminder that I recommend https://github.com/tianocore/edk2/pull/5667 be merged to unblock CI for those that are currently trying to test changes. Thanks, Michael On 5/17/2024 8:10 PM, Kinney, Michael D wrote: Approved. I agree there is no impact to FW. Mike

Re: [edk2-devel] [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3

2024-05-17 Thread Michael D Kinney
Approved. I agree there is no impact to FW. Mike > -Original Message- > From: Michael Kubacki > Sent: Friday, May 17, 2024 4:28 PM > To: Kinney, Michael D ; devel@edk2.groups.io; > Andrew Fish ; Leif Lindholm ; > Liming Gao > Cc: Feng, Bob C ; Joey Vagedes > ; Rebecca Cran ; Sean

Re: [edk2-devel] [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3

2024-05-17 Thread Michael Kubacki
Forgot about the hard freeze. Added remaining stewards to consider merging this. It has no impact on firmware but is needed to unblock an immediate issue in CI where the CodeQL queries being fetched are newer and incompatible with the CodeQL CLI being used. As I mentioned in the release

Re: [edk2-devel] [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3

2024-05-17 Thread Michael Kubacki
To ensure CI is unblocked, I am going to add the push tag now. On 5/17/2024 6:31 PM, Michael Kubacki wrote: Thanks Mike. Are you okay with me completing the PR now? On 5/17/2024 5:31 PM, Kinney, Michael D wrote: Reviewed-by: Michael D Kinney -Original Message- From:

Re: [edk2-devel] [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3

2024-05-17 Thread Michael Kubacki
Thanks Mike. Are you okay with me completing the PR now? On 5/17/2024 5:31 PM, Kinney, Michael D wrote: Reviewed-by: Michael D Kinney -Original Message- From: mikub...@linux.microsoft.com Sent: Friday, May 17, 2024 2:09 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Joey Vagedes ;

Re: [edk2-devel] [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3

2024-05-17 Thread Joey Vagedes via groups.io
Reviewed-by: Joey Vagedes -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119060): https://edk2.groups.io/g/devel/message/119060 Mute This Topic: https://groups.io/mt/106161774/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3

2024-05-17 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Friday, May 17, 2024 2:09 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Joey Vagedes > ; Liming Gao ; Kinney, > Michael D ; Rebecca Cran ; > Sean Brogan ; Chen, Christine > > Subject:

[edk2-devel] [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3

2024-05-17 Thread Michael Kubacki
From: Michael Kubacki This fixes an issue where the CodeQL queries currently fetched in the pipeline are incompatible with the current executable used. Update to pick up functional and security fixes. See the following comparison for detailed differences: