Hi Shenglei,
Your explanation makes sense.
Reviewed-by: Nate DeSimone
Thanks,
Nate
-Original Message-
From: Zhang, Shenglei
Sent: Monday, September 16, 2019 7:48 PM
To: Desimone, Nathaniel L ; devel@edk2.groups.io
Cc: Kubacki, Michael A ; Chiu, Chasel
; Gao, Liming
Subject: RE:
Hi Nathaniel,
Thanks for your comments and below is my response.
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Tuesday, September 17, 2019 3:25 AM
> To: Zhang, Shenglei ; devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Gao, Liming
> Subject: RE: [PATCH v2]
Hi Shenglei,
I don't see how this patch is at all related to the previous version of this
patch. Also, you are introducing yet another new bug with this patch. Moreover,
this bug is unrelated to the previous bug.
Please take a look at the function TestPointGetAcpi(). With your change added,
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Zhang, Shenglei
> Sent: Monday, September 16, 2019 9:09 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming
> Subject: [PATCH v2] MinPlatformPkg/TestPointCheckLib: Add
Currently there is no check for the parameter OutTable.
So add the logic that return value EFI_INVALID_PARAMETER when the
OutTable is NULL.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
v2:Update the copyright and the if...else
