Re: [edk2-devel] [Patch 3/4] BaseTools/Scripts/PatchCheck: Error if no Cc tags are present

2024-02-21 Thread Ard Biesheuvel
On Wed, 21 Feb 2024 at 23:16, Laszlo Ersek wrote: > > On 2/20/24 15:48, Ard Biesheuvel wrote: > > Hello Mike, > > > > I understand the desire to be pedantic about cc'ing the right > > maintainers, but I'm not convinced this is the way. > > > > - the presence of a cc: tag does not guarantee that

Re: [edk2-devel] [Patch 3/4] BaseTools/Scripts/PatchCheck: Error if no Cc tags are present

2024-02-21 Thread Laszlo Ersek
On 2/20/24 15:48, Ard Biesheuvel wrote: > Hello Mike, > > I understand the desire to be pedantic about cc'ing the right > maintainers, but I'm not convinced this is the way. > > - the presence of a cc: tag does not guarantee that the person was > cc'ed - only git send-email will take CC:s in the

Re: [edk2-devel] [Patch 3/4] BaseTools/Scripts/PatchCheck: Error if no Cc tags are present

2024-02-20 Thread Michael D Kinney
istine ; Michael Kubacki > > Subject: Re: [edk2-devel] [Patch 3/4] BaseTools/Scripts/PatchCheck: > Error if no Cc tags are present > > Hello Mike, > > I understand the desire to be pedantic about cc'ing the right > maintainers, but I'm not convinced this is the way. >

Re: [edk2-devel] [Patch 3/4] BaseTools/Scripts/PatchCheck: Error if no Cc tags are present

2024-02-20 Thread Ard Biesheuvel
Hello Mike, I understand the desire to be pedantic about cc'ing the right maintainers, but I'm not convinced this is the way. - the presence of a cc: tag does not guarantee that the person was cc'ed - only git send-email will take CC:s in the message body into account by default (but this can

[edk2-devel] [Patch 3/4] BaseTools/Scripts/PatchCheck: Error if no Cc tags are present

2024-02-18 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4694 If no Cc tags are detected in a commit message, then generate an error. All patches sent for review are required to provide the set of maintainers and reviewers responsible for the directories/files modified. The set of maintainers and