Re: [edk2-devel] [Patch V2 0/2] Let AcpiTableDxe driver install Acpi table from Hob

2021-03-25 Thread Laszlo Ersek
On 03/25/21 04:55, Andrew Fish wrote: > Ray, > > The other option would be to define a Library Class for the AcpiTableDxe > driver to consume and have a NULL version of it in the MdeModulePkg. That > would allow more flexibility? It kind of depends if you want to make the > implementation depen

Re: [edk2-devel] [Patch V2 0/2] Let AcpiTableDxe driver install Acpi table from Hob

2021-03-25 Thread Laszlo Ersek
ume the ACPI table in > SYSTEM_TABLE_INFO. Same compatibility question for existent, dependent platforms. Thanks Laszlo > > >> -Original Message----- >> From: devel@edk2.groups.io On Behalf Of Laszlo Ersek >> Sent: Thursday, March 25, 2021 2:33 AM >>

Re: [edk2-devel] [Patch V2 0/2] Let AcpiTableDxe driver install Acpi table from Hob

2021-03-24 Thread Andrew Fish via groups.io
eSize. > 4. Remove the BlSupportDxe code that consume the ACPI table in > SYSTEM_TABLE_INFO. > > >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of Laszlo Ersek >> Sent: Thursday, March 25, 2021 2:33 AM >> To: Benjamin Doron ; devel@edk2.groups

Re: [edk2-devel] [Patch V2 0/2] Let AcpiTableDxe driver install Acpi table from Hob

2021-03-24 Thread Benjamin Doron
On Wed, Mar 24, 2021 at 02:33 PM, Laszlo Ersek wrote: > > >> >>> Hi all, Would it be acceptable/feasible for AcpiTableDxe or AcpiPlatformDxe (in MdeModulePkg) to use `EfiGetSystemConfigurationTable` to get the RSDP and then install the tables? It's a solution that uses the

Re: [edk2-devel] [Patch V2 0/2] Let AcpiTableDxe driver install Acpi table from Hob

2021-03-24 Thread Ni, Ray
ACPI table in SYSTEM_TABLE_INFO. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Thursday, March 25, 2021 2:33 AM > To: Benjamin Doron ; devel@edk2.groups.io > Subject: Re: [edk2-devel] [Patch V2 0/2] Let AcpiTableDxe driver install Ac

Re: [edk2-devel] [Patch V2 0/2] Let AcpiTableDxe driver install Acpi table from Hob

2021-03-24 Thread Laszlo Ersek
On 03/24/21 17:55, Benjamin Doron wrote: >> >> >>> Hi all, >>> Would it be acceptable/feasible for AcpiTableDxe or AcpiPlatformDxe (in >>> MdeModulePkg) to use `EfiGetSystemConfigurationTable` to get the RSDP >>> and then install the tables? It's a solution that uses the regular >>> UefiLib, so it

Re: [edk2-devel] [Patch V2 0/2] Let AcpiTableDxe driver install Acpi table from Hob

2021-03-24 Thread Benjamin Doron
> > >> Hi all, >> Would it be acceptable/feasible for AcpiTableDxe or AcpiPlatformDxe (in >> MdeModulePkg) to use `EfiGetSystemConfigurationTable` to get the RSDP >> and then install the tables? It's a solution that uses the regular >> UefiLib, so it avoids platform-specific quirks (and as I see

Re: [edk2-devel] [Patch V2 0/2] Let AcpiTableDxe driver install Acpi table from Hob

2021-03-24 Thread Benjamin Doron
Hi all, Would it be acceptable/feasible for AcpiTableDxe or AcpiPlatformDxe (in MdeModulePkg) to use `EfiGetSystemConfigurationTable` to get the RSDP and then install the tables? It's a solution that uses the regular UefiLib, so it avoids platform-specific quirks (and as I see it, if RSDP is in

Re: [edk2-devel] [Patch V2 0/2] Let AcpiTableDxe driver install Acpi table from Hob

2021-03-24 Thread Laszlo Ersek
On 03/24/21 05:09, Ni, Ray wrote: >> >> (1) Currently, BlSupportDxe expects the ACPI content to come from >> "SYSTEM_TABLE_INFO.AcpiTableBase" >> [Include/Guid/SystemTableInfoGuid.h]. >> That header file is at least *moderately* documented (it's better than >> nothing). Additionally, BlSupportDxe i

Re: [edk2-devel] [Patch V2 0/2] Let AcpiTableDxe driver install Acpi table from Hob

2021-03-24 Thread Laszlo Ersek
On 03/24/21 00:52, Benjamin Doron wrote: > Hi all, > Would it be acceptable/feasible for AcpiTableDxe or AcpiPlatformDxe (in > MdeModulePkg) to use `EfiGetSystemConfigurationTable` to get the RSDP > and then install the tables? It's a solution that uses the regular > UefiLib, so it avoids platform-

Re: [edk2-devel] [Patch V2 0/2] Let AcpiTableDxe driver install Acpi table from Hob

2021-03-24 Thread Laszlo Ersek
>> Sent: Tuesday, March 23, 2021 9:48 AM >> To: devel@edk2.groups.io; Dong, Guo ; Liu, Zhiguang >> ; Ni, Ray >> Cc: Wang, Jian J ; Wu, Hao A ; >> Bi, Dandan ; Liming Gao ; >> Andrew Fish >> Subject: Re: [edk2-devel] [Patch V2 0/2] Let AcpiTab

Re: [edk2-devel] [Patch V2 0/2] Let AcpiTableDxe driver install Acpi table from Hob

2021-03-23 Thread Ni, Ray
A ; Bi, Dandan ; Liming Gao Subject: Re: [edk2-devel] [Patch V2 0/2] Let AcpiTableDxe driver install Acpi table from Hob My concern is gEfiAcpiTableGuid is owned by the UEFI Spec and any off label usage should probably be defined by the PI Spec. Is this a code 1st proposal or just an implemen

Re: [edk2-devel] [Patch V2 0/2] Let AcpiTableDxe driver install Acpi table from Hob

2021-03-23 Thread Ni, Ray
> > (1) Currently, BlSupportDxe expects the ACPI content to come from > "SYSTEM_TABLE_INFO.AcpiTableBase" > [Include/Guid/SystemTableInfoGuid.h]. > That header file is at least *moderately* documented (it's better than > nothing). Additionally, BlSupportDxe is a DXE-phase component. > > The patch

Re: [edk2-devel] [Patch V2 0/2] Let AcpiTableDxe driver install Acpi table from Hob

2021-03-23 Thread Guo Dong
Fish Sent: Tuesday, March 23, 2021 9:13 AM To: edk2-devel-groups-io ; Dong, Guo Cc: ler...@redhat.com; Liu, Zhiguang ; Ni, Ray ; Wang, Jian J ; Wu, Hao A ; Bi, Dandan ; Liming Gao Subject: Re: [edk2-devel] [Patch V2 0/2] Let AcpiTableDxe driver install Acpi table from Hob My concern is gEfiAc

Re: [edk2-devel] [Patch V2 0/2] Let AcpiTableDxe driver install Acpi table from Hob

2021-03-23 Thread Guo Dong
uot; -- without > as much as a header file describing the actual contents of the new GUID HOB. > > (Meanwhile we argue for months about actual, proven spec breakage in > edk2, such as signaling ready to boot around recovery options or > whatever. Standardization matters as long as *you* n

Re: [edk2-devel] [Patch V2 0/2] Let AcpiTableDxe driver install Acpi table from Hob

2021-03-23 Thread Laszlo Ersek
From: devel@edk2.groups.io On Behalf Of Laszlo >> Ersek >> Sent: Tuesday, March 23, 2021 5:40 AM >> To: Liu, Zhiguang ; Ni, Ray ; Dong, >> Guo >> Cc: devel@edk2.groups.io; Wang, Jian J ; Wu, Hao A >> ; Bi, Dandan ; Liming Gao >> >> Subject: Re: [e

Re: [edk2-devel] [Patch V2 0/2] Let AcpiTableDxe driver install Acpi table from Hob

2021-03-23 Thread Andrew Fish via groups.io
intel.com>> >> Cc: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Wang, Jian J >> mailto:jian.j.w...@intel.com>>; Wu, Hao A >> mailto:hao.a...@intel.com>>; Bi, Dandan >> mailto:dandan...@intel.com>>; Liming Gao >> mailto:gaolim...@byosoft.com.cn&

Re: [edk2-devel] [Patch V2 0/2] Let AcpiTableDxe driver install Acpi table from Hob

2021-03-23 Thread Guo Dong
, Zhiguang ; Ni, Ray ; Dong, > Guo > Cc: devel@edk2.groups.io; Wang, Jian J ; Wu, Hao A > ; Bi, Dandan ; Liming Gao > > Subject: Re: [edk2-devel] [Patch V2 0/2] Let AcpiTableDxe driver install Acpi > table from Hob > > On 03/23/21 04:24, Zhiguang Liu wrote: > >

Re: [edk2-devel] [Patch V2 0/2] Let AcpiTableDxe driver install Acpi table from Hob

2021-03-23 Thread Laszlo Ersek
On 03/23/21 04:24, Zhiguang Liu wrote: > If HOB contains APCI table information, entry point of AcpiTableDxe.inf > should parse the APCI table from HOB, and install these tables. > We assume the whole ACPI table (starting with > EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER) > is contained by a sin

[edk2-devel] [Patch V2 0/2] Let AcpiTableDxe driver install Acpi table from Hob

2021-03-22 Thread Zhiguang Liu
If HOB contains APCI table information, entry point of AcpiTableDxe.inf should parse the APCI table from HOB, and install these tables. We assume the whole ACPI table (starting with EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER) is contained by a single gEfiAcpiTableGuid HOB. This way, for UefiPayl