[edk2-devel] [RFC] [PATCH 0/2] Proposal to add EFI_MP_SERVICES_PROTOCOL support for AARCH64

2021-09-24 Thread Rebecca Cran
I'd like to propose adding EFI_MP_SERVICES_PROTOCOL support for AARCH64 systems. I've attached two patches to implement support for it in the DXE phase, based on code in EmulatorPkg and UefiCpuPkg. It's added under ArmPkg for now, but longer term it should probably be moved into UefiCpuPkg. Patch

Re: [edk2-devel] [RFC] [PATCH 0/2] Proposal to add EFI_MP_SERVICES_PROTOCOL support for AARCH64

2021-10-08 Thread Ard Biesheuvel
On Thu, 7 Oct 2021 at 13:02, Leif Lindholm wrote: > > On Thu, Oct 07, 2021 at 12:03:30 +0200, Ard Biesheuvel wrote: > > On Thu, 7 Oct 2021 at 11:41, Leif Lindholm wrote: > > > > > > Ard/Sami - any comments? > > > > > > > The code changes by itself look fine to me. The only problem I see is > > th

Re: [edk2-devel] [RFC] [PATCH 0/2] Proposal to add EFI_MP_SERVICES_PROTOCOL support for AARCH64

2021-10-11 Thread Leif Lindholm
+Samer On Fri, Oct 8, 2021 at 3:51 PM Ard Biesheuvel wrote: > > > So either we severely constrain the kind of code that we permit to run > > > on other cores, or we enable the MMU and caches on each core as it > > > comes out of reset, as well as do any other CPU specific > > > initialization th

Re: [edk2-devel] [RFC] [PATCH 0/2] Proposal to add EFI_MP_SERVICES_PROTOCOL support for AARCH64

2021-10-11 Thread Samer El-Haj-Mahmoud
> In PI, the only references I find to the protocol are in MM and SAL protocols. > And we're not even looking at EFI_MP_SERVICES_PPI at this point. The PI 1.7 spec defined the EFI_MP_SERVICES_PROTOCOL in page 2-180, with the PPI and MM versions in 1-193 and 4-57 respectively. > But it might be

Re: [edk2-devel] [RFC] [PATCH 0/2] Proposal to add EFI_MP_SERVICES_PROTOCOL support for AARCH64

2021-10-14 Thread Rebecca Cran
On 9/28/21 5:14 AM, Leif Lindholm wrote: On Fri, Sep 24, 2021 at 20:17:50 -0600, Rebecca Cran wrote: I'd like to propose adding EFI_MP_SERVICES_PROTOCOL support for AARCH64 systems. I've attached two patches to implement support for it in the DXE phase, based on code in EmulatorPkg and UefiCpuP

Re: [edk2-devel] [RFC] [PATCH 0/2] Proposal to add EFI_MP_SERVICES_PROTOCOL support for AARCH64

2021-09-28 Thread Leif Lindholm
On Fri, Sep 24, 2021 at 20:17:50 -0600, Rebecca Cran wrote: > I'd like to propose adding EFI_MP_SERVICES_PROTOCOL support for > AARCH64 systems. I've attached two patches to implement support for it > in the DXE phase, based on code in EmulatorPkg and UefiCpuPkg. It's added > under ArmPkg for now,

Re: [edk2-devel] [RFC] [PATCH 0/2] Proposal to add EFI_MP_SERVICES_PROTOCOL support for AARCH64

2021-10-07 Thread Leif Lindholm
Ard/Sami - any comments? / Leif On Tue, Sep 28, 2021 at 12:14:35 +0100, Leif Lindholm wrote: > On Fri, Sep 24, 2021 at 20:17:50 -0600, Rebecca Cran wrote: > > I'd like to propose adding EFI_MP_SERVICES_PROTOCOL support for > > AARCH64 systems. I've attached two patches to implement support fo

Re: [edk2-devel] [RFC] [PATCH 0/2] Proposal to add EFI_MP_SERVICES_PROTOCOL support for AARCH64

2021-10-07 Thread Ard Biesheuvel
On Thu, 7 Oct 2021 at 11:41, Leif Lindholm wrote: > > Ard/Sami - any comments? > The code changes by itself look fine to me. The only problem I see is that we cannot run arbitrary code on other cores with the MMU off, given that in that case, they don't comply with the UEFI AArch64 platform requi

Re: [edk2-devel] [RFC] [PATCH 0/2] Proposal to add EFI_MP_SERVICES_PROTOCOL support for AARCH64

2021-10-07 Thread Leif Lindholm
On Thu, Oct 07, 2021 at 12:03:30 +0200, Ard Biesheuvel wrote: > On Thu, 7 Oct 2021 at 11:41, Leif Lindholm wrote: > > > > Ard/Sami - any comments? > > > > The code changes by itself look fine to me. The only problem I see is > that we cannot run arbitrary code on other cores with the MMU off, > g