Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

2024-05-16 Thread Chang, Abner via groups.io
Attar, AbdulLateef (Abdul Lateef) > ; Tinh Nguyen > > Subject: Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add > support for the phosphor ipmi blob transfer protocol > > Caution: This message originated from an External Source. Use proper caution > w

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

2024-05-16 Thread Nhi Pham via groups.io
On 5/16/2024 3:44 PM, Chang, Abner wrote: [AMD Official Use Only - AMD Internal Distribution Only] Hi Nhi, Are you using SSIF as the transport interface based on the ManabeabilityPkg framework? If yes, will you contribute that driver? yes, we are. I will need to update the SSIF driver to be

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

2024-05-16 Thread Chang, Abner via groups.io
4 4:40 PM > To: devel@edk2.groups.io; nick...@nvidia.com; Chang, Abner > ; Rebecca Cran > Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) > ; Tinh Nguyen > > Subject: Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add > support for the phosphor ipmi blob

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

2024-05-16 Thread Nhi Pham via groups.io
Lateef) ; Tinh Nguyen Subject: Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol External email: Use caution opening links or attachments On 2/9/2024 11:37 PM, Chang, Abner via groups.io wrote: [AMD Official Use Only - General] Yeah

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

2024-05-15 Thread Nickle Wang via groups.io
10:26 AM > To: Nickle Wang ; devel@edk2.groups.io; > abner.ch...@amd.com; Rebecca Cran > Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) > ; Tinh Nguyen > > Subject: Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add > support for the phosphor ipmi blob transfer pro

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

2024-05-13 Thread Nhi Pham via groups.io
Sent: Monday, May 13, 2024 5:02 PM To: devel@edk2.groups.io; abner.ch...@amd.com; Nickle Wang ; Rebecca Cran Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) ; Tinh Nguyen Subject: Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

2024-05-13 Thread Nickle Wang via groups.io
.com; Nickle Wang > ; Rebecca Cran > Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) > ; Tinh Nguyen > > Subject: Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add > support for the phosphor ipmi blob transfer protocol > > External email: Use caution opening

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

2024-05-13 Thread Nhi Pham via groups.io
On 2/9/2024 11:37 PM, Chang, Abner via groups.io wrote: [AMD Official Use Only - General] Yeah, I forget this patch set and seems we don't have any follow up conversation after below feedbacks from community. https://edk2.groups.io/g/devel/message/103116

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

2023-04-17 Thread Mike Maslenkin
Hello Nick, CalculateCrc16 function has already defined in edk2-platforms/Platform/Intel/WhitleyOpenBoardPkg/Include/Library/CrcLib.h and edk2/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c. This patch adds another CalculateCrc16 declaration. There was an attempt to unify

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

2023-04-16 Thread Tinh Nguyen via groups.io
Hi Abner, On 17/04/2023 10:01, Chang, Abner wrote: [EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please be mindful of safe email handling and proprietary information protection practices.] [AMD Official Use Only - General] -Original Message- From: Tinh

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

2023-04-16 Thread Tinh Nguyen via groups.io
On 4/16/2023 5:50 PM, Chang, Abner wrote: [EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please be mindful of safe email handling and proprietary information protection practices.] [AMD Official Use Only - General] Tink and Nickle, Two feedbacks in below,

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

2023-04-16 Thread Tinh Nguyen via groups.io
Hi Nickle, Please find my inline comments below On 4/12/2023 10:17 AM, Nickle Wang wrote: [EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please be mindful of safe email handling and proprietary information protection practices.] This change implements the blob

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

2023-04-12 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Nickle, Could you please create a BZ ticket for this? Pease also run Uncristify on these files. Feedback inline, > -Original Message- > From: Nickle Wang > Sent: Wednesday, April 12, 2023 11:17 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ;

[edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

2023-04-11 Thread Nickle Wang via groups.io
This change implements the blob transfer protocol used in OpenBmc documented here: https://github.com/openbmc/phosphor-ipmi-blobs Signed-off-by: Nick Ramirez Cc: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Tinh Nguyen --- .../ManageabilityPkg/ManageabilityPkg.dec