Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeSiliconPkg: Logic Error in EISS bit ASSERT

2019-10-02 Thread Kubacki, Michael A
Please change MmioRead8 () to PciSegmentRead8 () since the address is derived from PCI_SEGMENT_LIB_ADDRESS (). > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, October 2, 2019 12:36 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Chaganty,

Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeSiliconPkg: Logic Error in EISS bit ASSERT

2019-10-02 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Desimone, Nathaniel L Sent: Wednesday, October 02, 2019 12:36 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Kubacki, Michael A ; Chaganty, Rangasai V Subject: [edk2-platforms] [PATCH V1] KabylakeSiliconPkg: Logic Error in EISS bit

[edk2-devel] [edk2-platforms] [PATCH V1] KabylakeSiliconPkg: Logic Error in EISS bit ASSERT

2019-10-02 Thread Nate DeSimone
Current ASSERT logic checks that the EISS bit is still set after we clear it. This is incorrect, it should be checking that that the EISS bit is clear after we clear it. Cc: Chasel Chiu Cc: Michael Kubacki Cc: Sai Chaganty Signed-off-by: Nate DeSimone ---