Hi chasel,
> -Original Message-
> From: Chiu, Chasel
> Sent: Wednesday, September 4, 2019 8:13 PM
> To: [email protected]; Zhang, Shenglei
> Cc: Kubacki, Michael A ; Desimone, Nathaniel
> L ; Gao, Liming
> Subject: RE: [edk2-devel] [PATCH]
> MinPlatformPkg/Sec
It works after I apply the change according to your advice.
And that makes the code more clean. Thanks for your advice.
I'll sent out a v2 patch.
Best Regards,
Shenglei
> -Original Message-
> From: Chiu, Chasel
> Sent: Thursday, September 5, 2019 10:54 AM
> To: Zhang,
Update the type of TopOfTemporaryRam from UINT32 to UINTN.
This change is intended to support X64 build scenarios.
The original code(line 64) may cast the overfloewed result
produced by "(TopOfTemporaryRam - sizeof (UINT32))"from
32bit to 64bit.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSim
From: shenglei
FILE GUID in PeiEmuSerialPortLib.inf is same to
MdePkg\Library\BaseSerialPortLibNull\BaseSerialPortLibNull.inf.
PeiEmuSerialPortLib.inf FILE_GUID should be updated.
https://bugzilla.tianocore.org/show_bug.cgi?id=2144
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: S
The file guids of PeiEmuSerialPortLib.inf and SerialDxe.inf
are same to other guids. So update them to new ones.
https://bugzilla.tianocore.org/show_bug.cgi?id=2144
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
Cc: Jian J Wang
Cc: Hao A Wu
Shenglei Zhang (1):
MdeModulePkg/SerialDxe: Update t
FILE GUID in MdeModulePkg\Universal\SerialDxe\SerialDxe.inf is
same to the one gEdkiiSerialPortLibVendorGuid.
Its FILE GUID should be updated to another value.
https://bugzilla.tianocore.org/show_bug.cgi?id=2144
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/Univer
Cc: Eric Dong
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
.../BoardModulePkg/Library/CmosAccessLib/CmosAccessLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/Platform/Intel/BoardModulePkg/Library/CmosAccessLib/CmosAccessLib.inf
b/Platform/Intel/BoardModule
To make the comments in IntelSiliconPkg consistent with those in other
packages, update "@exception" to "@retval" and remove "@result"
Cc: Ray Ni
Cc: Rangasai V Chaganty
Signed-off-by: Shenglei Zhang
---
.../SmmAccess/Library/PeiSmmAccessLib/PeiSmmAccessLib.c | 6 ++
.../Feature/SmmAcc
Change the order of parameters in comments to match the order in code,
in PeiSmmAccessLib.c. Add the attribute "out" for parameters.
This is to fix issues reported by ECC.
Cc: Ray Ni
Cc: Rangasai V Chaganty
Signed-off-by: Shenglei Zhang
---
.../SmmAccess/Library/PeiSmmAccessLib/PeiSmmAccessLib
Cc: Dandan Bi
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
.../Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc
b/Platform/Intel/UserInterfaceFe
Cc: Eric Dong
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c | 3 +--
Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiD
The original the of last line is '/r'. Now update it to '/r/n'.
Cc: Dandan Bi
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
v2: In v1 the patch remove the '/r'. In v2 it is updated to '/r/n'.
The v1 patch is "UserInterfaceFeaturePkg:Remove white ending line in DSC
file".
.../Intel/Use
Remove white space in AcpiDebug.c.
The original end of last line in DebugFeaturePkg.dsc is '/r'.
Now update it to '/r/n'.
Cc: Eric Dong
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
v2: In v1 the patch remove the '/r'. In v2 it is updated to '/r/n'.
The v1 patch is "DebugFeaturePkg: Remo
The original end of last line is '/r'. Now update it to '/r/n'.
Cc: Eric Dong
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
v2: In v1 the patch remove the '/r'. In v2 it is updated to '/r/n'.
The v1 patch is "BoardModulePkg/CmosAccessLib: Remove white ending line".
.../BoardModulePkg/L
As is requested in the BZ 2077, add two switches to support setting
compression mode and dictionary size.
(https://bugzilla.tianocore.org/show_bug.cgi?id=2077)
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
.../Source/C/LzmaCompress/LzmaCompress.c | 39 +++
In DxeCheckBootVariable.c, add check for BootOrder and Variable
that return EFI_NOT_FOUND when they are NULL.
In DxeCheckGcd.c, add check for GcdIoMap to ensure it not NULL
when allocating memory to what it points to.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-
MadtStructs, NewMadtTable and MaxMadtStructCount are not initialized
before used or at the proper place. So assign values to them at the
beginning and change the logic when freeing MadtStructs and
NewMadtTable.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by:
1.Add error handling to enhance status checking.
2.Initialize the variables before used and add check before
FreePool().
v2: Update copyright in 01/02.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Shenglei Zhang (2):
MinPlatformPkg/AcpiTables: Initialize variables
Change ASSERT_EFI_ERROR to return value when the "if" statement is true.
As a result, when SortCpuLocalApicInTable is called, error handling is
needed. So add "if" statement to judge the returned Status from
SortCpuLocalApicInTable () in function InstallMadtFromScratch().
Cc: Michael Kubacki
Cc:
Currently there is no check for the parameter OutTable.
So add the logic that return value EFI_INVALID_PARAMETER when the
OutTable is NULL.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
v2:Update the copyright and the if...else stateme
Hi Nathaniel,
Thanks for your comments and below is my response.
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Tuesday, September 17, 2019 3:25 AM
> To: Zhang, Shenglei ; [email protected]
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Gao, Liming
> S
Hi Nathaniel,
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Saturday, September 14, 2019 6:31 AM
> To: Zhang, Shenglei ; [email protected]
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Gao, Liming
> Subject: Re: [edk2-devel] [PATCH] MinPlatformPkg/T
As is requested in the BZ 2077, add two switches to support setting
compression mode and dictionary size.
(https://bugzilla.tianocore.org/show_bug.cgi?id=2077)
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
v2: 1.Update DictionarySize to mDictionarySize.
2.Update Compression
Hi Ard,
That's my mistake to push the broken
patch(0d85e67714e31e0dbe4241ab2ebb7c423aba174d).
This patch only updates the file guid, which I thought has no risk. So I didn’t
check the build result.
I should double check the new guid used in the file. Liming has help send a
patch to fix this is
In DxeCheckBootVariable.c, add check for BootOrder and Variable
that return EFI_NOT_FOUND when they are NULL.
In DxeCheckGcd.c, add check for GcdIoMap to ensure it not NULL
when allocating memory to what it points to.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-
In DxeCheckBootVariable.c, add check for BootOrder and Variable
that return EFI_NOT_FOUND when they are NULL.
In DxeCheckGcd.c, add check for GcdIoMap to ensure it not NULL
when allocating memory to what it points to.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-
From: "Zhang, Shenglei"
As is requested in the BZ 2077, add two switches to support setting
compression mode and dictionary size.
(https://bugzilla.tianocore.org/show_bug.cgi?id=2077)
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
v2: 1.Update DictionarySize to mDict
In DxeCheckBootVariable.c, add check for BootOrder and Variable
that return EFI_NOT_FOUND when they are NULL.
In DxeCheckGcd.c, add check for GcdIoMap to ensure it not NULL
when allocating memory to what it points to.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-
OK I'll update that then.
Thanks,
Shenglei
> -Original Message-
> From: Chiu, Chasel
> Sent: Thursday, September 19, 2019 5:27 PM
> To: Zhang, Shenglei ; [email protected]
> Cc: Kubacki, Michael A ; Desimone, Nathaniel L
> ; Gao, Liming
> Subject: RE
From: "Zhang, Shenglei"
As is requested in the BZ 2077, add two switches to support setting
compression mode and dictionary size.
(https://bugzilla.tianocore.org/show_bug.cgi?id=2077)
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
v2: 1.Update Diction
For this patch, I'll update the file format of AcpiDebug.c to Dos format when
pushing the patch.
Thanks,
Shenglei
> -Original Message-
> From: Dong, Eric
> Sent: Monday, September 9, 2019 8:36 AM
> To: Zhang, Shenglei ; [email protected]
> Cc: Gao, Liming
>
The range of dictionary size is set from [0,30] to [0,27].
And update the help information for this.
The previous logic for processing the parameter dict size is incorrect.
Now fix the logic.
The option "d" is added at 6b80310f34199d1f62e45e40fa902734735091fa.
(https://bugzilla.tianocore.org/show_b
The condition, NET_HEADSPACE(&(Nbuf->BlockOp[Index])) < Len, is meaningless
if Index < 0. So 'Index < 0' should be performed first in the if statement.
Cc: Siyuan Fu
Cc: Jiaxin Wu
Signed-off-by: Shenglei Zhang
---
NetworkPkg/Library/DxeNetLib/NetBuffer.c | 2 +-
1 file changed, 1 insertion(+),
If DpcEntry is NULL, it means it failed to be allocated space.
ReturnStatus should be EFI_OUT_OF_RESOURCES regardless of the
content of mDpcEntryFreeList.
Cc: Siyuan Fu
Cc: Jiaxin Wu
Signed-off-by: Shenglei Zhang
---
NetworkPkg/DpcDxe/Dpc.c | 9 +++--
1 file changed, 3 insertions(+), 6 del
Add check for MemFile->Buffer.
Return EFI_OUT_OF_RESOURCES if MemFile->Buffer is NULL.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Shenglei Zhang
---
ShellPkg/Application/Shell/FileHandleWrappers.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/ShellPkg/Application/Sh
> -Original Message-
> From: Fu, Siyuan
> Sent: Saturday, October 12, 2019 3:59 PM
> To: Zhang, Shenglei ; [email protected]
> Cc: Wu, Jiaxin
> Subject: RE: [PATCH] NetworkPkg/DpcDxe: Update the consequent logic
> when DpcEntry is NULL
>
> > -
Add check for MemFile->Buffer.
Return EFI_OUT_OF_RESOURCES if MemFile->Buffer is NULL.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Shenglei Zhang
---
v2: Add the expressiong to free AsciiBuffer before the function is returned.
ShellPkg/Application/Shell/FileHandleWrappers.c | 7 +++
1 file
After the expression,
'CopyMem (&ConfigNvData->TargetUrl, Field->Str, Field->Len);',
the '\0' should be set to TargetUrl[Field->Len] rather than
TargetUrl[Field->Len + 1].
Besides the boundary check should be more strict.
Field->Len should range from 0-254 rather than 0-255.
Cc: Siyuan Fu
Cc: Jia
After the expression,
'CopyMem (&ConfigNvData->TargetUrl, Field->Str, Field->Len);',
the '\0' should be set to TargetUrl[Field->Len] rather than
TargetUrl[Field->Len + 1].
Besides the boundary check should be more strict.
Field->Len should range from 0-254 rather than 0-255.
Cc: Siyuan Fu
Cc: Jia
Hi Philippe,
> -Original Message-
> From: Philippe Mathieu-Daudé [mailto:[email protected]]
> Sent: Monday, October 14, 2019 5:35 PM
> To: [email protected]; Zhang, Shenglei
> Cc: Fu, Siyuan ; Wu, Jiaxin ;
> Laszlo Ersek
> Subject: Re: [edk2-devel] [PATCH v2] Net
> -Original Message-
> From: Philippe Mathieu-Daudé [mailto:[email protected]]
> Sent: Monday, October 14, 2019 5:39 PM
> To: [email protected]; Gao, Zhichao ; Zhang,
> Shenglei
> Cc: Ni, Ray
> Subject: Re: [edk2-devel] [PATCH v2] ShellPkg/Shell/FileHandleWrappe
Currently brotli is used and customized by edk2 in BaseTools
and MdeModulePkg. These two patches make brotli a submodule in
edk2.
https://bugzilla.tianocore.org/show_bug.cgi?id=2558
https://bugzilla.tianocore.org/show_bug.cgi?id=2559
Cc: Liming Gao
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Bob Feng
She
Reviewed-by: Shenglei Zhang
> -Original Message-
> From: [email protected] [mailto:[email protected]] On Behalf Of
> GuoMinJ
> Sent: Wednesday, February 19, 2020 10:35 AM
> To: [email protected]
> Cc: GuoMinJ
> Subject: [edk2-devel] [PATCH] UnitTestFrameworkPkg: Suspicious chec
Reviewed-by: Shenglei Zhang
> -Original Message-
> From: [email protected] [mailto:[email protected]] On Behalf Of
> GuoMinJ
> Sent: Thursday, February 20, 2020 9:42 AM
> To: [email protected]
> Cc: GuoMinJ
> Subject: [edk2-devel] [PATCH] UnitTestFrameworkPkg: Invalid index may
> -Original Message-
> From: [email protected] [mailto:[email protected]] On Behalf Of
> GuoMinJ
> Sent: Saturday, February 22, 2020 1:25 PM
> To: [email protected]
> Cc: GuoMinJ
> Subject: [edk2-devel] [PATCH] MdeModulePkg/SdDxe: Potential NULL
> pointer on Token
>
> REF: htt
Hi Guomin,
Please update the subject and let us know the brief change through it.
The details could be placed in commit message.
When sending a patch of next version, you can update the subject prefix like
"[PATCH v2] CryptoPkg: *** ".
Thanks,
Shenglei
> -Original Message-
> From: deve
Same comments with mail thread " CryptoPkg: ECC issue. "
Thanks,
Shenglei
> -Original Message-
> From: [email protected] [mailto:[email protected]] On Behalf Of
> GuoMinJ
> Sent: Tuesday, February 25, 2020 9:33 AM
> To: [email protected]
> Cc: GuoMinJ
> Subject: [edk2-devel] [P
tp, pch, digits and xdigits are both 4-byte-size, but not
cast to 8-byte-size when operated with 8-byte-size variables.
This is a issue reported by my local static tool.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Signed-off-by: Shenglei Zhang
---
CryptoPkg/Library/BaseCryptLib/SysCall/inet_pton.c | 4 ++--
Add ASSERT for Ek to ensure things out of EK would not
be visited.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Shenglei Zhang
---
SecurityPkg/RandomNumberGenerator/RngDxe/AesCore.c | 2 ++
SecurityPkg/RandomNumberGenerator/RngDxe/AesCore.h | 2 ++
2 files changed, 4 insertion
Add 'Index < HASH_COUNT' to ensure things out of boundary
of digests[] can not be visited.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Shenglei Zhang
---
SecurityPkg/Library/Tpm2CommandLib/Tpm2Help.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Security
Reviewed-by: Shenglei Zhang
> -Original Message-
> From: Philippe Mathieu-Daude [mailto:[email protected]]
> Sent: Friday, December 6, 2019 7:26 PM
> To: [email protected]
> Cc: Philippe Mathieu-Daude ; Zhang, Shenglei
>
> Subject: [PATCH v2 083/105] .mail
Thanks, Lazslo. I will add it to the exception list on my local tool.
Thanks,
Shenglei
> -Original Message-
> From: [email protected] [mailto:[email protected]] On Behalf Of
> Laszlo Ersek
> Sent: Saturday, December 7, 2019 10:11 PM
> To: [email protected]; Zhang,
> -Original Message-
> From: Yao, Jiewen
> Sent: Friday, December 6, 2019 10:04 AM
> To: Zhang, Shenglei ; [email protected]
> Cc: Wang, Jian J ; Zhang, Chao B
>
> Subject: RE: [PATCH] SecurityPkg/Tpm2Help.c: Add boundary check for array
>
> Hi
> May
> -Original Message-
> From: [email protected] [mailto:[email protected]] On Behalf Of
> Laszlo Ersek
> Sent: Friday, December 6, 2019 5:27 PM
> To: [email protected]; Zhang, Shenglei
> Cc: Yao, Jiewen ; Wang, Jian J
> ; Zhang, Chao B
> Subject:
Add 'Index < HASH_COUNT' to ensure things out of digests[]
can not be visited.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Shenglei Zhang
---
v2: Remove the comma operator and use &&.
SecurityPkg/Library/Tpm2CommandLib/Tpm2Help.c | 2 +-
1 file changed, 1 insertion(+), 1 del
Reviewed-by: Shenglei Zhang
> -Original Message-
> From: Chen, Marc W
> Sent: Thursday, December 26, 2019 2:53 PM
> To: [email protected]
> Cc: Kubacki, Michael A ; Chaganty, Rangasai V
> ; Gao, Liming ;
> Zhang, Shenglei ; Chen, Marc W
>
> Subject: [edk2-d
Hi Ray,
Could you help review this patch?
Thanks,
Shenglei
> -Original Message-
> From: Chen, Marc W
> Sent: Thursday, December 26, 2019 2:53 PM
> To: [email protected]
> Cc: Kubacki, Michael A ; Chaganty, Rangasai V
> ; Gao, Liming ;
> Zhang, Shenglei ; Chen
Initialize MapMemory to 0 in HeapGuard.c.
Cc: Dandan Bi
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/Core/Dxe/Mem/HeapGuard.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MdeModulePkg/Core/Dxe/Mem/HeapGuard.c
b/MdeModulePkg/Core/Dxe/Mem/HeapGuard.c
index 9477b94044ba
Map is used but not Initialized.
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c
b/MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c
index 7c6a6a5f9716..995ccd246
Initialize the variables before used.
Cc: Hao A Wu
Cc: Ray Ni
Cc: Dandan Bi
Cc: Liming Gao
Shenglei Zhang (3):
MdeModulePkg/EhciPei: Initialize the variable Map
MdeModulePkg/UhciPei: Initialize the variable RequestMap
MdeModulePkg/Mem: Initialize the variable MapMemory
MdeModulePkg/Bus
RequestMap is used but not Initialized.
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c
b/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c
index b897c3f82ce6..a0
IndexTable->Length is used as index in array IndexTable->Index[].
So IndexTable->Length needs to be checked, which should be less than
the array size.
Cc: Hao A Wu
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/Universal/Variable/Pei/Variable.c | 2 +-
1 file changed, 1 insertio
The returned value from GetBufferForValue might be NULL, so add a
check for that before it is used.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/Universal/SetupBrowserDxe/Expression.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/MdeModulePkg/Universal
If the target string doesn't appear in the searched string,
StringPtr will be NULL. So add a check for that.
Cc: Dandan Bi
Cc: Eric Dong
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 4
1 file changed, 4 insertions(+)
diff --git a/MdeModulePkg/
Entry and RetEntry might be NULL before used.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c | 2 +-
MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff
The variables and return value might be NULL.
So add check for them before they are used.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Dandan Bi
Cc: Eric Dong
Cc: Hao A Wu
Cc: Liming Gao
Shenglei Zhang (4):
MdeModulePkg/EbcDebugger: Add check for Entry and RetEntry
MdeModulePkg/HiiDatabaseDxe: Add c
EsrtRepository might be NULL. So return EFI_OUT_OF_RESOURCES
when it is NULL.
Cc: Hao A Wu
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/Universal/EsrtDxe/EsrtImpl.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MdeModulePkg/Universal/EsrtDxe/EsrtImpl.c
b/Mde
The size of mHiiEfiColors is 16.
mHiiEfiColors[Private->Attribute >> 4] may be out of boundary.
So add a check for that.
Cc: Dandan Bi
Cc: Eric Dong
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/Universal/HiiDatabaseDxe/Font.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff
DeviceIndex is used as index in Slot[]. The max size of Slot[]
is SD_PEIM_MAX_SLOTS. So DeviceIndex should be checked before used.
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/Bus/Sd/SdBlockIoPei/SdBlockIoPei.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
The if statement is not necessary, so keep it to edk2 style.
And this change has been merged to onigruma.
REF:https://github.com/kkos/oniguruma/pull/158
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
---
.../Oniguruma/unicode_fold1_key.c | 18 +++---
.../On
Update openssl from 1.1.1b to 1.1.1d.
Something needs to be noticed is that, there is a bug existing in the
released 1_1_1d version(894da2fb7ed5d314ee5c2fc9fd2d9b8b74111596),
which causes build failure. So we switch the code base to a usable
version, which is 2 commits later than the stable tag.
No
Hi Laszlo,
> -Original Message-
> From: Laszlo Ersek [mailto:[email protected]]
> Sent: Tuesday, October 22, 2019 12:29 AM
> To: [email protected]; Zhang, Shenglei
> Cc: Wang, Jian J ; Lu, XiaoyuX
> ; David Woodhouse
> Subject: Re: [edk2-devel] [PATCH] CryptoPk
Hi Laszlo,
> -Original Message-
> From: [email protected] [mailto:[email protected]] On Behalf Of
> Laszlo Ersek
> Sent: Tuesday, October 22, 2019 12:46 AM
> To: [email protected]; Gao, Liming ; Zhang,
> Shenglei
> Cc: Wang, Jian J ; Lu, XiaoyuX
> ; Da
There are missing headers added into INF files at 8906f076de35b222a..
They are now manually added but not auto-generated. So we update the
perl script to enable this feature.
Meanwhile, update the order of the .h files in INF files, which are
auto-generated now.
https://bugzilla.tianocore.org/show_
Update openssl from 1.1.1b to 1.1.1d.
Something needs to be noticed is that, there is a bug existing in the
released 1_1_1d version(894da2fb7ed5d314ee5c2fc9fd2d9b8b74111596),
which causes build failure. So we switch the code base to a usable
version, which is 2 commits later than the stable tag.
No
> -Original Message-
> From: Wu, Hao A
> Sent: Wednesday, October 30, 2019 3:15 PM
> To: [email protected]; Zhang, Shenglei
> Cc: Ni, Ray
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/SdBlockIoPei: Add check
> for DeviceIndex
>
> > -Origina
DeviceIndex is used as index in Slot[]. The max size of Slot[]
is SD_PEIM_MAX_SLOTS. So DeviceIndex should be checked before used.
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
---
v2. Update the check boundary from "SD_PEIM_MAX_SLOTS-1"
to "SD_PEIM_MAX_SLOTS". Beacuse DeviceIndex i
The size of mHiiEfiColors is 16.
mHiiEfiColors[Private->Attribute >> 4] may be out of boundary.
So add a check for that.
Cc: Dandan Bi
Cc: Eric Dong
Signed-off-by: Shenglei Zhang
---
v2: Instead of returing value, we add ASSERT to ensure
"Private->Attribute >> 4" is not out of boundary.
M
RequestMap is used but not Initialized.
RequestMap is called by UhciMapUserRequest, in which RequestMap(Map)
is called by IoMmuMap, and is finally called by IoMmu->Map.
We can not assume RequestMap is given an initial value at any step.
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
---
Initialize the variables before used.
v2: Commit message in all patches has been updated.
Cc: Hao A Wu
Cc: Ray Ni
Cc: Dandan Bi
Cc: Liming Gao
Shenglei Zhang (3):
MdeModulePkg/EhciPei: Initialize the variable Map
MdeModulePkg/UhciPei: Initialize the variable RequestMap
MdeModulePkg/Mem
MapMemory is not initialized by FindGuardedMemoryMap
or CoreInternalAllocatePages which calls MapMemory.
So we give a 0 to it.
Cc: Dandan Bi
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/Core/Dxe/Mem/HeapGuard.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MdeModulePkg
Map is used but not Initialized.
Map is called by IoMmuMap, in which Mapping(Map) is called by IoMmu->Map.
We can not assume Map is given an initial value at any step.
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c | 2 ++
1 file changed, 2 ins
EsrtRepository might be NULL. So return EFI_OUT_OF_RESOURCES
when it is NULL.
Cc: Hao A Wu
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
Reviewed-by: Hao A Wu
---
MdeModulePkg/Universal/EsrtDxe/EsrtImpl.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MdeModulePkg/Universal/Es
The variables and return value might be NULL.
So add check for them before they are used.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Dandan Bi
Cc: Eric Dong
Cc: Hao A Wu
Cc: Liming Gao
Shenglei Zhang (4):
v2: Update the checking method in 02/04.
MdeModulePkg/EbcDebugger: Add check for Entry and Re
The returned value from GetBufferForValue might be NULL, so add a
check for that before it is used.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/Universal/SetupBrowserDxe/Expression.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/MdeModulePkg/Universal
Entry and RetEntry might be NULL before used.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
Reviewed-by: Hao A Wu
---
MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c | 2 +-
MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c| 2 +-
2 files changed, 2 insertions(+)
If the target string doesn't appear in the searched string,
StringPtr will be NULL. So add a check for that.
Cc: Dandan Bi
Cc: Eric Dong
Signed-off-by: Shenglei Zhang
---
v2: Instead of returning a value, we add ASSERT to ensure
StringPtr is not NULL.
MdeModulePkg/Universal/HiiDatabaseDxe
The caller of CompareAndMergeDefaultString has checked that
AltCfgResp must contain AltConfigHdr. So we add ASSERT to assume
StringPtr is not NULL.
Cc: Dandan Bi
Cc: Eric Dong
Signed-off-by: Shenglei Zhang
Reviewed-by: Dandan Bi
---
MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 1 +
Before called by GetBufferForValue(), Value has already been called
function IsTypeInBuffer to make sure the value must be buffer type.
So GetBufferForValue can not return NULL.
This commit adds ASSERT to assume (GetBufferForValue (&Value) is not
NULL.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by:
EsrtRepository might be NULL. So return EFI_OUT_OF_RESOURCES
when it is NULL.
Cc: Hao A Wu
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
Reviewed-by: Hao A Wu
---
MdeModulePkg/Universal/EsrtDxe/EsrtImpl.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MdeModulePkg/Universal/Es
Entry and RetEntry might be NULL before used.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
Reviewed-by: Hao A Wu
---
MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c | 2 +-
MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c| 2 +-
2 files changed, 2 insertions(+)
Add error handling and ASSERT to ensure the variables are
usable when called.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Dandan Bi
Cc: Eric Dong
Cc: Hao A Wu
Cc: Liming Gao
Shenglei Zhang (4):
v2: Update the checking method in 02/04.
v3: Add ASSERT instead of error handling in 04/04.
Shenglei Zhang
Update openssl from 1.1.1b to 1.1.1d.
Something needs to be noticed is that, there is a bug existing in the
released 1_1_1d version(894da2fb7ed5d314ee5c2fc9fd2d9b8b74111596),
which causes build failure. So we switch the code base to a usable
version, which is 2 commits later than the stable tag.
No
Take the below code as example.
if (Type >= 0 && Type <= ARRAY_SIZE(mSxTypeString)) {
return mSxTypeString[Type];
The variable 'Type' used as index should range from 0 ~ ARRAY_SIZE-1.
So the if statement should be :
if (Type >= 0 && Type < ARRAY_SIZE(mSxTypeString)) {
And other cases shou
From: Shenglei Zhang
There are missing strings in MdeModulePkg.uni, NetworkPkg.uni
and UefiCpuPkg.uni. So add them into uni files.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Shenglei Zhang (3):
MdeModulePkg/MdeMo
From: Shenglei Zhang
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/MdeModulePkg.uni | 12
1 file changed, 12 insertions(+)
diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni
index a2c7a7ded3e8..d9c7b1ac6cf0 100644
--- a/MdeMo
From: Shenglei Zhang
In MpLib.c, remove the white space on a new line.
In PageTbl.c and PiSmmCpuDxeSmm.h, update the comment style.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Shenglei Zhang
---
UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 +-
UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/P
From: Shenglei Zhang
Keep the comment style of IsLanguageSupported align with
other functions.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
MdePkg/Library/UefiLib/UefiLib.c | 18 +-
MdePkg/Include/Library/UefiLib.h | 19 ++-
2 files ch
From: Shenglei Zhang
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Signed-off-by: Shenglei Zhang
---
NetworkPkg/NetworkPkg.uni | 7 +++
1 file changed, 7 insertions(+)
diff --git a/NetworkPkg/NetworkPkg.uni b/NetworkPkg/NetworkPkg.uni
index 19e57a4a60de..328d8cb54a6e 100644
--- a/Networ
From: Shenglei Zhang
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Shenglei Zhang
---
UefiCpuPkg/UefiCpuPkg.uni | 16
1 file changed, 16 insertions(+)
diff --git a/UefiCpuPkg/UefiCpuPkg.uni b/UefiCpuPkg/UefiCpuPkg.uni
index a7e279c5cb14..bfd696f48c35 100644
--- a
1 - 100 of 477 matches
Mail list logo
