Lastest CVS version is Ok.
Thanks.
Lucio Ferrao
OutSystems
-Original Message-
From: Stipe Tolj [mailto:[EMAIL PROTECTED]]
Sent: Sunday, January 27, 2002 1:19
To: Lucio Ferrao
Cc: Devel@Kannel. 3glab. Org
Subject: Re: [PATCH] smsc_at2.c not counting escape caracters (gsm7bit)
is the
Lucio Ferrao wrote:
>
> When smsc_at2 sent a message in 7bit the length written in the PDU did not
> include
> the escape chars. I solved the problem calling the charset_latin1_to_gsm a
> little earlier.
> This lead to missing end chars when using "escaped chars" []...
>
> Lucio Ferrao
>
Oded Arbel wrote:
>
> Hi list.
>
> Since we're already discussing the at2 gsm7bit escaping issue, I would
> like to resubmit my suggested fix for the problem (as apparently it did
> not arrive to the proper authorities the first time). my apologies if
> you are reading it for the second time.
>
Lucio Ferrao wrote:
>
> I have tested succesfully the patch for the specific problems with AT2.
> The code looks good too.
>
> My vote to commit.
Ok, I'm going to commit this today.
Stipe
[EMAIL PROTECTED]
---
Wapme Systems AG
M
-devel (E-mail)
Subject: Re: FW: [PATCH] smsc_at2.c not counting escape caracters
(gsm7bit)
Stipe Tolj wrote:
>
> Just applied the patch to a test environment and giving it a try for
> various smsc types.
tested messages via EMI2, SMPP and AT2, all ok. +1 for commitment from
my side.
Ca
Stipe Tolj wrote:
>
> Just applied the patch to a test environment and giving it a try for
> various smsc types.
tested messages via EMI2, SMPP and AT2, all ok. +1 for commitment from
my side.
Can someone test against the issues the patch is fixing, I guess I
only tried to send "normal" message
Oded Arbel wrote:
>
> Hi list.
>
> Since we're already discussing the at2 gsm7bit escaping issue, I would
> like to resubmit my suggested fix for the problem (as apparently it did
> not arrive to the proper authorities the first time). my apologies if
> you are reading it for the second time.
>
The changes make sense to me including a minor fix for error handling and
the major flow changes are well commented so if someone can test in a live
environment I would vote for commiting.
Alex
On Thu, 24 Jan 2002, Oded Arbel wrote:
> Hi list.
>
> Since we're already discussing the at2 gsm7b
]
Sent: Thursday, January 24, 2002 1:56 PM
To: Oded Arbel
Subject: RE: [PATCH] smsc_at2.c not counting escape caracters (gsm7bit)
Looks sensible. Check your at2_wait_mdoem_command which you're calling
with 4 parameters in the patch however I think adding your changes to
cvs
makes sense.
A
>Hi List,
>I'm thinking about a general overhaul in this area. The interaction of
>
>* 7bit escape characters
>* UDH with multiple IEI's
>* message splitting and concatenation
>
>is a big mess right now (IMHO).
I agree to some extent. Things are done in different places or even done twice.
We ha
Regards
Jörg
-Original Message-
From: Stipe Tolj
Cc: Devel@Kannel. 3glab. Org
Sent: 1/23/02 9:06 PM
Subject: Re: [PATCH] smsc_at2.c not counting escape caracters (gsm7bit)
Lucio Ferrao wrote:
> When smsc_at2 sent a message in 7bit the length written in the
PDU did not
> in
t."
> -Original Message-
> From: Stipe Tolj [mailto:[EMAIL PROTECTED]]
> Sent: Wednesday, January 23, 2002 10:06 PM
> Cc: Devel@Kannel. 3glab. Org
> Subject: Re: [PATCH] smsc_at2.c not counting escape caracters
> (gsm7bit)
>
>
> Lucio Ferrao wrote:
>
&g
12 matches
Mail list logo
