Rene,
Looks good. +1
Though i dont like the "for (;;) {" approach in catenate_msg very much... it
looks stressing before going through the code in detail ;)
I'd rather have a do { .. } while(++max > total) -> and then instead of
unreachable return do a failure code...
But then again it seems like
I changed it. It does look tidier.
== Rene
From: konstan...@appcell.net [mailto:konstan...@appcell.net] On Behalf Of
Konstantin Vayner
Sent: vrijdag 18 juni 2010 9:04
To: Rene Kluwen
Cc: Kannel Devel
Subject: Re: [PATCH] SMPP box multipart messages
Rene,
Looks good. +1
Thoug
And right away committed to svn (earlier), since there were no objections.
== Rene
From: devel-boun...@kannel.org [mailto:devel-boun...@kannel.org] On Behalf Of
Rene Kluwen
Sent: vrijdag 18 juni 2010 15:05
To: 'Konstantin Vayner'
Cc: 'Kannel Devel'
Subject: RE: [PATCH] SMPP box multipart m
