Changes made for the most part.
One issue: How might one determine if the SMSC is offline (#7
below) and as such hold pending messages? Because the message parts
could have come from different physical connections, does this mean
we check each smsc connection of each part of the message b
Hi Paul,
sorry for the delay, here we go with my comments...
1) fix indentation. We don't use tabs use 4 spaces instead
2) I don't think we want to see such things in access log:
+ bb_alog_sms(conn, sms, "CONCATENATED SMS Part Received,
stored");
You shoul
Hi Paul,
smscat patch commited, thanks!
MO concat patch has many issues I will try to get review later this week.
Paul Bagyenda wrote:
> Following your comments, here is a MO concatenation patch that now
> resides in bb_smscconn.c, and uses the key as advised below. Same
> code, largely, just
Following your comments, here is a MO concatenation patch that now
resides in bb_smscconn.c, and uses the key as advised below. Same
code, largely, just integrated in a different place. There is also
better handling of the message stores...
Tests, comments, votes.
P.
Ps. If you are using
-
From: "Paul Bagyenda" <[EMAIL PROTECTED]>
To: "Kannel Devel"
Sent: Tuesday, January 09, 2007 8:16 PM
Subject: Re: [PATCH] Re: MO Concatenation
So we have some sort of agreement, except that I can't seem to find
any reference to 'smsc-group-id
, January 08, 2007 7:45 PM
To: Δημήτρης Ευμορφόπουλος
Cc: devel@kannel.org; Alexander Malysh
Subject: Re: [PATCH] Re: MO Concatenation
On 08.01.2007, at 17:38, Δημήτρης Ευμορφόπουλος
wrote:
The triple key is not valid. From personal experience I was getting
the SMS parts from all SMSC's not
09, 2007 10:46 AM
To: Δημήτρης Ευμορφόπουλος
Cc: devel@kannel.org; Alexander Malysh
Subject: Re: [PATCH] Re: MO Concatenation
On 09.01.2007, at 08:59, Δημήτρης Ευμορφόπουλος
wrote:
> So you mean msisdn + refnum + smsc-group-id not smscid ... That is
> valid!
well group-id seems to be new and
45 PM
To: Δημήτρης Ευμορφόπουλος
Cc: devel@kannel.org; Alexander Malysh
Subject: Re: [PATCH] Re: MO Concatenation
On 08.01.2007, at 17:38, Δημήτρης Ευμορφόπουλος
wrote:
The triple key is not valid. From personal experience I was getting
the SMS parts from all SMSC's not the one that trans
PROTECTED]
Sent: Monday, January 08, 2007 7:45 PM
To: Δημήτρης Ευμορφόπουλος
Cc: devel@kannel.org; Alexander Malysh
Subject: Re: [PATCH] Re: MO Concatenation
On 08.01.2007, at 17:38, Δημήτρης Ευμορφόπουλος
wrote:
> The triple key is not valid. From personal experience I was getting
> the SMS
On 08.01.2007, at 17:38, Δημήτρης Ευμορφόπουλος
wrote:
The triple key is not valid. From personal experience I was getting
the SMS parts from all SMSC's not the one that transmitted the
first part only. All the operators I worked with do the same thing.
So the key should remain msisdn +
ssage-
From: Alexander Malysh [mailto:[EMAIL PROTECTED]
Sent: Monday, January 08, 2007 4:01 PM
To: devel@kannel.org
Subject: Re: [PATCH] Re: MO Concatenation
Hi Paul,
+1 for the at2 part.
-1 for the reassemble part. Your patch will never work reliable because
not only msisdn + refnum shou
Watch out here
If you have TWO EMI/UCP connection to the same SMSC's (like to
overcome speed limitations while windowing = 0) which have the same
id, then they actually can have one SMS come in on one link and the
other on the other. For the SMSC its just two different SMS's. Same
is true
Am 08.01.2007, 15:50 Uhr, schrieb Paul Bagyenda <[EMAIL PROTECTED]>:
On Jan 08, 2007, at 17:04, Stipe Tolj wrote:
Alexander Malysh wrote:
Hi Paul,
+1 for the at2 part.
-1 for the reassemble part. Your patch will never work reliable
because not only msisdn + refnum should be considered.
R
On Jan 08, 2007, at 17:04, Stipe Tolj wrote:
Alexander Malysh wrote:
Hi Paul,
+1 for the at2 part.
-1 for the reassemble part. Your patch will never work reliable
because not only msisdn + refnum should be considered.
Reassemble should have triple as key: SMSC, msisdn, refnum.
IMO bb_boxc
Alexander Malysh wrote:
Hi Paul,
+1 for the at2 part.
-1 for the reassemble part. Your patch will never work reliable because
not only msisdn + refnum should be considered.
Reassemble should have triple as key: SMSC, msisdn, refnum.
IMO bb_boxc.c is the wrong place for this, bb_smscconn sui
Hi Paul,
+1 for the at2 part.
-1 for the reassemble part. Your patch will never work reliable because
not only msisdn + refnum should be considered.
Reassemble should have triple as key: SMSC, msisdn, refnum.
IMO bb_boxc.c is the wrong place for this, bb_smscconn suites better
because bb_bo
Oops! Yes there was a small bug once duplicate copies of the same
message part were received (trying to debug-dump the sender address
after free-ing the message structure). I've corrected this -- patch
attached.
I've also included a patch (also posted earlier) to the AT2 module
that is s
17 matches
Mail list logo
