Re: [PATCH] mysql_real_escape_string() usage in gw/dlr_mysql.c

2005-09-27 Thread Stipe Tolj
Peter Christensen wrote: Under all circumstances, the patch is better than the one I was forced to make myself in a hurry when I encountered the problem. I ended up not using the real_escape version because I didn't have time to dig into how the DB pool was working, and I didn't use the Octst

RE: [PATCH] mysql_real_escape_string() usage in gw/dlr_mysql.c

2005-09-27 Thread Gaurav_Khurana
ECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Peter Christensen Sent: Tuesday, September 27, 2005 4:22 PM To: Stipe Tolj Cc: Kannel Development list; Rene Kluwen Subject: Re: [PATCH] mysql_real_escape_string() usage in gw/dlr_mysql.c Hi, Under all circumstances, the patch is better than the one I was f

Re: [PATCH] mysql_real_escape_string() usage in gw/dlr_mysql.c

2005-09-27 Thread Peter Christensen
Hi, Under all circumstances, the patch is better than the one I was forced to make myself in a hurry when I encountered the problem. I ended up not using the real_escape version because I didn't have time to dig into how the DB pool was working, and I didn't use the Octstr struct. This is also

Re: [PATCH] mysql_real_escape_string() usage in gw/dlr_mysql.c

2005-09-26 Thread Stipe Tolj
Rene Kluwen wrote: IMHO consuming DBPoolConns is not a bad thing. After all, that is why the pool even exist. So consuming and producing sql connections is not so expensive. ok, that's true. The main issue is that in some circumstances you may need 2 connections for "one-and-the-same" job, wh

RE: [PATCH] mysql_real_escape_string() usage in gw/dlr_mysql.c

2005-09-26 Thread Rene Kluwen
maandag 26 september 2005 19:10 To: Kannel Development list Subject: [PATCH] mysql_real_escape_string() usage in gw/dlr_mysql.c Hi list, according to bug #258 we don't use the string character escaping functions from mysql client library to ensure the safety of the SQL statements. A

[PATCH] mysql_real_escape_string() usage in gw/dlr_mysql.c

2005-09-26 Thread Stipe Tolj
Hi list, according to bug #258 we don't use the string character escaping functions from mysql client library to ensure the safety of the SQL statements. Attached is a patch for gw/dlr_mysql.c:dlr_mysql_add() which uses a static mysql_escaipe() that does this. Please review and vote for commi