Patch: test/drive_smpp.c

2010-06-28 Thread Nikos Balkanas
Hi, This is a patch to test/drive_smpp.c, which I found useful in SMPPbox testing, since I do not have a real SMSc connection. It adds external SMS submission along with concatenation, if SMS is too large. drive_smpp is a very nifty tool. It acts as a (FAKE) SMPP SMSc and smsbox for MOs with

Re: Patch: test/drive_smpp.c

2010-06-28 Thread Nikos Balkanas
OOps! - Original Message - From: "Nikos Balkanas" To: Sent: Monday, June 28, 2010 5:33 PM Subject: Patch: test/drive_smpp.c Hi, This is a patch to test/drive_smpp.c, which I found useful in SMPPbox testing, since I do not have a real SMSc connection. It adds ex

Re: Patch: test/drive_smpp.c

2010-06-30 Thread Alexander Malysh
Sent: Monday, June 28, 2010 5:33 PM > Subject: Patch: test/drive_smpp.c > > >> Hi, >> >> This is a patch to test/drive_smpp.c, which I found useful in SMPPbox >> testing, since I do not have a real SMSc connection. It adds external SMS >> submission along wi

Re: Patch: test/drive_smpp.c

2010-06-30 Thread Nikos Balkanas
arily addressed to interested people who find it useful to use it. BR, Nikos - Original Message - From: "Alexander Malysh" To: "Nikos Balkanas" Cc: Sent: Wednesday, June 30, 2010 12:10 PM Subject: Re: Patch: test/drive_smpp.c Hi Nikos, why do you redefine and

Re: Patch: test/drive_smpp.c

2010-06-30 Thread Alexander Malysh
is primarily > addressed to interested people who find it useful to use it. > > BR, > Nikos > - Original Message - From: "Alexander Malysh" > To: "Nikos Balkanas" > Cc: > Sent: Wednesday, June 30, 2010 12:10 PM > Subject: Re: Patch: test/drive_smp

Re: Patch: test/drive_smpp.c

2010-06-30 Thread Nikos Balkanas
, Nikos - Original Message - From: "Alexander Malysh" To: "Nikos Balkanas" Cc: Sent: Wednesday, June 30, 2010 9:33 PM Subject: Re: Patch: test/drive_smpp.c HI Nikos, I'm aware of the fact that you have only Octstr as input at this place but it would be better to

RE: Patch: test/drive_smpp.c

2010-06-30 Thread Rene Kluwen
Nikos Balkanas Sent: woensdag 30 juni 2010 20:59 To: Alexander Malysh Cc: devel@kannel.org Subject: Re: Patch: test/drive_smpp.c The flow at that point doesn't need anywhere to use Msg *. It is an SMPP (FAKE) server with an added smsbox for testing the loop. smsbox just sends a hard-coded "H

Re: Patch: test/drive_smpp.c

2010-06-30 Thread Alexander Malysh
the test function will be void. > > == Rene > > -Original Message- > From: devel-boun...@kannel.org [mailto:devel-boun...@kannel.org] On Behalf > Of Nikos Balkanas > Sent: woensdag 30 juni 2010 20:59 > To: Alexander Malysh > Cc: devel@kannel.org > Subject: Re:

Re: Patch: test/drive_smpp.c

2010-06-30 Thread Nikos Balkanas
Hi, Fixed identation. Beafed up smsbox_thread and routed most variables to configuration. Uses main kannel configuration. Just add an smpp smsc definition to 127.0.0.1 for it. It will test main kannel configuration in addition to TLVs. As already mentioned I extended its functionality to hand

Re: Patch: test/drive_smpp.c

2010-07-01 Thread Alexander Malysh
Hi Nikos, if you write "fixed indentation" then I assume it's fixed. But as far as I see it's not and your fix made it even worse... Please fix it and provide doc and I will commit it. Thanks in advance. Here are comments: +#define MAX_SMS_OCTETS 140 +#define CATENATE_UDH_LEN 5 dont' redefine

Re: Patch: test/drive_smpp.c

2010-07-03 Thread Nikos Balkanas
retracted. BR, Nikos - Original Message - From: "Alexander Malysh" To: "Nikos Balkanas" Cc: Sent: Thursday, July 01, 2010 11:04 AM Subject: Re: Patch: test/drive_smpp.c Hi Nikos, if you write "fixed indentation" then I assume it's fixed. But as far

Re: Patch: test/drive_smpp.c

2010-07-04 Thread Milan P. Stanic
On Sun, 2010-07-04 at 00:58, Nikos Balkanas wrote: > I am very sorry. My apologies for the missunderstanding. My > impression is that identation means replacing tabs with spaces and > aligning left text according to level. I see here that you are > actually asking about source code reformatting and

Re: Patch: test/drive_smpp.c

2010-07-04 Thread Nikos Balkanas
BR, Nikos - Original Message - From: "Milan P. Stanic" To: Sent: Sunday, July 04, 2010 12:52 PM Subject: Re: Patch: test/drive_smpp.c On Sun, 2010-07-04 at 00:58, Nikos Balkanas wrote: I am very sorry. My apologies for the missunderstanding. My impression is that identation

Re: Patch: test/drive_smpp.c

2010-07-04 Thread Milan P. Stanic
. Yes. I agree with you. And, I really appreciate your contribution to kannel. > BR, > Nikos > - Original Message - From: "Milan P. Stanic" > > To: > Sent: Sunday, July 04, 2010 12:52 PM > Subject: Re: Patch: test/drive_smpp.c > > > >

Re: Patch: test/drive_smpp.c

2010-07-04 Thread Nikos Balkanas
ginal Message - From: "Milan P. Stanic" To: Sent: Sunday, July 04, 2010 10:47 PM Subject: Re: Patch: test/drive_smpp.c [ You shouldn't post replies to me. I'm subscribed to list ] On Sun, 2010-07-04 at 13:22, Nikos Balkanas wrote: If styling rules are one man's

Re: Patch: test/drive_smpp.c

2010-07-04 Thread Alejandro Guerrieri
ther he will submit it or not. > > BR, > Nikos > ----- Original Message - From: "Milan P. Stanic" > To: > Sent: Sunday, July 04, 2010 10:47 PM > Subject: Re: Patch: test/drive_smpp.c > > >> [ You shouldn't post replies to me. I'm subscribed t

Re: Patch: test/drive_smpp.c

2010-07-04 Thread Milan P. Stanic
t. > BR, > Nikos > - Original Message - From: "Milan P. Stanic" > > To: > Sent: Sunday, July 04, 2010 10:47 PM > Subject: Re: Patch: test/drive_smpp.c > > > >[ You shouldn't post replies to me. I'm subscribed to list ] > > > &g

Re: Patch: test/drive_smpp.c

2010-07-04 Thread Konstantin Vayner
ether to accept it or not. And it is up to the > > contributor, based on those rules, whether he will submit it or not. > > > BR, > > Nikos > > - Original Message - From: "Milan P. Stanic" > > > > To: > > Sent: Sunday, July 04, 2010 10:47

Re: Patch: test/drive_smpp.c

2010-07-04 Thread Milan P. Stanic
[ This is totally of-topic to the list. I will resist after that post and sorry for this one ] On Mon, 2010-07-05 at 01:54, Konstantin Vayner wrote: > @Milan, > > Actually, this is quite normal to reply *to* specific person and cc to list. > This is nothing new, and in fact this is default beha