This is a patch to the pcl812.c file that fixes up the following
issues:
ERROR: code indent should use tabs where possible x 27
WARNING: line over 80 characters x 37
WARNING: please, no space before tabs x 13
WARNING:
Add another device ID as listed in the vendor driver version
0003.0825.2009.
Signed-off-by: Ben Hutchings
---
Again, I don't know whether this device actually works.
Ben.
drivers/staging/rtl8192u/r8192U_core.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/st
The rtl8192s_usb driver was claiming a number of device IDs which are
actually supported by the code in the rtl8192u_usb driver. Remove
them from rtl8192s_usb, and add more device IDs as listed in the
vendor driver version 0003.0825.2009.
Signed-off-by: Ben Hutchings
---
I don't know whether the
On Thu, 2010-06-17 at 16:28 -0700, Greg KH wrote:
> On Thu, Jun 17, 2010 at 04:15:58PM -0700, Joe Perches wrote:
> > On Thu, 2010-06-17 at 15:51 -0700, Greg KH wrote:
> > > On Sat, Jun 12, 2010 at 10:30:50PM -0700, Joe Perches wrote:
> > > > On Sat, 2010-06-12 at 22:07 -0700, Joe Perches wrote:
> >
On Thu, Jun 17, 2010 at 04:15:58PM -0700, Joe Perches wrote:
> On Thu, 2010-06-17 at 15:51 -0700, Greg KH wrote:
> > On Sat, Jun 12, 2010 at 10:30:50PM -0700, Joe Perches wrote:
> > > On Sat, 2010-06-12 at 22:07 -0700, Joe Perches wrote:
> > > > 2: Create some comedi logging functions or macros lik
On Thu, 2010-06-17 at 15:51 -0700, Greg KH wrote:
> On Sat, Jun 12, 2010 at 10:30:50PM -0700, Joe Perches wrote:
> > On Sat, 2010-06-12 at 22:07 -0700, Joe Perches wrote:
> > > 2: Create some comedi logging functions or macros like:
> > > comedi_(fmt, arg...) (ie: comedi_info, comedi_err,
On Thu, Jun 17, 2010 at 10:00:11AM +0300, Matti Lammi wrote:
> Fixed a few "line over 80 characters" warnings. One of those lines were an
> actual code line and I don't know if my corresction is sufficent with that
> part. This is my third patch.
>
> Signed-off-by: Matti Lammi
> ---
> drivers/st
On Wed, Jun 16, 2010 at 07:30:44PM +0100, John Sheehan wrote:
> From: John Sheehan
>
> fix some warnings in adl_pci9111.c reported by
> checkpatch.pl tool
> -printk() should include KERN_ facility level
> -no space before tabs
>
> Signed-off-by: John Sheehan
> ---
> drivers/staging/comedi/driv
On Mon, Jun 14, 2010 at 11:04:51AM +0300, Henri Häkkinen wrote:
> Cleaned up and fixed coding convention issues as reported by checkpatch.pl
> on the file `drivers/adl_pci9111.c' as well as other minor changes for
> consistency and clarity.
For some reason, parts of this patch no longer apply. Ca
On Mon, Jun 14, 2010 at 09:34:15AM +0300, Henri Häkkinen wrote:
> Cleaned up and fixed coding convention issues as reporteed by
> checkpatch.pl tool on the file `drivers.c'. Added logging macros
> to `comedidev.h'. Replaced "BUG:" printk functions calls with
> BUG_ON macro.
>
> Signed-off-by: Hen
On Tue, Jun 15, 2010 at 12:43:31AM -0500, Gustavo Silva wrote:
> 2010/6/14 Ian Abbott :
> > On 13/06/10 04:25, Gustavo Silva wrote:
> >> + * Driver: pcl812
> >> + * Description: Advantech PCL-812/PG, PCL-813/B,
> >> + * ADLink ACL-8112DG/HG/PG, ACL-8113, ACL-8216,
> >> + * ICP DAS
On Sat, Jun 12, 2010 at 10:30:50PM -0700, Joe Perches wrote:
> On Sat, 2010-06-12 at 22:07 -0700, Joe Perches wrote:
> > 2: Create some comedi logging functions or macros like:
> > comedi_(fmt, arg...) (ie: comedi_info, comedi_err, etc)
> >where "comedi:" is always prefixed and an
> >op
On Thu, 2010-06-17 at 13:36 -0700, Greg KH wrote:
> On Sat, May 29, 2010 at 10:05:44AM +0100, Maurice Dawson wrote:
> > This is a patch to the ni_labpc.c file that fixes most over 80
> > character warnings found by the checkpatch.pl tool. Two lines, 4 and
> > 1035 have not been changed because read
Hello Javier,
Op 17-6-2010 19:46, Javier Martinez Canillas schreef:
2) #ifdefs are ugly
Code cluttered with ifdefs is difficult to read and maintain. Don't do
it. Instead, put your ifdefs in a header, and conditionally define
'static inline'
That's very true. The wlags49_h2 driver is ful
On Fri, May 28, 2010 at 04:31:28PM +0100, John Sheehan wrote:
> From: John Sheehan
>
> A patch for s626.c to fix errors reported by
> checkpatch.pl tool, namely,
> code indent should use tabs where possible
> "foo * bar" should be "foo *bar"
> trailing statements should be on next line
>
> Signe
On Sat, May 29, 2010 at 10:05:44AM +0100, Maurice Dawson wrote:
> This is a patch to the ni_labpc.c file that fixes most over 80 character
> warnings found by the checkpatch.pl tool. Two lines, 4 and 1035 have not been
> changed because readability is better and no information is hidden
>
> Sign
Greetings From Dubai,
This message might meet you in (utmost surprise),however,it's just my urgent
need for foreign partner that made me to contact you for this transaction.I am
a banker by profession from United Arab Emirates and currently holding the post
of Director Auditing and Accounting
On Thu, Jun 17, 2010 at 07:23:32PM +0200, Henk de Groot wrote:
> Javier,
>
> I assumed Greg KH already added this last version of your patch to the
> queue for the staging tree. Anyway I think it's fine. The only problem I
> see is a possible complained from the compiler because of an argument
Hank,
Thank you very much for your feedback.
On Thu, Jun 17, 2010 at 1:23 PM, Henk de Groot wrote:
> The only problem I see is a
> possible complained from the compiler because of an argument that's defined
> but never used. The only way around that is to avoid the call to the
> function in the
Javier,
I assumed Greg KH already added this last version of your patch to the
queue for the staging tree. Anyway I think it's fine. The only problem I
see is a possible complained from the compiler because of an argument
that's defined but never used. The only way around that is to avoid the
On Thu, Jun 17, 2010 at 07:09:01AM +0530, Nitin Gupta wrote:
> On 06/17/2010 12:13 AM, Greg KH wrote:
> > On Wed, Jun 16, 2010 at 07:44:20AM +0530, Nitin Gupta wrote:
> >> Hi Greg,
> >>
> >> On 05/28/2010 09:56 PM, Greg KH wrote:
> >>> On Fri, May 28, 2010 at 09:38:53PM +0530, Nitin Gupta wrote:
>
On Thu, 2010-06-17 at 11:43 +0300, Matti Lammi wrote:
> Another small fix.
>
> Signed-off-by: Matti Lammi
> ---
> drivers/staging/otus/athr_common.h |3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/otus/athr_common.h
> b/drivers/staging/otus/athr_
This doesn't change the behavior. It just silences a sparse warning.
drivers/staging/wlan-ng/hfa384x_usb.c:2810:62: warning: dubious: !x | !y
The point of the bitwise OR is so that a logical OR could short circuit
the second call to test_and_set_bit().
Signed-off-by: Dan Carpenter
diff --git
>> The patch is ok. I'm pretty sure that it will get merged eventually.
>
> To be honest, it wouldn't surprise me if it didn't get merged until
> 2.6.36. It fixes a build error yes, but it's also a staging thing so
> there might not be a rush on it.
>
Thank you very much for the feedback Dan.
B
Fixed all errors and a lot of wornings reported by the checkpatch.pl tool.
Signed-off-by: Matti Lammi
---
drivers/staging/otus/usbdrv.c | 721 +
1 files changed, 362 insertions(+), 359 deletions(-)
diff --git a/drivers/staging/otus/usbdrv.c b/drivers/sta
Fixed all warning reported by the checkpatch.pl tool by removing unnecessary
spaces.
Signed-off-by: Matti Lammi
---
drivers/staging/otus/oal_marc.h | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/otus/oal_marc.h b/drivers/staging/otus/oal
Moved braces and removed some unnecessary spaces. Just small fixes.
Signed-off-by: Matti Lammi
---
drivers/staging/otus/ioctl.c | 41 +
1 files changed, 17 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/otus/ioctl.c b/drivers/staging/otus/i
Another small fix.
Signed-off-by: Matti Lammi
---
drivers/staging/otus/athr_common.h |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/otus/athr_common.h
b/drivers/staging/otus/athr_common.h
index 3e32f5b..c58ffee 100644
--- a/drivers/staging/otus/athr_c
Nothing special really, just a small fix.
Signed-off-by: Matti Lammi
---
drivers/staging/otus/apdbg.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/otus/apdbg.c b/drivers/staging/otus/apdbg.c
index b59028e..32c26e5 100644
--- a/drivers/staging/otus/apd
On Thu, Jun 17, 2010 at 01:17:44AM -0400, Javier Martinez Canillas wrote:
> Hello,
>
> Didn't get any feedback so resending the patch.
>
The patch is ok. I'm pretty sure that it will get merged eventually.
To be honest, it wouldn't surprise me if it didn't get merged until
2.6.36. It fixes a
Fixed a few "line over 80 characters" warnings. One of those lines were an
actual code line and I don't know if my corresction is sufficent with that
part. This is my third patch.
Signed-off-by: Matti Lammi
---
drivers/staging/comedi/drivers.c | 17 +++--
1 files changed, 11 insert
31 matches
Mail list logo
