Re: Writing a driver for Logitech G710+, need help.

2013-04-18 Thread Greg KH
On Thu, Apr 18, 2013 at 01:20:49PM +0400, K900 wrote: > Hi, > I've got a Logitech G710+ keyboard here, and it's not exactly 100% > working ('normal' keys and media controls work, 'programmable' keys > don't) out of the box. So I started playing with it, and I think I > know how to implement all the

Re: [PATCH v2] mfd:rtsx: Support RTS5249

2013-04-18 Thread wwang
于 2013年04月19日 06:50, Samuel Ortiz 写道: Hi Wei, On Thu, Apr 11, 2013 at 10:43:40AM +0800, wei_w...@realsil.com.cn wrote: From: Wei WANG Support new model: RTS5249 Could you please provide me with a more detailled changelog (What's so different with this model that the current driver does not s

Re: [PATCH v2] mfd:rtsx: Support RTS5249

2013-04-18 Thread Samuel Ortiz
Hi Wei, On Thu, Apr 11, 2013 at 10:43:40AM +0800, wei_w...@realsil.com.cn wrote: > From: Wei WANG > > Support new model: RTS5249 Could you please provide me with a more detailled changelog (What's so different with this model that the current driver does not support ?) before I apply it ? Cheer

[PATCH v2 11/11] staging: comedi: drivers: free_irq() in comedi_legacy_detach()

2013-04-18 Thread H Hartley Sweeten
All the legacy comedi drivers now call comedi_legacy_detach() either directly or as part of their (*detach). Move the free_irq() into comedi_legacy_detach() so that the drivers don't have to deal with it. For drivers that then only call comedi_legacy_detach() in their private (*detach), remove the

[PATCH v2 10/11] staging: comedi: drivers: use comedi_legacy_detach()

2013-04-18 Thread H Hartley Sweeten
Use comedi_legacy_detach() to release the I/O region requested by these drivers. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/aio_aio12_8.c| 3 +-- drivers/staging/comedi/drivers/amplc_pc236.c| 3 +-- drivers/staging/comedi/d

[PATCH v2 07/11] staging: comedi: drivers: use comedi_legacy_detach() in simple drivers

2013-04-18 Thread H Hartley Sweeten
Use the new comedi_legacy_detach() helper in the (*detach) to release the I/O region requested by these drivers. Since the (*detach) for these drivers only releases the region, remove the private (*detach) functions and use comedi_legacy_detach() directly for the (*detach). Signed-off-by: H Hartl

[PATCH v2 09/11] staging: comedi: skel: use comedi_legacy_detach()

2013-04-18 Thread H Hartley Sweeten
Update the skeleton driver to use the new comedi_legacy_detach() helper in the (*detach) to release the I/O region. Also, update the comment about it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/skel.c | 9 + 1 file changed,

[PATCH v2 06/11] staging: comedi: das1800: use comedi_legacy_detach()

2013-04-18 Thread H Hartley Sweeten
Use the new comedi_legacy_detach() helper in the (*detach) to release the first I/O region requested by this driver. An additional I/O region is requested for some of the boards this driver supports. The iobase for that region is stored in the private data so that the (*detach) knows it needs to b

[PATCH v2 08/11] staging: comedi: amplc_dio200: use comedi_legacy_detach()

2013-04-18 Thread H Hartley Sweeten
The I/O region used by this driver is always requested using comedi_request_region(). The devpriv->io union is only used by the common code shared by the legacy and PCI drivers. Use the new comedi_legacy_detach() helper in the (*detach) to release the I/O region requested by this driver. That func

[PATCH v2 05/11] staging: comedi: das16m1: check for subdev_8255_init() failure

2013-04-18 Thread H Hartley Sweeten
Make sure to check if subdev_8255_init() fails and propogate the error code. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16m1.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers

[PATCH v2 04/11] staging: comedi: das16m1: use comedi_legacy_detach()

2013-04-18 Thread H Hartley Sweeten
Use the new comedi_legacy_detach() helper in the (*detach) to release the first I/O region requested by this driver. An additional I/O region is requested by this driver for the 8255 device. Save the iobase for that region in the private data so that the (*detach) knows it needs to be released. S

[PATCH v2 02/11] staging: comedi: pcl812: use comedi_legacy_detach()

2013-04-18 Thread H Hartley Sweeten
This driver does not follow the standard (*attach) (*detach) flow of the other drivers in comedi. Comedi drivers do not 'cleanup' any of the allocations made during the (*attach) if failures are encountered. If the (*attach) fails, the comedi core will call the (*detach) to handle any clenaup. In

[PATCH v2 03/11] staging: comedi: das16: use comedi_legacy_detach()

2013-04-18 Thread H Hartley Sweeten
Use the new comedi_legacy_detach() helper in the (*detach) to release the first I/O region requested by this driver. An additional I/O region is requested for some of the boards this driver supports. Save the iobase for that region in the private data so that the (*detach) knows it needs to be rel

[PATCH v2 01/11] staging: comedi: drivers: introduce comedi_legacy_detach()

2013-04-18 Thread H Hartley Sweeten
This function is intended to be used by the comedi legacy (ISA) drivers either directly as the (*detach) function or as a helper in the drivers private (*detach) function. Modify the comedi_request_region() helper so that it stores the 'len' of the region as well as the 'start' after the region ha

[PATCH v2 00/11] staging: comedi: tidy up legacy driver detach

2013-04-18 Thread H Hartley Sweeten
Tidy up the (*detach) boilerplate code for comedi legacy drivers. Introduce a common (*detach) function for the legacy drivers. This function will automatically release the first I/O region that a driver requests using the comedi_request_region() helper. It will also automatically free any irq res

RE: [PATCH 12/12] staging: comedi: comedi_pci: free_irq() in comedi_pci_disable()

2013-04-18 Thread H Hartley Sweeten
On Thursday, April 18, 2013 10:44 AM, Ian Abbott wrote: > On 2013/04/18 04:51 PM, H Hartley Sweeten wrote: >> On Thursday, April 18, 2013 5:06 AM, Ian Abbott wrote: >>> On 2013-04-17 19:20, H Hartley Sweeten wrote: All the PCI comedi drivers call comedi_pci_disable() either directly or as

RE: [PATCH 01/12] staging: comedi: drivers: introduce comedi_legacy_detach()

2013-04-18 Thread H Hartley Sweeten
On Thursday, April 18, 2013 10:26 AM, Ian Abbott wrote: > On 2013/04/18 04:35 PM, H Hartley Sweeten wrote: >> On Thursday, April 18, 2013 3:37 AM, Ian Abbott wrote: >>> On 2013-04-17 19:16, H Hartley Sweeten wrote: This function is intended to be used by the comedi legacy (ISA) drivers ei

Re: [PATCH 12/12] staging: comedi: comedi_pci: free_irq() in comedi_pci_disable()

2013-04-18 Thread Ian Abbott
On 2013/04/18 04:51 PM, H Hartley Sweeten wrote: > On Thursday, April 18, 2013 5:06 AM, Ian Abbott wrote: >> On 2013-04-17 19:20, H Hartley Sweeten wrote: >>> All the PCI comedi drivers call comedi_pci_disable() either directly >>> or as part of their (*detach). Move the free_irq() into comedi_pci_

Re: [PATCH 01/12] staging: comedi: drivers: introduce comedi_legacy_detach()

2013-04-18 Thread Ian Abbott
On 2013/04/18 04:35 PM, H Hartley Sweeten wrote: > On Thursday, April 18, 2013 3:37 AM, Ian Abbott wrote: >> On 2013-04-17 19:16, H Hartley Sweeten wrote: >>> This function is intended to be used by the comedi legacy (ISA) drivers >>> either directly as the (*detach) function or as a helper in the

Please, apply patch both 3.10 and 3.9 Re: [PATCH 1/1] X86: Handle Xen emulation of Hyper-V more gracefully

2013-04-18 Thread Victor Miasnikov
Hi! - /* - * Xen emulates Hyper-V to support enlightened Windows. - * Check to see first if we are on a Xen Hypervisor. - */ - if (xen_cpuid_base()) - return false; . . . void hv_register_vmbus_handler(int irq, irq_handler_t handler) { + /* + * Setup the IDT for hypervisor callback. + *

RE: [PATCH 12/12] staging: comedi: comedi_pci: free_irq() in comedi_pci_disable()

2013-04-18 Thread H Hartley Sweeten
On Thursday, April 18, 2013 5:06 AM, Ian Abbott wrote: > On 2013-04-17 19:20, H Hartley Sweeten wrote: >> All the PCI comedi drivers call comedi_pci_disable() either directly >> or as part of their (*detach). Move the free_irq() into comedi_pci_disable() >> so that the drivers don't have to deal wi

RE: [PATCH 01/12] staging: comedi: drivers: introduce comedi_legacy_detach()

2013-04-18 Thread H Hartley Sweeten
On Thursday, April 18, 2013 3:37 AM, Ian Abbott wrote: > On 2013-04-17 19:16, H Hartley Sweeten wrote: >> This function is intended to be used by the comedi legacy (ISA) drivers >> either directly as the (*detach) function or as a helper in the drivers >> private (*detach) function. >> >> Modify th

Re: [PATCH 1/1] X86: Handle Xen emulation of Hyper-V more gracefully

2013-04-18 Thread Michael S. Tsirkin
On Thu, Apr 18, 2013 at 08:44:46AM -0700, K. Y. Srinivasan wrote: > Install the Hyper-V specific interrupt handler only when needed. This would > permit us to get rid of the Xen check. Note that when the vmbus drivers > invokes > the call to register its handler, we are sure to be running on Hyper

[PATCH 1/1] X86: Handle Xen emulation of Hyper-V more gracefully

2013-04-18 Thread K. Y. Srinivasan
Install the Hyper-V specific interrupt handler only when needed. This would permit us to get rid of the Xen check. Note that when the vmbus drivers invokes the call to register its handler, we are sure to be running on Hyper-V. Signed-off-by: K. Y. Srinivasan --- arch/x86/kernel/cpu/mshyperv.c |

RE: [PATCH 2/3] X86: Add a check to catch Xen emulation of Hyper-V

2013-04-18 Thread KY Srinivasan
> -Original Message- > From: devel [mailto:devel-boun...@linuxdriverproject.org] On Behalf Of KY > Srinivasan > Sent: Thursday, April 18, 2013 9:23 AM > To: Michael S. Tsirkin > Cc: o...@aepfle.de; gre...@linuxfoundation.org; jasow...@redhat.com; > x...@kernel.org; linux-ker...@vger.kerne

RE: [PATCH 2/3] X86: Add a check to catch Xen emulation of Hyper-V

2013-04-18 Thread KY Srinivasan
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Thursday, April 18, 2013 3:48 AM > To: KY Srinivasan > Cc: Jan Beulich; o...@aepfle.de; b...@alien8.de; a...@canonical.com; > x...@kernel.org; t...@linutronix.de; devel@linuxdriverproject.org; > gre...@linuxf

Re: [PATCH 12/12] staging: comedi: comedi_pci: free_irq() in comedi_pci_disable()

2013-04-18 Thread Ian Abbott
On 2013-04-17 19:20, H Hartley Sweeten wrote: All the PCI comedi drivers call comedi_pci_disable() either directly or as part of their (*detach). Move the free_irq() into comedi_pci_disable() so that the drivers don't have to deal with it. For drivers that then only call comedi_pci_disable() in

Re: [PATCH 01/12] staging: comedi: drivers: introduce comedi_legacy_detach()

2013-04-18 Thread Ian Abbott
On 2013-04-18 11:48, Ian Abbott wrote: On 2013-04-18 11:36, Ian Abbott wrote: An alternative implementation would be to leave __comedi_request_region() alone, but change comedi_request_region() to record the length in a new member dev->iolen at the same time that it records the start address in

Re: [PATCH 01/12] staging: comedi: drivers: introduce comedi_legacy_detach()

2013-04-18 Thread Ian Abbott
On 2013-04-18 11:36, Ian Abbott wrote: An alternative implementation would be to leave __comedi_request_region() alone, but change comedi_request_region() to record the length in a new member dev->iolen at the same time that it records the start address in dev->iobase. Then your comedi_legacy_d

Re: [PATCH 01/12] staging: comedi: drivers: introduce comedi_legacy_detach()

2013-04-18 Thread Ian Abbott
On 2013-04-17 19:16, H Hartley Sweeten wrote: This function is intended to be used by the comedi legacy (ISA) drivers either directly as the (*detach) function or as a helper in the drivers private (*detach) function. Modify the __comedi_request_region() helper so that it stores the first struct

Writing a driver for Logitech G710+, need help.

2013-04-18 Thread K900
Hi, I've got a Logitech G710+ keyboard here, and it's not exactly 100% working ('normal' keys and media controls work, 'programmable' keys don't) out of the box. So I started playing with it, and I think I know how to implement all the features (spec wise). I have Python proof-of-concept code here:

Re: [PATCH 2/3] X86: Add a check to catch Xen emulation of Hyper-V

2013-04-18 Thread Michael S. Tsirkin
On Wed, Apr 17, 2013 at 04:28:36PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Jan Beulich [mailto:jbeul...@suse.com] > > Sent: Wednesday, April 17, 2013 11:51 AM > > To: KY Srinivasan; Michael S. Tsirkin > > Cc: o...@aepfle.de; b...@alien8.de; a...@canonical.com; x..

Re: [PATCH 03/12] staging: comedi: das16: use comedi_legacy_detach()

2013-04-18 Thread Dan Carpenter
On Thu, Apr 18, 2013 at 11:27:36AM +0300, Dan Carpenter wrote: > On Wed, Apr 17, 2013 at 11:17:42AM -0700, H Hartley Sweeten wrote: > > static int das16_cmd_test(struct comedi_device *dev, struct > > comedi_subdevice *s, > > @@ -1122,11 +1124,9 @@ static int das16_attach(struct comedi_device *dev

Re: [PATCH 03/12] staging: comedi: das16: use comedi_legacy_detach()

2013-04-18 Thread Dan Carpenter
On Wed, Apr 17, 2013 at 11:17:42AM -0700, H Hartley Sweeten wrote: > Use the new comedi_legacy_detach() helper in the (*detach) to release > the first I/O region requested by this driver. > > An additional I/O region is requested for some of the boards this driver > supports. Save the iobase for t