Re: [PATCH 01/23] staging/lustre/clio: don't ignore layout on writeback

On 2013-05-31, at 11:29, "Greg Kroah-Hartman" mailto:gre...@linuxfoundation.org>> wrote: On Sat, Jun 01, 2013 at 01:22:51AM +0800, Peng Tao wrote: From: Niu Yawei mailto:yawei@intel.com>> In some cases such as kernel writeback, we shouldn't ignore the layout, otherwise, it could race with lay

[PATCH 4/9] staging: csr: Add space around equal sign

Added space around equal sign when necessary to resolve errors generated by checkpatch.pl and meet kernel coding standards in sme_userspace.c Signed-off-by: Lisa Nguyen --- drivers/staging/csr/sme_userspace.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/stagi

[PATCH 6/9] staging: csr: Fix assignment error in if statement

Fixed the assignment error generated by checkpatch.pl to meet kernel coding standards in sme_userspace.c Signed-off-by: Lisa Nguyen --- drivers/staging/csr/sme_userspace.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/csr/sme_userspace.c b/drivers/staging

[PATCH 9/9] staging: csr: Move else keyword up to follow after }

Resolved a closing brace issue generated by checkpatch.pl to meet kernel coding standards in sme_userspace.c Signed-off-by: Lisa Nguyen --- drivers/staging/csr/sme_userspace.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/csr/sme_userspace.c b/drivers/sta

[PATCH 8/9] staging: csr: Move open brace to previous line

Moved open braces to previous lines to resolve errors generated by checkpatch.pl and meet kernel coding standards in sme_userspace.c Signed-off-by: Lisa Nguyen --- drivers/staging/csr/sme_userspace.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/csr/sm

[PATCH 7/9] staging: csr: Reformat pointer type casts

Reformatted pointer type casts to resolve errors generated by checkpatch.pl and meet kernel coding standards in sme_userspace.c Signed-off-by: Lisa Nguyen --- drivers/staging/csr/sme_userspace.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/csr/sme_use

[PATCH 3/9] staging: csr: Add space after comma

Added space after commas when necessary to resolve errors generated by checkpatch.pl and meet kernel coding standards in sme_userspace.c Signed-off-by: Lisa Nguyen --- drivers/staging/csr/sme_userspace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/csr/

[PATCH 1/9] staging: csr: Fix code indentation errors

Fixed code indentation errors generated by checkpatch.pl to meet kernel coding standards in sme_userspace.c Signed-off-by: Lisa Nguyen --- drivers/staging/csr/sme_userspace.c | 217 ++-- 1 file changed, 109 insertions(+), 108 deletions(-) diff --git a/drivers/sta

[PATCH 2/9] staging: csr: Add space before open parenthesis

Added space before an open parenthesis wherever needed to resolve errors generated by checkpatch.pl and meet kernel coding standards in sme_userspace.c Signed-off-by: Lisa Nguyen --- drivers/staging/csr/sme_userspace.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff

[PATCH 5/9] staging: csr: Add space before open brace

Added space before each open brace when necessary to resolve errors generated by checkpatch.pl and meet kernel coding standards in sme_userspace.c Signed-off-by: Lisa Nguyen --- drivers/staging/csr/sme_userspace.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/driver

[RFC v2 4/5] rtl8192u: remove unnecessary line continuations in r8192U_core.c

This patch fixes the following checkpatch warning: WARNING: Avoid unnecessary line continuations Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r8192U_core.c | 50 +++- 1 file changed, 24 insertions(+), 26 deletions(-) diff --git a/drivers/staging/rtl

[RFC v2 3/5] rtl8192u: fix function definitions' style in r8192U_core.c

This patch fixes the function definitions' style in order to be uniform across the file and in compliance with the linux kernel coding style. Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r8192U_core.c | 114 ++-- 1 file changed, 34 insertions(+), 80 d

Re: [PATCH 01/23] staging/lustre/clio: don't ignore layout on writeback

On Sat, Jun 01, 2013 at 10:33:38AM +0800, Peng Tao wrote: > On Sat, Jun 1, 2013 at 1:29 AM, Greg Kroah-Hartman > wrote: > > On Sat, Jun 01, 2013 at 01:22:51AM +0800, Peng Tao wrote: > >> From: Niu Yawei > >> > >> In some cases such as kernel writeback, we shouldn't ignore the > >> layout, otherwi

Re: [PATCH 01/23] staging/lustre/clio: don't ignore layout on writeback

On Sat, Jun 1, 2013 at 1:29 AM, Greg Kroah-Hartman wrote: > On Sat, Jun 01, 2013 at 01:22:51AM +0800, Peng Tao wrote: >> From: Niu Yawei >> >> In some cases such as kernel writeback, we shouldn't ignore the >> layout, otherwise, it could race with layout change undergoing. >> >> Intel-bug-id: LU-

Re: [PATCH 3/3] rtl8192e cleanups

On Fri, 31 May 2013 04:16:35 -0700 Greg KH wrote: > Also, you send 3 patches, with the same exact subject, please be more > descriptive of what you are doing in the subject to make them unique. > > Can you refresh these against the latest linux-next release and resend > them so that I can apply

Re: [PATCH 1/3] rtl8192e cleanups

On Fri, 31 May 2013 09:37:02 +0300 Dan Carpenter wrote: > I just had a patch go in here yesterday so these don't apply any > more, sorry. I will fix that. > > +#if 0 > > struct phy_ofdm_rx_status_rxsc_sgien_exintfflag { > > u8 reserved:4; > > u8

Re: [RFC 5/5] rtl8192u: fix identation in r8192U_core.c

On 06/01/2013 02:29 AM, Dan Carpenter wrote: On Sat, Jun 01, 2013 at 02:07:18AM +0300, Xenia Ragiadakou wrote: On 06/01/2013 01:47 AM, Dan Carpenter wrote: On Fri, May 31, 2013 at 08:10:52PM +0300, Xenia Ragiadakou wrote: This patch fixes identation and alignment in r8192U_core.c. Also, remove

Re: [PATCH net] hyperv: Fix vlan_proto setting in netvsc_recv_callback()

From: Haiyang Zhang Date: Tue, 28 May 2013 09:15:56 -0700 > Since the recent addition of 8021AD, we need to set the new field vlan_proto > in > sk_buff. Otherwise, it will trigger BUG() call in vlan_proto_idx(). > > This patch fixes the problem. > > Signed-off-by: Haiyang Zhang > Reviewed-by:

Re: [RFC 5/5] rtl8192u: fix identation in r8192U_core.c

On Sat, Jun 01, 2013 at 02:07:18AM +0300, Xenia Ragiadakou wrote: > On 06/01/2013 01:47 AM, Dan Carpenter wrote: > >On Fri, May 31, 2013 at 08:10:52PM +0300, Xenia Ragiadakou wrote: > >>This patch fixes identation and alignment in r8192U_core.c. > >>Also, removes spaces from idents when applicable.

Re: [RFC 5/5] rtl8192u: fix identation in r8192U_core.c

On Sat, Jun 01, 2013 at 02:07:18AM +0300, Xenia Ragiadakou wrote: > On 06/01/2013 01:47 AM, Dan Carpenter wrote: > >On Fri, May 31, 2013 at 08:10:52PM +0300, Xenia Ragiadakou wrote: > >>This patch fixes identation and alignment in r8192U_core.c. > >>Also, removes spaces from idents when applicable.

Re: [RFC 5/5] rtl8192u: fix identation in r8192U_core.c

On Sat, Jun 01, 2013 at 02:07:18AM +0300, Xenia Ragiadakou wrote: > On 06/01/2013 01:47 AM, Dan Carpenter wrote: > >On Fri, May 31, 2013 at 08:10:52PM +0300, Xenia Ragiadakou wrote: > >>This patch fixes identation and alignment in r8192U_core.c. > >>Also, removes spaces from idents when applicable.

Re: [RFC 5/5] rtl8192u: fix identation in r8192U_core.c

On 06/01/2013 01:47 AM, Dan Carpenter wrote: On Fri, May 31, 2013 at 08:10:52PM +0300, Xenia Ragiadakou wrote: This patch fixes identation and alignment in r8192U_core.c. Also, removes spaces from idents when applicable. Signed-off-by: Xenia Ragiadakou --- Please take a look at changes in stag

Re: [RFC 5/5] rtl8192u: fix identation in r8192U_core.c

On Fri, May 31, 2013 at 08:10:52PM +0300, Xenia Ragiadakou wrote: > This patch fixes identation and alignment in r8192U_core.c. > Also, removes spaces from idents when applicable. > > Signed-off-by: Xenia Ragiadakou > --- > > Please take a look at changes in stage: > @@-2686,35 +2688,35 @@ stati

Re: [RFC 2/5] rtl8192u: fix braces in r8192U_core.c

On 06/01/2013 01:11 AM, Dan Carpenter wrote: This one will need to be redone. It introduces new GCC warnings: drivers/staging/rtl8192u/r8192U_core.c:1958:9: warning: mixing declarations and code drivers/staging/rtl8192u/r8192U_core.c:2698:25: warning: mixing declarations and code drivers/stag

Re: [RFC 2/5] rtl8192u: fix braces in r8192U_core.c

This one will need to be redone. It introduces new GCC warnings: drivers/staging/rtl8192u/r8192U_core.c:1958:9: warning: mixing declarations and code drivers/staging/rtl8192u/r8192U_core.c:2698:25: warning: mixing declarations and code drivers/staging/rtl8192u/r8192U_core.c:2809:9: warning: mix

[no subject]

business offer please email me : abd-al-ham...@siamza.com -- The information contained in this e-mail message is intended solely for the recipient(s) and may contain privileged information. Tamper

[PATCH 22/23] staging/lustre/tests: check nr_local in ofd_preprw()

From: Jian Yu This patch checks the number of bulk I/O RPC pages with PTLRPC_MAX_BRW_PAGES in ofd_preprw() to avoid LASSERT(iobuf->dr_npages < iobuf->dr_max_pages) occurring while larger I/O size is specified. The patch also fixes echo_client_prep_commit() to reuse the env context so as to avoid

[PATCH 23/23] staging/lustre/osc: check ostid if no OBD_CONNECT_FID

From: Hongchao Zhang in lustre_set_wire_obdo, if "ocd->ocd_connect_flags" doesn't contain OBD_CONNECT_FID, use "ost_id" to check the type of the object instead of using ost_id.oi_fid only. Intel-bug-id: LU-3360 Lustre-commit: fed98fbd8f0c84c8e757bea96bcc7c251b4ffe30 Lustre-change: http://review.

Re: [PATCH 01/23] staging/lustre/clio: don't ignore layout on writeback

On Sat, Jun 01, 2013 at 01:22:51AM +0800, Peng Tao wrote: > From: Niu Yawei > > In some cases such as kernel writeback, we shouldn't ignore the > layout, otherwise, it could race with layout change undergoing. > > Intel-bug-id: LU-3160 What can I do with this number? > Lustre-commit: 3141db609

[PATCH 21/23] staging/lustre/osc: fixed a typo in osc_cache_truncate_start

From: Jinshan Xiong Dump osc_extent waiting instead of ext in case error occurred. Intel-bug-id: LU-3359 Lustre-commit: 5a3610b711efff16cd14a098aa20f87a7055ba1a Lustre-change: http://review.whamcloud.com/6402 Signed-off-by: Jinshan Xiong Reviewed-by: Lai Siyao Reviewed-by: Oleg Drokin [updat

[PATCH 19/23] staging/lustre/llite: Always build 64bit ino internally

From: wang di Always build 64bit ino internally except the client is mounted with "32bitapi" option, so client will always use 64bit ino internally. It will build 32bit ino, only if application requires 32 bit ino. Intel-bug-id: LU-3318 Lustre-commit: cf775525f5fa8c96d073809a6afc4af0643dda9a Lus

[PATCH 20/23] staging/lustre/lprocfs: interpret result of dt_statfs() correctly

From: "John L. Hammond" In a7369bcd860af61a073cb2424139e3acccdcb203, I accidentally reversed the sense of the error check after the call to dt_statfs() in lprocfs_dt_rd_{blksize,{files,kbytes}{free,avail}. Unreverse the error checking. Intel-bug-id: LU-3300 Lustre-commit: 09b6f7b2f8832cca4dcf837

[PATCH 18/23] staging/lustre/mdt: set ATTR_xTIME_SET to make atime update properly

From: Emoly Liu To make atime update properly between 1.8 client and 2.x server, this patch includes the following fixes: - if MDS_ATTR_xTIME is set without MDS_ATTR_xTIME_SET and the client does not have OBD_CONNECT_FULL20, convert it to LA_xTIME in mdt_setattr_unpack(). - set both MDS_ATTR_

[PATCH 15/23] staging/lustre/changelog: fix CL_LAYOUT, accept all types

From: Andreas Dilger In order to avoid compatibility issues with older ChangeLog consumers, change the new CL_LAYOUT record to use the value previously assigned to CL_IOCTL. The CL_IOCTL type was never used anywhere, and it didn't really make any sense as a ChangeLog record, since it could reall

[PATCH 17/23] staging/lustre/changelog: fix CL_LAYOUT comment, string

From: Andreas Dilger Fix the CL_LAYOUT comment, since it is possible that layout swap could be used in cases where the file content is changed. I don't think there are any real world use cases for this, but that depends on what tools are being used on the filesystem. Also change the "LAYOUT" st

[PATCH 16/23] staging/lustre/ost: Ensure dirty flushed on fiemap ioctl

From: Artem Blagodarenko Data corruption is possible if cp(coreutils) uses FIEMAP to obtain data holes in shared file, since there could be dirty cache on other clients which hasn't been flushed back. To ensure all the dirty on remote clients being flushed back on fiemap ioctl, we'd acquire ldlm

[PATCH 13/23] staging/lustre/ost: check pre 2.4 echo client in obdo validation

From: wang di Because old echo client still uses o_id/o_seq for objid, but new echo client will uses FID for the objid. Add OBD_CONNECT_FID for 2.4 echo client, so 2.4 OST will convert o_id/o_seq to FID if the request from old echo client. Add local flag OBD_FL_OSTID for o_flags to indicate OST

[PATCH 14/23] staging/lustre/lprocfs: use stats counter index for *pos

From: "John L. Hammond" In lprocfs_stats_seq_{start,next,show,stop}() encode the counter index (rather than the counter address) into *pos. Doing so simplifies these functions and fixes a bug in the case of per-CPU stats where no stats would be displayed at all if no events had yet occurred on CP

[PATCH 10/23] staging/lustre/lov: only dump header in lsm_lmm_verify

From: Andreas Dilger If lsm_lmm_verify_*() find an error in the lov_mds_md header structure, don't dump the full stripe information, since this can be totally bogus (e.g. if stripe_count == -1 or similar). Instead, just dump the header information for debugging. Intel-bug-id: LU-3271 Lustre-comm

[PATCH 09/23] staging/lustre/obdclass: remove obsoleted md_local_file.c

From: Mikhail Pershin This library is not used anymore and is replaced by local_storage.c. Patch removed last remnants of it. Intel-bug-id: LU-2886 Lustre-commit: 29e98f581ab68ecdfc1b923925eda2ec5b251f3a Lustre-change: http://review.whamcloud.com/6107 Signed-off-by: Mikhail Pershin Reviewed-by:

[PATCH 11/23] staging/lustre/obdclass: use common way to store lastid

From: Mikhail Pershin Local files last id are stored in root in files named seq-xxx-lastid while lastid for OST objects is stored in O/seq/LAST_ID special object with zero OID and handled by OSD. Patch reworks local files lastid to be stored in O/seq/LAST_ID too and using the same format. Intel-

[PATCH 12/23] staging/lustre/llog: Do not use ostid swab for llogid

From: wang di Since logid still use id/seq format in the request, it will be swabbed by its own swab func, instead of using ostid swab, which might see logid as FID incorrectly. Intel-bug-id: LU-3302 Lustre-commit: 57d8d7f152b1a1cabc103193f859bd927b3fbe9c Lustre-change: http://review.whamcloud.c

[PATCH 08/23] staging/lustre/osc: some cleanup to reduce stack overflow chance

From: Bobi Jam ptlrpcd_add_req() will wake_up other process, do not hold a spinlock before calling ptlrpcd_queue_work()->ptlrpcd_add_req(). If current process is allocating memory, memory shrinker could get to osc_lru_del(), don't call osc_lru_shrink() further since it could lead a long calling

[PATCH 06/23] staging/lustre: Revert "LU-2139 osc: Track and limit "unstable" pages"

From: Oleg Drokin This seems to be causing multiple issues: LU-3274, LU-3277 Lustre-commit: fd2b619ca59739b1978fb3f09690526afa9d00dc [The original commit is folded in the large Lusre patch. So we don't have an exact commit to revert for kernel client -- Peng Tao] [updated for upstream kernel su

[PATCH 07/23] staging/lustre/ldlm: suppress useless lock RPC for layout

From: jcl In ldlm_lock_decref_internal() when l_lvb_data is freed to reduce memory consumption, LDLM_FL_LVB_READY is not cleared, so later when the lock is reused lvb is not updated. But clearing LDLM_FL_LVB_READY forces layout refetch at each file access, so the better is to remove the optimizat

[PATCH 02/23] staging/lustre/ofd: refill env in ofd_get_info

From: wang di Because ofd_get_info(KEY_FIEMAP) might be called from ptlrpc_server_handle_req_in(see the stack below), where env might not be initialized correctly(see LBUG below), so it refill refill in ofd_get_info. LutreError: 19182:0:(ofd_internal.h:518:ofd_info_init()) LBUG Pid: 19182, comm:

[PATCH 05/23] staging/lustre/debug: quiet noisy console error messages

From: Andreas Dilger Quiet a number of overly noisy and unhelpful console error messages. Improve the format of other nearby errors. In the case of {lod,lov}_fix_desc_stripe_size(), this doesn't even need a console message unless it is actually changing some stripe size that is below the minimu

[PATCH 01/23] staging/lustre/clio: don't ignore layout on writeback

From: Niu Yawei In some cases such as kernel writeback, we shouldn't ignore the layout, otherwise, it could race with layout change undergoing. Intel-bug-id: LU-3160 Lustre-commit: 3141db609d95d379761e3b54899618b4037d38f6 Lustre-change: http://review.whamcloud.com/6154 Signed-off-by: Niu Yawei

[PATCH 03/23] staging/lustre/fids: fix compilation error with gcc 4.7.2

From: Alex Zhuravlev initialize oi.oi.oi_id which gcc 4.7.2 is afraid of being used later. Intel-bug-id: LU-3179 Lustre-commit: f2150a414ee84676a2e22809555b3b29898d8d12 Lustre-change: http://review.whamcloud.com/6064 Signed-off-by: Alex Zhuravlev Reviewed-by: wangdi Reviewed-by: Bob Glossman

[PATCH 04/23] staging/lustre/utils: missing setting echo seq for getattr/setattr

From: wang di It should set echo seq before do echo getattr/setattr, otherwise echo_client will regard it as the object with MDT0 sequence. Intel-bug-id: LU-3267 Lustre-commit: 3e2d4d2d7477dd338a87de103027d37865285e44 Lustre-change: http://review.whamcloud.com/6263 Signed-off-by: wang di Review

[PATCH 00/23] staging/lustre: sync with Lustre git repo

Hi Greg, The patchsets port commits from Lustre git repo(*) to kernel client. so that we have the same code base for both. Thanks, Tao (*) git://git.whamcloud.com/fs/lustre-release.git Alex Zhuravlev (1): staging/lustre/fids: fix compilation error with gcc 4.7.2 Andreas Dilger (4): staging

[RFC 4/5] rtl8192u: remove unnecessary line continuations in r8192U_core.c

This patch fixes the following checkpatch warning: WARNING: Avoid unnecessary line continuations Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r8192U_core.c | 50 +++- 1 file changed, 24 insertions(+), 26 deletions(-) diff --git a/drivers/staging/rtl

[RFC 3/5] rtl8192u: fix function definitions' style in r8192U_core.c

This patch fixes the function definitions' style in order to be uniform across the file and in compliance with the linux kernel coding style. Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r8192U_core.c | 114 ++-- 1 file changed, 34 insertions(+), 80 d

[RFC 1/5] rtl8192u: remove dead and commented-out code in r8192U_core.c

This cleanup patch removes commented-out code and the functions rtl8192_dump_reg() and print_buffer() which are not called anywhere in the driver. Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r8192U_core.c | 353 ++-- 1 file changed, 19 insertions(+),

Re: [PATCH] clean up scary strncpy(dst, src, strlen(src)) uses

On Fri, May 31, 2013 at 09:18:07AM -0700, Kees Cook wrote: > Fix various weird constructions of strncpy(dst, src, strlen(src)). Length > limits should be about the space available in the destination, not > repurposed as a method to either always include or always exclude > a trailing NULL byte. Eit

Re: [Patch 2/2] Staging: winbond: Memory & urb freed

On Friday 31 May 2013 10:16 PM, Julia Lawall wrote: > On Fri, 31 May 2013, Dan Carpenter wrote: > >> On Fri, May 31, 2013 at 09:48:58PM +0530, Harsh Kumar wrote: >>> >>> >>> On Friday 31 May 2013 09:27 PM, Dan Carpenter wrote: On Fri, May 31, 2013 at 09:02:11PM +0530, Harsh Kumar wrote: >>>

Re: [Patch 2/2] Staging: winbond: Memory & urb freed

On Fri, 31 May 2013, Dan Carpenter wrote: > On Fri, May 31, 2013 at 09:48:58PM +0530, Harsh Kumar wrote: > > > > > > On Friday 31 May 2013 09:27 PM, Dan Carpenter wrote: > > > On Fri, May 31, 2013 at 09:02:11PM +0530, Harsh Kumar wrote: > > >> Memory & urb should be freed before exiting from the f

Re: [Patch 2/2] Staging: winbond: Memory & urb freed

On Fri, May 31, 2013 at 09:48:58PM +0530, Harsh Kumar wrote: > > > On Friday 31 May 2013 09:27 PM, Dan Carpenter wrote: > > On Fri, May 31, 2013 at 09:02:11PM +0530, Harsh Kumar wrote: > >> Memory & urb should be freed before exiting from the function, I think. > >> > > > > They are freed in Wb3

Re: [Patch 2/2] Staging: winbond: Memory & urb freed

On Friday 31 May 2013 09:27 PM, Dan Carpenter wrote: > On Fri, May 31, 2013 at 09:02:11PM +0530, Harsh Kumar wrote: >> Memory & urb should be freed before exiting from the function, I think. >> > > They are freed in Wb35Reg_EP0VM_complete() so this patch will make > the system crash right away.

[PATCH] clean up scary strncpy(dst, src, strlen(src)) uses

Fix various weird constructions of strncpy(dst, src, strlen(src)). Length limits should be about the space available in the destination, not repurposed as a method to either always include or always exclude a trailing NULL byte. Either the NULL should always be copied (using strlcpy), or it should

Re: [Patch 2/2] Staging: winbond: Memory & urb freed

On Fri, May 31, 2013 at 09:02:11PM +0530, Harsh Kumar wrote: > Memory & urb should be freed before exiting from the function, I think. > They are freed in Wb35Reg_EP0VM_complete() so this patch will make the system crash right away. Btw, there are tons of real bugs that I know about but which I

[Patch 2/2] Staging: winbond: Memory & urb freed

Memory & urb should be freed before exiting from the function, I think. Note: This patch is to be applied after applying the earlier patch i.e [patch 1/2] Signed-off-by: Harsh Kumar --- drivers/staging/winbond/wb35reg.c | 12 1 file changed, 12 insertions(+) diff -uprN a/drive

[Patch 1/2] Staging: winbond: Check for unsuccessful allocation immediately

Check to see if allocation by kzalloc() or usb_alloc_urb() was unsuccessful immediately after the allocation. Exit from the function can be right at that point in case of allocation failure. This avoids unnecessary use of usb_alloc_urb() & usb_free_urb() if kzalloc() returns NULL. Also, makes th

Re: [PATCH 3/3] rtl8192e cleanups

On Thu, May 30, 2013 at 10:22:21PM -0400, Sean MacLennan wrote: > Cleanup unused portions of rtl_core.h. > > Signed-off-by: Sean MacLennan As Dan said, these will not apply anymore. Also, you send 3 patches, with the same exact subject, please be more descriptive of what you are doing in the su

RE: [PATCH 4/4] staging/lustre: drop CONFIG_BROKEN dependency

> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Friday, May 31, 2013 2:17 PM > To: Peng, Tao > Cc: Dilger, Andreas; Greg Kroah-Hartman; de...@driverdev.osuosl.org; Peng Tao > Subject: Re: [PATCH 4/4] staging/lustre: drop CONFIG_BROKEN dependency > > Ple