Re: Adding additional flag in cmake-rpm-macros to disallow the use of the FetchContent module

2024-05-27 Thread Cristian Le via devel
On 2024/05/27 10:09, Vitaly Zaitsev via devel wrote: On 27/05/2024 02:46, Kan-Ru Chen wrote: It is documented that FIND_PACKAGE_ARGS argument in FetchContent_Declare should instruct it to find system packages first. This only works as expected in very rare cases. The library name in

Re: Adding additional flag in cmake-rpm-macros to disallow the use of the FetchContent module

2024-05-27 Thread Vitaly Zaitsev via devel
On 27/05/2024 02:22, Byoungchan Lee via devel wrote: In well-maintained Fedora packages, the use of the FetchContent module is generally discouraged because dependencies are already available in the Fedora repositories. FetchContent never worked on Fedora because the builders have no network

Re: Adding additional flag in cmake-rpm-macros to disallow the use of the FetchContent module

2024-05-27 Thread Vitaly Zaitsev via devel
On 27/05/2024 02:46, Kan-Ru Chen wrote: It is documented that FIND_PACKAGE_ARGS argument in FetchContent_Declare should instruct it to find system packages first. This only works as expected in very rare cases. The library name in FetchContent() must match the name in find_package(). This

Re: Adding additional flag in cmake-rpm-macros to disallow the use of the FetchContent module

2024-05-26 Thread Neal Gompa
On Sun, May 26, 2024 at 8:47 PM Kan-Ru Chen wrote: > > On Mon, May 27, 2024, at 9:22 AM, Byoungchan Lee via devel wrote: > > In well-maintained Fedora packages, the use of the FetchContent module > > is generally discouraged because dependencies are already available in > > the Fedora

Re: Adding additional flag in cmake-rpm-macros to disallow the use of the FetchContent module

2024-05-26 Thread Kan-Ru Chen
On Mon, May 27, 2024, at 9:22 AM, Byoungchan Lee via devel wrote: > In well-maintained Fedora packages, the use of the FetchContent module > is generally discouraged because dependencies are already available in > the Fedora repositories. > > While it's uncertain if build workers in Fedora have

Adding additional flag in cmake-rpm-macros to disallow the use of the FetchContent module

2024-05-26 Thread Byoungchan Lee via devel
In well-maintained Fedora packages, the use of the FetchContent module is generally discouraged because dependencies are already available in the Fedora repositories. While it's uncertain if build workers in Fedora have internet access, to improve security, I believe it is recommended to