Re: Build system clocks?

2023-05-08 Thread Florian Weimer
* Fabio Valentini: > Yeah, the way the forge macros determine "snapshot date" is a bit > broken / produces inconsistent results. > It uses the source file *modification time* ("mtime"), which might or > might not be consistent in all environments ... it's also an attempt > to get the "date the

Re: Build system clocks?

2023-05-08 Thread Fabio Valentini
On Sun, May 7, 2023 at 11:11 PM Elliott Sales de Andrade wrote: > > On Sun, May 7, 2023 at 4:59 PM Chris Adams wrote: >> >> Once upon a time, Kevin Kofler said: >> > Chris Adams wrote: >> > > I updated the source of a package of mine last night. The upstream is >> > > on Github, and I use the

Re: Build system clocks?

2023-05-07 Thread Elliott Sales de Andrade
On Sun, May 7, 2023 at 4:59 PM Chris Adams wrote: > Once upon a time, Kevin Kofler said: > > Chris Adams wrote: > > > I updated the source of a package of mine last night. The upstream is > > > on Github, and I use the %forgemeta macro for an easy spec file. When > I > > > tried to run

Re: Build system clocks?

2023-05-07 Thread Chris Adams
Once upon a time, Kevin Kofler said: > Chris Adams wrote: > > I updated the source of a package of mine last night. The upstream is > > on Github, and I use the %forgemeta macro for an easy spec file. When I > > tried to run "fedpkg build" though, it failed - the build system > > rejected the

Re: Build system clocks?

2023-05-07 Thread Blaise Pabon
There ought to be a doc on "lifecycle of a timestamp" I'm willing to help if we don't already have one. Tldr there are various levels of abstraction when it comes to representing time. Developers overlook the details until something like this happens. System clocks don't know about locales,

Re: Build system clocks?

2023-05-07 Thread Kevin Kofler via devel
Chris Adams wrote: > I updated the source of a package of mine last night. The upstream is > on Github, and I use the %forgemeta macro for an easy spec file. When I > tried to run "fedpkg build" though, it failed - the build system > rejected the build because it was expecting an SRPM with a

Re: Build system clocks?

2023-05-07 Thread Chris Adams
Once upon a time, Kevin Fenzi said: > All the builders are using chrony and seem to be pretty close, so I > don't think thats it. :) It was pretty much grasphing at straws, but I do appreciate the quick check. It's weird; the forge macro Lua support is definitely using UTC when it gets the date

Re: Build system clocks?

2023-05-07 Thread Kevin Fenzi
On Sun, May 07, 2023 at 07:59:26AM -0500, Chris Adams wrote: > I updated the source of a package of mine last night. The upstream is > on Github, and I use the %forgemeta macro for an easy spec file. When I > tried to run "fedpkg build" though, it failed - the build system > rejected the build

Build system clocks?

2023-05-07 Thread Chris Adams
I updated the source of a package of mine last night. The upstream is on Github, and I use the %forgemeta macro for an easy spec file. When I tried to run "fedpkg build" though, it failed - the build system rejected the build because it was expecting an SRPM with a release string including