Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-05-22 Thread Zbigniew Jędrzejewski-Szmek
On Wed, May 22, 2024 at 09:06:07AM +0200, Vitaly Zaitsev via devel wrote: > On 17/04/2024 09:20, Zbigniew Jędrzejewski-Szmek wrote: > > In some ways, that'd be nice, because we wouldn't have to install > > additional tools in the buildroot. But OTOH, those tools are rather > > small and

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-05-22 Thread Vitaly Zaitsev via devel
On 17/04/2024 09:20, Zbigniew Jędrzejewski-Szmek wrote: In some ways, that'd be nice, because we wouldn't have to install additional tools in the buildroot. But OTOH, those tools are rather small and bash/find/etc probably need to be installed anyway. It doesn't seem to work properly without

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-23 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Apr 17, 2024 at 11:28:53AM +0200, Fabio Valentini wrote: > On Wed, Apr 17, 2024, 08:45 Tim Landscheidt wrote: > > > Zbigniew Jędrzejewski-Szmek wrote: > > > > > […] > > > > >> - use dynamic buildrequires to detect what plugins are needed > > > > > My problem is that the binary is linked

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-19 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Apr 17, 2024 at 05:12:07PM -0500, Maxwell G wrote: > On 4/13/24 06:41, Fabio Valentini wrote: > > On Sat, Apr 13, 2024 at 1:18 PM Zbigniew Jędrzejewski-Szmek > > wrote: > > > Yes. But actually I think Rust is the optimal choice here. Writing > > > this in Python would be possibly

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-18 Thread Robert Relyea
On 4/17/24 12:54 AM, Zbigniew Jędrzejewski-Szmek wrote: On Wed, Apr 17, 2024 at 09:38:30AM +0200, Miroslav Suchý wrote: Dne 17. 04. 24 v 9:20 dop. Zbigniew Jędrzejewski-Szmek napsal(a): By adding this functionality to Mock itself. It can be optional (--add-determinism). And then Mock can call

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-17 Thread Maxwell G
On 4/17/24 02:20, Zbigniew Jędrzejewski-Szmek wrote: I don't think we should make this particular functionality special. Yeah, I tend to agree. If we want to reimagine the way BRP scripts work, that should be a separate discussion. -- ___ devel

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-17 Thread Maxwell G
On 4/13/24 06:41, Fabio Valentini wrote: On Sat, Apr 13, 2024 at 1:18 PM Zbigniew Jędrzejewski-Szmek wrote: Yes. But actually I think Rust is the optimal choice here. Writing this in Python would be possibly slightly nicer, but we don't want to pull the interpreter and packages into the

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-17 Thread Fabio Valentini
On Wed, Apr 17, 2024 at 3:10 PM Zbigniew Jędrzejewski-Szmek wrote: > > > Because this is written in Rust instead of Python, you will need a > > build variant for *every* Python interpreter shipped in Fedora. > > No, just one one, at any given time. Assuming that the marshalparser package can

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-17 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Apr 17, 2024 at 10:41:22AM -0700, Brian C. Lane wrote: > On Sat, Apr 13, 2024 at 11:16:37AM +, Zbigniew Jędrzejewski-Szmek wrote: > > If we don't want to pull in an additional language framework, the > > options are either a compiled language or a scripting language that is > > already

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-17 Thread Brian C. Lane
On Sat, Apr 13, 2024 at 11:16:37AM +, Zbigniew Jędrzejewski-Szmek wrote: > If we don't want to pull in an additional language framework, the > options are either a compiled language or a scripting language that is > already installed anyway, i.e. bash or awk. Considering that we want > to do

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-17 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Apr 17, 2024 at 08:58:46AM -0400, Neal Gompa wrote: > On Wed, Apr 17, 2024 at 5:30 AM Fabio Valentini wrote: > > > > On Wed, Apr 17, 2024, 08:45 Tim Landscheidt wrote: > >> > >> Zbigniew Jędrzejewski-Szmek wrote: > >> > >> > […] > >> > >> >> - use dynamic buildrequires to detect what

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-17 Thread Neal Gompa
On Wed, Apr 17, 2024 at 5:30 AM Fabio Valentini wrote: > > On Wed, Apr 17, 2024, 08:45 Tim Landscheidt wrote: >> >> Zbigniew Jędrzejewski-Szmek wrote: >> >> > […] >> >> >> - use dynamic buildrequires to detect what plugins are needed >> >> > My problem is that the binary is linked to the

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-17 Thread Fabio Valentini
On Wed, Apr 17, 2024, 08:45 Tim Landscheidt wrote: > Zbigniew Jędrzejewski-Szmek wrote: > > > […] > > >> - use dynamic buildrequires to detect what plugins are needed > > > My problem is that the binary is linked to the libpython3.12.so shared > > library… The detection part is easy, the hard

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-17 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Apr 17, 2024 at 09:38:30AM +0200, Miroslav Suchý wrote: > Dne 17. 04. 24 v 9:20 dop. Zbigniew Jędrzejewski-Szmek napsal(a): > > > By adding this functionality to Mock itself. It can be optional > > > (--add-determinism). And then Mock can call > > > > > >   add-determinism

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-17 Thread Miroslav Suchý
Dne 17. 04. 24 v 9:20 dop. Zbigniew Jędrzejewski-Szmek napsal(a): By adding this functionality to Mock itself. It can be optional (--add-determinism). And then Mock can call   add-determinism $chroot/%buildroot/ I don't think we should make this particular functionality special. We have a

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-17 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Apr 17, 2024 at 08:39:48AM +0200, Miroslav Suchý wrote: > Dne 16. 04. 24 v 10:04 odp. Zbigniew Jędrzejewski-Szmek napsal(a): > > Hmm, how would that work? We call mock, which calls systemd-nspawn, > > which runs rpmbuild, and the build env is completely isolated from the > > host. > > By

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-17 Thread Tim Landscheidt
Zbigniew Jędrzejewski-Szmek wrote: > […] >> - use dynamic buildrequires to detect what plugins are needed > My problem is that the binary is linked to the libpython3.12.so shared > library… The detection part is easy, the hard part is how to have the > binary work when the shared lib is not

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-17 Thread Miroslav Suchý
Dne 16. 04. 24 v 10:04 odp. Zbigniew Jędrzejewski-Szmek napsal(a): Hmm, how would that work? We call mock, which calls systemd-nspawn, which runs rpmbuild, and the build env is completely isolated from the host. By adding this functionality to Mock itself. It can be optional

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-16 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Apr 16, 2024 at 09:42:27AM +0200, Pavel Raiskup wrote: > On sobota 13. dubna 2024 21:04:06, CEST Zbigniew Jędrzejewski-Szmek wrote: > > On Sat, Apr 13, 2024 at 01:38:49PM +, Zbigniew Jędrzejewski-Szmek wrote: > > > On Sat, Apr 13, 2024 at 01:41:59PM +0200, Fabio Valentini wrote: > > >

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-16 Thread Pavel Raiskup
On sobota 13. dubna 2024 21:04:06, CEST Zbigniew Jędrzejewski-Szmek wrote: > On Sat, Apr 13, 2024 at 01:38:49PM +, Zbigniew Jędrzejewski-Szmek wrote: > > On Sat, Apr 13, 2024 at 01:41:59PM +0200, Fabio Valentini wrote: > > > On Sat, Apr 13, 2024 at 1:18 PM Zbigniew Jędrzejewski-Szmek > > >

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-15 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Apr 15, 2024 at 12:59:04PM +0200, Vít Ondruch wrote: > Could you please share some comparison of what is impact on buildroot? How > many packages added, download size, install size. $ rpm -qiR add-determinism-0.2.0-1.fc40.x86_64 ... Size: 2801276 (installed

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-15 Thread Vít Ondruch
Dne 15. 04. 24 v 11:10 Miroslav Suchý napsal(a): Dne 13. 04. 24 v 1:16 odp. Zbigniew Jędrzejewski-Szmek napsal(a): The proposal explicitly states that we don't want Perl in all buildroots. How many seconds we save by NOT pulling Perl? Per each build? In total for whole release cycle? I

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-15 Thread Vít Ondruch
Dne 13. 04. 24 v 21:04 Zbigniew Jędrzejewski-Szmek napsal(a): On Sat, Apr 13, 2024 at 01:38:49PM +, Zbigniew Jędrzejewski-Szmek wrote: On Sat, Apr 13, 2024 at 01:41:59PM +0200, Fabio Valentini wrote: On Sat, Apr 13, 2024 at 1:18 PM Zbigniew Jędrzejewski-Szmek wrote: Yes. But actually I

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-15 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Apr 15, 2024 at 11:10:28AM +0200, Miroslav Suchý wrote: > Dne 13. 04. 24 v 1:16 odp. Zbigniew Jędrzejewski-Szmek napsal(a): > > The proposal explicitly states that we don't want Perl in all buildroots. > > How many seconds we save by NOT pulling Perl? Per each build? In total for > whole

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-15 Thread Miroslav Suchý
Dne 13. 04. 24 v 1:16 odp. Zbigniew Jędrzejewski-Szmek napsal(a): The proposal explicitly states that we don't want Perl in all buildroots. How many seconds we save by NOT pulling Perl? Per each build? In total for whole release cycle? How many seconds we loose (lost) by refactoring the

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-13 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Apr 13, 2024 at 01:38:49PM +, Zbigniew Jędrzejewski-Szmek wrote: > On Sat, Apr 13, 2024 at 01:41:59PM +0200, Fabio Valentini wrote: > > On Sat, Apr 13, 2024 at 1:18 PM Zbigniew Jędrzejewski-Szmek > > wrote: > > > > > > Yes. But actually I think Rust is the optimal choice here. Writing

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-13 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Apr 13, 2024 at 01:41:59PM +0200, Fabio Valentini wrote: > On Sat, Apr 13, 2024 at 1:18 PM Zbigniew Jędrzejewski-Szmek > wrote: > > > > Yes. But actually I think Rust is the optimal choice here. Writing > > this in Python would be possibly slightly nicer, but we don't want > > to pull the

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-13 Thread Fabio Valentini
On Sat, Apr 13, 2024 at 1:18 PM Zbigniew Jędrzejewski-Szmek wrote: > > Yes. But actually I think Rust is the optimal choice here. Writing > this in Python would be possibly slightly nicer, but we don't want > to pull the interpreter and packages into the buildroot. Python > also has the problem

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-13 Thread Zbigniew Jędrzejewski-Szmek
On Sat, Apr 13, 2024 at 04:12:09AM -0500, Neal Gompa wrote: > On Sat, Apr 13, 2024 at 3:59 AM Richard W.M. Jones wrote: > > > > On Fri, Apr 12, 2024 at 10:41:43PM +0100, Aoife Moloney wrote: > > > [https://github.com/keszybz/add-determinism add-determinism] is a Rust > > > program which, as its

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-13 Thread Neal Gompa
On Sat, Apr 13, 2024 at 3:59 AM Richard W.M. Jones wrote: > > On Fri, Apr 12, 2024 at 10:41:43PM +0100, Aoife Moloney wrote: > > [https://github.com/keszybz/add-determinism add-determinism] is a Rust > > program which, as its name suggests, adds determinism to files that > > are given as input by

Re: F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-13 Thread Richard W.M. Jones
On Fri, Apr 12, 2024 at 10:41:43PM +0100, Aoife Moloney wrote: > [https://github.com/keszybz/add-determinism add-determinism] is a Rust > program which, as its name suggests, adds determinism to files that > are given as input by attempting to standardize metadata contained in > binary or source

F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-12 Thread Aoife Moloney
Wiki - https://fedoraproject.org/wiki/Changes/ReproduciblePackageBuilds Discussion.fpo - https://discussion.fedoraproject.org/t/f41-change-proposal-reproducible-package-builds-system-wide/112740 == Summary == A post-build cleanup is integrated into the RPM build process so that common causes

F41 Change Proposal - Reproducible Package Builds (System-Wide)

2024-04-12 Thread Aoife Moloney
Wiki - https://fedoraproject.org/wiki/Changes/ReproduciblePackageBuilds Discussion.fpo - https://discussion.fedoraproject.org/t/f41-change-proposal-reproducible-package-builds-system-wide/112740 == Summary == A post-build cleanup is integrated into the RPM build process so that common causes