Re: Fedora 30 Self-Contained Change Proposal: Enabling Python Generators by default

2019-01-02 Thread Neal Gompa
On Wed, Jan 2, 2019 at 5:30 AM Panu Matilainen wrote: > > On 12/30/18 12:26 AM, Orcan Ogetbil wrote: > > On Fri, 7 Dec 2018 at 19:37, Ben Cotton wrote: > >> > >> https://fedoraproject.org/wiki/Changes/EnablingPythonGeneratorsByDefault > >> > >> = Enabling Python Generators by default = > > > > No

Re: Fedora 30 Self-Contained Change Proposal: Enabling Python Generators by default

2019-01-02 Thread Panu Matilainen
On 12/30/18 12:26 AM, Orcan Ogetbil wrote: On Fri, 7 Dec 2018 at 19:37, Ben Cotton wrote: https://fedoraproject.org/wiki/Changes/EnablingPythonGeneratorsByDefault = Enabling Python Generators by default = No objection on the change. Yet the "Generators" have a well established meaning in

Re: Fedora 30 Self-Contained Change Proposal: Enabling Python Generators by default

2018-12-29 Thread Orcan Ogetbil
On Fri, 7 Dec 2018 at 19:37, Ben Cotton wrote: > > https://fedoraproject.org/wiki/Changes/EnablingPythonGeneratorsByDefault > > = Enabling Python Generators by default = No objection on the change. Yet the "Generators" have a well established meaning in Python, which is very different than this

Re: Fedora 30 Self-Contained Change Proposal: Enabling Python Generators by default

2018-12-29 Thread Igor Gnatenko
On Sat, Dec 29, 2018, 14:36 Avram Lubkin > On Sat, Dec 29, 2018 at 2:04 AM Igor Gnatenko < > ignatenkobr...@fedoraproject.org> wrote: > >> Duplicated dependencies is a problem because rpm-md becomes larger. If >> we would use Requires: python%{python3_version}dist() dependencies, >> then RPM

Re: Fedora 30 Self-Contained Change Proposal: Enabling Python Generators by default

2018-12-29 Thread Avram Lubkin
On Sat, Dec 29, 2018 at 2:04 AM Igor Gnatenko < ignatenkobr...@fedoraproject.org> wrote: > Duplicated dependencies is a problem because rpm-md becomes larger. If > we would use Requires: python%{python3_version}dist() dependencies, > then RPM would merge them and it would be fine. But since we

Re: Fedora 30 Self-Contained Change Proposal: Enabling Python Generators by default

2018-12-28 Thread Igor Gnatenko
On Fri, Dec 28, 2018 at 7:21 PM Miro Hrončok wrote: > > On 28. 12. 18 18:58, Avram Lubkin wrote: > > On Fri, Dec 28, 2018 at 12:38 PM Igor Gnatenko > > > > wrote: > > > > You can't make it work in EPEL easily because python modules do not > > have

Re: Fedora 30 Self-Contained Change Proposal: Enabling Python Generators by default

2018-12-28 Thread Neal Gompa
On Fri, Dec 28, 2018 at 4:12 PM Miro Hrončok wrote: > > On 28. 12. 18 22:10, Neal Gompa wrote: > > On Fri, Dec 28, 2018 at 1:10 PM Miro Hrončok wrote: > >> > >> On 28. 12. 18 18:58, Avram Lubkin wrote: > >>> Especially since there is no test code! > >> > >> And this is the only thing when I

Re: Fedora 30 Self-Contained Change Proposal: Enabling Python Generators by default

2018-12-28 Thread Miro Hrončok
On 28. 12. 18 22:10, Neal Gompa wrote: On Fri, Dec 28, 2018 at 1:10 PM Miro Hrončok wrote: On 28. 12. 18 18:58, Avram Lubkin wrote: Especially since there is no test code! And this is the only thing when I agree with you. Neal, where would be the best place to add some tests for the

Re: Fedora 30 Self-Contained Change Proposal: Enabling Python Generators by default

2018-12-28 Thread Neal Gompa
On Fri, Dec 28, 2018 at 1:10 PM Miro Hrončok wrote: > > On 28. 12. 18 18:58, Avram Lubkin wrote: > > Especially since there is no test code! > > And this is the only thing when I agree with you. > > Neal, where would be the best place to add some tests for the generator? > I can scratch something

Re: Fedora 30 Self-Contained Change Proposal: Enabling Python Generators by default

2018-12-28 Thread Igor Gnatenko
On Fri, Dec 28, 2018 at 7:06 PM Avram Lubkin wrote: > > On Fri, Dec 28, 2018 at 12:38 PM Igor Gnatenko > wrote: >> >> You can't make it work in EPEL easily because python modules do not >> have pythonX.Ydist() provides. > > > Didn't realize that and not sure why that wasn't backported.

Re: Fedora 30 Self-Contained Change Proposal: Enabling Python Generators by default

2018-12-28 Thread Miro Hrončok
On 28. 12. 18 18:58, Avram Lubkin wrote: On Fri, Dec 28, 2018 at 12:38 PM Igor Gnatenko > wrote: You can't make it work in EPEL easily because python modules do not have pythonX.Ydist() provides. Didn't realize that and not sure why that

Re: Fedora 30 Self-Contained Change Proposal: Enabling Python Generators by default

2018-12-28 Thread Avram Lubkin
On Fri, Dec 28, 2018 at 12:38 PM Igor Gnatenko < ignatenkobr...@fedoraproject.org> wrote: > You can't make it work in EPEL easily because python modules do not > have pythonX.Ydist() provides. > Didn't realize that and not sure why that wasn't backported. Honestly, if we aren't going to be

Re: Fedora 30 Self-Contained Change Proposal: Enabling Python Generators by default

2018-12-28 Thread Neal Gompa
On Fri, Dec 28, 2018 at 12:38 PM Avram Lubkin wrote: > > On Fri, Dec 28, 2018 at 11:55 AM Zbigniew Jędrzejewski-Szmek > wrote: >> >> Well, now that this has been enabled, it is likely that there already >> are packages which make use of this functionality, and disabling the >> generator again

Re: Fedora 30 Self-Contained Change Proposal: Enabling Python Generators by default

2018-12-28 Thread Igor Gnatenko
On Fri, Dec 28, 2018 at 6:46 PM Avram Lubkin wrote: > > On Fri, Dec 28, 2018 at 11:55 AM Zbigniew Jędrzejewski-Szmek > wrote: >> >> Well, now that this has been enabled, it is likely that there already >> are packages which make use of this functionality, and disabling the >> generator again

Re: Fedora 30 Self-Contained Change Proposal: Enabling Python Generators by default

2018-12-28 Thread Igor Gnatenko
You can't make it work in EPEL easily because python modules do not have pythonX.Ydist() provides. On Fri, Dec 28, 2018 at 6:36 PM Avram Lubkin wrote: > > > On Fri, Dec 28, 2018 at 11:48 AM Neal Gompa wrote: >> >> python-rpm-generators is not the real upstream for that code (rpm is). >> And

Re: Fedora 30 Self-Contained Change Proposal: Enabling Python Generators by default

2018-12-28 Thread Avram Lubkin
On Fri, Dec 28, 2018 at 11:55 AM Zbigniew Jędrzejewski-Szmek < zbys...@in.waw.pl> wrote: > Well, now that this has been enabled, it is likely that there already > are packages which make use of this functionality, and disabling the > generator again would break them. So reverting the changes

Re: Fedora 30 Self-Contained Change Proposal: Enabling Python Generators by default

2018-12-28 Thread Avram Lubkin
On Fri, Dec 28, 2018 at 11:48 AM Neal Gompa wrote: > python-rpm-generators is not the real upstream for that code (rpm is). > And testability would be a bit difficult because all the script does > is pull stuff from python module metadata using setuptools and print it > out. > So you provide

Re: Fedora 30 Self-Contained Change Proposal: Enabling Python Generators by default

2018-12-28 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Dec 28, 2018 at 11:34:02AM -0500, Avram Lubkin wrote: > Looks like the dependency generator was turned on in rawhide. Igor has been > making pull releases against packages because this is now creating > duplicate requires for some packages. That would seem reasonable, but he > never pushed

Re: Fedora 30 Self-Contained Change Proposal: Enabling Python Generators by default

2018-12-28 Thread Neal Gompa
On Fri, Dec 28, 2018 at 11:35 AM Avram Lubkin wrote: > > Looks like the dependency generator was turned on in rawhide. Igor has been > making pull releases against packages because this is now creating duplicate > requires for some packages. That would seem reasonable, but he never pushed >

Re: Fedora 30 Self-Contained Change Proposal: Enabling Python Generators by default

2018-12-28 Thread Avram Lubkin
Looks like the dependency generator was turned on in rawhide. Igor has been making pull releases against packages because this is now creating duplicate requires for some packages. That would seem reasonable, but he never pushed the dependency generator to EPEL so packages which maintain a common

Re: Fedora 30 Self-Contained Change Proposal: Enabling Python Generators by default

2018-12-08 Thread Ben Cotton
On Sat, Dec 8, 2018 at 4:08 AM Igor Gnatenko wrote: > > This is system-wide change, at least that's what wiki says ;) That is correct. I should not send email after being in meetings all day. :-D -- Ben Cotton Fedora Program Manager TZ=America/Indiana/Indianapolis

Fedora 30 Self-Contained Change Proposal: Enabling Python Generators by default

2018-12-08 Thread Ben Cotton
https://fedoraproject.org/wiki/Changes/EnablingPythonGeneratorsByDefault = Enabling Python Generators by default = == Summary == This change enables the Python module dependency generator for packages that provide Python Egg/Wheel metadata by default (this was

Re: Fedora 30 Self-Contained Change Proposal: Enabling Python Generators by default

2018-12-08 Thread Igor Gnatenko
This is system-wide change, at least that's what wiki says ;) On Sat, Dec 8, 2018 at 1:45 AM Ben Cotton wrote: > > https://fedoraproject.org/wiki/Changes/EnablingPythonGeneratorsByDefault > > = Enabling Python Generators by default = > > == Summary == > This change enables the Python module

Fedora 30 Self-Contained Change Proposal: Enabling Python Generators by default

2018-12-07 Thread Ben Cotton
https://fedoraproject.org/wiki/Changes/EnablingPythonGeneratorsByDefault = Enabling Python Generators by default = == Summary == This change enables the Python module dependency generator for packages that provide Python Egg/Wheel metadata by default (this was