Re: Package maintainers -- want test results by mail?

2010-06-06 Thread Mat Booth
On 3 June 2010 07:44, Ville Skyttä ville.sky...@iki.fi wrote: On Thursday 03 June 2010, Adam Williamson wrote: On Wed, 2010-06-02 at 23:05 +0100, Mat Booth wrote: It doesn't even know all English words. In one review I did recently rpmlint flagged the word decryption as a spelling error.

Re: Package maintainers -- want test results by mail?

2010-06-06 Thread Richard Fearn
Hi, Thanks for this. Just a couple of points: The package name is converted to lower case. Should it be doing that? For example, the jFormatString opt-in files are in /srv/people/site/packages/j/jformatstring. Also autoqa-optin doesn't validate the package name: I missed it out at one point

Re: Package maintainers -- want test results by mail?

2010-06-06 Thread Toshio Kuratomi
On Sun, Jun 06, 2010 at 03:27:33PM +0100, Richard Fearn wrote: Hi, Thanks for this. Just a couple of points: The package name is converted to lower case. Should it be doing that? For example, the jFormatString opt-in files are in /srv/people/site/packages/j/jformatstring. As long as

Re: Package maintainers -- want test results by mail?

2010-06-05 Thread Ville Skyttä
On Thursday 03 June 2010, Adam Williamson wrote: One thing I'd dearly like to see suppressed in most cases is the spell checking. Most package descriptions need to use jargon which spell checkers just don't recognize. Some of this particular flavor of noise is now reduced in upstream

Re: Package maintainers -- want test results by mail?

2010-06-03 Thread Ville Skyttä
On Thursday 03 June 2010, Adam Williamson wrote: On Wed, 2010-06-02 at 23:05 +0100, Mat Booth wrote: It doesn't even know all English words. In one review I did recently rpmlint flagged the word decryption as a spelling error. Which I didn't believe, so I looked it up. It's a valid noun

Re: Package maintainers -- want test results by mail?

2010-06-03 Thread Matt McCutchen
On Wed, 2010-06-02 at 14:46 -0400, Toshio Kuratomi wrote: When the shebang is to allow running some sort of unittest I generally just leave it alone (the end user won't want to run it and upstream does want to run the code when they're testing). There is still no reason to have a shebang on a

Re: Package maintainers -- want test results by mail?

2010-06-03 Thread seth vidal
On Thu, 2010-06-03 at 10:57 -0400, Matt McCutchen wrote: On Wed, 2010-06-02 at 14:46 -0400, Toshio Kuratomi wrote: When the shebang is to allow running some sort of unittest I generally just leave it alone (the end user won't want to run it and upstream does want to run the code when

Re: Package maintainers -- want test results by mail?

2010-06-03 Thread Iain Arnell
On Thu, Jun 3, 2010 at 5:09 PM, seth vidal skvi...@fedoraproject.org wrote: On Thu, 2010-06-03 at 10:57 -0400, Matt McCutchen wrote: On Wed, 2010-06-02 at 14:46 -0400, Toshio Kuratomi wrote: When the shebang is to allow running some sort of unittest I generally just leave it alone (the end

Re: Package maintainers -- want test results by mail?

2010-06-03 Thread Adam Williamson
On Thu, 2010-06-03 at 11:09 -0400, seth vidal wrote: On Thu, 2010-06-03 at 10:57 -0400, Matt McCutchen wrote: On Wed, 2010-06-02 at 14:46 -0400, Toshio Kuratomi wrote: When the shebang is to allow running some sort of unittest I generally just leave it alone (the end user won't want

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread Jaroslav Reznik
On Wednesday 02 June 2010 06:12:48 Peter Lemenkov wrote: 2010/6/2 James Laska jla...@redhat.com: Greetings package maintainers, Want to get notification of any breakage in your just-built koji packages? It would be great if rpmlint logs will be automatically generated on each koji

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread Stanislav Ochotnicky
On 06/02/2010 12:11 AM, seth vidal wrote: On Tue, 2010-06-01 at 16:43 -0400, James Laska wrote: Greetings package maintainers, Want to get notification of any breakage in your just-built koji packages? This includes results of rpmlint [1], rpmguard [2] and, if applicable, initscript [3]

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread Rahul Sundaram
On 06/02/2010 01:08 PM, Jaroslav Reznik wrote: +1. Nice idea. But I hope this is the first phase of auto QA development and we will see this integrated to Koji and other Fedora infrastructure in the future It would also be useful to be able to filter out bogus rpmlint warnings like

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread Ralf Corsepius
On 06/01/2010 10:43 PM, James Laska wrote: Greetings package maintainers, Want to get notification of any breakage in your just-built koji packages? This includes results of rpmlint [1], Unless rpmlint starts to use a massively cleaned up set of rules, its results are mostly noise. --

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread James Laska
On Wed, 2010-06-02 at 10:49 +0200, Ralf Corsepius wrote: On 06/01/2010 10:43 PM, James Laska wrote: Greetings package maintainers, Want to get notification of any breakage in your just-built koji packages? This includes results of rpmlint [1], Unless rpmlint starts to use a massively

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread Ralf Corsepius
On 06/02/2010 01:49 PM, James Laska wrote: On Wed, 2010-06-02 at 10:49 +0200, Ralf Corsepius wrote: On 06/01/2010 10:43 PM, James Laska wrote: Greetings package maintainers, Want to get notification of any breakage in your just-built koji packages? This includes results of rpmlint [1],

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread Matthias Clasen
On Wed, 2010-06-02 at 07:49 -0400, James Laska wrote: On Wed, 2010-06-02 at 10:49 +0200, Ralf Corsepius wrote: On 06/01/2010 10:43 PM, James Laska wrote: Greetings package maintainers, Want to get notification of any breakage in your just-built koji packages? This includes results

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread seth vidal
On Wed, 2010-06-02 at 08:25 -0400, Matthias Clasen wrote: On Wed, 2010-06-02 at 07:49 -0400, James Laska wrote: On Wed, 2010-06-02 at 10:49 +0200, Ralf Corsepius wrote: On 06/01/2010 10:43 PM, James Laska wrote: Greetings package maintainers, Want to get notification of any

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread Ralf Corsepius
On 06/02/2010 02:36 PM, seth vidal wrote: On Wed, 2010-06-02 at 08:25 -0400, Matthias Clasen wrote: On Wed, 2010-06-02 at 07:49 -0400, James Laska wrote: On Wed, 2010-06-02 at 10:49 +0200, Ralf Corsepius wrote: On 06/01/2010 10:43 PM, James Laska wrote: Greetings package maintainers, Want

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread James Laska
On Wed, 2010-06-02 at 14:10 +0200, Ralf Corsepius wrote: On 06/02/2010 01:49 PM, James Laska wrote: On Wed, 2010-06-02 at 10:49 +0200, Ralf Corsepius wrote: On 06/01/2010 10:43 PM, James Laska wrote: Greetings package maintainers, Want to get notification of any breakage in your

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread Matthias Clasen
On Wed, 2010-06-02 at 08:36 -0400, seth vidal wrote: I think the goal is, of course, to reduce the noise out and focus on making sure the packagers know about the truly broken. :) Another useful goal might be to only emit errors/warnings for which we can accompany the message with a link

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread seth vidal
On Wed, 2010-06-02 at 09:09 -0400, Kamil Paral wrote: - seth vidal skvi...@fedoraproject.org wrote: I just added autoqa-optout to fedorapeople. it does what you expect it to do and acts just like autoqa-optin Just a minor remark... please add --help. Thanks :) autoqa-optout

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread seth vidal
On Wed, 2010-06-02 at 19:07 +0300, Ville Skyttä wrote: On Wednesday 02 June 2010, Matthias Clasen wrote: On Wed, 2010-06-02 at 07:49 -0400, James Laska wrote: Which packages do you maintain where the output has become unmanageable? For myself, I really only think that the spell checks

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread Matt McCutchen
On Wed, 2010-06-02 at 14:48 +0200, Ralf Corsepius wrote: Well, then lets begin: # rpmlint yum yum.noarch: W: self-obsoletion yum-allow-downgrade 1.1.20-0 obsoletes yum-allow-downgrade [...] yum.noarch: W: non-conffile-in-etc /etc/bash_completion.d/yum.bash yum.noarch: E:

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread Till Maas
On Wed, Jun 02, 2010 at 01:25:01PM -0400, Matt McCutchen wrote: On Wed, 2010-06-02 at 14:48 +0200, Ralf Corsepius wrote: yum.noarch: W: non-conffile-in-etc /etc/bash_completion.d/yum.bash yum.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/yum/repos.py 0644L

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread Jesse Keating
On Wed, 2010-06-02 at 19:41 +0200, Till Maas wrote: And I doubt that python scripts in below /usr/lib/python2.6/site-packages usually need to be executable. Since yum works without any problems, these tons of errors are useless, too. And they make it only harder to find real errors. I did not

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread Till Maas
On Wed, Jun 02, 2010 at 10:46:51AM -0700, Jesse Keating wrote: On Wed, 2010-06-02 at 19:41 +0200, Till Maas wrote: And I doubt that python scripts in below /usr/lib/python2.6/site-packages usually need to be executable. Since yum works without any problems, these tons of errors are useless,

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread Matt McCutchen
On Wed, 2010-06-02 at 19:41 +0200, Till Maas wrote: On Wed, Jun 02, 2010 at 01:25:01PM -0400, Matt McCutchen wrote: On Wed, 2010-06-02 at 14:48 +0200, Ralf Corsepius wrote: yum.noarch: W: non-conffile-in-etc /etc/bash_completion.d/yum.bash yum.noarch: E: non-executable-script

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread seth vidal
On Wed, 2010-06-02 at 10:46 -0700, Jesse Keating wrote: On Wed, 2010-06-02 at 19:41 +0200, Till Maas wrote: And I doubt that python scripts in below /usr/lib/python2.6/site-packages usually need to be executable. Since yum works without any problems, these tons of errors are useless, too.

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread James Antill
On Wed, 2010-06-02 at 13:25 -0400, Matt McCutchen wrote: On Wed, 2010-06-02 at 14:48 +0200, Ralf Corsepius wrote: Well, then lets begin: # rpmlint yum yum.noarch: W: self-obsoletion yum-allow-downgrade 1.1.20-0 obsoletes yum-allow-downgrade [...] Which of those messages do you

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread Jesse Keating
On Wed, 2010-06-02 at 19:59 +0200, Till Maas wrote: On Wed, Jun 02, 2010 at 10:46:51AM -0700, Jesse Keating wrote: On Wed, 2010-06-02 at 19:41 +0200, Till Maas wrote: And I doubt that python scripts in below /usr/lib/python2.6/site-packages usually need to be executable. Since yum

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread Toshio Kuratomi
On Wed, Jun 02, 2010 at 07:59:22PM +0200, Till Maas wrote: On Wed, Jun 02, 2010 at 10:46:51AM -0700, Jesse Keating wrote: On Wed, 2010-06-02 at 19:41 +0200, Till Maas wrote: And I doubt that python scripts in below /usr/lib/python2.6/site-packages usually need to be executable. Since

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread Ville Skyttä
On Wednesday 02 June 2010, James Antill wrote: The self obsolete ones are wrong, being able to do: Name: foo Provide: bar = 2 Obsolete: bar = 2 ...is completely legal and needed for rename/merging Yes (assuming you mean Obsoletes: bar 2, not = 2). which is why yum has them. yum

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread Ville Skyttä
On Wednesday 02 June 2010, Matt McCutchen wrote: The right thing to do is to file a bug against bash-completion to get that decision made and then implement it, either by marking the file as config or moving /etc/bash_completion.d to /usr/share. The warning is not wrong. Moving to

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread Ville Skyttä
On Wednesday 02 June 2010, Ralf Corsepius wrote: binutils.x86_64: W: spelling-error %description -l en_US addr - add, adder, adds This is a genuine bug, I'll try to have a look into and/or work around it. Enchant appears to tokenize addr2line into two words and naturally ends up flagging

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread Adam Williamson
On Wed, 2010-06-02 at 07:49 -0400, James Laska wrote: On Wed, 2010-06-02 at 10:49 +0200, Ralf Corsepius wrote: On 06/01/2010 10:43 PM, James Laska wrote: Greetings package maintainers, Want to get notification of any breakage in your just-built koji packages? This includes results

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread Mat Booth
On 2 June 2010 22:33, Adam Williamson awill...@redhat.com wrote: On Wed, 2010-06-02 at 07:49 -0400, James Laska wrote: On Wed, 2010-06-02 at 10:49 +0200, Ralf Corsepius wrote: On 06/01/2010 10:43 PM, James Laska wrote: Greetings package maintainers, Want to get notification of

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread Adam Williamson
On Wed, 2010-06-02 at 23:05 +0100, Mat Booth wrote: It doesn't even know all English words. In one review I did recently rpmlint flagged the word decryption as a spelling error. Which I didn't believe, so I looked it up. It's a valid noun form of the verb decrypt in the English dictionary I

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread James Antill
On Wed, 2010-06-02 at 23:15 +0300, Ville Skyttä wrote: On Wednesday 02 June 2010, James Antill wrote: The self obsolete ones are wrong, being able to do: Name: foo Provide: bar = 2 Obsolete: bar = 2 ...is completely legal and needed for rename/merging Yes (assuming you mean

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread Ralf Corsepius
On 06/02/2010 07:25 PM, Matt McCutchen wrote: On Wed, 2010-06-02 at 14:48 +0200, Ralf Corsepius wrote: Well, then lets begin: # rpmlint yum yum.noarch: W: self-obsoletion yum-allow-downgrade 1.1.20-0 obsoletes yum-allow-downgrade [...] yum.noarch: W: non-conffile-in-etc

Re: Package maintainers -- want test results by mail?

2010-06-02 Thread Ralf Corsepius
On 06/02/2010 08:23 PM, seth vidal wrote: On Wed, 2010-06-02 at 10:46 -0700, Jesse Keating wrote: On Wed, 2010-06-02 at 19:41 +0200, Till Maas wrote: And I doubt that python scripts in below /usr/lib/python2.6/site-packages usually need to be executable. Since yum works without any problems,

Package maintainers -- want test results by mail?

2010-06-01 Thread James Laska
Greetings package maintainers, Want to get notification of any breakage in your just-built koji packages? This includes results of rpmlint [1], rpmguard [2] and, if applicable, initscript [3] tests. Good news, you can now opt-in to receive test results by mail! All you have to do is: 1.

Re: Package maintainers -- want test results by mail?

2010-06-01 Thread Bruno Wolff III
On Tue, Jun 01, 2010 at 16:43:07 -0400, James Laska jla...@redhat.com wrote: Greetings package maintainers, Want to get notification of any breakage in your just-built koji packages? This includes results of rpmlint [1], rpmguard [2] and, if applicable, initscript [3] tests. Good news,

Re: Package maintainers -- want test results by mail?

2010-06-01 Thread seth vidal
On Tue, 2010-06-01 at 16:32 -0500, Bruno Wolff III wrote: Who gets the email? What if I am a co-maintainer, do I get the email or does it go to the package owner? we send the email to the pkgname-owner email address so all the folks on that alias get it. Can I opt in for all packages I am

Re: Package maintainers -- want test results by mail?

2010-06-01 Thread seth vidal
On Tue, 2010-06-01 at 16:43 -0400, James Laska wrote: Greetings package maintainers, Want to get notification of any breakage in your just-built koji packages? This includes results of rpmlint [1], rpmguard [2] and, if applicable, initscript [3] tests. Good news, you can now opt-in to

Re: Package maintainers -- want test results by mail?

2010-06-01 Thread Sam Varshavchik
seth vidal writes: I just added autoqa-optout to fedorapeople. it does what you expect it to do and acts just like autoqa-optin Would it be a good idea to mention these scripts somewhere in http://fedoraproject.org/wiki/PackageMaintainers/Join? pgpF35QPUIyEW.pgp Description: PGP

Re: Package maintainers -- want test results by mail?

2010-06-01 Thread seth vidal
On Tue, 2010-06-01 at 18:29 -0400, Sam Varshavchik wrote: seth vidal writes: I just added autoqa-optout to fedorapeople. it does what you expect it to do and acts just like autoqa-optin Would it be a good idea to mention these scripts somewhere in

Re: Package maintainers -- want test results by mail?

2010-06-01 Thread Peter Lemenkov
2010/6/2 James Laska jla...@redhat.com: Greetings package maintainers, Want to get notification of any breakage in your just-built koji packages? It would be great if rpmlint logs will be automatically generated on each koji build ans will be stored with oher koji build logs (in separate

Package maintainers -- want test results by mail?

2010-06-01 Thread James Laska
Greetings package maintainers, Want to get notification of any breakage in your just-built koji packages? This includes results of rpmlint [1], rpmguard [2] and, if applicable, initscript [3] tests. Good news, you can now opt-in to receive test results by mail! All you have to do is: 1.