Re: Potential changes to systemd RPM macros

2023-09-12 Thread Andrea Bolognani
On Mon, Sep 11, 2023 at 11:01:17AM +, Zbigniew Jędrzejewski-Szmek wrote: > On Wed, Aug 09, 2023 at 08:34:59AM +, Zbigniew Jędrzejewski-Szmek wrote: > > This is now merged. The new macros are: > > %systemd_postun_with_reload, %systemd_user_postun_with_reload, > >

Re: Potential changes to systemd RPM macros

2023-09-11 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Aug 09, 2023 at 08:34:59AM +, Zbigniew Jędrzejewski-Szmek wrote: > On Wed, Jul 26, 2023 at 06:06:45AM -0400, Andrea Bolognani wrote: > > On Wed, Jul 26, 2023 at 07:15:42AM +, Zbigniew Jędrzejewski-Szmek wrote: > > > > %systemd_postun_with_restart, so adding

Re: Potential changes to systemd RPM macros

2023-08-09 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Jul 26, 2023 at 06:06:45AM -0400, Andrea Bolognani wrote: > On Wed, Jul 26, 2023 at 07:15:42AM +, Zbigniew Jędrzejewski-Szmek wrote: > > > %systemd_postun_with_restart, so adding %systemd_postun_with_reload > > > or something along those lines doesn't seem like a stretch. > > > > →

Re: Potential changes to systemd RPM macros

2023-07-26 Thread Andrea Bolognani
On Wed, Jul 26, 2023 at 07:15:42AM +, Zbigniew Jędrzejewski-Szmek wrote: > On Tue, Jul 25, 2023 at 10:45:30AM -0400, Andrea Bolognani wrote: > > On Tue, Jul 25, 2023 at 10:51:04AM +, Zbigniew Jędrzejewski-Szmek wrote: > > > I think it'd be more effiecient to go with the (slightly ugly, no

Re: Potential changes to systemd RPM macros

2023-07-26 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jul 25, 2023 at 10:45:30AM -0400, Andrea Bolognani wrote: > On Tue, Jul 25, 2023 at 10:51:04AM +, Zbigniew Jędrzejewski-Szmek wrote: > > I don't think Fedora would reject those changes, because in general > > we don't reject things unless they really break stuff for other people. > >

Re: Potential changes to systemd RPM macros

2023-07-25 Thread Andrea Bolognani
On Tue, Jul 25, 2023 at 10:51:04AM +, Zbigniew Jędrzejewski-Szmek wrote: > I don't think Fedora would reject those changes, because in general > we don't reject things unless they really break stuff for other people. > Nevertheless, I agree with what Daniel P. Berrangé wrote in another reply:

Re: Potential changes to systemd RPM macros

2023-07-25 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jul 24, 2023 at 07:36:41AM -0700, Andrea Bolognani wrote: > On Fri, Jul 21, 2023 at 08:20:21AM +, Zbigniew Jędrzejewski-Szmek wrote: > > On Thu, Jul 20, 2023 at 07:40:08AM -0700, Andrea Bolognani wrote: > > > Now, since this is clearly not a libvirt-specific issue, I believe > > > this

Re: Potential changes to systemd RPM macros

2023-07-24 Thread Kevin Fenzi
On Mon, Jul 24, 2023 at 06:45:12AM -0700, Andrea Bolognani wrote: > On Thu, Jul 20, 2023 at 02:01:37PM -0700, Kevin Fenzi wrote: > > On Thu, Jul 20, 2023 at 07:40:08AM -0700, Andrea Bolognani wrote: > > > The problem is that Fedora 39 and RHEL 9.3 are fast approaching and, > > > if we don't do

Re: Potential changes to systemd RPM macros

2023-07-24 Thread Andrea Bolognani
On Fri, Jul 21, 2023 at 08:20:21AM +, Zbigniew Jędrzejewski-Szmek wrote: > On Thu, Jul 20, 2023 at 07:40:08AM -0700, Andrea Bolognani wrote: > > Now, since this is clearly not a libvirt-specific issue, I believe > > this approach should be adopted across Fedora by way of these macros > > (or

Re: Potential changes to systemd RPM macros

2023-07-24 Thread Andrea Bolognani
On Thu, Jul 20, 2023 at 02:01:37PM -0700, Kevin Fenzi wrote: > On Thu, Jul 20, 2023 at 07:40:08AM -0700, Andrea Bolognani wrote: > > The problem is that Fedora 39 and RHEL 9.3 are fast approaching and, > > if we don't do anything about this issue before then, a subset of > > libvirt users will see

Re: Potential changes to systemd RPM macros

2023-07-21 Thread Zbigniew Jędrzejewski-Szmek
Hi Andrea, On Thu, Jul 20, 2023 at 07:40:08AM -0700, Andrea Bolognani wrote: > since the libvirt-daemon-proxy package is a completely new one as far > as RPM is concerned, all its systemd units will get presets applied > during %post. In at least two completely valid deployment scenarios, > this

Re: Potential changes to systemd RPM macros

2023-07-20 Thread Kevin Fenzi
On Thu, Jul 20, 2023 at 07:40:08AM -0700, Andrea Bolognani wrote: > Hi, > > this requires a bit of background, so please bear with me :) Thanks for all the background... :) ...snip reasonable stuff... I agree that an upstream systemd solution is what we should strive for. > The problem is

Potential changes to systemd RPM macros

2023-07-20 Thread Andrea Bolognani
Hi, this requires a bit of background, so please bear with me :) Earlier this year, the libvirt project changed its RPM package to be more granular[1] as a step towards a future where the legacy monolithic daemon (libvirtd) is completely gone. This change has happened upstream, but the Fedora