Re: Test gating enabled in Bodhi

2018-03-01 Thread Randy Barlow
On 03/01/2018 11:01 AM, mcatanz...@gnome.org wrote: > I know Pierre-Yves warned us about the bug that the tests will be > reported as a failure if the tests are still being run, but there was > absolutely no indication that there were more tests that were still > being run. So this could definitely

Re: Test gating enabled in Bodhi

2018-03-01 Thread mcatanzaro
On Wed, Feb 28, 2018 at 7:49 PM, Randy Barlow wrote: It does not appear to be blocked currently. There is a bug. Yesterday it was red and said tests failed; the result changed itself. I see there are many more test results now than there were yesterday. It looks like the tests had not finish

Re: Test gating enabled in Bodhi

2018-02-28 Thread Randy Barlow
On 02/28/2018 07:05 PM, mcatanz...@gnome.org wrote: > I have an update here: > > https://bodhi.fedoraproject.org/updates/epiphany-3.26.6-1.fc27 > > that is blocked due to some harmless translation-related warnings from > desktop-file-validate. It does not appear to be blocked currently. signa

Re: Test gating enabled in Bodhi

2018-02-28 Thread mcatanzaro
I have an update here: https://bodhi.fedoraproject.org/updates/epiphany-3.26.6-1.fc27 that is blocked due to some harmless translation-related warnings from desktop-file-validate. I'm not the translation police and do not plan to make any changes to the desktop file. * Who can help unblock

Re: Test gating enabled in Bodhi

2018-02-20 Thread Alexander Ploumistos
On Tue, Feb 20, 2018 at 11:10 PM, Rex Dieter wrote: > Alexander Ploumistos wrote: >> I am asking because the rpm documentation leaves quite a lot to be >> desired. If I went and changed all my "Requires: foo" to "Requires: >> foo%{_isa}" in all my non-noarch packages, would I be plain wrong, or >>

Re: Test gating enabled in Bodhi

2018-02-20 Thread Rex Dieter
Alexander Ploumistos wrote: > Well, with some delay, the waiver worked and I was able to push the > f26 package to batched. > > > On Tue, Feb 20, 2018 at 8:47 PM, Rex Dieter wrote: >> Alexander Ploumistos wrote: >>> OpenBabel is a runtime dependency for some optional features of >>> Molsketch.

Re: Test gating enabled in Bodhi

2018-02-20 Thread Alexander Ploumistos
Well, with some delay, the waiver worked and I was able to push the f26 package to batched. On Tue, Feb 20, 2018 at 8:47 PM, Rex Dieter wrote: > Alexander Ploumistos wrote: >> OpenBabel is a runtime dependency for some optional features of >> Molsketch. The %{_isa} macro got added during the rev

Re: Test gating enabled in Bodhi

2018-02-20 Thread Rex Dieter
Alexander Ploumistos wrote: > OpenBabel is a runtime dependency for some optional features of > Molsketch. The %{_isa} macro got added during the review I think the reviewer in this case was wrong to suggest that, just use Requires: openbabel FYI, the package is multilib'd because it has a -dev

Re: Test gating enabled in Bodhi

2018-02-20 Thread Adam Williamson
On Tue, 2018-02-20 at 19:15 +0100, Alexander Ploumistos wrote: > On Tue, Feb 20, 2018 at 5:13 PM, Rex Dieter wrote: > > Alexander Ploumistos wrote: > > > First question, why "arch" and "scenario" are x86_64, but the error > > > concerns the 32-bit build? Since OpenBabel exists on all arches, why >

Re: Test gating enabled in Bodhi

2018-02-20 Thread Alexander Ploumistos
On Tue, Feb 20, 2018 at 5:13 PM, Rex Dieter wrote: > Alexander Ploumistos wrote: >> First question, why "arch" and "scenario" are x86_64, but the error >> concerns the 32-bit build? Since OpenBabel exists on all arches, why >> do I get this particular error message? > > Your package is multilib'd?

Re: Test gating enabled in Bodhi

2018-02-20 Thread Rex Dieter
Alexander Ploumistos wrote: > Hi, > > I've been having a problem with dist.rpmdeplint checks for one of my > packages (molsketch). > This is a new package and it has a run-time dependency on OpenBabel: > > Requires: openbabel%{?_isa} > > The failure is the same on both f26 & f27: > > results:

Re: Test gating enabled in Bodhi

2018-02-20 Thread Alexander Ploumistos
Hi, I've been having a problem with dist.rpmdeplint checks for one of my packages (molsketch). This is a new package and it has a run-time dependency on OpenBabel: Requires: openbabel%{?_isa} The failure is the same on both f26 & f27: results: - arch: x86_64 item: molsketch-0.5.1-7.fc26 out

Re: Test gating enabled in Bodhi

2018-01-29 Thread Kamil Paral
On Tue, Jan 23, 2018 at 10:28 AM, Pierre-Yves Chibon wrote: > Good Morning Fedorans! > > On Thursday, a new version of Bodhi was deployed that enabled Bodhi to > gate updates based on test results. You may notice a "Test Gating > Status" message in the right have side of the page. > > One thing t

Re: Test gating enabled in Bodhi

2018-01-24 Thread Kevin Kofler
Rex Dieter wrote: > Pierre-Yves Chibon wrote: >> 1. dist.abicheck - to make sure the update's ABI remains stable in a >>given Fedora release. > > I think it unwise to make item 1 a mandatory item at this point. I'd > argue a large number of packages do not provide public api/abi that's > wort

Re: Test gating enabled in Bodhi

2018-01-24 Thread Ralph Bean
On Tue, Jan 23, 2018 at 10:33:01PM +0100, Dominik 'Rathann' Mierzejewski wrote: > On Tuesday, 23 January 2018 at 20:16, Matthew Miller wrote: > > On Tue, Jan 23, 2018 at 12:25:56PM -0600, Rex Dieter wrote: > > > > There are three tests that must pass in order for updates to go to > > > > stable: >

Re: Test gating enabled in Bodhi

2018-01-24 Thread Pierre-Yves Chibon
On Wed, Jan 24, 2018 at 03:25:48AM -0500, Randy Barlow wrote: > On 01/23/2018 05:12 PM, Adam Williamson wrote: > > The initial thought we - we being Tim, Kamil, Josef, Ralph and I - had > > is to simply invert the policy, if we can, so it becomes "the update > > passes *unless* we can find a 'fail'

Re: Test gating enabled in Bodhi

2018-01-24 Thread Randy Barlow
On 01/23/2018 05:12 PM, Adam Williamson wrote: > The initial thought we - we being Tim, Kamil, Josef, Ralph and I - had > is to simply invert the policy, if we can, so it becomes "the update > passes *unless* we can find a 'fail' for any of the required tests". So > all updates would be push-able (

Re: Test gating enabled in Bodhi

2018-01-23 Thread Philip Kovacs
On Tue, 2018-01-23 at 21:25 +, Philip Kovacs wrote: >> Can someone please elaborate on how I can control the abi tests >> directly?Where exactly can I access these and refine them on a per- >> package basis? >That text isn't talking about "fixing the tests", but about fixing the >*bugs*. It as

Re: Test gating enabled in Bodhi

2018-01-23 Thread Tim Flink
On Tue, 23 Jan 2018 11:06:59 +0100 Pierre-Yves Chibon wrote: > On Tue, Jan 23, 2018 at 09:42:50AM +, Richard W.M. Jones wrote: > > On Tue, Jan 23, 2018 at 10:28:14AM +0100, Pierre-Yves Chibon > > wrote: > > > Good Morning Fedorans! > > > > > > On Thursday, a new version of Bodhi was deploy

Re: Test gating enabled in Bodhi

2018-01-23 Thread Adam Williamson
On Tue, 2018-01-23 at 18:12 +, Richard W.M. Jones wrote: > The problem for the OCaml packages is missing tests or tests that > haven't been run: > > https://bodhi.fedoraproject.org/updates/FEDORA-2018-932548462e > https://bodhi.fedoraproject.org/updates/FEDORA-2018-ecd3541af9 > > BTW these b

Re: Test gating enabled in Bodhi

2018-01-23 Thread Adam Williamson
On Tue, 2018-01-23 at 21:25 +, Philip Kovacs wrote: > Can someone please elaborate on how I can control the abi tests > directly?Where exactly can I access these and refine them on a per- > package basis? > How to fix the tests? That text isn't talking about "fixing the tests", but about fixi

Re: Test gating enabled in Bodhi

2018-01-23 Thread Adam Williamson
On Tue, 2018-01-23 at 14:16 -0500, Matthew Miller wrote: > On Tue, Jan 23, 2018 at 12:25:56PM -0600, Rex Dieter wrote: > > > There are three tests that must pass in order for updates to go to stable: > > > 0. dist.depcheck - to make sure the update's dependencies are available. > > > 1. dist.abiche

Re: Test gating enabled in Bodhi

2018-01-23 Thread Dominik 'Rathann' Mierzejewski
On Tuesday, 23 January 2018 at 20:16, Matthew Miller wrote: > On Tue, Jan 23, 2018 at 12:25:56PM -0600, Rex Dieter wrote: > > > There are three tests that must pass in order for updates to go to stable: > > > 0. dist.depcheck - to make sure the update's dependencies are available. > > > 1. dist.abi

Re: Test gating enabled in Bodhi

2018-01-23 Thread Philip Kovacs
Can someone please elaborate on how I can control the abi tests directly?Where exactly can I access these and refine them on a per-package basis? How to fix the tests? The tests are all in your hand, you can fix the dist.depcheck and dist.abicheck  by adjusting the update or the build and you can

Re: Test gating enabled in Bodhi

2018-01-23 Thread Matthew Miller
On Tue, Jan 23, 2018 at 12:25:56PM -0600, Rex Dieter wrote: > > There are three tests that must pass in order for updates to go to stable: > > 0. dist.depcheck - to make sure the update's dependencies are available. > > 1. dist.abicheck - to make sure the update's ABI remains stable in a > >giv

Re: Test gating enabled in Bodhi

2018-01-23 Thread Rafael dos Santos
On 23 January 2018 at 19:22, Ralph Bean wrote: > On Tue, Jan 23, 2018 at 06:35:45PM +0100, Rafael dos Santos wrote: > > I get this error after clicking the authorization link: > > > > [16450:16491:0123/182437.407698:ERROR:browser_gpu_ > channel_host_factory.cc(120)] > > Failed to launch GPU proce

Re: Test gating enabled in Bodhi

2018-01-23 Thread Rex Dieter
Pierre-Yves Chibon wrote: > On Thursday, a new version of Bodhi was deployed that enabled Bodhi to > gate updates based on test results. You may notice a "Test Gating > Status" message in the right have side of the page. ... > There are three tests that must pass in order for updates to go to stab

Re: Test gating enabled in Bodhi

2018-01-23 Thread Ralph Bean
On Tue, Jan 23, 2018 at 06:35:45PM +0100, Rafael dos Santos wrote: > I get this error after clicking the authorization link: > > [16450:16491:0123/182437.407698:ERROR:browser_gpu_channel_host_factory.cc(120)] > Failed to launch GPU process. > Created new window in existing browser session. > 127.0.

Re: Test gating enabled in Bodhi

2018-01-23 Thread Richard W.M. Jones
On Tue, Jan 23, 2018 at 05:18:42PM +0100, Adam Williamson wrote: > On Tue, 2018-01-23 at 08:42 -0700, Jerry James wrote: > > Where are the instructions? Why is informing packagers, the group > > most affected by this change, an afterthought? We should have been > > told about all of this, in deta

Re: Test gating enabled in Bodhi

2018-01-23 Thread Josh Stone
On 01/23/2018 01:28 AM, Pierre-Yves Chibon wrote: > There are three tests that must pass in order for updates to go to stable: > > 0. dist.depcheck - to make sure the update's dependencies are available. > 1. dist.abicheck - to make sure the update's ABI remains stable in a >given Fedora relea

Re: Test gating enabled in Bodhi

2018-01-23 Thread Rafael dos Santos
I get this error after clicking the authorization link: [16450:16491:0123/182437.407698:ERROR:browser_gpu_channel_host_factory.cc(120)] Failed to launch GPU process. Created new window in existing browser session. 127.0.0.1 - - [23/Jan/2018 18:24:37] "GET /?error_description=Unknown+client+ID&erro

Re: Test gating enabled in Bodhi

2018-01-23 Thread Tom Hughes
On 23/01/18 16:18, Adam Williamson wrote: On Tue, 2018-01-23 at 08:42 -0700, Jerry James wrote: Where are the instructions? Why is informing packagers, the group most affected by this change, an afterthought? We should have been told about all of this, in detail, prior to the thing being turn

Re: Test gating enabled in Bodhi

2018-01-23 Thread Adam Williamson
On Tue, 2018-01-23 at 08:42 -0700, Jerry James wrote: > > There are no instructions on how to use it on this wiki page. Okay, > we'll try using --help: > > $ waiverdb-cli --help > Usage: waiverdb-cli [OPTIONS] > > Creates new waivers against test results. > > Examples: > > waiverdb-

Re: Test gating enabled in Bodhi

2018-01-23 Thread Jerry James
On Tue, Jan 23, 2018 at 2:28 AM, Pierre-Yves Chibon wrote: > Finally, if it turns out you need to push an update through despite of the > test > results, you can do so using waiver-cli (dnf install waiverdb-cli). We are > working on integrating this into Bodhi itself, making this easier. Good!

Re: Test gating enabled in Bodhi

2018-01-23 Thread Richard W.M. Jones
On Tue, Jan 23, 2018 at 09:47:44AM +, Tom Hughes wrote: > On 23/01/18 09:42, Richard W.M. Jones wrote: > > >When I click on the "automated tests" it says: > > > > "Automated Test Results > > Failed to talk to Greenwave. > > The update can not be pushed: 1 of 2 required tests not found" >

Re: Test gating enabled in Bodhi

2018-01-23 Thread Pierre-Yves Chibon
On Tue, Jan 23, 2018 at 09:42:50AM +, Richard W.M. Jones wrote: > On Tue, Jan 23, 2018 at 10:28:14AM +0100, Pierre-Yves Chibon wrote: > > Good Morning Fedorans! > > > > On Thursday, a new version of Bodhi was deployed that enabled Bodhi to > > gate updates based on test results. You may notice

Re: Test gating enabled in Bodhi

2018-01-23 Thread Tom Hughes
On 23/01/18 09:42, Richard W.M. Jones wrote: When I click on the "automated tests" it says: "Automated Test Results Failed to talk to Greenwave. The update can not be pushed: 1 of 2 required tests not found" and then the only "red" test (ie. failure) is rpmlint which is just a bunch o

Re: Test gating enabled in Bodhi

2018-01-23 Thread Richard W.M. Jones
On Tue, Jan 23, 2018 at 10:28:14AM +0100, Pierre-Yves Chibon wrote: > Good Morning Fedorans! > > On Thursday, a new version of Bodhi was deployed that enabled Bodhi to > gate updates based on test results. You may notice a "Test Gating > Status" message in the right have side of the page. > > One

Test gating enabled in Bodhi

2018-01-23 Thread Pierre-Yves Chibon
Good Morning Fedorans! On Thursday, a new version of Bodhi was deployed that enabled Bodhi to gate updates based on test results. You may notice a "Test Gating Status" message in the right have side of the page. One thing to know about this is that there is currently a confusing issue where Bodhi