Re: [Geany-Devel] Segmentation fault when auto-close plug-in is enable [patch]

2013-10-24 Thread Thomas Martitz
Am 24.10.2013 04:09, schrieb Matthew Brush: On 13-10-23 11:36 AM, Thomas Martitz wrote: [snip] Regarding that pattern we discussed previously and used in this AutoClose code for attaching data to a document, I'd be interested whether you or anyone thinks this branch (last/top two commits) wo

Re: [Geany-Devel] Segmentation fault when auto-close plug-in is enable [patch]

2013-10-24 Thread Thomas Martitz
Am 24.10.2013 05:59, schrieb Matthew Brush:Don't try to make special conditions that say your contributions must not be discussed/reviewed, thats rude, its like saying you think you are better than the other contributors on this list. I said it specifically to avoid getting into deep design d

[Geany-Devel] On document pointer recycling

2013-10-24 Thread Thomas Martitz
Am 24.10.2013 05:39, schrieb Lex Trotman: PS On the recycling of doc structures and doc->is_valid, this does have the advantage (for a structure where miscellaneous pointers to the structure are going to exist in Geany and plugins) that doc pointers will always point to a geanydocument struc

Re: [Geany-Devel] On document pointer recycling

2013-10-24 Thread Lex Trotman
On 24 October 2013 18:39, Thomas Martitz < thomas.mart...@student.htw-berlin.de> wrote: > Am 24.10.2013 05:39, schrieb Lex Trotman: > >> >> >> PS On the recycling of doc structures and doc->is_valid, this does have >> the advantage (for a structure where miscellaneous pointers to the >> structure

Re: [Geany-Devel] On document pointer recycling

2013-10-24 Thread Thomas Martitz
Am 24.10.2013 10:22, schrieb Lex Trotman: On 24 October 2013 18:39, Thomas Martitz > wrote: Am 24.10.2013 05:39, schrieb Lex Trotman: PS On the recycling of doc structures and doc->is_valid, this does have the advantage (fo

Re: [Geany-Devel] On document pointer recycling

2013-10-24 Thread Lex Trotman
[...] > >> Agreed. I wasn't meaning to sound like I was defending it. I was just >> pointing out that one of its side effects. >> > > Yes you sounded like that. I must remember to be more emphatic next time :) [...] > Its certainly not a one line change, but may not be huge, depending on the

Re: [Geany-Devel] On document pointer recycling

2013-10-24 Thread Thomas Martitz
Am 24.10.2013 11:24, schrieb Lex Trotman: I currently do not have access to a dev environment where I can grab the plugins and search for places the index is used. But if its not used anywhere (or even if its not used much) then it should be deprecated immediately so nobody uses it in new co

Re: [Geany-Devel] On document pointer recycling

2013-10-24 Thread Lex Trotman
On 24 October 2013 20:48, Thomas Martitz < thomas.mart...@student.htw-berlin.de> wrote: > Am 24.10.2013 11:24, schrieb Lex Trotman: > > >> I currently do not have access to a dev environment where I can grab the >> plugins and search for places the index is used. But if its not used >> anywhere (

Re: [Geany-Devel] Segmentation fault when auto-close plug-in is enable [patch]

2013-10-24 Thread Matthew Brush
On 13-10-24 12:23 AM, Thomas Martitz wrote: Am 24.10.2013 04:09, schrieb Matthew Brush: On 13-10-23 11:36 AM, Thomas Martitz wrote: [snip] Regarding that pattern we discussed previously and used in this AutoClose code for attaching data to a document, I'd be interested whether you or anyone t

Re: [Geany-Devel] On document pointer recycling

2013-10-24 Thread Dimitar Zhekov
On Thu, 24 Oct 2013 19:22:34 +1100 Lex Trotman wrote: > Unfortunately there is an accessor document_index() in the plugin interface > that uses the index into the array. > > Switching to a list means that there needs to be a change everywhere in > Geany and the plugins that the array index is us

Re: [Geany-Devel] Segmentation fault when auto-close plug-in is enable [patch]

2013-10-24 Thread Thomas Martitz
Am 24.10.2013 16:25, schrieb Matthew Brush: I agree with that. I also agree with your general idea of per-document data lists. However, I'm not seeing the point of the new code you added because each doc has already a ScintillaObject, which is a GObject. I would suggest that the document_set_d

Re: [Geany-Devel] On document pointer recycling

2013-10-24 Thread Lex Trotman
On 25 October 2013 04:04, Dimitar Zhekov wrote: > On Thu, 24 Oct 2013 19:22:34 +1100 > Lex Trotman wrote: > > > Unfortunately there is an accessor document_index() in the plugin > interface > > that uses the index into the array. > > > > Switching to a list means that there needs to be a change

Re: [Geany-Devel] On document pointer recycling

2013-10-24 Thread Matthew Brush
On 13-10-24 02:51 PM, Lex Trotman wrote: On 25 October 2013 04:04, Dimitar Zhekov wrote: On Thu, 24 Oct 2013 19:22:34 +1100 Lex Trotman wrote: Unfortunately there is an accessor document_index() in the plugin interface that uses the index into the array. Switching to a list means that th

Re: [Geany-Devel] On document pointer recycling

2013-10-24 Thread Lex Trotman
[...] We could use GHashTable as a Set to contain the documents internally > afterwards. It doesn't make much sense to have a particular document > instantiated more than once anyway and the only order we care about for > documents here is maybe the order/time they were opened, which is better > s

Re: [Geany-Devel] On document pointer recycling

2013-10-24 Thread Matthew Brush
On 13-10-24 08:34 PM, Lex Trotman wrote: [...] We could use GHashTable as a Set to contain the documents internally afterwards. It doesn't make much sense to have a particular document instantiated more than once anyway and the only order we care about for documents here is maybe the order/time

Re: [Geany-Devel] splitwindow2

2013-10-24 Thread Thomas Martitz
Am 14.10.2013 21:48, schrieb Thomas Martitz: > Am 10.10.2013 12:03, schrieb Thomas Martitz: >> Hello, >> >> [1]: https://github.com/kugel-/geany/tree/splitwindow2 > > I have pushed a new version. It works really well so far. But of course there's still lots of TODOs but it is already pretty usable.