Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-16 Thread Thomas Martitz
Am 16.10.2013 01:52, schrieb Lex Trotman: For me, you will be *very* welcome if you can provide a proper set of multi-platform spawn with/without stdin/stdout/stderr that can remove the #ifdef G_OS_WIN32 stuff from build.c that I have been tiptoeing around for years not daring to pass the

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-16 Thread Nick Treleaven
On 05/10/2013 14:59, Nick Treleaven wrote: Maybe to you, but it's very common on Windows to have spaces in the path names, it's even the default on Windows XP (Documents and Settings). To most people (ex. the bug reporters) it seems outright broken now, whereas before it worked. See my other

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-16 Thread Dimitar Zhekov
On Tue, 15 Oct 2013 22:02:45 +0200 Thomas Martitz thomas.mart...@student.htw-berlin.de wrote: Am 15.10.2013 19:05, schrieb Dimitar Zhekov: The last time FiF-ed, glib did not contain any calls to PeekNamedPipe or SetNamedPipeHandleState. [...] Speaking of PeekNamedPipe... A few months

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-16 Thread Thomas Martitz
Am 16.10.2013 21:04, schrieb Dimitar Zhekov: Actually, I finished most of it, what remains is mainly blocking Geany while the new async tools execution is running. Sync spawning is not good, because I'm using the Geany message loop for async I/O (somewhat similar to g_main_context_add_poll),

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-16 Thread Lex Trotman
On 17 October 2013 06:08, Thomas Martitz thomas.mart...@student.htw-berlin.de wrote: Am 16.10.2013 21:04, schrieb Dimitar Zhekov: Actually, I finished most of it, what remains is mainly blocking Geany while the new async tools execution is running. Sync spawning is not good, because I'm

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-16 Thread Matthew Brush
On 13-10-16 12:04 PM, Dimitar Zhekov wrote: [snip] Actually, I finished most of it, what remains is mainly blocking Geany while the new async tools execution is running. Sync spawning is not good, because I'm using the Geany message loop for async I/O (somewhat similar to

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-15 Thread Dimitar Zhekov
On Tue, 15 Oct 2013 11:29:17 +1100 Lex Trotman ele...@gmail.com wrote: A good news first: using a bit of Scope code, I was able to pipe 12.3MB of mixed stdout and stderr output into Geany, in async mode, for just a few seconds. There is a delay when scrolling the messages down, and the scroll

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-15 Thread Thomas Martitz
Am 15.10.2013 19:05, schrieb Dimitar Zhekov: The last time FiF-ed, glib did not contain any calls to PeekNamedPipe or SetNamedPipeHandleState. I am not aware of any way to implement async anonymous pipe I/O under Windows without these, and see no reason to check the various glib functions one by

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-15 Thread Lex Trotman
On 16 October 2013 04:05, Dimitar Zhekov dimitar.zhe...@gmail.com wrote: On Tue, 15 Oct 2013 11:29:17 +1100 Lex Trotman ele...@gmail.com wrote: A good news first: using a bit of Scope code, I was able to pipe 12.3MB of mixed stdout and stderr output into Geany, in async mode, for just a few

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-15 Thread Matthew Brush
On 13-10-15 10:05 AM, Dimitar Zhekov wrote: On Tue, 15 Oct 2013 11:29:17 +1100 Lex Trotman ele...@gmail.com wrote: [snip] Basically the whole spawning thing needs to be looked at critically, especially those uses that do i/o to the child process. A working version of each permutation

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-14 Thread Dimitar Zhekov
Hi, I'm looking how to fix this famous bug without too many changes, and found something strange: tools.c runs it's command with spawn async, but uses blocking I/O to read the data from stdout/stderr. Any idea why is that? What comes to ming is blocking Geany until the command finishes, to be

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-14 Thread Lex Trotman
On 15 October 2013 03:15, Dimitar Zhekov dimitar.zhe...@gmail.com wrote: Hi, I'm looking how to fix this famous bug without too many changes, and found something strange: tools.c runs it's command with spawn async, but uses blocking I/O to read the data from stdout/stderr. Given that it

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-10 Thread Dimitar Zhekov
Hi, I don't have today, so the results quickly. Short test proram, which writes The quick brown fox jumps over the stdout/err %d times\n, plus a few characters in stdout to create valid gdb output. Geany, with 1 iterations: dies at stdout 140, stderr 128. I cancelled it after 2 minutes, then

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-09 Thread Nick Treleaven
On 07/10/2013 20:07, Matthew Brush wrote: On 13-10-07 08:31 AM, Nick Treleaven wrote: On 05/10/2013 15:40, Matthew Brush wrote: On 13-10-05 07:06 AM, Nick Treleaven wrote: It was last year, but I think it wasn't just with dmd, although that triggered it the most, and it only happened when dmd

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-09 Thread Nick Treleaven
On 09/10/2013 01:50, Matthew Brush wrote: I can simply test FiF with regex = ., which will generate a lot of output quite fast. Without the SYNC_SPAWN patches, build.c and search.c async executions are identical (except that build checks if the returned pid after successful spawn async is 0,

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-09 Thread Dimitar Zhekov
On Tue, 08 Oct 2013 17:50:15 -0700 Matthew Brush mbr...@codebrainz.ca wrote: On 13-10-08 10:28 AM, Dimitar Zhekov wrote: On Mon, 07 Oct 2013 12:28:49 -0700 Matthew Brush mbr...@codebrainz.ca wrote: [...] Any chance you could find time to review and test Geany's implementation to

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-09 Thread Matthew Brush
On 13-10-09 07:42 AM, Nick Treleaven wrote: On 09/10/2013 01:50, Matthew Brush wrote: [snip] GTK+ 2.22 is over 3 years old by now, FWIW. I'm using 2.22 under win~1 too, and don't think it will have any problems with async exec, but we'll see. Yeah, just pointing it out because 3 years

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-08 Thread Dimitar Zhekov
On Mon, 07 Oct 2013 12:28:49 -0700 Matthew Brush mbr...@codebrainz.ca wrote: [...] Any chance you could find time to review and test Geany's implementation to see if anything looks fishy? I can simply test FiF with regex = ., which will generate a lot of output quite fast. Without the

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-08 Thread Matthew Brush
On 13-10-08 10:28 AM, Dimitar Zhekov wrote: On Mon, 07 Oct 2013 12:28:49 -0700 Matthew Brush mbr...@codebrainz.ca wrote: [...] Any chance you could find time to review and test Geany's implementation to see if anything looks fishy? I can simply test FiF with regex = ., which will generate

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-07 Thread Nick Treleaven
On 05/10/2013 15:40, Matthew Brush wrote: On 13-10-05 07:06 AM, Nick Treleaven wrote: On 05/10/2013 14:59, Nick Treleaven wrote: I don't remember seeing any bug reports for this, so it's possible it's limited to you or the specific application you were using, maybe a bug in a certain version

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-07 Thread Matthew Brush
On 13-10-07 08:31 AM, Nick Treleaven wrote: On 05/10/2013 15:40, Matthew Brush wrote: On 13-10-05 07:06 AM, Nick Treleaven wrote: On 05/10/2013 14:59, Nick Treleaven wrote: I don't remember seeing any bug reports for this, so it's possible it's limited to you or the specific application you

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-07 Thread Matthew Brush
On 13-10-07 09:13 AM, Dimitar Zhekov wrote: On Sun, 6 Oct 2013 11:02:07 +1100 Lex Trotman ele...@gmail.com wrote: On 6 October 2013 06:06, Dimitar Zhekov dimitar.zhe...@gmail.com wrote: On Sat, 05 Oct 2013 07:40:15 -0700 Matthew Brush mbr...@codebrainz.ca wrote: So with the pull request

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-05 Thread Nick Treleaven
On 03/10/2013 18:00, Nick Treleaven wrote: In the meantime, there are 3 spawning variants: I'm confident that the custom process spawning code is definitely seriously buggy. I really do need the system() code. I tried, but couldn't fix it. I know that last time I tried it, the g_spawn didn't

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-05 Thread Nick Treleaven
Now I'll answer the rest of your mail Matt. On 03/10/2013 15:43, Matthew Brush wrote: On 13-10-03 05:31 AM, Nick Treleaven wrote: On 02/10/2013 22:58, Matthew Brush wrote: On 13-10-02 04:40 AM, Nick Treleaven wrote: On 01/10/2013 22:28, Matthew Brush wrote: On 13-10-01 05:34 AM, Nick

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-05 Thread Nick Treleaven
On 05/10/2013 14:59, Nick Treleaven wrote: spawn that doesn't block Geany or outright hang. This definitely It would be nice to figure out *why* it was hanging and fix *that* problem though, not just drop the existing workaround code and write 3rd workaround that's arguably worse[1] than the

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-05 Thread Dimitar Zhekov
On Sat, 05 Oct 2013 07:40:15 -0700 Matthew Brush mbr...@codebrainz.ca wrote: So with the pull request adding system() as a fallback/hidden preference, maybe we could just drop the win32 API code altogether, switch back to using the same codepath as all platforms (ie. GLib async spawning)

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-05 Thread Lex Trotman
On 6 October 2013 06:06, Dimitar Zhekov dimitar.zhe...@gmail.com wrote: On Sat, 05 Oct 2013 07:40:15 -0700 Matthew Brush mbr...@codebrainz.ca wrote: So with the pull request adding system() as a fallback/hidden preference, maybe we could just drop the win32 API code altogether, switch

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-03 Thread Matthew Brush
On 13-10-03 05:31 AM, Nick Treleaven wrote: Moving to devel list. On 02/10/2013 22:58, Matthew Brush wrote: On 13-10-02 04:40 AM, Nick Treleaven wrote: On 01/10/2013 22:28, Matthew Brush wrote: On 13-10-01 05:34 AM, Nick Treleaven wrote: Just checked my email, was away last week. I'll have

Re: [Geany-Devel] Ping on Bug #943 - windows build command

2013-10-03 Thread Nick Treleaven
cc'ing the devel list. Hi Matt, I'll have to reply to this email properly tomorrow. In the meantime, there are 3 spawning variants: I'm confident that the custom process spawning code is definitely seriously buggy. I really do need the system() code. I tried, but couldn't fix it. I know that