Re: [PATCH] GEODE: decouple sleep/resume from powerdown/powerup (take 2)

2007-11-17 Thread Andres Salomon
On Sun, 23 Sep 2007 22:19:58 -0400 Bernardo Innocenti <[EMAIL PROTECTED]> wrote: > This patch merges the fb_powerup and fb_powerdown hooks in a single > operation fb_power with an additional "state" parameter ranging > from 0 (running) to 3 (poweroff). > > diff --git a/drivers/video/geode/lxfb_op

Re: [PATCH] GEODE: decouple sleep/resume from powerdown/powerup (take 2)

2007-09-25 Thread Andres Salomon
On Tue, 25 Sep 2007 11:50:47 -0400 Bernardo Innocenti <[EMAIL PROTECTED]> wrote: > Andres Salomon wrote: > > >> On the GX, we *save* them always and restore them only on powerup. > >> Saving the registers is needed because, later on, we peek a few values > >> from that structure for powering up t

Re: [PATCH] GEODE: decouple sleep/resume from powerdown/powerup (take 2)

2007-09-25 Thread Bernardo Innocenti
Andres Salomon wrote: >> On the GX, we *save* them always and restore them only on powerup. >> Saving the registers is needed because, later on, we peek a few values >> from that structure for powering up the video unit. > > Er, brain fart. We don't want to be calling lx_graphics_{en,dis}able wh

Re: [PATCH] GEODE: decouple sleep/resume from powerdown/powerup (take 2)

2007-09-25 Thread Andres Salomon
On Tue, 25 Sep 2007 02:18:09 -0400 Bernardo Innocenti <[EMAIL PROTECTED]> wrote: > Andres Salomon wrote: > > >> diff --git a/drivers/video/geode/lxfb_ops.c > >> b/drivers/video/geode/lxfb_ops.c > >> index b2ecb4d..b380238 100644 > >> --- a/drivers/video/geode/lxfb_ops.c > >> +++ b/drivers/video/

Re: [PATCH] GEODE: decouple sleep/resume from powerdown/powerup (take 2)

2007-09-25 Thread Bernardo Innocenti
Bernardo Innocenti wrote: > This patch merges the fb_powerup and fb_powerdown hooks in a single > operation fb_power with an additional "state" parameter ranging > from 0 (running) to 3 (poweroff). Oops, I sent take2 again by mistake. Will follow up immediately. -- \___/ |___| Bernardo Innoc

[PATCH] GEODE: decouple sleep/resume from powerdown/powerup (take 2)

2007-09-24 Thread Bernardo Innocenti
This patch merges the fb_powerup and fb_powerdown hooks in a single operation fb_power with an additional "state" parameter ranging from 0 (running) to 3 (poweroff). The geodefb uses state 2 as an intermediate low-power mode, where the LX or GX video unit is turned off, but the GPU may still be wo

Re: [PATCH] GEODE: decouple sleep/resume from powerdown/powerup (take 2)

2007-09-24 Thread Bernardo Innocenti
Andres Salomon wrote: >> diff --git a/drivers/video/geode/lxfb_ops.c b/drivers/video/geode/lxfb_ops.c >> index b2ecb4d..b380238 100644 >> --- a/drivers/video/geode/lxfb_ops.c >> +++ b/drivers/video/geode/lxfb_ops.c >> @@ -829,33 +829,42 @@ static void lx_restore_regs(struct fb_info *info, >> stru

[PATCH] GEODE: decouple sleep/resume from powerdown/powerup (take 2)

2007-09-23 Thread Bernardo Innocenti
This patch merges the fb_powerup and fb_powerdown hooks in a single operation fb_power with an additional "state" parameter ranging from 0 (running) to 3 (poweroff). The geodefb uses state 2 as an intermediate low-power mode, where the LX or GX video unit is turned off, but the GPU may still be wo