[RFC PATCH 1/1] qemu: monitor: parse deprecated-props from query-cpu-model-expansion response

2024-05-07 Thread Collin Walling
query-cpu-model-expansion may report an array of deprecated properties. This array is optional, and may not be supported for a particular architecture or reported for a particular CPU model. If the output is present, then capture it and store in a qemuMonitorCPUModelInfo struct for later use. Base

[RFC PATCH 0/1] support deprecated-props from query-cpu-model-expansion

2024-05-07 Thread Collin Walling
Overview QEMU will soon support reporting an optional array of deprecated features for an expanded CPU model via the query-cpu-model-expansion command. The intended use of this data is to make it easier for a user to define a CPU model with features flagged as deprecated set to disabl

Re: [PATCH 30/35] virshtest: Adapt 'virsh-read-bufsiz' and 'virsh-read-non-seekable'

2024-05-07 Thread Andrea Bolognani
On Tue, May 07, 2024 at 08:14:18PM GMT, Daniel P. Berrangé wrote: > On Tue, May 07, 2024 at 04:56:00PM +, Andrea Bolognani wrote: > > On Fri, Mar 22, 2024 at 06:56:08PM GMT, Peter Krempa wrote: > > > +static void > > > +testPipeFeeder(void *opaque) > > > +{ > > > +/* feed more than observed

Re: [PATCH 30/35] virshtest: Adapt 'virsh-read-bufsiz' and 'virsh-read-non-seekable'

2024-05-07 Thread Daniel P . Berrangé
On Tue, May 07, 2024 at 04:56:00PM +, Andrea Bolognani wrote: > On Fri, Mar 22, 2024 at 06:56:08PM GMT, Peter Krempa wrote: > > +static void > > +testPipeFeeder(void *opaque) > > +{ > > +/* feed more than observed buffer size which was historically 128k in > > the > > + * test this was

Re: [PATCH 08/13] ci: Drop Ubuntu 20.04

2024-05-07 Thread Michal Prívozník
On 5/7/24 18:40, Andrea Bolognani wrote: > On Tue, May 07, 2024 at 01:58:07PM GMT, Daniel P. Berrangé wrote: >> On Tue, May 07, 2024 at 02:37:05PM +0200, Michal Prívozník wrote: >>> On 5/7/24 12:11, Daniel P. Berrangé wrote: FYI, I'd really *not* splitting out the removal and addition into >>>

Re: [PATCH 30/35] virshtest: Adapt 'virsh-read-bufsiz' and 'virsh-read-non-seekable'

2024-05-07 Thread Andrea Bolognani
On Fri, Mar 22, 2024 at 06:56:08PM GMT, Peter Krempa wrote: > +static void > +testPipeFeeder(void *opaque) > +{ > +/* feed more than observed buffer size which was historically 128k in the > + * test this was adapted from */ > +size_t emptyspace = 140 * 1024; This test seems to fail co

Re: [PATCH 08/13] ci: Drop Ubuntu 20.04

2024-05-07 Thread Andrea Bolognani
On Tue, May 07, 2024 at 01:58:07PM GMT, Daniel P. Berrangé wrote: > On Tue, May 07, 2024 at 02:37:05PM +0200, Michal Prívozník wrote: > > On 5/7/24 12:11, Daniel P. Berrangé wrote: > > > FYI, I'd really *not* splitting out the removal and addition into > > > separate jobs. If you remove 20.04 and

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-07 Thread Peter Xu
On Tue, May 07, 2024 at 01:50:43AM +, Gonglei (Arei) wrote: > Hello, > > > -Original Message- > > From: Peter Xu [mailto:pet...@redhat.com] > > Sent: Monday, May 6, 2024 11:18 PM > > To: Gonglei (Arei) > > Cc: Daniel P. Berrangé ; Markus Armbruster > > ; Michael Galaxy ; Yu Zhang > >

Re: [PATCH 00/12] fix many test failures in various build config scenarios

2024-05-07 Thread Peter Krempa
On Tue, May 07, 2024 at 14:58:55 +0100, Daniel P. Berrangé wrote: > I was annoyed that > > meson build --auto-features=disabled -Dtests=enabled > > will fail in unit tests. Rather than just fix that scenario, I went > down the rabbit hole and tested (almost) every single minimal build > option.

Re: [PATCH 07/12] tests: build driver modules before virdrivermoduletest

2024-05-07 Thread Peter Krempa
On Tue, May 07, 2024 at 14:59:02 +0100, Daniel P. Berrangé wrote: > The virdrivermoduletest will attempt to dlopen() each driver module, > so they must be build before the test can run. > > Signed-off-by: Daniel P. Berrangé > --- > src/meson.build | 3 +++ > tests/meson.build | 2 +- > 2 files

Re: [PATCH 04/12] docs: ensure HTML/images are built before running reference tests

2024-05-07 Thread Daniel P . Berrangé
On Tue, May 07, 2024 at 04:30:55PM +0200, Michal Prívozník wrote: > On 5/7/24 16:23, Daniel P. Berrangé wrote: > > On Tue, May 07, 2024 at 02:58:59PM +0100, Daniel P. Berrangé wrote: > >> The 'check-html-references' test will process the built HTML files, > >> so they must exist before it is run, a

Re: [PATCH 04/12] docs: ensure HTML/images are built before running reference tests

2024-05-07 Thread Michal Prívozník
On 5/7/24 16:23, Daniel P. Berrangé wrote: > On Tue, May 07, 2024 at 02:58:59PM +0100, Daniel P. Berrangé wrote: >> The 'check-html-references' test will process the built HTML files, >> so they must exist before it is run, along with any images that >> they point to. >> >> Signed-off-by: Daniel P.

Re: [PATCH 07/12] tests: build driver modules before virdrivermoduletest

2024-05-07 Thread Peter Krempa
On Tue, May 07, 2024 at 14:59:02 +0100, Daniel P. Berrangé wrote: > The virdrivermoduletest will attempt to dlopen() each driver module, > so they must be build before the test can run. > > Signed-off-by: Daniel P. Berrangé > --- > src/meson.build | 3 +++ > tests/meson.build | 2 +- > 2 files

Re: [PATCH 06/12] tests: build 'virsh' before running virsh-auth test

2024-05-07 Thread Peter Krempa
On Tue, May 07, 2024 at 14:59:01 +0100, Daniel P. Berrangé wrote: > The 'virsh-auth' test needs to be able to invoke the 'virsh' binary > > Signed-off-by: Daniel P. Berrangé > --- > tests/meson.build | 16 +++- > 1 file changed, 11 insertions(+), 5 deletions(-) > > diff --git a/test

[PATCH v2 08/10] ci: Drop Ubuntu 20.04

2024-05-07 Thread Michal Privoznik
It's now more than two years since Ubuntu 22.04 was released and per our support policy, Ubuntu 20.04 (the previous major release) is now not supported. Remove it from our CI testing. Signed-off-by: Michal Privoznik Reviewed-by: Daniel P. Berrangé --- ci/buildenv/ubuntu-2004.sh | 103

[PATCH v2 10/10] ci: Introduce Ubuntu 24.04

2024-05-07 Thread Michal Privoznik
Ubuntu 24.04 was released recently. Add it to our CI. Also, to be able to run ASAN/UBSAN builds on Ubuntu 24.04 libclang-rt-dev needs to be installed (because clang's runtime was moved into a separate package). Hence so many seemingly unrelated changes. Signed-off-by: Michal Privoznik --- ci/bui

[PATCH v2 09/10] meson: Bump glib version to 2.58.0

2024-05-07 Thread Michal Privoznik
Now that we don't have any distro stuck with glib-2.56.0, we can bump the glib version. In fact, this is needed, because of g_clear_pointer. Since v7.4.0-rc1~301 we declare at compile time what version of glib APIs we want to use (by setting GLIB_VERSION_MIN_REQUIRED = GLIB_VERSION_MAX_ALLOWED = 2.

[PATCH v2 07/10] ci: Switch from Fedora 38 to Fedora 40

2024-05-07 Thread Michal Privoznik
Since Fedora 40 was released recently, Fedora 38 is now unsupported. Drop Fedora 38 and introduce Fedora 40 to our CI. Signed-off-by: Michal Privoznik Reviewed-by: Daniel P. Berrangé --- ...-mingw32.sh => fedora-40-cross-mingw32.sh} | 0 ...-mingw64.sh => fedora-40-cross-mingw64.sh} | 0 ci/b

[PATCH v2 00/10] Big CI update (and some bug fixes)

2024-05-07 Thread Michal Privoznik
v2 of: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/MMENBGZ3HYYKUVPY6FJ443SYCBNFTDHH/ diff to v1: - Juggled some patches around, namely: squashed Fedora and AlmaLinux drop & reintroduction patches, reordered some for easier review. - Switched website job to AlmaLinux 9

[PATCH v2 06/10] ci: Switch from AlmaLinux 8 to AlmaLinux 9

2024-05-07 Thread Michal Privoznik
By the time of release, it's going to be more than two years since AlmaLinux 9 was released and per our support policy, AlmaLinux 8 (the previous major release) will be not supported. Switch from AlmaLinux 8 to AlmaLinux 9. This also means the website_job which depends on AlmaLinux 8 needs to be m

[PATCH v2 05/10] meson: Disable -fsanitize=function

2024-05-07 Thread Michal Privoznik
Strictly speaking, xdrproc_t is declared as following: typedef bool_t (*xdrproc_t)(XDR *, ...); But our rpcgen generates properly typed functions, e.g.: bool_t xdr_virNetMessageError(XDR *xdrs, virNetMessageError *objp) Now, these functions of ours are passed around as callbacks (via an arg

[PATCH v2 04/10] security: Fix return types of .probe callbacks

2024-05-07 Thread Michal Privoznik
The .probe member of virSecurityDriver struct is declared to return virSecurityDriverStatus enum. But there are two instances (AppArmorSecurityManagerProbe() and virSecuritySELinuxDriverProbe()) where callbacks are defined to return an integer. This is an undefined behavior because integer has stri

[PATCH v2 03/10] testutilsqemu: Don't leak struct testQemuArgs::vdpafds

2024-05-07 Thread Michal Privoznik
Allocated in testQemuInfoSetArgs(), the vdpafds member of testQemuArgs is never freed. Signed-off-by: Michal Privoznik Reviewed-by: Daniel P. Berrangé --- tests/testutilsqemu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c index 9c12a165b1..d7

[PATCH v2 02/10] qemuxml2argvmock: Drop link time dependency on qemuFDPassDirectNew()

2024-05-07 Thread Michal Privoznik
While Linux linker has no trouble resolving the symbols, valgrind does. It has probably something to do with the fact that we don't tell what symbols to export from mock libraries. Anyway, just resolve the symbol at runtime. Signed-off-by: Michal Privoznik Reviewed-by: Daniel P. Berrangé --- te

[PATCH v2 01/10] domaincapsmock: Drop link time dependency on virQEMUCapsGet()

2024-05-07 Thread Michal Privoznik
While Linux linker has no trouble resolving the symbols, valgrind does. It has probably something to do with the fact that we don't tell what symbols to export from mock libraries. Anyway, just resolve the symbol at runtime. Signed-off-by: Michal Privoznik Reviewed-by: Daniel P. Berrangé --- te

Re: [PATCH 03/12] meson: record which other options are a pre-requisite

2024-05-07 Thread Peter Krempa
On Tue, May 07, 2024 at 14:58:58 +0100, Daniel P. Berrangé wrote: > Several meson options cannot be enabled, without first enabling another > option. This adds a small comment prior to an optino to record its s/optino/option/ > mandatory dependencies. > > Signed-off-by: Daniel P. Berrangé > ---

Re: [PATCH 04/12] docs: ensure HTML/images are built before running reference tests

2024-05-07 Thread Daniel P . Berrangé
On Tue, May 07, 2024 at 02:58:59PM +0100, Daniel P. Berrangé wrote: > The 'check-html-references' test will process the built HTML files, > so they must exist before it is run, along with any images that > they point to. > > Signed-off-by: Daniel P. Berrangé > --- > docs/images/meson.build | 5 +

[PATCH 12/12] src/node_device: don't overwrite error messages

2024-05-07 Thread Daniel P . Berrangé
The nodedev code unhelpfully reports couldn't convert node device def to mdevctl JSON which hides the actual error message No JSON parser implementation is available Signed-off-by: Daniel P. Berrangé --- src/node_device/node_device_driver.c | 2 -- 1 file changed, 2 deletions(-) diff --g

[PATCH 11/12] tests: don't run mdevctl test if lacking YAJL

2024-05-07 Thread Daniel P . Berrangé
The mdev code requires YAJL in order to convert from node dev XML to mdev's config format. Signed-off-by: Daniel P. Berrangé --- tests/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/meson.build b/tests/meson.build index 027567d25c..0d83dd445a 100644 --- a/t

[PATCH 09/12] tests: always build securityselinuxhelper if libselinux is present

2024-05-07 Thread Daniel P . Berrangé
The securityselinuxhelper build is conditionalized on the SELinux security driver feature. It is also needed, however, by viridentitytest whenever libselinux is present. Signed-off-by: Daniel P. Berrangé --- tests/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/meson.buil

[PATCH 10/12] test: drop bogus check for YAJL from libxl test/mock

2024-05-07 Thread Daniel P . Berrangé
The libxlmock.c conditionalizes on WITH_YAJL, but this mock is used from other tests which only conditionalize on WITH_LIBXL. The libxl code does not have any dependancy on YAJL, so the bogus condition can be removed from the mock and also from libxlxml2domconfigtest.c Signed-off-by: Daniel P. Ber

[PATCH 08/12] test: conditionalize 'virsh-auth' on test driver

2024-05-07 Thread Daniel P . Berrangé
The 'virsh-auth' test is mistakenly conditionalized on the libvirtd daemon build, however, it just uses the 'test:///default' driver URI, so does not require a daemon. Signed-off-by: Daniel P. Berrangé --- tests/meson.build | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff -

[PATCH 07/12] tests: build driver modules before virdrivermoduletest

2024-05-07 Thread Daniel P . Berrangé
The virdrivermoduletest will attempt to dlopen() each driver module, so they must be build before the test can run. Signed-off-by: Daniel P. Berrangé --- src/meson.build | 3 +++ tests/meson.build | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/meson.build b/src/meson

[PATCH 05/12] src: ensure augeas test file is generated before running test

2024-05-07 Thread Daniel P . Berrangé
We fail to express an ordering between the custom target that generates the combined augeas test input file, and the meson test command. Signed-off-by: Daniel P. Berrangé --- src/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/meson.build b/src/meson.build i

[PATCH 06/12] tests: build 'virsh' before running virsh-auth test

2024-05-07 Thread Daniel P . Berrangé
The 'virsh-auth' test needs to be able to invoke the 'virsh' binary Signed-off-by: Daniel P. Berrangé --- tests/meson.build | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/tests/meson.build b/tests/meson.build index 73b87be2a0..68fe00d0c1 100644 --- a/tests/

[PATCH 04/12] docs: ensure HTML/images are built before running reference tests

2024-05-07 Thread Daniel P . Berrangé
The 'check-html-references' test will process the built HTML files, so they must exist before it is run, along with any images that they point to. Signed-off-by: Daniel P. Berrangé --- docs/images/meson.build | 5 +++-- docs/logos/meson.build | 5 +++-- docs/meson.build| 1 + 3 files ch

[PATCH 03/12] meson: record which other options are a pre-requisite

2024-05-07 Thread Daniel P . Berrangé
Several meson options cannot be enabled, without first enabling another option. This adds a small comment prior to an optino to record its mandatory dependencies. Signed-off-by: Daniel P. Berrangé --- meson_options.txt | 20 1 file changed, 20 insertions(+) diff --git a/mes

[PATCH 02/12] tests: fix tests when test driver is disabled

2024-05-07 Thread Daniel P . Berrangé
Various tests try to open a connection to 'test:///default' and must be skipped when the test driver is disabled. Signed-off-by: Daniel P. Berrangé --- tests/fchosttest.c | 9 ++--- tests/meson.build | 37 - 2 files changed, 30 insertions(+), 16 deletion

[PATCH 00/12] fix many test failures in various build config scenarios

2024-05-07 Thread Daniel P . Berrangé
I was annoyed that meson build --auto-features=disabled -Dtests=enabled will fail in unit tests. Rather than just fix that scenario, I went down the rabbit hole and tested (almost) every single minimal build option. By that I mean I looked at meson_options.txt and got a list of every option th

[PATCH 01/12] scripts/rpcgen: skip tests if tirpc is not present

2024-05-07 Thread Daniel P . Berrangé
This skips building tests which rely on tirpc when it is not present. Signed-off-by: Daniel P. Berrangé --- scripts/rpcgen/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/rpcgen/meson.build b/scripts/rpcgen/meson.build index 7fb32c0f91..bce652c7ad 100644 -

Re: [PATCH 08/13] ci: Drop Ubuntu 20.04

2024-05-07 Thread Daniel P . Berrangé
On Tue, May 07, 2024 at 02:37:05PM +0200, Michal Prívozník wrote: > On 5/7/24 12:11, Daniel P. Berrangé wrote: > > On Mon, May 06, 2024 at 10:43:05AM +0200, Michal Privoznik wrote: > >> It's now more than two years since Ubuntu 22.04 was released and > >> per our support policy, Ubuntu 20.04 (the p

Re: [PATCH 12/13] ci: Introduce Ubuntu 24.04

2024-05-07 Thread Daniel P . Berrangé
On Tue, May 07, 2024 at 02:36:42PM +0200, Michal Prívozník wrote: > On 5/7/24 12:20, Daniel P. Berrangé wrote: > > On Mon, May 06, 2024 at 10:43:09AM +0200, Michal Privoznik wrote: > >> Ubuntu 24.04 was released recently. Add it to our CI. > >> > >> Signed-off-by: Michal Privoznik > >> --- > >> c

Re: [PATCH 08/13] ci: Drop Ubuntu 20.04

2024-05-07 Thread Michal Prívozník
On 5/7/24 12:11, Daniel P. Berrangé wrote: > On Mon, May 06, 2024 at 10:43:05AM +0200, Michal Privoznik wrote: >> It's now more than two years since Ubuntu 22.04 was released and >> per our support policy, Ubuntu 20.04 (the previous major release) >> is now not supported. Remove it from our CI test

Re: [PATCH 12/13] ci: Introduce Ubuntu 24.04

2024-05-07 Thread Michal Prívozník
On 5/7/24 12:20, Daniel P. Berrangé wrote: > On Mon, May 06, 2024 at 10:43:09AM +0200, Michal Privoznik wrote: >> Ubuntu 24.04 was released recently. Add it to our CI. >> >> Signed-off-by: Michal Privoznik >> --- >> ci/buildenv/centos-stream-9.sh| 1 + >> ci/buildenv/debian-12-c

Re: [PATCH 06/13] gitlab-ci: Move website_job to Fedora 39

2024-05-07 Thread Michal Prívozník
On 5/7/24 12:09, Daniel P. Berrangé wrote: > On Mon, May 06, 2024 at 10:43:03AM +0200, Michal Privoznik wrote: >> Currently, our website job depends on almalinux-8 container. >> Well, AlmaLinux 8 is going to be dropped soon. Therefore, switch >> the job to something newer. Fedora 39 was chosen by a

[PATCH v2 2/3] docs: Document SSH proxy

2024-05-07 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- docs/docs.rst | 3 ++ docs/meson.build | 1 + docs/nss.rst | 7 + docs/ssh-proxy.rst | 68 ++ 4 files changed, 79 insertions(+) create mode 100644 docs/ssh-proxy.rst diff --git a/docs/docs.rst b/

[PATCH v2 3/3] NEWS: Document SSH proxy feature

2024-05-07 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- NEWS.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index d72c15bf10..ef0e4f8b51 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -22,6 +22,11 @@ v10.4.0 (unreleased) It is now possible to set on/off ``ras`` feature in the domain X

[PATCH v2 0/3] Introduce SSH proxy

2024-05-07 Thread Michal Privoznik
v2 of: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/QYFHZFXUVKPM3JCPUKFVPBRZOIG2R2RK/ diff to v1: - rebased onto current master - Worked in Dan's review Michal Prívozník (3): tools: Introduce SSH proxy docs: Document SSH proxy NEWS: Document SSH proxy feature NE

[PATCH v2 1/3] tools: Introduce SSH proxy

2024-05-07 Thread Michal Privoznik
This allows users to SSH into a domain with a VSOCK device: ssh user@qemu/machineName So far, only QEMU domains are supported AND qemu:///system is looked for the first for 'machineName' followed by qemu:///session. I took an inspiration from SystemD's ssh proxy [1] [2]. To just work out of th

Re: [PATCH 01/13] domaincapsmock: Drop link time dependency on virQEMUCapsGet()

2024-05-07 Thread Daniel P . Berrangé
On Mon, May 06, 2024 at 10:42:58AM +0200, Michal Privoznik wrote: > While Linux linker has no trouble resolving the symbols, valgrind > does. It has probably something to do with the fact that we don't > tell what symbols to export from mock libraries. Anyway, just > resolve the symbol at runtime.

Re: [PATCH 04/13] security: Fix return types of .probe callbacks

2024-05-07 Thread Daniel P . Berrangé
On Mon, May 06, 2024 at 10:43:01AM +0200, Michal Privoznik wrote: > The .probe member of virSecurityDriver struct is declared to > return virSecurityDriverStatus enum. But there are two instances > (AppArmorSecurityManagerProbe() and > virSecuritySELinuxDriverProbe()) where callbacks are defined to

Re: [PATCH 02/13] qemuxml2argvmock: Drop link time dependency on qemuFDPassDirectNew()

2024-05-07 Thread Daniel P . Berrangé
On Mon, May 06, 2024 at 10:42:59AM +0200, Michal Privoznik wrote: > While Linux linker has no trouble resolving the symbols, valgrind > does. It has probably something to do with the fact that we don't > tell what symbols to export from mock libraries. Anyway, just > resolve the symbol at runtime.

Re: [PATCH 12/13] ci: Introduce Ubuntu 24.04

2024-05-07 Thread Daniel P . Berrangé
On Mon, May 06, 2024 at 10:43:09AM +0200, Michal Privoznik wrote: > Ubuntu 24.04 was released recently. Add it to our CI. > > Signed-off-by: Michal Privoznik > --- > ci/buildenv/centos-stream-9.sh| 1 + > ci/buildenv/debian-12-cross-aarch64.sh| 1 + > ci/buildenv/debi

Re: [PATCH 13/13] ci: Introduce AlmaLinux 9

2024-05-07 Thread Daniel P . Berrangé
On Mon, May 06, 2024 at 10:43:10AM +0200, Michal Privoznik wrote: > AlmaLinux 9 was released a while ago, but for some reason it's > missing in our CI. Add it there. > > Signed-off-by: Michal Privoznik > --- > ci/buildenv/almalinux-9.sh | 101 ++ > ci/containers

Re: [PATCH 11/13] ci: Introduce Fedora 40

2024-05-07 Thread Daniel P . Berrangé
On Mon, May 06, 2024 at 10:43:08AM +0200, Michal Privoznik wrote: > Fedora 40 was released recently. Add it to our CI. > > Signed-off-by: Michal Privoznik > --- > ci/buildenv/fedora-40-cross-mingw32.sh| 77 > ci/buildenv/fedora-40-cross-mingw64.sh| 77

Re: [PATCH 10/13] meson: Bump glib version to 2.58.0

2024-05-07 Thread Daniel P . Berrangé
On Mon, May 06, 2024 at 10:43:07AM +0200, Michal Privoznik wrote: > Now that we don't have any distro stuck with glib-2.56.0, we can > bump the glib version. In fact, this is needed, because of > g_clear_pointer. Since v7.4.0-rc1~301 we declare at compile time > what version of glib APIs we want to

Re: [PATCH 09/13] ci: Drop AlmaLinux 8

2024-05-07 Thread Daniel P . Berrangé
On Mon, May 06, 2024 at 10:43:06AM +0200, Michal Privoznik wrote: > By the time of release, it's going to be more than two years > since AlmaLinux 9 was released and per our support policy, > AlmaLinux 8 (the previous major release) will be not supported. > Remove it from our CI testing. > > Signe

Re: [PATCH 08/13] ci: Drop Ubuntu 20.04

2024-05-07 Thread Daniel P . Berrangé
On Mon, May 06, 2024 at 10:43:05AM +0200, Michal Privoznik wrote: > It's now more than two years since Ubuntu 22.04 was released and > per our support policy, Ubuntu 20.04 (the previous major release) > is now not supported. Remove it from our CI testing. > > Signed-off-by: Michal Privoznik > ---

Re: [PATCH 07/13] ci: Drop Fedora 38

2024-05-07 Thread Daniel P . Berrangé
On Mon, May 06, 2024 at 10:43:04AM +0200, Michal Privoznik wrote: > Since Fedora 40 was released recently, Fedora 38 is now > unsupported. Remove it from our CI. > > Signed-off-by: Michal Privoznik > --- > ci/buildenv/fedora-38-cross-mingw32.sh| 77 > ci/buildenv/fedora-38-

Re: [PATCH 06/13] gitlab-ci: Move website_job to Fedora 39

2024-05-07 Thread Daniel P . Berrangé
On Mon, May 06, 2024 at 10:43:03AM +0200, Michal Privoznik wrote: > Currently, our website job depends on almalinux-8 container. > Well, AlmaLinux 8 is going to be dropped soon. Therefore, switch > the job to something newer. Fedora 39 was chosen by a roll of > dice. I'd suggest AlmaLinux 9 so tha

Re: [PATCH 05/13] meson: Disable -fsanitize=function

2024-05-07 Thread Daniel P . Berrangé
On Mon, May 06, 2024 at 10:43:02AM +0200, Michal Privoznik wrote: > Strictly speaking, xdrproc_t is declared as following: > > typedef bool_t (*xdrproc_t)(XDR *, ...); > > But our rpcgen generates properly typed functions, e.g.: > > bool_t xdr_virNetMessageError(XDR *xdrs, virNetMessageError

Re: [PATCH 03/13] testutilsqemu: Don't leak struct testQemuArgs::vdpafds

2024-05-07 Thread Daniel P . Berrangé
On Mon, May 06, 2024 at 10:43:00AM +0200, Michal Privoznik wrote: > Allocated in testQemuInfoSetArgs(), the vdpafds member of > testQemuArgs is never freed. > > Signed-off-by: Michal Privoznik > --- > tests/testutilsqemu.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Daniel P. Berrangé

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-07 Thread Jinpu Wang via Devel
Hi Peter, hi Daniel, On Mon, May 6, 2024 at 5:29 PM Peter Xu wrote: > > On Mon, May 06, 2024 at 12:08:43PM +0200, Jinpu Wang wrote: > > Hi Peter, hi Daniel, > > Hi, Jinpu, > > Thanks for sharing this test results. Sounds like a great news. > > What's your plan next? Would it then be worthwhile /

RE: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-07 Thread Gonglei (Arei) via Devel
Hello, > -Original Message- > From: Peter Xu [mailto:pet...@redhat.com] > Sent: Monday, May 6, 2024 11:18 PM > To: Gonglei (Arei) > Cc: Daniel P. Berrangé ; Markus Armbruster > ; Michael Galaxy ; Yu Zhang > ; Zhijian Li (Fujitsu) ; Jinpu Wang > ; Elmar Gerdes ; > qemu-de...@nongnu.org; Yu

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-07 Thread Jinpu Wang via Devel
Hi Peter, hi Daniel, On Fri, May 3, 2024 at 4:33 PM Peter Xu wrote: > > On Fri, May 03, 2024 at 08:40:03AM +0200, Jinpu Wang wrote: > > I had a brief check in the rsocket changelog, there seems some > > improvement over time, > > might be worth revisiting this. due to socket abstraction, we can'

RE: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-07 Thread Gonglei (Arei) via Devel
Hi, Peter RDMA features high bandwidth, low latency (in non-blocking lossless network), and direct remote memory access by bypassing the CPU (As you know, CPU resources are expensive for cloud vendors, which is one of the reasons why we introduced offload cards.), which TCP does not have. I

Re: [PATCH 3/4] docs: Document SSH proxy

2024-05-07 Thread Daniel P . Berrangé
On Fri, Apr 19, 2024 at 12:12:32PM +0200, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > docs/docs.rst | 3 +++ > docs/meson.build | 1 + > docs/nss.rst | 7 ++ > docs/ssh-proxy.rst | 60 ++ > 4 files changed, 71 i

Re: [PATCH 2/4] tools: Introduce SSH proxy

2024-05-07 Thread Daniel P . Berrangé
On Fri, Apr 19, 2024 at 12:12:31PM +0200, Michal Privoznik wrote: > This allows users to SSH into a domain with a VSOCK device: > > ssh user@qemu/machineName > > So far, only QEMU domains are supported AND qemu:///system is > looked for the first for 'machineName' followed by > qemu:///session.

Re: [PATCH 1/4] datatypes: Declare g_autoptr cleanup functions for more public objects

2024-05-07 Thread Daniel P . Berrangé
On Fri, Apr 19, 2024 at 12:12:30PM +0200, Michal Privoznik wrote: > Some public objects (like virDomain, virInterface, and so on) are > missing g_autoptr() cleanup functions. Provide missing > declarations. Note, this is only for our internal use - hence > datatypes.h. > > Signed-off-by: Michal Pr

Re: [PATCH 0/2] interface: Refactor code and fix old listing API when interface is unbound

2024-05-07 Thread Michal Prívozník
On 5/6/24 17:58, Peter Krempa wrote: > Patch 1/2 removes a pointless helper in favor of making an almost > identical function more universal, so that patch 2/2 then fixes all > cases in one place. > > Peter Krempa (2): > interface_udev: Replace udevNumOfInterfacesByStatus by > udevListInterf