Re: [PATCH v3 5/9] qemu: Fix matching for stateless/combined firmware

On 9/10/25 07:57, Andrea Bolognani via Devel wrote: The current code assumes that a stateless firmware has to be explicitly requested by the user, and should never be picked otherwise. This means that, for example, domains configured to use SEV-SNP are forced to explicitly request for the firmwar

Re: [PATCH 3/8] conf: Add nodeset attribute to the element

On Sat, Sep 06, 2025 at 03:08:58PM +0200, Andrea Righi wrote: > This enables partitioning of PCI devices into multiple isolated > instances, each requiring a dedicated virtual NUMA node definition. > > Link: https://mail.gnu.org/archive/html/qemu-arm/2024-03/msg00358.html > Signed-off-by: Andrea R

[libvirt PATCH 1/8] qemu: passt: split out qemuPasstBuildCommand

From: Ján Tomko Separate the command line building to make it testable. Signed-off-by: Ján Tomko --- src/qemu/qemu_passt.c | 38 +- src/qemu/qemu_passt.h | 5 + 2 files changed, 34 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_passt.c b/src/

[PATCH 2/4] ch: Make sure the cloud-hypervisor process is killed in virCHProcessStop()

From: Michal Privoznik Currently, virCHProcessStop() is called either when the cloud-hypervisor process dies gracefully (e.g. on shutdown initiated from within the guest) or when virDomainDestroy() is called (or on failed start attempt, but that's not important right now). At any rate, if the cl

[libvirt-python PATCH] build: Adapt to PEP 625 distribution file naming

The version of setuptools shipped by Fedora 42 is PEP 625 compliant, which requires distribution files to contain a normalized package name. Thus the generated tarball is called libvirt_python-$VER.tar.gz rather than libvirt-python-$VER.tar.gz created by older setuptools. The source directory insid

Re: [PATCH] conf: clear the acpiNodeset field after freeing

On Tue, Sep 09, 2025 at 10:28:33 +0100, Daniel P. Berrangé via Devel wrote: > From: Daniel P. Berrangé > > The virDomainDeviceInfoClear method does not free the struct, only > its contents, so all pointer fields must be explicitly set to NULL > after releasing to avoid disk of double-free. > > R

[PATCH 2/6] qemuMigrationSrcIsSafe: Extract code for checking safe migrability of one disk

From: Peter Krempa Extract the code which checks a source of a single disk for safe migratability into 'qemuMigrationSrcIsSafeDisk'. Signed-off-by: Peter Krempa --- src/qemu/qemu_migration.c | 132 -- 1 file changed, 71 insertions(+), 61 deletions(-) diff -

Re: [libvirt-python PATCH] build: Adapt to PEP 625 distribution file naming

On Wed, Sep 10, 2025 at 13:43:01 +0100, Daniel P. Berrangé wrote: > On Wed, Sep 10, 2025 at 02:04:39PM +0200, Jiri Denemark via Devel wrote: > > The version of setuptools shipped by Fedora 42 is PEP 625 compliant, > > which requires distribution files to contain a normalized package name. > > Thus

[PATCH] conf: clear the acpiNodeset field after freeing

From: Daniel P. Berrangé The virDomainDeviceInfoClear method does not free the struct, only its contents, so all pointer fields must be explicitly set to NULL after releasing to avoid disk of double-free. Reported by coverity: *** CID 895678: Memory - corruptions (USE_AFTER_FREE) /

Re: [PATCH 5/8] qemu: Generate acpi-generic-initiator command from acpi nodeset

Hi Daniel, On Mon, Sep 08, 2025 at 06:02:20PM +0100, Daniel P. Berrangé wrote: > On Sat, Sep 06, 2025 at 03:09:00PM +0200, Andrea Righi wrote: > > Signed-off-by: Andrea Righi > > --- > > src/qemu/qemu_command.c | 45 + > > 1 file changed, 45 insertions(+)

Re: [PATCH 01/14] qemu: Drop legacy probing of CPU features

On Thu, Sep 04, 2025 at 16:46:49 +0200, Jiri Denemark via Devel wrote: > From: Jiri Denemark > > The legacy probing which reads CPUID registers from QEMU and interprets > the individual bits is not used with any QEMU version currently > supported by libvirt. Preferrably mention also why the stat

[PATCH v3 0/9] qemu: Fixes to firmware selection

Changes from [v2]: * more tweaks to firmware files, with a matching edk2 PR this time around. Changes from [v1]: * pick up Jim's test suite improvements; * squash in fixes for issues found during review; * add a few commits intented to spark further discussion around what the fir

Re: [PATCH 24/31] qemu: Add qemuDomainDefaultUSBControllerModel()

On Fri, Sep 19, 2025 at 07:26:21 -0700, Andrea Bolognani wrote: > On Thu, Sep 18, 2025 at 03:57:10PM +0200, Peter Krempa wrote: > > On Tue, Aug 19, 2025 at 18:22:28 +0200, Andrea Bolognani via Devel wrote: > > > Extract the logic from qemuDomainControllerDefPostParse() to > > > a dedicated helper.

Re: [PATCH 1/1] x86: install modules-load.d file to load msr module

On 9/4/25 17:59, Hector Cao wrote: On Fri, Sep 5, 2025 at 1:48 AM Jim Fehlig > wrote: On 9/4/25 17:00, Hector Cao wrote: > > > On Thu, Sep 4, 2025 at 11:40 PM Jim Fehlig mailto:jfeh...@suse.com> >

[PATCH 3/4] ch: Introduce flags to virCHProcessStop()

From: Michal Privoznik A caller (e.g. chDomainDestroyFlags()) might want to chose whether to kill emulator process forcefully or gracefully (the @force argument of virProcessKillPainfully()). Invent a flag to virCHProcessStop() for this. And to keep consistent behaviour, pass the flag everywhere

Re: [libvirt-python PATCH] build: Adapt to PEP 625 distribution file naming

On Wed, Sep 10, 2025 at 02:04:39PM +0200, Jiri Denemark via Devel wrote: > The version of setuptools shipped by Fedora 42 is PEP 625 compliant, > which requires distribution files to contain a normalized package name. > Thus the generated tarball is called libvirt_python-$VER.tar.gz rather > than l

Re: [PATCH v4 07/10] qmp: add chardev-resize command

On Tue, 2025-09-16 at 15:07 +0200, Markus Armbruster wrote: > Filip Hejsek writes: > > > On Mon, 2025-09-15 at 08:35 +0200, Markus Armbruster wrote: > > > Filip Hejsek writes: > > > > > > > On Fri, 2025-09-12 at 16:01 +0200, Markus Armbruster wrote: > > > > > Cc: libvirt > > > > > > > > > > Fi

Re: [PATCH 16/31] qemu: Validate presence of PCI support

On Tue, Aug 19, 2025 at 18:22:20 +0200, Andrea Bolognani via Devel wrote: > The qemuValidateDomainDeviceDefControllerPCI() function is > called if PCI controllers are present in the domain > configuration, which shouldn't happen if the machine type > doesn't support PCI. If we somehow find ourselve

Re: [PATCH v6 0/8] qemu: acpi-generic-initiator support

On Sat, Sep 06, 2025 at 03:08:55PM +0200, Andrea Righi wrote: > = Overview = > > This patch set introduces support for acpi-generic-initiator devices, > supported by QEMU [1]. > > The acpi-generic-initiator object is required to support Multi-Instance GPU > (MIG) configurations on NVIDIA GPUs [2]

[PATCH 1/2] ch: Avoid memory leak in virCHProcessEvents()

From: Michal Privoznik The aim of virCHProcessEvents() is to read data (in JSON format) from CH monitor and then process them. To parse incoming data virJSONValueFromString() is used. But the corresponding virJSONValue is freed only when processing of an even succeeds. If processing an event fail

Re: [PATCH 24/31] qemu: Add qemuDomainDefaultUSBControllerModel()

On Thu, Sep 18, 2025 at 03:57:10PM +0200, Peter Krempa wrote: > On Tue, Aug 19, 2025 at 18:22:28 +0200, Andrea Bolognani via Devel wrote: > > Extract the logic from qemuDomainControllerDefPostParse() to > > a dedicated helper. The behavior is unchanged. > > I don't see it changed anywhere else ...

Re: [PATCH 26/31] qemu: Clean up qemuDomainDefaultUSBControllerModel()

On Fri, Sep 19, 2025 at 11:19:38AM +0200, Peter Krempa wrote: > On Tue, Aug 19, 2025 at 18:22:30 +0200, Andrea Bolognani via Devel wrote: > > Switch from the current approach, in which an initial (poor) > > default is picked and then a better one later overwrites it, > > to the more common and easy