Re: [OMPI devel] [PATCH 4/4] Trying to get the C/R code to compile again. (last)

2013-12-09 Thread Adrian Reber
On Fri, Dec 06, 2013 at 08:43:39AM -0600, Josh Hursey wrote: > Did the mca_base_component_distill_checkpoint_ready paramter go away? Its > intention was to allow a user to have a build with C/R compiled in and then > choose at runtime if they want to restrict their component section to just > C/R

Re: [OMPI devel] [PATCH 4/4] Trying to get the C/R code to compile again. (last)

2013-12-06 Thread Josh Hursey
Did the mca_base_component_distill_checkpoint_ready paramter go away? Its intention was to allow a user to have a build with C/R compiled in and then choose at runtime if they want to restrict their component section to just C/R enabled components or not. I have reservations about that part of the

Re: [OMPI devel] [PATCH 4/4] Trying to get the C/R code to compile again. (last)

2013-12-05 Thread Ralph Castain
Thanks Adrian - I think that will silence the questions in a fair way. Appreciate your flexibility. Ralph On Thu, Dec 5, 2013 at 1:55 AM, Adrian Reber wrote: > On Wed, Dec 04, 2013 at 08:07:39PM +, Jeff Squyres (jsquyres) wrote: > > On Dec 4, 2013, at 11:29 AM, Ralph

Re: [OMPI devel] [PATCH 4/4] Trying to get the C/R code to compile again. (last)

2013-12-05 Thread Adrian Reber
On Wed, Dec 04, 2013 at 08:07:39PM +, Jeff Squyres (jsquyres) wrote: > On Dec 4, 2013, at 11:29 AM, Ralph Castain wrote: > > > Jeff - you are jumping way ahead. I already said this needs further work to > > resolve blocking. These patches (per Adrian's email) just

Re: [OMPI devel] [PATCH 4/4] Trying to get the C/R code to compile again. (last)

2013-12-04 Thread Paul Hargrove
On Dec 4, 2013 12:07 PM, "Jeff Squyres (jsquyres)" wrote: [...] > But in some ways, having uncompilable code is a *good* thing, because it tells you exactly where you need to work on the architecture. Just updating it to *compile* removes that safeguard -- will you

Re: [OMPI devel] [PATCH 4/4] Trying to get the C/R code to compile again. (last)

2013-12-04 Thread Ralph Castain
All he is doing is pushing intermediate steps upstream to maintain contact and gain familiarity. No harm done as the code isn't built by default. Broader design discussion can take place as we understand the problems Sent from my iPhone > On Dec 4, 2013, at 12:07 PM, "Jeff Squyres

Re: [OMPI devel] [PATCH 4/4] Trying to get the C/R code to compile again. (last)

2013-12-04 Thread Jeff Squyres (jsquyres)
On Dec 4, 2013, at 11:29 AM, Ralph Castain wrote: > Jeff - you are jumping way ahead. I already said this needs further work to > resolve blocking. These patches (per Adrian's email) just makes things compile Fair enough. But in some ways, having uncompilable code is a

Re: [OMPI devel] [PATCH 4/4] Trying to get the C/R code to compile again. (last)

2013-12-04 Thread Ralph Castain
Jeff - you are jumping way ahead. I already said this needs further work to resolve blocking. These patches (per Adrian's email) just makes things compile Lower your bar, dude :-) Sent from my iPhone > On Dec 4, 2013, at 8:07 AM, "Jeff Squyres (jsquyres)" > wrote: > >>

Re: [OMPI devel] [PATCH 4/4] Trying to get the C/R code to compile again. (last)

2013-12-04 Thread Jeff Squyres (jsquyres)
On Nov 25, 2013, at 9:59 AM, Adrian Reber wrote: > diff --git a/ompi/mca/bml/r2/bml_r2_ft.c b/ompi/mca/bml/r2/bml_r2_ft.c > index 1448c04..fc16452 100644 > --- a/ompi/mca/bml/r2/bml_r2_ft.c > +++ b/ompi/mca/bml/r2/bml_r2_ft.c > @@ -191,7 +191,7 @@ int mca_bml_r2_ft_event(int

[OMPI devel] [PATCH 4/4] Trying to get the C/R code to compile again. (last)

2013-11-25 Thread Adrian Reber
From: Adrian Reber This are the remaining changes to get C/R to compile again. This patch includes various fixes all over the C/R code and are hard to group like the previous patches. Signed-off-by: Adrian Reber ---