Re: [OMPI devel] r21096

2009-04-29 Thread Jeff Squyres
On Apr 29, 2009, at 9:33 AM, Ralph Castain wrote: My personal opinion however is, that every header and every source file should be self contained: It should include all the headers with symbols it needs, no less, and certainly not more ;-) That's an unusual coding style - we could debate th

Re: [OMPI devel] r21096

2009-04-29 Thread Ralph Castain
On Wed, Apr 29, 2009 at 7:16 AM, Rainer Keller wrote: > Hi Jeff, > sure like to try to explain the matters. > The script check_unnecessary_headers.sh is not smart at all. > It checks whether a header, if known, is required due to some content. > It does not know about hierarchies of include files

Re: [OMPI devel] r21096

2009-04-29 Thread Rainer Keller
Hi Jeff, sure like to try to explain the matters. The script check_unnecessary_headers.sh is not smart at all. It checks whether a header, if known, is required due to some content. It does not know about hierarchies of include files, or convenience headers such as bindings.h and would delete the

[OMPI devel] r21096

2009-04-29 Thread Jeff Squyres
Rainer -- Can you explain this a little more: In ompi/mpi/c/ header files are moved up into the actual c-file, where necessary (these are the only additional #include), otherwise it is only deletions of #include (apart from the above additions required due to notifier...) It looks l