Hi Gilles,
I'm fine with the pull request method too. We hadn't been considering this
avenue for master updates
in the transition to github. I think as long as we have a set way for
associating the pull of a given
request into master, so they don't end up in a kind of purgatory, we'll be
in good
Yeah - to be clear, I had no problem with anything you did, Gilles. I was only
noting that several of them had positive comments, but they weren’t being
merged. Hate to see the good work lost or forgotten :-)
> On Nov 6, 2014, at 5:29 PM, Jeff Squyres (jsquyres)
> wrote:
>
> Actually, I like
Actually, I like the PRs; I like the nice github tools for commenting and
discussing.
I'm sorry I haven't followed up on the two you filed for me yet. :-(
On Nov 6, 2014, at 8:23 PM, Gilles Gouaillardet
wrote:
> My bad (mostly)
>
> I made quite a lot of PR to get some review before commit
My bad (mostly)
I made quite a lot of PR to get some review before commiting to the master, and
did not follow up in a timely manner.
I closed two obsoletes PR today.
#245 should be ready for prime time.
#227 too unless George has an objection.
I asked Jeff to review #232 and #228 because they
