Re: [OMPI devel] RFC 1/1: improvements to the "notifier" framework and ORTE WDC

2010-05-12 Thread Abhishek Kulkarni
(Updated RFC, per online/offline discussions) == [RFC 1/2] ORTE WDC and improvements to the "notifier" framework == WHAT: Merge improvements to the "notifier" f

Re: [OMPI devel] RFC 1/1: improvements to the "notifier" framework and ORTE WDC

2010-03-30 Thread Abhishek Kulkarni
On Mar 29, 2010, at 9:16 PM, Ralph Castain wrote: On Mar 29, 2010, at 5:53 PM, Abhishek Kulkarni wrote: On Mon, 29 Mar 2010, Sylvain Jeaugey wrote: Hi Ralph, For now, I think that yes, this is a unique identifier. However, in my opinion, this could be improved in the future replacing

Re: [OMPI devel] RFC 1/1: improvements to the "notifier" framework and ORTE WDC

2010-03-30 Thread Sylvain Jeaugey
On Mon, 29 Mar 2010, Abhishek Kulkarni wrote: #define ORTE_NOTIFIER_DEFINE_EVENT(eventstr, associated_text) { static int event = -1; if (OPAL_UNLIKELY(event == -1) { event = opal_sos_create_new_event(eventstr, associated_text); } .. } This

Re: [OMPI devel] RFC 1/1: improvements to the "notifier" framework and ORTE WDC

2010-03-30 Thread Nadia Derbey
On Mon, 2010-03-29 at 09:37 -0600, Ralph Castain wrote: > Hi Abhishek > > > I'm confused by the WDC wiki page, specifically the part about the new > ORTE_NOTIFIER_DEFINE_EVENT macro. Are you saying that I (as the > developer) have to provide this macro with a unique notifier id? Hi Ralph, Actua

Re: [OMPI devel] RFC 1/1: improvements to the "notifier" framework and ORTE WDC

2010-03-29 Thread Ralph Castain
On Mar 29, 2010, at 5:53 PM, Abhishek Kulkarni wrote: > > > On Mon, 29 Mar 2010, Sylvain Jeaugey wrote: > >> Hi Ralph, >> >> For now, I think that yes, this is a unique identifier. However, in my >> opinion, this could be improved in the future replacing it by a unique >> string. >> >> Som

Re: [OMPI devel] RFC 1/1: improvements to the "notifier" framework and ORTE WDC

2010-03-29 Thread Abhishek Kulkarni
On Mon, 29 Mar 2010, Sylvain Jeaugey wrote: Hi Ralph, For now, I think that yes, this is a unique identifier. However, in my opinion, this could be improved in the future replacing it by a unique string. Something like : #define ORTE_NOTIFIER_DEFINE_EVENT(eventstr, associated_text) {

Re: [OMPI devel] RFC 1/1: improvements to the "notifier" framework and ORTE WDC

2010-03-29 Thread Abhishek Kulkarni
On Mon, 29 Mar 2010, Ralph Castain wrote: Hi Abhishek I'm confused by the WDC wiki page, specifically the part about the new ORTE_NOTIFIER_DEFINE_EVENT macro. Are you saying that I (as the developer) have to provide this macro with a unique notifier id? So that would mean that ORTE/OMPI would

Re: [OMPI devel] RFC 1/1: improvements to the "notifier" framework and ORTE WDC

2010-03-29 Thread Ralph Castain
Hi Sylvain I think something like that is really required. Having to manage event identifiers across OMPI layers is going to prove impractical otherwise. Abhishek: I would suggest this be done prior to moving the branch into the trunk. Whether you use Sylvain's proposed solution or another is u

Re: [OMPI devel] RFC 1/1: improvements to the "notifier" framework and ORTE WDC

2010-03-29 Thread Sylvain Jeaugey
Hi Ralph, For now, I think that yes, this is a unique identifier. However, in my opinion, this could be improved in the future replacing it by a unique string. Something like : #define ORTE_NOTIFIER_DEFINE_EVENT(eventstr, associated_text) { static int event = -1; if (OPAL_UNL

Re: [OMPI devel] RFC 1/1: improvements to the "notifier" framework and ORTE WDC

2010-03-29 Thread Ralph Castain
Hi Abhishek I'm confused by the WDC wiki page, specifically the part about the new ORTE_NOTIFIER_DEFINE_EVENT macro. Are you saying that I (as the developer) have to provide this macro with a unique notifier id? So that would mean that ORTE/OMPI would have to maintain a global notifier id count