Re: [OMPI devel] Reviewing MPI_Dims_create

2014-02-11 Thread Jeff Squyres (jsquyres)
+1 On Feb 11, 2014, at 9:25 AM, Andreas Schäfer wrote: > On 15:20 Tue 11 Feb , Christoph Niethammer wrote: >> Ah and some restults for MPI_Dims_create(100, 3, {}) >> >> original: 8.110628 sec >> optimized-primes: 0.048702 sec >> optimized-factorization: 0.13 sec > > Awesome! I did

Re: [OMPI devel] Reviewing MPI_Dims_create

2014-02-11 Thread Andreas Schäfer
On 15:20 Tue 11 Feb , Christoph Niethammer wrote: > Ah and some restults for MPI_Dims_create(100, 3, {}) > > original: 8.110628 sec > optimized-primes: 0.048702 sec > optimized-factorization: 0.13 sec Awesome! I didn't expect that nested loop for checking whether a factor would still

Re: [OMPI devel] Reviewing MPI_Dims_create

2014-02-11 Thread Christoph Niethammer
Mail - Von: "Andreas Schäfer" An: "Open MPI Developers" Gesendet: Dienstag, 11. Februar 2014 12:16:53 Betreff: Re: [OMPI devel] Reviewing MPI_Dims_create Hi, ah, that's clever indeed! Best -Andreas On 12:02 Tue 11 Feb , Christoph Niethammer wrote: > He

Re: [OMPI devel] Reviewing MPI_Dims_create

2014-02-11 Thread Andreas Schäfer
er Stuttgart (HLRS) > Nobelstrasse 19 > 70569 Stuttgart > > Tel: ++49(0)711-685-87203 > email: nietham...@hlrs.de > http://www.hlrs.de/people/niethammer > > > > - Ursprüngliche Mail - > Von: "Andreas Schäfer" > An: "Open MPI Develop

Re: [OMPI devel] Reviewing MPI_Dims_create

2014-02-11 Thread Christoph Niethammer
An: "Open MPI Developers" Gesendet: Dienstag, 11. Februar 2014 06:24:56 Betreff: Re: [OMPI devel] Reviewing MPI_Dims_create OK, so we were thinking the same thing :-) The optimization you mention below is the same I've used in my updated patch. On 02:29 Tue 11 Feb , Christoph Nieth

Re: [OMPI devel] Reviewing MPI_Dims_create

2014-02-11 Thread Andreas Schäfer
rasse 19 > 70569 Stuttgart > > Tel: ++49(0)711-685-87203 > email: nietham...@hlrs.de > http://www.hlrs.de/people/niethammer > > - Ursprüngliche Mail - > Von: "Andreas Schäfer" > An: "Open MPI Developers" > Gesendet: Montag, 10. Februar 201

Re: [OMPI devel] Reviewing MPI_Dims_create

2014-02-11 Thread Andreas Schäfer
s go for MPI with > int64 types. ^^ > > - Ursprüngliche Mail - > Von: "Jeff Squyres (jsquyres)" > An: "Open MPI Developers" > Gesendet: Dienstag, 11. Februar 2014 01:32:53 > Betreff: Re: [OMPI devel] Reviewing MPI_Dims_create > > On Feb 10, 2014,

Re: [OMPI devel] Reviewing MPI_Dims_create

2014-02-11 Thread Andreas Schäfer
On 19:12 Mon 10 Feb , Jeff Squyres (jsquyres) wrote: > 1. Should we cache generated prime numbers? (if so, it'll have to be done in > a thread-safe way) The code I've submitted in the other thread is much faster than the original code (e.g. 100x faster for 1 nodes, the ratio increases wi

Re: [OMPI devel] Reviewing MPI_Dims_create

2014-02-10 Thread Christoph Niethammer
MPI Developers" Gesendet: Dienstag, 11. Februar 2014 01:32:53 Betreff: Re: [OMPI devel] Reviewing MPI_Dims_create On Feb 10, 2014, at 7:22 PM, Christoph Niethammer wrote: > 2.) Interesting idea: Using the approximation from the cited paper we should > only need around 400 MB to store all

Re: [OMPI devel] Reviewing MPI_Dims_create

2014-02-10 Thread Christoph Niethammer
www.hlrs.de/people/niethammer - Ursprüngliche Mail - Von: "Andreas Schäfer" An: "Open MPI Developers" Gesendet: Montag, 10. Februar 2014 23:24:24 Betreff: Re: [OMPI devel] Reviewing MPI_Dims_create Christoph- your patch has the same problem as my original patch: indeed

Re: [OMPI devel] Reviewing MPI_Dims_create

2014-02-10 Thread Jeff Squyres (jsquyres)
On Feb 10, 2014, at 7:22 PM, Christoph Niethammer wrote: > 2.) Interesting idea: Using the approximation from the cited paper we should > only need around 400 MB to store all primes in the int32 range. Potential for > applying compression techniques still present. ^^ Per Andreas' last mail, we

Re: [OMPI devel] Reviewing MPI_Dims_create

2014-02-10 Thread Christoph Niethammer
Nobelstrasse 19 70569 Stuttgart Tel: ++49(0)711-685-87203 email: nietham...@hlrs.de http://www.hlrs.de/people/niethammer - Ursprüngliche Mail - Von: "Jeff Squyres (jsquyres)" An: "Open MPI Developers" Gesendet: Montag, 10. Februar 2014 20:12:08 Betreff: Re: [OMPI dev

Re: [OMPI devel] Reviewing MPI_Dims_create

2014-02-10 Thread Andreas Schäfer
Christoph- your patch has the same problem as my original patch: indeed there may be a prime factor p of n with p > sqrt(n). What's important is that there may only be at most one. I've submitted an updated patch (see my previous mail) which catches this special case. Best -Andreas On 19:30 Mon

Re: [OMPI devel] Reviewing MPI_Dims_create

2014-02-10 Thread Jeff Squyres (jsquyres)
Nice! Can you verify that it passes the ibm test? I didn't look closely, and to be honest, I'm not sure why the previous improvement broke the IBM test because it hypothetically did what you mentioned (stopped at sqrt(freenodes)). I think patch 1 is a no-brainer. I'm not sure about #2 because