Re: [OMPI devel] pointer_array

2007-12-21 Thread Jeff Squyres
Fixed in https://svn.open-mpi.org/trac/ompi/changeset/17021 -- a simple off-by-one error caused by some logic moving around. On Dec 21, 2007, at 12:19 PM, Jeff Squyres wrote: I'm unfortunately getting some test failures after r17007 when converting between C and C++/F77 handles, such as the

Re: [OMPI devel] pointer_array

2007-12-21 Thread Jeff Squyres
I'm unfortunately getting some test failures after r17007 when converting between C and C++/F77 handles, such as the following (I checked; trunk/r17006 works fine): - [9:17] svbu-mpi:~/svn/ompi-tests/cxx-test-suite % mpirun -np 4 src/ mpi2c++_test Since we made it this far, we will ass

Re: [OMPI devel] pointer_array

2007-12-21 Thread George Bosilca
The opal_pointer_array is now committed. I try to update all BTL to use the opal_pointer_array instead of the orte_pointer_array. Now, the OMPI layer only use opal_pointer_array. Unfortunately, I cannot test most of the BTLs so I hope I didn't miss anything. Thanks, george. On Dec 17

Re: [OMPI devel] pointer_array

2007-12-17 Thread George Bosilca
Sound good. I will replace all references to ompi_pointer_array as well as orte_pointer_array in the ompi layer (some BTL use the orte_pointer_array) and replace them with the opal_pointer_array. I'll avoid any modification of the orte layer. I'll commit tomorrow morning. Thanks, geo

Re: [OMPI devel] pointer_array

2007-12-17 Thread Ralph H Castain
That would be fine with me - I can grab that out of the trunk and adjust ORTE in my branch instead. Thanks Ralph On 12/17/07 9:54 AM, "Tim Mattox" wrote: > How about this as a suggested compromise. > George, could you just do half the patch... where you leave orte alone, > and just move the om

Re: [OMPI devel] pointer_array

2007-12-17 Thread Tim Mattox
How about this as a suggested compromise. George, could you just do half the patch... where you leave orte alone, and just move the ompi pointer array implementation down into opal. That way, any new code can make use of it from opal, and only orte would need to be adjusted later, after Ralph is do

Re: [OMPI devel] pointer_array

2007-12-17 Thread Ralph H Castain
It would require extensive modification as use of the pointer array has spread over a wide range of the code base. I would really appreciate it if we didn't do this right now. The differences are historic in nature - several years ago, the folks working on the OMPI layer needed to insert some Fort

Re: [OMPI devel] pointer_array

2007-12-17 Thread Jeff Squyres
I see a few changes in this patch that seem to be unrelated to the s/ orte_pointer_array/opal_pointer_array/g change: 1. Several ORTE files add (and nothing else) 2. I see a in ompi/class/Makefile.am :-) 3. Some superfluous indenting changes (op.h, and coll_hierarch, etc.) 4. Changes from exte

Re: [OMPI devel] pointer_array

2007-12-17 Thread Jeff Squyres
Adding RHC to the thread... I'm guessing that the patch will have to be modified for the ORTE tmp branch. On Dec 16, 2007, at 6:18 PM, George Bosilca wrote: Right, I wonder why it didn't show in the patch file. Anyway, it completely remove the orte_pointer_array.[ch] as well as the omp

Re: [OMPI devel] pointer_array

2007-12-16 Thread George Bosilca
Right, I wonder why it didn't show in the patch file. Anyway, it completely remove the orte_pointer_array.[ch] as well as the ompi_pointer_array.[ch] file. Thanks, george. On Dec 16, 2007, at 12:01 AM, Tim Mattox wrote: The patch looks good to my eyeballs, though I've not done any t

Re: [OMPI devel] pointer_array

2007-12-16 Thread Tim Mattox
The patch looks good to my eyeballs, though I've not done any testing with it. I presume a follow on patch would remove the orte_pointer_array.[ch] files? On Dec 15, 2007 4:01 PM, George Bosilca wrote: > I have a patch that unify the pointer array implementations into just > one. Right now, we ha