Re: sizeof a struct element

2024-09-11 Thread Fred Wright via devel
On Wed, 11 Sep 2024, Hal Murray via devel wrote: I'm trying to cleanup the tangle in ntp_control.c that generates warnings. They may be actual bugs. The problem is that the man page says long while the actual size may be 32 or 64 on 32 bit Linux systems. If I knew the size, the fix would be

re: CI: The "cross-build" job doesn't have EVP_MD_CTX_new

2024-09-08 Thread Fred Wright via devel
On Sat, 7 Sep 2024, Hal Murray via devel wrote: Does #ifdef work on functions? I thought not, but the old code looks like its doing that. It only works when the apparent functions are macros. The preprocessor knows nothing about functions. On Sat, 7 Sep 2024, Hal Murray via devel wrote:

Re: Anybody know anything about rtems_trace?

2024-06-25 Thread Fred Wright via devel
On Tue, 25 Jun 2024, Hal Murray via devel wrote: $ grep rtems wscript */wscript wafhelpers/* wscript:if ctx.options.enable_rtems_trace: wscript:ctx.find_program("rtems-tld", var="BIN_RTEMS_TLD", wscript: path_list=[ctx.options.rtems_trace_path, wscript:# Bor

Re: Strange error on NetBSD

2024-06-22 Thread Fred Wright via devel
On Fri, 21 Jun 2024, Hal Murray via devel wrote: Does anybody other than me run/test on NetBSD? Ocasionally. I have a NetBSD 6.1.5 VM. The test-all part of option-tester gets the following error. Why only in option-tester? ntp_stdlib includes signal.h Do we have to do some magic to ma

Re: Alternatives to port 123

2024-05-02 Thread Fred Wright via devel
On Thu, 2 May 2024, Hal Murray via devel wrote: Note that for AT&T, the normal case of an NTP client goes through NAT so NTP isn't using port 123 and doesn't get blocked. Many, if not most, NAT implementations avoid remapping "privileged" client ports, on the theory that specific port numbe

Re: NTPsec 1.2.3 released

2024-01-03 Thread Fred Wright via devel
On Wed, 3 Jan 2024, Matthew Selsky wrote: On Tue, Jan 02, 2024 at 08:52:53PM -0800, Fred Wright via devel wrote: It should, though if the timestamps get updated in the process it would trade bad name ordering for bad timestamp ordering. The ideal thing would be to fix the names but keep the

Re: NTPsec 1.2.3 released

2024-01-02 Thread Fred Wright via devel
On Tue, 2 Jan 2024, Hal Murray via devel wrote: Fred Wright said: [context is my reply to the released message.] For some reason the antecedent to this message wasn't sent to the list, though I'd noticed the release by checking the repo. My copy was sent to: Subject: NTPsec 1.2.3 released

Re: NTPsec 1.2.3 released

2024-01-02 Thread Fred Wright via devel
On Wed, 3 Jan 2024, Matthew Selsky wrote: On Tue, Jan 02, 2024 at 07:21:39PM -0800, Fred Wright via devel wrote: There are a couple of minor issues that I should have noticed in the RC but didn't: 1) The 1.2.2a entry is missing from NEWS. This is presumably because of the way the

Re: NTPsec 1.2.3 released

2024-01-02 Thread Fred Wright via devel
On Sat, 30 Dec 2023, Hal Murray via devel wrote: Thanks. and thanks to all who contributed and tested. For some reason the antecedent to this message wasn't sent to the list, though I'd noticed the release by checking the repo. There are a couple of minor issues that I should have notic

Re: Bug in Attic Build

2023-12-26 Thread Fred Wright via devel
On Mon, 25 Dec 2023, Fred Wright via devel wrote: Commit 07231d10e2 to add cipher-find also added exp-timing.c to the build list but didn't actually add a source for it. Thus the attic build fails. It probably makes sense to fix this before the release since it's a regressio

Bug in Attic Build

2023-12-25 Thread Fred Wright via devel
Commit 07231d10e2 to add cipher-find also added exp-timing.c to the build list but didn't actually add a source for it. Thus the attic build fails. It probably makes sense to fix this before the release since it's a regression and also doesn't affect any normally installed components, and

Re: Regression in OpenBSD

2023-12-22 Thread Fred Wright via devel
On Thu, 21 Dec 2023, Hal Murray wrote: Let's put that stuff on the back burner until the release is out. Agreed for OpenBSD per se, though it might be worth trying to determine whether the apparent fencepost error with OPENSSL_VERSION_NUMBER is really OpenBSD-specific, or a more general pr

Re: Regression in OpenBSD

2023-12-21 Thread Fred Wright via devel
On Thu, 21 Dec 2023, Fred Wright via devel wrote: I found one build error that's a regression - in OpenBSD 5.6. It's "'CMAC_CTX' undeclared" in authreadkeys.c, which is due to the new conditional around the inclusion of . Some other sources include this unc

Regression in OpenBSD

2023-12-21 Thread Fred Wright via devel
I found one build error that's a regression - in OpenBSD 5.6. It's "'CMAC_CTX' undeclared" in authreadkeys.c, which is due to the new conditional around the inclusion of . Some other sources include this unconditionally, and macencrypt.c has it in an if/else construct. The else case there

Re: Missing clockwork

2023-12-21 Thread Fred Wright via devel
On Mon, 18 Dec 2023, Hal Murray via devel wrote: James said: It sounds like a race condition in our wscript files or waf. How willing are you to sink time into this, I think it's a losing proposition. I've got a --jobs=1 in my script. That was added to make sure the printout was easy to rea

Re: Release

2023-12-21 Thread Fred Wright via devel
On Mon, 18 Dec 2023, Fred Wright wrote: On Mon, 18 Dec 2023, Matthew Selsky wrote: On Sun, Dec 17, 2023 at 08:17:23PM -0800, Fred Wright via devel wrote: There are also a bunch of warnings with some compilers, which might be worth looking at. They're often fairly easy to fix, and some

Re: Release

2023-12-18 Thread Fred Wright via devel
it would be heavy-handed for the normal build procedure. Or even having CI tests both ways might be useful, to distiguish between errors and warnings. Though if CI tests had the ability to report error versus warning results, that would be unnecessary. On Mon, 18 Dec 2023, Matthew Selsky w

Re: Release

2023-12-17 Thread Fred Wright via devel
On Wed, 6 Dec 2023, Matthew Selsky via devel wrote: Sounds good. I'll aim to release ~15-Dec-2023. Fortunately this hasn't happened yet. :-) The main issue I've found is that the "struct var" in ntp_control.c, is relying on anonymous unions, which are a relatively new language feature. Th

Re: I/we need a lesson in git and/or gitlab and/or merge requests

2023-11-19 Thread Fred Wright via devel
On Sat, 18 Nov 2023, Fred Wright via devel wrote: [...] With or without this problem, it's a bad idea to combine multiple unrelated changes into a single MR anyway. It's best to stick to one topic per branch, both locally and in any MRs derived from such branches. I neglected t

Re: I/we need a lesson in git and/or gitlab and/or merge requests

2023-11-18 Thread Fred Wright via devel
In general, it's a good idea to read an actual book on git, rather than trying to understand it purely through manpages. The one I used (almost a decade ago) is this one: https://www.amazon.com/gp/product/1449316387/ It doesn't tell you everything you might want to know, but it cov

Re: NTPsec 1.2.2a released

2023-08-07 Thread Fred Wright via devel
On Fri, 4 Aug 2023, James Browning via devel wrote: On 08/04/2023 6:35 PM PDT Fred Wright via devel wrote: :::snip::: I notice that the two commits for that don't seem to be in any branch. Having commits only "owned" by a tag and not a branch seems fragile. I do

Re: NTPsec 1.2.2a released

2023-08-04 Thread Fred Wright via devel
On Fri, 4 Aug 2023, Fred Wright via devel wrote: On Fri, 4 Aug 2023, Matthew Selsky wrote: On Fri, Aug 04, 2023 at 01:47:29PM -0700, Fred Wright via devel wrote: And for that matter, what exactly is 1.2.2a, given that there's no git tag for that version? 1.2.2a is 1.2.2 + the 2 line

Re: NTPsec 1.2.2a released

2023-08-04 Thread Fred Wright via devel
On Fri, 4 Aug 2023, Matthew Selsky wrote: On Fri, Aug 04, 2023 at 01:47:29PM -0700, Fred Wright via devel wrote: And for that matter, what exactly is 1.2.2a, given that there's no git tag for that version? 1.2.2a is 1.2.2 + the 2 line patch to avoid the crash. We'll releas

Re: NTPsec 1.2.2a released

2023-08-04 Thread Fred Wright via devel
On Thu, 3 Aug 2023, Hal Murray via devel wrote: Should that also go to users@ and devel@? What fraction of people on users or devel are also on announce? And for that matter, what exactly is 1.2.2a, given that there's no git tag for that version? Fred Wright _

Re: Old email on gitlab

2023-07-23 Thread Fred Wright via devel
On Sun, 23 Jul 2023, Hal Murray via devel wrote: git log on a fresh clone shows things like this: Author: Hal Murray Date: Tue Jul 4 15:16:47 2023 -0700 Squash warnings about not handled enumeration I haven't used that email in ages. My profile has been updated. Mail from gitlab goe

Re: proposal for sntp program: include 'delay' in json output

2023-01-04 Thread Fred Wright via devel
On Mon, 2 Jan 2023, folkert via devel wrote: [...] It makes it include the delay in the json output. Note that the delay is not the full story in the time uncertainty. A long-standing ntpdig bug is that it fails to include the dispersion. The delay gives the uncertainty in the server->cl

Re: Pushing to GitLab (x: proposal for sntp program: include 'delay' in json output)

2023-01-04 Thread Fred Wright via devel
On Tue, 3 Jan 2023, folkert wrote: Lost me. What about sntp do you want to put on gitlab? Oh, reading these in reverse order. I think you are offering to add this as a Merge Request on GitLab? Yes, that would be good. Can I please send the patch via e-mail? I've been struggeling with gi

Re: proposal for sntp program: include 'delay' in json output

2023-01-03 Thread Fred Wright via devel
On Tue, 3 Jan 2023, folkert via devel wrote: Lost me. What about sntp do you want to put on gitlab? Oh, reading these in reverse order. I think you are offering to add this as a Merge Request on GitLab? Yes, that would be good. Can I please send the patch via e-mail? I've been struggeli

Re: We need to test leap smearing :)

2022-12-22 Thread Fred Wright via devel
On Wed, 21 Dec 2022, Hal Murray via devel wrote: Google says: https://developers.google.com/time/smear We encourage anyone smearing leap seconds to use a 24-hour linear smear from noon to noon UTC. There were earlier versions which did sine rather than linear. Hmm. I don't recall any non

Re: Broken for OpenSSL 1.1

2022-12-22 Thread Fred Wright via devel
On Wed, 21 Dec 2022, Fred Wright via devel wrote: On Wed, 21 Dec 2022, Hal Murray wrote: I guess if you don't see the issue I'll have to look more closely; I thought you might "just know" the problem. Does git head work on 3.0? Yes. I think it gets confused when

Re: Broken for OpenSSL 1.1

2022-12-21 Thread Fred Wright via devel
On Wed, 21 Dec 2022, Hal Murray wrote: f...@fwright.net said: It's 1.1.1s, which is the latest 1.1. I don'think there's anything nonstandard besides using versioned install locations so that multiple versions can be installed side-by-side. I poked around some more. I have it building and r

Re: Broken for OpenSSL 1.1

2022-12-21 Thread Fred Wright via devel
On Wed, 21 Dec 2022, Hal Murray wrote: but if breaking OpenSSL 1.1 was unintentional, then it needs to be fixed I'm not aware of any intententional breakage. I'm pretty sure we would have done it at configure time. I don't think *unintentional* breakage would be done at configure time.

Re: We need to test leap smearing :)

2022-12-21 Thread Fred Wright via devel
On Wed, 21 Dec 2022, Hal Murray via devel wrote: Does anybody use it? Do any distros build with it enabled? Should we add an "#warn untested" to the code? If some systems need leap-smeared time to get around bugs in their code, they should be free to implement an *internal* leap-smeared tim

Broken for OpenSSL 1.1

2022-12-21 Thread Fred Wright via devel
The build currently fails when building againts OpenSSL 1.1. MacPorts is currently building it that way since the last release failed to build against OpenSSL 3 (due to the attic problem), though it should be able to move to OpenSSL 3 on the next release. So it's not actually an issue for

Re: Mail delays are back: 4 hours

2022-12-21 Thread Fred Wright via devel
On Wed, 21 Dec 2022, Matt Selsky via devel wrote: This is only a 2 minute delay, if I converted all timestamps to UTC correctly. My last post was delayed 11 minutes, which is longer than it should be, but not awful. I did find that a spammer was abusing our Mailman instance's web interfa

Re: More cookie keys

2022-12-20 Thread Fred Wright via devel
On Mon, 19 Dec 2022, James Browning via devel wrote: On 12/18/2022 6:02 PM PST Hal Murray via devel wrote: The commit message for that is lacking the blank line after the summary line. This means that some git tools treat the entire commit message as the summary, creating obnoxiously long li

Re: More cookie keys

2022-12-18 Thread Fred Wright via devel
On Sat, 17 Dec 2022, Hal Murray via devel wrote: I just pushed code to save 10 NTS keys used to make cookies. The commit message for that is lacking the blank line after the summary line. This means that some git tools treat the entire commit message as the summary, creating obnoxiously l

Re: devel/make-tarball broken

2022-12-18 Thread Fred Wright via devel
On Thu, 15 Dec 2022, Matthew Selsky via devel wrote: On Wed, Dec 14, 2022 at 03:39:29PM -0800, James Browning via devel wrote: 'Do not apply transform to symbolic link targets' [1] Which I got from googling 'gnu tar transform' IIRC. It is also a gnuism, but I do not see a portable transform t

Re: build on Python 2.6 broken and strongly suggested minimum version

2022-12-09 Thread Fred Wright via devel
On Thu, 8 Dec 2022, James Browning via devel wrote: Selsky broke the build[1] back in May 2020 when switching the python_scripts variable in /wscript to a set when Python 2.6 does not support sets. Given the lack of complaints, I suspect no one uses 2.6 anymore, which can be dropped. Python

Re: waf: --disable-attic

2022-02-20 Thread Fred Wright via devel
On Tue, 15 Feb 2022, Hal Murray via devel wrote: matthew.sel...@twosigma.com said: Are we worried about the speed of the build, lack of build support on particular platforms, or something else? I'm not particularly concerned about the speed of a build. As far as I know, nobody has complain

Re: RUST for linux kernel

2021-08-31 Thread Fred Wright via devel
On Fri, 27 Aug 2021, MLewis via devel wrote: " A new set of patches submitted to the Linux kernel mailing list summarises the progress of the project to enable Rust to be used alongside C for implementing the Linux kernel. [...] " There's a YouTube video of a talk on this subject. It's

Re: Lesson/Example please

2021-03-15 Thread Fred Wright via devel
On Sun, 14 Mar 2021, Hal Murray via devel wrote: [Context is cleaning up ntp_control] This will probably be simple after somebody gives me a good example and/or explains things to me. I want to put a (pointer to a) function in a field of a struct. The type of that function includes a pointer

Re: GitLab | Projects forced to "Private" (#294196)

2020-12-17 Thread Fred Wright via devel
On Thu, 17 Dec 2020, Eric S. Raymond wrote: James Browning via devel : The ntpsec forks belonging to rlaager, selsky, and ianbreune are still detached. A quick check shows that there are no forks. The page I looked at claimed that such detached repositories cannot be reattached. TLDR there is

Re: ✘Python 2.7 broken

2020-12-12 Thread Fred Wright via devel
On Sat, 12 Dec 2020, James Browning via devel wrote: On Sat, Dec 12, 2020, at 6:41 PM Gary E. Miller via devel wrote: Yo James! On Sat, 12 Dec 2020 18:35:13 -0800 James Browning via devel wrote: The following patch clears it up on the machine I bisected on. No, that uses the installed

Re: ntpq broken on new Debian box

2020-10-14 Thread Fred Wright via devel
On Wed, 14 Oct 2020, Hal Murray via devel wrote: I'm setting up a new Debian system. I'm far from a Debian wizard, but I'm not a total newbie either. I have a ntp.pth setup, so ntpq finds the python libraries. [...] File "/usr/local/lib/python3/dist-packages/ntp/ntpc.py", line 49, in _dlo

Re: ntpsec | The --disable-nts option is partially ineffective (#666)

2020-09-03 Thread Fred Wright via devel
On Wed, 2 Sep 2020, Hal Murray via devel wrote: As of 1.1.9, NTPsec doesn't build "normally" on Debian 7... Debian 7 is pretty old. Support ended May 2018 Do we want to support versions of distros that the vendor doesn't support any more? My vote would be no. There are sometimes signifi

Re: cpp hacking: bump FOO by 1

2020-09-03 Thread Fred Wright via devel
On Thu, 3 Sep 2020, Hal Murray wrote: I don't see how to use your master/entry macros to solve my problem. I didn't mean for those to be usable as is, but just as an illustration of the concept. YMMV. The current code has only one table but it needs a symbol for the offset of each slot

Re: cpp hacking: bump FOO by 1

2020-09-02 Thread Fred Wright via devel
On Sun, 30 Aug 2020, Hal Murray via devel wrote: Is there any way to do something like #define FOO $FOO+1 I want to keep track of the number of times a macro has been called. That seems like something that would happen often enough that there would be a standard recipe but I haven't seen it.

Re: OpenSSL 3.0.0

2020-06-16 Thread Fred Wright via devel
On Tue, 16 Jun 2020, Mike Simpson via devel wrote: There is libressl from the OpenBSD team https://www.libressl.org/ It was forked from openssl in 2014 The last time I tried it, libaes_siv wouldn't build with LibreSSL, so that would need to be fixed. Unless LibreSSL provides an adequate A

Re: 1.1.6 build fails on FC30

2020-04-17 Thread Fred Wright via devel
On Thu, 16 Apr 2020, Hal Murray via devel wrote: Because RS232 signaling is negative logic. That's what I used to think, but somebody corrected me many years ago. The data is upside down but the control signals are not. From https://en.wikipedia.org/wiki/RS-232 under Voltage levels For d

Re: ✘Warnings on OSX

2019-08-31 Thread Fred Wright via devel
On Sat, 31 Aug 2019, Matthew Selsky wrote: On Fri, Aug 30, 2019 at 08:01:59PM -0700, Fred Wright via devel wrote: On Thu, 29 Aug 2019, Gary E. Miller via devel wrote: Warnings on OSX: [ 73/131] Compiling libntp/ntp_calendar.c ../../ntpd/ntp_control.c:2612:27: warning: format specifies

Re: ✘Warnings on OSX

2019-08-30 Thread Fred Wright via devel
On Fri, 30 Aug 2019, Fred Wright via devel wrote: On Thu, 29 Aug 2019, Gary E. Miller via devel wrote: Warnings on OSX: [ 73/131] Compiling libntp/ntp_calendar.c ../../ntpd/ntp_control.c:2612:27: warning: format specifies type 'unsigned short' but the argument has type &#x

Re: ✘Warnings on OSX

2019-08-30 Thread Fred Wright via devel
On Thu, 29 Aug 2019, Gary E. Miller via devel wrote: Warnings on OSX: [ 73/131] Compiling libntp/ntp_calendar.c ../../ntpd/ntp_control.c:2612:27: warning: format specifies type 'unsigned short' but the argument has type 'unsigned int' [-Wformat] socktoa(rmt_addr),

Re: _XOPEN_SOURCE in ntpd/refclock_gpsd.c => warnings on BSD

2019-08-21 Thread Fred Wright via devel
On Wed, 21 Aug 2019, Hal Murray via devel wrote: ntpd/refclock_gpsd.c has: #define _XOPEN_SOURCE 600 I see the following warning: NetBSD: ../../ntpd/refclock_gpsd.c:2118:6: warning: implicit declaration of function 'strlcpy' [-Wimplicit-function-declaration] FreeBSD: ../../ntpd/refclock_gps

Re: New config feature - time1 can declare GPS wraparound compensation

2019-08-16 Thread Fred Wright via devel
On Fri, 16 Aug 2019, Eric S. Raymond via devel wrote: Sanjeev Gupta : sizeof(double) seems to be 8 bytes. The 8192 * No of Secs per week overflows this. Huh. If "long double" isn't 16 bytes, we're foing to have a problem. There's no guarantee that long double differs from double. Anythi

Re: ✘"\x07ntske/1"

2019-07-22 Thread Fred Wright via devel
On Mon, 22 Jul 2019, Gary E. Miller via devel wrote: No one has a solid answer to the NTS ALPN issue? "at some time the NTPSEC server would return "\x07ntske/1" instead of just "ntske/1"." Doesn't ring any BELs for me. :-) All kidding aside, it's probably not a coincidence that \x07 is the

Re: The NTPsec Project is pleased to announce the tagging of version 1.1.5

2019-07-02 Thread Fred Wright via devel
On Sun, 30 Jun 2019, Mark Atwood wrote: The NTPsec Project is pleased to announce the tagging of version 1.1.5 I guess "tagging" is a good description given that the tarball doesn't seem to have been published. :-) Fred Wright ___ devel mailing

Re: What's the best way to fix warnings from unused result

2019-04-07 Thread Fred Wright via devel
On Sun, 7 Apr 2019, Hal Murray wrote: Does a simple void cast work? E.g.: (void) strerror_r(...) I haven't found the magic using that approach. ../../ntpd/nts.c:214:16: warning: ignoring return value of ???strerror_r???, declared with attribute warn_unused_result [-Wunused-result]

Re: What's the best way to fix warnings from unused result

2019-04-07 Thread Fred Wright via devel
On Sun, 7 Apr 2019, Eric S. Raymond via devel wrote: Hal Murray via devel : ../../ntpd/nts.c:213:9: warning: ignoring return value of ???strerror_r???, declared with attribute warn_unused_result [-Wunused-result] I'm only getting this on Ubuntu, so a secondary question is why isn't that check

Re: ✘Python 3.6.5 breaks build

2019-03-20 Thread Fred Wright via devel
On Wed, 20 Mar 2019, James Browning via devel wrote: On Wed, Mar 20, 2019 at 6:30 PM Gary E. Miller via devel wrote: Yo All! Something recently broke in NTPsec when using Python 3.6: ? I thought I got that bug with?a4453ee5a4 "Fix polyglot library for Python3 on NetBSD". Wher

Re: Upcoming GPS rollover

2019-03-12 Thread Fred Wright via devel
On Mon, 11 Mar 2019, Eric S. Raymond via devel wrote: GPSes will roll over to their third era on April 6th. Those of us with constellations of test GPSes will need to take time to audit how much of our kit has gone toes-up. Maybe none of it immedately, as manufacturers tend to pivod on their

Re: no ssl.h on macos?

2019-02-10 Thread Fred Wright via devel
On Sun, 10 Feb 2019, Hal Murray wrote: What's involved in getting developer access to the Mac world? It depends on what you mean by that. There are both free and paid developer accounts. The free version gives you access to most of the developer downloads. That's all I've ever used. I t

Re: no ssl.h on macos?

2019-02-10 Thread Fred Wright via devel
On Sat, 9 Feb 2019, Hal Murray via devel wrote: I thought we got farther than this last night. Does macos have OpenSSL? What version? Stage: build Name: macos-basic Trace: ../../include/nts.h:7:10: fatal error: 'openssl/ssl.h' file not found #include ^~~ 1 error generat

Re: 'AnsiTerm' object has no attribute 'buffer'

2019-01-30 Thread Fred Wright via devel
On Tue, 29 Jan 2019, Gary E. Miller via devel wrote: On Tue, 29 Jan 2019 19:01:40 -0800 (PST) Fred Wright via devel wrote: Well, the way we use sys.stdout is warned about in the Python doc. That is enough for me to want it aligned with the python doc. The real question is why the build

Re: 'AnsiTerm' object has no attribute 'buffer'

2019-01-29 Thread Fred Wright via devel
On Tue, 29 Jan 2019, Gary E. Miller via devel wrote: On Tue, 29 Jan 2019 17:11:15 -0800 Hal Murray via devel wrote: Gary said: Update: Works: 2.7, 3.7 Fails: 3.5, 3.6 It was working a week or two ago. Yup. Did we change anything? (I don't think so.) Agreed, not in that area. I hav

Re: Anybody testing/using Big endian?

2018-08-25 Thread Fred Wright via devel
On Sat, 25 Aug 2018, Hal Murray wrote: Thanks. https://gitlab.com/NTPsec/ntpsec/merge_requests/776 I approved the merge request, but I don't get anything new with git pull or a fresh clone. That just flags it as "approved", but doesn't actually merge it. Is the "Merge" button active for

Re: Anybody testing/using Big endian?

2018-08-25 Thread Fred Wright via devel
On Fri, 24 Aug 2018, Hal Murray via devel wrote: On a PowerPC: TEST(numtoa, RefidStr)../../tests/libntp/numtoa.c:19::FAIL: Expected '68.51.34.17' Was '17.34.51.68' It's probably a bug in the test code. Yes, it is. The argument to refid_str() is expected to be in network byte order, but t

Re: ntpd/varsion.h

2017-12-24 Thread Fred Wright via devel
On Sat, 23 Dec 2017, Hal Murray via devel wrote: > Should it be included in a tarball? > How about wafhelpers/.autorevision-cache? > > Should it be moved to $build/main/ntpd/, similar to the way that derived > python files were moved to $build/main/pylib/? I think it should, and I made a brief a

Re: Python libs on Debian/Raspbian

2017-12-23 Thread Fred Wright via devel
On Sat, 23 Dec 2017, Hal Murray wrote: > > but isn't when compiled extensions like 'ntpc' are involved. Extensions > > almost never work with a different Python that the one they were compiled > > and linked for, with a variety of possible failure modes. > > Should ntpc.so get installed in the A

Re: ./waf install is not idempotent?

2017-12-23 Thread Fred Wright via devel
On Sat, 23 Dec 2017, Jason Azze via devel wrote: > On Sat, Dec 23, 2017 at 5:47 PM, Hal Murray wrote: > > > >> I ran a ./waf distclean before my configure, build, install steps. I will > >> try from a fresh clone. > > > >> Before I open a GitLab issue, is this unexpected behavior? > > > > It sure

Re: Python libs on Debian/Raspbian

2017-12-23 Thread Fred Wright via devel
On Wed, 20 Dec 2017, Richard Laager via devel wrote: > Rather than debate hypotheticals further, I have submitted a merge > request to implement the "option H" idea being discussed: > https://gitlab.com/NTPsec/ntpsec/merge_requests/615 > > I'm looking for feedback on that particular merge request

Re: Bite of the Buildbugs!

2017-12-14 Thread Fred Wright via devel
(from a different thread) On Fri, 8 Dec 2017, Richard Laager via devel wrote: > I agree that your system does not have /usr/local in its sys.path by > default. [...] > 1) Ignore prefix and install to /usr. This is Fred Wright's solution and > is what is seemingly the point of fix_python_config.p

Re: Bite of the Buildbugs!

2017-12-10 Thread Fred Wright via devel
On Sun, 10 Dec 2017, Eric S. Raymond via devel wrote: > Ian Bruene via devel : > > After reading over the discussion regarding the recent /issues/, I have come > > to a side: Revert Fred's fix and throughly document the import breakage. > > Ugly, but simple. I'd like to hear counterargument from

Re: Preparing for a point release

2017-12-07 Thread Fred Wright via devel
On Wed, 6 Dec 2017, Ian Bruene via devel wrote: > For installs the only remaining problem is that for unknown reasons it > sometimes doesn't follow the PREFIX when installing the python libs. There's nothing "unknown" about it. This has been discussed at length on this ML, as well as being expl

Re: Big Endian testing

2017-11-29 Thread Fred Wright via devel
On Wed, 29 Nov 2017, Eric S. Raymond wrote: > Fred Wright via devel : > > > > On Sat, 25 Nov 2017, Hal Murray via devel wrote: > > > > > It seems like a good idea for somebody to actually test our code on a > > > big-endian system. > > > > I&#x

Re: waf -v clutter

2017-11-29 Thread Fred Wright via devel
On Sat, 25 Nov 2017, Eric S. Raymond via devel wrote: > Hal Murray : > > devel@ntpsec.org said: > > > waf doesn't know that config.h exists; this is its way to pass > > > configuration > > > switches. The fact that we generate a config.h is really legacy behavior > > > from autoconf and could b

Re: Big Endian testing

2017-11-29 Thread Fred Wright via devel
On Sat, 25 Nov 2017, Hal Murray via devel wrote: > It seems like a good idea for somebody to actually test our code on a > big-endian system. I've run it on my PowerBook (OSX 10.5), though I didn't attempt any detailed analysis of the behavior. The clock offset had more wander than I'd like, bu

Re: Fixing the build to run python tests

2017-11-29 Thread Fred Wright via devel
On Wed, 29 Nov 2017, Ian Bruene via devel wrote: > > On 11/29/2017 04:17 PM, Hal Murray via devel wrote: > > That link lets you test python code using the new libraries. > > > > In a previous version of that code, the link was in ntpclients and you could > > run things by cd-ing there. Now the li

Re: Getting things moving again

2017-11-09 Thread Fred Wright via devel
On Sat, 4 Nov 2017, Eric S. Raymond via devel wrote: > * Fred and Gary need to have, and resolve, their argument about what to > do to the build recipe around Python library installation. For > concreteness, this should probably start with a proposed patch from > Fred. My existing patch h

Re: NMEA driver - off by 1024 weeks but says 4096

2017-11-02 Thread Fred Wright via devel
On Mon, 30 Oct 2017, Hal Murray via devel wrote: > fallenpega...@gmail.com said: > > I suggest running it with gpsd for a while instead of NTPsec, and see if > > gpsd's logging identifies the issue. > > > Or if the ntpd log contains the NMEA strings, it may be possible to > > reconstruct a gpsd pl

Re: Library-path fix

2017-10-28 Thread Fred Wright via devel
On Thu, 19 Oct 2017, Eric S. Raymond via devel wrote: > Fred, can we get an updaterd MR and rationale for your library-path > fix proposal? OK, here goes: First of all, here's the case table for the "usability check" again: Exists? In sys.path?Usable? ---

Re: Library-path fix

2017-10-20 Thread Fred Wright via devel
On Thu, 19 Oct 2017, Eric S. Raymond via devel wrote: > Fred, can we get an updaterd MR and rationale for your library-path > fix proposal? Yes, but I'm about to go away for the weekend. I'll do that next week. BTW, I do have an outstanding MR (561) for a minor doc fix that should be non-contr

Re: Where to python libraries get installed?

2017-10-07 Thread Fred Wright via devel
On Sat, 7 Oct 2017, Hal Murray wrote: > > No, if "storing" includes the code that may clean up old library installs. > > Ahh... Thanks. That brings up a question I've been wondering about for ages. > > What sort of cleanup does waf install do? Is that documented anyplace? I don't think instal

Re: Where to python libraries get installed?

2017-10-07 Thread Fred Wright via devel
On Sat, 7 Oct 2017, Hal Murray wrote: > >>> Should it also printout where it will install the python libraries? > >> Good idea. I'd take that patch. > > > It's already there. Look at PYTHONDIR towards the end. > > Thanks. > > Is that used for anything other that storing python libraries? No, i

Re: Resolution of the library-path mess

2017-10-07 Thread Fred Wright via devel
On Sat, 7 Oct 2017, Gary E. Miller via devel wrote: > On Sat, 7 Oct 2017 12:15:27 -0700 (PDT) > Fred Wright via devel wrote: > > > > Makes sense. Fedora is one of the systems where Python doesn't > > include a "local" directory in the sys.path set

Re: Where to python libraries get installed?

2017-10-07 Thread Fred Wright via devel
On Sat, 7 Oct 2017, Eric S. Raymond via devel wrote: > Hal Murray via devel : > > waf configure prints out: > > PREFIX: /usr/local > > > > Should it also printout where it will install the python libraries? > > Good idea. I'd take that patch. It's already there. Look

Re: Resolution of the library-path mess

2017-10-07 Thread Fred Wright via devel
On Sat, 7 Oct 2017, Hal Murray via devel wrote: > If I have PYTHONPATH defined as /usr/local/lib/python2.7/site-packages > Then the python libs get installed in /usr/local/lib/... > If I unset PYTHONPATH, they get installed to /usr/lib/... Doh! (on Eric's behalf) That would be an unfortunate pr

Re: Resolution of the library-path mess

2017-10-06 Thread Fred Wright via devel
On Thu, 5 Oct 2017, Hal Murray wrote: > >> Warnings are easily lost in the noise. So either create the > >> directory or treat it as an error and bail. > > > There are two issues with just "creating the directory": > > 1) There's no guarantee that Python will actually use it. > > 2) Creating the

Re: Library-path glitch, again

2017-10-06 Thread Fred Wright via devel
On Fri, 6 Oct 2017, Eric S. Raymond via devel wrote: > Fred Wright writes: > >Sorry for the lateness, but I realized that the current code still has a > >bug (as well as a couple of deficiencies of a more-or-less cosmetic > >nature). It's currently checking sys.path in the *running* Python, but i

Re: Resolution of the library-path mess

2017-10-05 Thread Fred Wright via devel
On Sun, 1 Oct 2017, Eric S. Raymond wrote: > Fred Wright via devel : > > On Sun, 1 Oct 2017, Eric S. Raymond via devel wrote: > > > Gary E. Miller via devel : > > > > How do you plan that a local NTPsec install from source does not > > > > ove

Re: Resolution of the library-path mess

2017-10-01 Thread Fred Wright via devel
On Sun, 1 Oct 2017, Eric S. Raymond via devel wrote: > Gary E. Miller via devel : > > How do you plan that a local NTPsec install from source does not > > overwite an NTPsec install from the native OS repositories? > > That now will never happen if the /usr/local/lb/python-X.Y directory exists; >

Re: Fix for Python library path problem

2017-09-28 Thread Fred Wright via devel
will require much more than just > changes to get_python_lib(). Agreed. On Thu, 28 Sep 2017, Gary E. Miller via devel wrote: > On Wed, 27 Sep 2017 19:02:23 -0700 (PDT) > Fred Wright via devel wrote: > > > One of the ways to do #1 is to use the path returned by > > get_pyth

Re: Fix for Python library path problem

2017-09-27 Thread Fred Wright via devel
On Wed, 27 Sep 2017, Eric S. Raymond via devel wrote: > Gary E. Miller via devel : > > What we see that pip does, is edit the sys.path to include the > > location an egg is installed. That looks to me like a method > > to go forward with. > > It looks to me like a fscking disaster, introducing ye

Re: Fix for Python library path problem

2017-09-27 Thread Fred Wright via devel
On Wed, 27 Sep 2017, Gary E. Miller via devel wrote: > Fred Wright via devel wrote: > It only matters > > for Linux, since get_python_lib() returns FHS-compliant results on > > *BSD, and on OSX the paths are so completely different that FHS > > doesn't apply. &g

Re: Fix for Python library path problem

2017-09-27 Thread Fred Wright via devel
On Wed, 27 Sep 2017, Gary E. Miller via devel wrote: > > What we see that pip does, is edit the sys.path to include the > location an egg is installed. That looks to me like a method > to go forward with. That sounds plausible, but we need to figure out how it does that. It's not just about "ed

Re: Fix for Python library path problem

2017-09-27 Thread Fred Wright via devel
On Wed, 27 Sep 2017, Eric S. Raymond wrote: > Fred Wright via devel : > > FYI, I just took a look at sys.path on the three Linuces I have here > > (Ubuntu, CentOS, and Fedora), and none of them has a single entry with > > "local" as part of the path. > > I se

Re: Fix for Python library path problem

2017-09-27 Thread Fred Wright via devel
On Wed, 27 Sep 2017, Eric S. Raymond wrote: > Fred Wright via devel : > > > > On Wed, 27 Sep 2017, Eric S. Raymond via devel wrote: > > > > > I've pushed a fix for Fred Wright's FixConfig class that seems to > > > solve the problem of incorrect

Re: Fix for Python library path problem

2017-09-27 Thread Fred Wright via devel
On Wed, 27 Sep 2017, Fred Wright wrote: > On Wed, 27 Sep 2017, Eric S. Raymond via devel wrote: > > > I've pushed a fix for Fred Wright's FixConfig class that seems to > > solve the problem of incorrect Python library locations. > > > > I tested it with no --prefix option and with --prefix=/usr, >

Re: Fix for Python library path problem

2017-09-27 Thread Fred Wright via devel
On Wed, 27 Sep 2017, Eric S. Raymond via devel wrote: > I've pushed a fix for Fred Wright's FixConfig class that seems to > solve the problem of incorrect Python library locations. > > I tested it with no --prefix option and with --prefix=/usr, > using install --destdir=/tmp/ntp. > > Gary, please

Re: Python Library Cleanups

2017-09-26 Thread Fred Wright via devel
On Tue, 26 Sep 2017, Eric S. Raymond wrote: > Fred Wright via devel : > > > BTW, I have a tool that lists a few things including the library paths for > > every version of Python it can find on the system. I can submit it to > > devel/ if you like. > > Please d

  1   2   >