[Devel] Re: [PATCH 00/17] Pid-NS(V3) Enable multiple pid namespaces

2007-06-19 Thread sukadev
Dave Hansen [EMAIL PROTECTED] wrote: | What's different about this patch from earlier ones? What should I go | look at, first? Is the performance any better than before? | Sorry, I missed this mail. Following are the major changes since my last post to [EMAIL PROTECTED] They are listed in the

Re: [Devel] [PATCH 17/17] Pid-NS(V3) Introduce proc_mnt for pid_ns

2007-06-19 Thread sukadev
Pavel Emelianov [EMAIL PROTECTED] wrote: | [EMAIL PROTECTED] wrote: | > From: [EMAIL PROTECTED] | > Subject: [PATCH 17/17] Pid-NS(V3) Introduce proc_mnt for pid_ns | > | > The following patch completes the removal of the global proc_mnt. | > It fetches the mnt on which to do dentry invalidations f

[Devel] Re: [netns] sysfs: issues porting shadow directories on top of 2.6.21-mm2

2007-06-19 Thread Eric W. Biederman
Benjamin Thery <[EMAIL PROTECTED]> writes: > Hi Eric, > > For the past few weeks, I've been trying to port your netns patchset on top of > 2.6.21-mm2. It took me a lot more time than I first expected to have something > working. Ok. Interesting. There are a few pieces missing to make it work on

[Devel] Re: [PATCH 0/28] Pid namespaces (two models)

2007-06-19 Thread Andrew Morton
On Fri, 15 Jun 2007 19:55:43 +0400 Pavel Emelianov <[EMAIL PROTECTED]> wrote: > Long ago Sukadev and I sent two approaches for pid namespaces - the > hierarchical model in which namespaces are nested into each other, > and the flat model, where pids have only two values and creation of > level 3 n

[Devel] Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-19 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Tue, 19 Jun 2007 12:33:16 -0700 > Only x86_64 and ia64 are fixed. Would it be correct to assume that the > other CONFIG_COMPAT architectures also need to be fixed? Only platforms which compat to "i386" have the issue wrt. the alignment of "u64" types

[Devel] Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-19 Thread Mikael Pettersson
Andrew Morton writes: > On Mon, 18 Jun 2007 12:21:47 +0400 > Vasily Tarasov <[EMAIL PROTECTED]> wrote: > > > From: Vasily Tarasov <[EMAIL PROTECTED]> > > > > This patch should be applied after Arnd Bergmann's patch, > > that intoduces new compat types: > > http://lkml.org/lkml/2007/6/15/

[Devel] Re: dev_change_netns on a tunnel device

2007-06-19 Thread Eric W. Biederman
"Sapan Bhatia" <[EMAIL PROTECTED]> writes: > - Because the directing of packets is based on ip address and multiple > network namespaces are allowed to use the same ip addresses then > the decode needs to take the network namespace into account. > > > Hm, but a tunnel device can be

[Devel] Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-19 Thread Andrew Morton
On Mon, 18 Jun 2007 12:21:47 +0400 Vasily Tarasov <[EMAIL PROTECTED]> wrote: > From: Vasily Tarasov <[EMAIL PROTECTED]> > > This patch should be applied after Arnd Bergmann's patch, > that intoduces new compat types: > http://lkml.org/lkml/2007/6/15/98 > > OpenVZ Linux kernel team has discovere

[Devel] Re: New pid namespaces patches testing

2007-06-19 Thread Eric W. Biederman
Pavel Emelianov <[EMAIL PROTECTED]> writes: > OK. We have measured the nptl perf test for init namespace. > Summary - flat model is very light, Suka's patches break the > kernel performance event when CONFIG_PID_NS is off. > > |perf, s | perf loss | > -+---

[Devel] Re: [PATCH 16/28] [FLAT 1/6] Changes in data structures for flat model

2007-06-19 Thread Eric W. Biederman
Pavel Emelianov <[EMAIL PROTECTED]> writes: > [EMAIL PROTECTED] wrote: >> Pavel Emelianov [EMAIL PROTECTED] wrote: >> | This patch opens the flat model patches. >> | >> | The flat model idea is that struct pid has two numbers. The first one >> | (pid->nr) is a global one and is unique in the sys

[Devel] Re: dev_change_netns on a tunnel device

2007-06-19 Thread Sapan Bhatia
- Because the directing of packets is based on ip address and multiple network namespaces are allowed to use the same ip addresses then the decode needs to take the network namespace into account. Hm, but a tunnel device can belong to only one namespace, so shouldn't this get handled automa

[Devel] dev_change_netns on a tunnel device

2007-06-19 Thread Sapan Bhatia
Hi Eric, Are the current semantics of tunnel devices (ipip, ip_gre etc.) with respect to changing the current netns correct? These devices have an ip_tunnel structure associated with each net_device, which is currently a global (not per_net). The result is that you can set up in container X a tun

[Devel] Re: [RFC][PATCH 2.6.22-rc5] System V IPC: new IPC_SETID command to modify an ID

2007-06-19 Thread Cedric Le Goater
Pierre Peiffer wrote: > This patch adds a new IPC_SETID command to the System V IPCs set of > commands, which allows to change the ID of an existing IPC. > > This command can be used through the semctl/shmctl/msgctl API, with the new > ID passed as the third argument for msgctl and shmctl (instead

[Devel] Re: [netns] sysfs: issues porting shadow directories on top of 2.6.21-mm2

2007-06-19 Thread Eric W. Biederman
Benjamin Thery <[EMAIL PROTECTED]> writes: > Hi Eric, > > For the past few weeks, I've been trying to port your netns patchset on top of > 2.6.21-mm2. It took me a lot more time than I first expected to have something > working. > > I started the port based on your latest public git repository tag

[Devel] Re: dev_change_netns on a tunnel device

2007-06-19 Thread Eric W. Biederman
"Sapan Bhatia" <[EMAIL PROTECTED]> writes: > Hi Eric, > > Are the current semantics of tunnel devices (ipip, ip_gre etc.) with > respect to changing the current netns correct? These devices have an > ip_tunnel structure associated with each net_device, which is > currently a global (not per_net).

[Devel] Re: [PATCH 16/28] [FLAT 1/6] Changes in data structures for flat model

2007-06-19 Thread Dave Hansen
On Tue, 2007-06-19 at 11:18 +0400, Pavel Emelianov wrote: > [EMAIL PROTECTED] wrote: > > Pavel Emelianov [EMAIL PROTECTED] wrote: > > | This patch opens the flat model patches. > > | > > | The flat model idea is that struct pid has two numbers. The first one > > | (pid->nr) is a global one and is

[Devel] Re: [PATCH] create_new_namespaces: fix improper return of NULL

2007-06-19 Thread Cedric Le Goater
Oleg Nesterov wrote: > On 06/19, Cedric Le Goater wrote: >> Oleg Nesterov wrote: >>> Untested. >>> >>> dup_mnt_ns() and clone_uts_ns() return NULL on failure. This is wrong, >>> create_new_namespaces() uses ERR_PTR() to catch an error. This means >>> that the subsequent create_new_namespaces() will

[Devel] Re: [PATCH] create_new_namespaces: fix improper return of NULL

2007-06-19 Thread Oleg Nesterov
On 06/19, Cedric Le Goater wrote: > > Oleg Nesterov wrote: > > Untested. > > > > dup_mnt_ns() and clone_uts_ns() return NULL on failure. This is wrong, > > create_new_namespaces() uses ERR_PTR() to catch an error. This means > > that the subsequent create_new_namespaces() will hit BUG_ON() in > >

[Devel] Re: [PATCH] create_new_namespaces: fix improper return of NULL

2007-06-19 Thread Cedric Le Goater
Oleg Nesterov wrote: > Untested. > > dup_mnt_ns() and clone_uts_ns() return NULL on failure. This is wrong, > create_new_namespaces() uses ERR_PTR() to catch an error. This means > that the subsequent create_new_namespaces() will hit BUG_ON() in > copy_mnt_ns() or copy_utsname(). I sent one just

[Devel] [PATCH] create_new_namespaces: fix improper return of NULL

2007-06-19 Thread Oleg Nesterov
Untested. dup_mnt_ns() and clone_uts_ns() return NULL on failure. This is wrong, create_new_namespaces() uses ERR_PTR() to catch an error. This means that the subsequent create_new_namespaces() will hit BUG_ON() in copy_mnt_ns() or copy_utsname(). Signed-off-by: Oleg Nesterov <[EMAIL PROTECTED]>

[Devel] Re: New pid namespaces patches testing

2007-06-19 Thread Cedric Le Goater
[ ... ] >>> I do believe that Suka's hierarchical model is better than mine, >>> but my point is: let's support the flat model as well. >> >> OK. First thing we can do is to find what they have in common and >> get that included. Then, after the first round, we might even find >> some more to re

[Devel] Network namespace ported to 2.6.21-mm2

2007-06-19 Thread Daniel Lezcano
Hi all, The network namespace patchset has been ported to 2.6.21-mm2. They are still some issues but we are on it, for this reason the patchset is named netns1-beta1. The patchset can be found here : http://lxc.sourceforge.net/patches/2.6.21/2.6.21-mm2-netns1-beta1/ Documentation can be fou

Re: [Devel] breakfast at ols?

2007-06-19 Thread Kir Kolyshkin
Serge E. Hallyn wrote: Last year we all met for breakfast at OLS. Now we've all pretty much all already met so maybe it's less exciting, but do people (who will be at OLS) care to meet for breakfast on the thursday or friday? Good idea! Sorry for so late reply...better late than never. Let's d

[Devel] Re: VIA VT6420: SATA disconnects

2007-06-19 Thread Vasily Averin
Jeff Garzik wrote: > Vasily Averin wrote: >> Jeff, Tejun, >> >> Our RHEL5-based OpenVZ linux kernel reports about SATA-related issues: >> VIA VT6420 SATA RAID Controller on MSI motherboard, x86_64 kernel based on >> latest RHEL5 kernel, >> On booting hardware initialized properly and all works fin

[Devel] Re: New pid namespaces patches testing

2007-06-19 Thread Pavel Emelianov
Cedric Le Goater wrote: > Pavel Emelianov wrote: >> OK. We have measured the nptl perf test for init namespace. >> Summary - flat model is very light, Suka's patches break the >> kernel performance event when CONFIG_PID_NS is off. >> >> |perf, s | perf loss | >> ---

[Devel] Re: New pid namespaces patches testing

2007-06-19 Thread Cedric Le Goater
Pavel Emelianov wrote: > OK. We have measured the nptl perf test for init namespace. > Summary - flat model is very light, Suka's patches break the > kernel performance event when CONFIG_PID_NS is off. > > |perf, s | perf loss | > -+--+-

[Devel] Re: [PATCH 1/28] [PREP 1/14] Round up the API

2007-06-19 Thread Pavel Emelianov
Cedric Le Goater wrote: > Pavel Emelianov wrote: >> The set of functions process_session, task_session, process_group >> and task_pgrp is confusing, as the names can be mixed with each other >> when looking at the code for a long time. >> >> The proposals are to >> * equip the functions that return

[Devel] Re: [PATCH 1/28] [PREP 1/14] Round up the API

2007-06-19 Thread Cedric Le Goater
Pavel Emelianov wrote: > The set of functions process_session, task_session, process_group > and task_pgrp is confusing, as the names can be mixed with each other > when looking at the code for a long time. > > The proposals are to > * equip the functions that return the integer with _nr suffix to

[Devel] New pid namespaces patches testing

2007-06-19 Thread Pavel Emelianov
OK. We have measured the nptl perf test for init namespace. Summary - flat model is very light, Suka's patches break the kernel performance event when CONFIG_PID_NS is off. |perf, s | perf loss | -+--++ 2.6.22-rc4-mm2 | 13.79 ± 0.1

Re: [Devel] Re: [PATCH 16/28] [FLAT 1/6] Changes in data structures for flat model

2007-06-19 Thread Pavel Emelianov
[EMAIL PROTECTED] wrote: > Pavel Emelianov [EMAIL PROTECTED] wrote: > | [EMAIL PROTECTED] wrote: > | > Pavel Emelianov [EMAIL PROTECTED] wrote: > | > | This patch opens the flat model patches. > | > | > | > | The flat model idea is that struct pid has two numbers. The first one > | > | (pid->nr)

Re: [Devel] [PATCH 08/17] Pid-NS(V3) Define/use pid->upid_list list.

2007-06-19 Thread Pavel Emelianov
[EMAIL PROTECTED] wrote: > Pavel Emelianov [EMAIL PROTECTED] wrote: > | [EMAIL PROTECTED] wrote: > | > Pavel Emelianov [EMAIL PROTECTED] wrote: > | > | [EMAIL PROTECTED] wrote: > | > | > Subject: [PATCH 08/17] Pid-NS(V3) Define/use pid->upid_list list. > | > | > > | > | > From: Sukadev Bhattiprolu

Re: [Devel] Re: [PATCH 22/28] [MULTI 1/6] Changes in data structures for multilevel model

2007-06-19 Thread Pavel Emelianov
[EMAIL PROTECTED] wrote: > Pavel Emelianov [EMAIL PROTECTED] wrote: > | This patch opens the multilevel model patches. > | > | The multilevel model idea is basically the same as for the flat one, > | but in this case task may have many virtual pids - one id for each > | sub-namespace this task is