[Devel] Re: [patch 1/1] remove EXPERIMENTAL on PID namespace

2009-12-28 Thread Serge E. Hallyn
Quoting Daniel Lezcano (daniel.lezc...@free.fr): > The pid namespace is enabled by default in different distros > and the different bugs were fixed when they were reported. > No new bug is reported since some time now, so I guess it's safe to > remove the experimental condition on this subsystem. >

[Devel] Re: [PATCH] Restore task fs_root and pwd (v2)

2009-12-28 Thread Serge E. Hallyn
Quoting Serge E. Hallyn (se...@us.ibm.com): > Checkpoint and restore task->fs. Tasks sharing task->fs will > share them again after restart. Sigh. Shoulda written testcases in advance :) pwd restoration is fine. And technically root restoration is fine too. If any task which is not the contai

[Devel] Re: [PATCH 2/4] cgroups: subsystem module loading interface

2009-12-28 Thread Li Zefan
>>> + write_lock(&css_set_lock); >>> + for (i = 0; i < CSS_SET_TABLE_SIZE; i++) { >>> + struct css_set *cg; >>> + struct hlist_node *node, *tmp; >>> + struct hlist_head *bucket = &css_set_table[i], *new_bucket; >> Please add a blank line between variable declaratio

[Devel] Re: [patch 2/2] Remove the ns_cgroup

2009-12-28 Thread Serge E. Hallyn
Quoting Daniel Lezcano (daniel.lezc...@free.fr): > The ns_cgroup is an annoying cgroup at the namespace / cgroup frontier. True. However, it remains - apart from using smack or SELinux - the only way to truly lock a container into a cgroup configuration. That's unlikely to change until we finall

[Devel] [patch 2/2] Remove the ns_cgroup

2009-12-28 Thread Daniel Lezcano
The ns_cgroup is an annoying cgroup at the namespace / cgroup frontier. For example, a single process can not handle a big amount of namespaces without interacting with this cgroup and falling in an exponential creation time due to the nested cgroup directory depth (eg. /cgroup//...//...). That w

[Devel] [patch 1/2] Add clone_child control file

2009-12-28 Thread Daniel Lezcano
This patch is sent as an answer to a previous thread around the ns_cgroup. https://lists.linux-foundation.org/pipermail/containers/2009-June/018627.html It adds a control file 'clone_children' for a cgroup. This control file is a boolean specifying if the child cgroup should be a clone of the par

[Devel] [patch 0/2] Remove the ns_cgroup

2009-12-28 Thread Daniel Lezcano
This patchset is a proposition for the previous discussion we had a few months ago: https://lists.linux-foundation.org/pipermail/containers/2009-June/018601.html It was suggested to drop the ns_cgroup definitively and add a compatibility flag 'clone_children'. ___

[Devel] [patch 1/1] remove EXPERIMENTAL on PID namespace

2009-12-28 Thread Daniel Lezcano
The pid namespace is enabled by default in different distros and the different bugs were fixed when they were reported. No new bug is reported since some time now, so I guess it's safe to remove the experimental condition on this subsystem. Signed-off-by: Daniel Lezcano --- init/Kconfig |7 +

[Devel] [PATCH] Restore task fs_root and pwd (v2)

2009-12-28 Thread Serge E. Hallyn
Checkpoint and restore task->fs. Tasks sharing task->fs will share them again after restart. Changelog: Dec 28: Addressed comments by Oren (and Dave) 1. define and use {get,put}_fs_struct helpers 2. fix locking comment 3. define ckpt_read_fn

[Devel] Re: [PATCH RFC] c/r mounts ns. Except not really.

2009-12-28 Thread Serge E. Hallyn
Quoting Oren Laadan (or...@cs.columbia.edu): > > > Serge E. Hallyn wrote: > > Quoting Serge E. Hallyn (se...@us.ibm.com): > >> We only c/r a mounts ns with objref 0, meaning inherit the existing > >> mounts ns. We do intend to implement c/r of mounts and mounts > >> namespaces in the kernel. It

[Devel] Re: [PATCH 2/4] cgroups: subsystem module loading interface

2009-12-28 Thread Ben Blum
On Mon, Dec 28, 2009 at 02:32:20PM +0800, Li Zefan wrote: > > Add interface between cgroups subsystem management and module loading > > > > From: Ben Blum > > > > This patch implements rudimentary module-loading support for cgroups - > > namely, > > a cgroup_load_subsys (similar to cgroup_init_

[Devel] Re: [PATCH 3/4] cgroups: net_cls as module

2009-12-28 Thread Ben Blum
On Mon, Dec 28, 2009 at 02:34:12PM +0800, Li Zefan wrote: > > Allows the net_cls cgroup subsystem to be compiled as a module > > > > From: Ben Blum > > > > This patch modifies net/sched/cls_cgroup.c to allow the net_cls subsystem to > > be optionally compiled as a module instead of builtin. The