[Devel] Re: [PATCH v2 1/2] nfnetlink: netns support

2010-02-10 Thread Patrick McHardy
Patrick McHardy wrote: > Alexey Dobriyan wrote: >> Make nfnl socket per-petns. > > Applied, thanks. While merging the nf-next tree with the changes from net-next I noticed that this patch allows any namespace to send configurations and verdicts to nfnetlink_{log,queue}. It seems

[Devel] Re: [PATCH] xt_connlimit: netns support

2010-01-17 Thread Patrick McHardy
Alexey Dobriyan wrote: Applied, thanks. ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing list Devel@openvz.org

[Devel] Re: RFC: netfilter: nf_conntrack: add support for "conntrack zones"

2010-01-15 Thread Patrick McHardy
jamal wrote: > On Thu, 2010-01-14 at 16:37 +0100, Patrick McHardy wrote: >> jamal wrote: > >>> Agreed that this would be a main driver of such a feature. >>> Which means that you need zones (or whatever noun other people use) to >>> work on not just

[Devel] Re: RFC: netfilter: nf_conntrack: add support for "conntrack zones"

2010-01-14 Thread Patrick McHardy
ments inline: > > On Thu, 2010-01-14 at 15:05 +0100, Patrick McHardy wrote: >> The attached largish patch adds support for "conntrack zones", >> which are virtual conntrack tables that can be used to seperate >> connections from different zones, allowing to handle mu

[Devel] RFC: netfilter: nf_conntrack: add support for "conntrack zones"

2010-01-14 Thread Patrick McHardy
ould be quite small, its mainly the extra argument passing and an occasional extra comparison. Code size increase with all netfilter options enabled on x86_64 is 152 bytes. Any comments welcome. commit 7f68e7aa55f9e1f9dfd647b60dace4149f27ae1f Author: Patrick McHardy Date: Thu Jan 14 13:51:06 20

[Devel] Re: [PATCH v2 2/2] ctnetlink: netns support

2010-01-13 Thread Patrick McHardy
Alexey Dobriyan wrote: Also applied, thanks. ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing list Devel@openvz

[Devel] Re: [PATCH v2 1/2] nfnetlink: netns support

2010-01-13 Thread Patrick McHardy
Alexey Dobriyan wrote: > Make nfnl socket per-petns. Applied, thanks. ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel

[Devel] Re: [PATCH 1/2] nfnetlink: add netns support

2010-01-13 Thread Patrick McHardy
Alexey Dobriyan wrote: > On Wed, Jan 13, 2010 at 02:42:00PM +0100, Patrick McHardy wrote: >> Alexey Dobriyan wrote: >>> On Wed, Jan 13, 2010 at 02:27:08PM +0100, Patrick McHardy wrote: >>>> Alexey Dobriyan wrote: >>>>> On Wed, Jan 13, 2010 at 02:02:33P

[Devel] Re: [PATCH 1/2] nfnetlink: add netns support

2010-01-13 Thread Patrick McHardy
Alexey Dobriyan wrote: > On Wed, Jan 13, 2010 at 02:27:08PM +0100, Patrick McHardy wrote: >> Alexey Dobriyan wrote: >>> On Wed, Jan 13, 2010 at 02:02:33PM +0100, Patrick McHardy wrote: >>>> Alexey Dobriyan wrote: >>>>> + struct sock *nfnl

[Devel] Re: [PATCH 1/2] nfnetlink: add netns support

2010-01-13 Thread Patrick McHardy
Alexey Dobriyan wrote: > On Wed, Jan 13, 2010 at 02:02:33PM +0100, Patrick McHardy wrote: >> Alexey Dobriyan wrote: > >>> + struct sock *nfnl; >>> + struct sock *nfnl_stash; >> Shouldn't this be contained in an ifdef(CONFIG_

[Devel] Re: [PATCH 1/2] nfnetlink: add netns support

2010-01-13 Thread Patrick McHardy
Alexey Dobriyan wrote: > Make nfnetlink socket per-netns. > > --- a/include/net/net_namespace.h > +++ b/include/net/net_namespace.h > @@ -81,6 +81,8 @@ struct net { > #if defined(CONFIG_NF_CONNTRACK) || defined(CONFIG_NF_CONNTRACK_MODULE) > struct netns_ct ct; > #endif > + stru

[Devel] Re: [PATCH 2/2] ctnetlink: add netns support

2010-01-13 Thread Patrick McHardy
Alexey Dobriyan wrote: > Allow conntrack program to operate correctly in netns. > Note: passing events is not done in this patch. Why not? It seems like a small change and without this the netns support will still be incomplete. ___ Containers mailing l

[Devel] Re: [PATCH 5/7] netns ebtables: ebtable_filter in netns

2008-11-04 Thread Patrick McHardy
Alexey Dobriyan wrote: Applied, thanks. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing list Devel@openvz.org https://openvz.org/

[Devel] Re: [PATCH 7/7] netns ebtables: br_nf_pre_routing_finish() fixup

2008-11-04 Thread Patrick McHardy
Alexey Dobriyan wrote: Also applied, thanks. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing list Devel@openvz.org https://openvz.

[Devel] Re: [PATCH 4/7] netns ebtables: ebtable_broute in netns

2008-11-04 Thread Patrick McHardy
Alexey Dobriyan wrote: Applied, thanks. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing list Devel@openvz.org https://openvz.org/m

[Devel] Re: [PATCH 6/7] netns ebtables: ebtable_nat in netns

2008-11-04 Thread Patrick McHardy
Alexey Dobriyan wrote: Applied, thanks. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing list Devel@openvz.org https://openvz.org/m

[Devel] Re: [PATCH 3/7] netns ebtables: more cleanup during ebt_unregister_table()

2008-11-04 Thread Patrick McHardy
Alexey Dobriyan wrote: > Now that ebt_unregister_table() can be called during netns stop, and module > pinning scheme can't prevent netns stop, do table cleanup by hand. > Applied, thanks. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linu

[Devel] Re: [PATCH 2/7] netns ebtables: part 2

2008-11-04 Thread Patrick McHardy
Alexey Dobriyan wrote: > * return ebt_table from ebt_register_table(), module code will save it into > per-netns data for unregistration > * duplicate ebt_table at the very beginning of registration -- it's added into > list, so one ebt_table wouldn't end up in many lists (and each netns has >

[Devel] Re: [PATCH 1/7] netns ebtables: part 1

2008-11-04 Thread Patrick McHardy
Alexey Dobriyan wrote: > * propagate netns from userspace, register table in passed netns > * remporarily register every ebt_table in init_net > > P. S.: one needs to add ".netns_ok = 1" to igmp_protocol to test with > ebtables(8) in netns. Applied, thanks. _

[Devel] Re: [PATCH 1/7] netns ebtables: part 1

2008-10-29 Thread Patrick McHardy
Alexey Dobriyan wrote: > * propagate netns from userspace, register table in passed netns > * remporarily register every ebt_table in init_net > > P. S.: one needs to add ".netns_ok = 1" to igmp_protocol to test with > ebtables(8) in netns. The containers list address bounces and the netfilter ad

[Devel] Re: [PATCH 1/7] netns ebtables: part 1

2008-10-21 Thread Patrick McHardy
Alexey Dobriyan wrote: > On Wed, Oct 15, 2008 at 08:20:14AM +0400, Alexey Dobriyan wrote: >> One needs to add ".netns_ok = 1" to igmp_protocol to test all of this >> with ebtables() in netns. > > Contains 80-column violations, I forgot about damn script again :^) Apart from the minor comment abou

[Devel] Re: [PATCH 1/7] netns ebtables: part 1

2008-10-21 Thread Patrick McHardy
se you would like to add an ACK). commit c985d88e7ae4f45d50cca80033429c7270a8c185 Author: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu Oct 16 13:14:26 2008 +0200 netfilter: netns: use NFPROTO_NUMPROTO instead of NUMPROTO for tables array The netfilter families have b

[Devel] Re: [bug, -git] ERROR: "ebt_unregister_table" [net/bridge/netfilter/ebtable_nat.ko] undefined

2008-10-14 Thread Patrick McHardy
Ingo Molnar wrote: > * Patrick McHardy <[EMAIL PROTECTED]> wrote: > >> Ingo Molnar wrote: >>> i think you misunderstood my report. This is about latest upstream -git >>> being broken: >>> >>> ERROR: "ebt_register_table" [n

[Devel] Re: [bug, -git] ERROR: "ebt_unregister_table" [net/bridge/netfilter/ebtable_nat.ko] undefined

2008-10-14 Thread Patrick McHardy
Ingo Molnar wrote: i think you misunderstood my report. This is about latest upstream -git being broken: ERROR: "ebt_register_table" [net/bridge/netfilter/ebtable_filter.ko] undefined! ERROR: "ebt_do_table" [net/bridge/netfilter/ebtable_filter.ko] undefined! ERROR: "ebt_unregister_table" [net/b

[Devel] Re: [PATCH 33/33] Enable netfilter in netns

2008-10-02 Thread Patrick McHardy
Alexey Dobriyan wrote: > On Thu, Oct 02, 2008 at 11:12:08AM +0200, Patrick McHardy wrote: > >> Is there an easy way to test all this stuff? >> > > I used the following: > > 0) netns is currently mutually exclusive with sysfs, so depending on >sanity of

[Devel] Re: [PATCH 33/33] Enable netfilter in netns

2008-10-02 Thread Patrick McHardy
Alexey Dobriyan wrote: > >From kernel perspective, allow entrance in nf_hook_slow(). > > Stuff which uses nf_register_hook/nf_register_hooks, but otherwise not > netns-ready: > > DECnet netfilter > ipt_CLUSTERIP > nf_nat_standalone.c together with XFRM (?) > IPVS > se

[Devel] Re: [PATCH 31/33] netns ct: fixup DNAT in netns

2008-10-02 Thread Patrick McHardy
Alexey Dobriyan wrote: Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing list Devel@openvz.org https://openvz.org/mailman/l

[Devel] Re: [PATCH 32/33] netns nat: PPTP NAT in netns

2008-10-02 Thread Patrick McHardy
Alexey Dobriyan wrote: Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing list Devel@openvz.org https://openvz.org/mailman/l

[Devel] Re: [PATCH 29/33] netns nat: per-netns NAT table

2008-10-02 Thread Patrick McHardy
Alexey Dobriyan wrote: > Same story as with iptable_filter, iptables_raw tables. Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel

[Devel] Re: [PATCH 30/33] netns nat: per-netns bysource hash

2008-10-02 Thread Patrick McHardy
Alexey Dobriyan wrote: Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing list Devel@openvz.org https://openvz.org/mailman/l

[Devel] Re: [PATCH 28/33] netns nat: fix ipt_MASQUERADE in netns

2008-10-02 Thread Patrick McHardy
Alexey Dobriyan wrote: > First, allow entry in notifier hook. > Second, start conntrack cleanup in netns to which netdevice belongs. Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers __

[Devel] Re: [PATCH 29/33] netns nat: per-netns NAT table

2008-10-02 Thread Patrick McHardy
Alexey Dobriyan wrote: > Same story as with iptable_filter, iptables_raw tables. > Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers ___

[Devel] Re: [PATCH 27/33] netns ct: PPTP conntracking in netns

2008-10-02 Thread Patrick McHardy
Alexey Dobriyan wrote: Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing list Devel@openvz.org https://openvz.org/mailman/l

[Devel] Re: [PATCH 26/33] netns ct: GRE conntracking in netns

2008-10-02 Thread Patrick McHardy
Alexey Dobriyan wrote: > * make keymap list per-netns > * per-netns keymal lock (not strictly necessary) > * flush keymap at netns stop and module unload. Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/l

[Devel] Re: [PATCH 25/33] netns ct: H323 conntracking in netns

2008-10-02 Thread Patrick McHardy
Alexey Dobriyan wrote: Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing list Devel@openvz.org https://openvz.org/mailman/l

[Devel] Re: [PATCH 24/33] netns ct: SIP conntracking in netns

2008-10-02 Thread Patrick McHardy
Alexey Dobriyan wrote: Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing list Devel@openvz.org https://openvz.org/mailman/l

[Devel] Re: [PATCH v2 7/6] netns ct: final netns tweaks

2008-10-02 Thread Patrick McHardy
Alexey Dobriyan wrote: > Add init_net checks to not remove kmem_caches twice and so on. > > Refactor functions to split code which should be executed only for > init_net into one place. > > ip_ct_attach and ip_ct_destroy assignments remain separate, because > they're separate stages in setup and te

[Devel] Re: [PATCH v2 2/6] netns ct: per-netns /proc/net/stat/nf_conntrack , /proc/net/stat/ip_conntrack

2008-10-02 Thread Patrick McHardy
Alexey Dobriyan wrote: > Show correct conntrack count, while I'm at it. Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing

[Devel] Re: [PATCH v2 6/6] netns ct: per-netns conntrack accounting

2008-10-02 Thread Patrick McHardy
Alexey Dobriyan wrote: > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> > --- > > include/net/netfilter/nf_conntrack_acct.h | 10 +-- > include/net/netns/conntrack.h |2 > net/netfilter/nf_conntrack_acct.c | 100 > +- > net/netfilter/nf_

[Devel] Re: [PATCH v2 4/6] netns ct: per-netns net.netfilter.nf_conntrack_checksum sysctl

2008-10-02 Thread Patrick McHardy
Alexey Dobriyan wrote: > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> > --- > > include/net/netfilter/nf_conntrack.h |1 - > include/net/netns/conntrack.h |1 + > net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c |2 +- > net/ipv4/netfilter/nf_conntrack_pr

[Devel] Re: [PATCH v2 3/6] netns ct: per-netns net.netfilter.nf_conntrack_count sysctl

2008-10-02 Thread Patrick McHardy
Alexey Dobriyan wrote: > Note, sysctl table is always duplicated, this is simpler and less > special-cased. > > Applied. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers ___

[Devel] Re: [PATCH v2 5/6] netns ct: per-netns net.netfilter.nf_conntrack_log_invalid sysctl

2008-10-02 Thread Patrick McHardy
Alexey Dobriyan wrote: > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> > --- > > include/net/netfilter/nf_conntrack_l4proto.h | 15 +++ > include/net/netns/conntrack.h |1 + > net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c |2 +- > net/ipv4/netfilter/n

[Devel] Re: [PATCH v2 1/6] netns ct: per-netns statistics

2008-10-02 Thread Patrick McHardy
Alexey Dobriyan wrote: > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> > --- > > include/net/netfilter/nf_conntrack.h |8 +- > include/net/netns/conntrack.h |1 > net/ipv4/netfilter/nf_conntrack_l3proto_ipv4_compat.c |4 - > net/netfilter/

[Devel] Re: [PATCH 17/33] netns ct: final init_net tweaks

2008-09-28 Thread Patrick McHardy
Alexey Dobriyan wrote: > Ping! > > I've just sent patch which adds init_net checks in somewhat nicer way. Thanks. > Please, review and apply the rest. I'll do that this week during the netfilter workshop. ___ Containers mailing list [EMAIL PROTECTED

[Devel] Re: [PATCH 17/33] netns ct: final init_net tweaks

2008-09-09 Thread Patrick McHardy
Alexey Dobriyan wrote: > On Tue, Sep 09, 2008 at 09:20:42AM +0200, Patrick McHardy wrote: >> Having multiple of these net_eq checks per function (14 total) is >> not a very nice way to do this. > > Yep, I was just afraid of some subtle ordering rules and to keep > potent

[Devel] Re: [PATCH 17/33] netns ct: final init_net tweaks

2008-09-09 Thread Patrick McHardy
Alexey Dobriyan wrote: > Add checks for init_net to not create kmem caches twice and so on. > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> > > diff --git a/net/netfilter/nf_conntrack_core.c > b/net/netfilter/nf_conntrack_core.c > index b55944e..52d0663 100644 > --- a/net/netfilter/nf_con

[Devel] Re: [PATCH 16/33] netns ct: per-netns event cache

2008-09-09 Thread Patrick McHardy
Patrick McHardy wrote: > Alexey Dobriyan wrote: >> On Tue, Sep 09, 2008 at 08:12:27AM +0200, Patrick McHardy wrote: >>> Alexey Dobriyan wrote: >>>> Heh, last minute proof-reading of this patch made me think, >>>> that this is actually unneeded, simply be

[Devel] Re: [PATCH 05/33] netns ct: per-netns expectations

2008-09-09 Thread Patrick McHardy
Alexey Dobriyan wrote: > On Tue, Sep 09, 2008 at 07:49:34AM +0200, Patrick McHardy wrote: >>> @@ -406,7 +404,7 @@ int nf_ct_expect_related(struct nf_conntrack_expect >>> *expect) >>> } >>> } >>> - if (nf_ct_expect_count >= n

[Devel] Re: [PATCH 16/33] netns ct: per-netns event cache

2008-09-09 Thread Patrick McHardy
Alexey Dobriyan wrote: > On Tue, Sep 09, 2008 at 08:12:27AM +0200, Patrick McHardy wrote: >> Alexey Dobriyan wrote: >>> Heh, last minute proof-reading of this patch made me think, >>> that this is actually unneeded, simply because "ct" pointers will be >

[Devel] Re: [PATCH 16/33] netns ct: per-netns event cache

2008-09-08 Thread Patrick McHardy
Alexey Dobriyan wrote: > Heh, last minute proof-reading of this patch made me think, > that this is actually unneeded, simply because "ct" pointers will be > different for different conntracks in different netns, just like they > are different in one netns. > > Not so sure anymore. Its necessary

[Devel] Re: [PATCH 15/33] netns ct: pass conntrack to nf_conntrack_event_cache() not skb

2008-09-08 Thread Patrick McHardy
Alexey Dobriyan wrote: > This is cleaner, we already know conntrack to which event is relevant. Applied, thanks. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers ___

[Devel] Re: [PATCH 14/33] netns ct: cleanup after L3 and L4 proto unregister in every netns

2008-09-08 Thread Patrick McHardy
Alexey Dobriyan wrote: Applthanks. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing list Devel@openvz.org https://openvz.org/mailma

[Devel] Re: [PATCH 12/33] netns ct: export netns list

2008-09-08 Thread Patrick McHardy
Alexey Dobriyan wrote: > Conntrack code will use it for > a) removing expectations and helpers when corresponding module is removed, and > b) removing conntracks when L3 protocol conntrack module is removed. Applied, thanks. ___ Containers mailing list [

[Devel] Re: [PATCH 13/33] netns ct: unregister helper in every netns

2008-09-08 Thread Patrick McHardy
Alexey Dobriyan wrote: Applied, thanks. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing list Devel@openvz.org https://openvz.org/m

[Devel] Re: [PATCH 10/33] netns ct: per-netns /proc/net/nf_conntrack_expect

2008-09-08 Thread Patrick McHardy
Alexey Dobriyan wrote: Applied, thanks. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing list Devel@openvz.org https://openvz.org/m

[Devel] Re: [PATCH 11/33] netns ct: per-netns /proc/net/ip_conntrack, /proc/net/stat/ip_conntrack, /proc/net/ip_conntrack_expect

2008-09-08 Thread Patrick McHardy
Alexey Dobriyan wrote: Applied, thanks. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing list Devel@openvz.org https://openvz.org/m

[Devel] Re: [PATCH 09/33] netns ct: per-netns /proc/net/nf_conntrack, /proc/net/stat/nf_conntrack

2008-09-08 Thread Patrick McHardy
Alexey Dobriyan wrote: Applied, thanks. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing list Devel@openvz.org https://openvz.org/

[Devel] Re: [PATCH 08/33] netns ct: pass netns pointer to L4 protocol's ->error hook

2008-09-08 Thread Patrick McHardy
Alexey Dobriyan wrote: > Again, it's deducible from skb, but we're going to use it for > nf_conntrack_checksum and statistics, so just pass it from upper layer. Applied, thanks. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation

[Devel] Re: [PATCH 07/33] netns ct: pass netns pointer to nf_conntrack_in()

2008-09-08 Thread Patrick McHardy
Alexey Dobriyan wrote: > It's deducible from skb->dev or skb->dst->dev, but we know netns at > the moment of call, so pass it down and use for finding and creating > conntracks. Applied, thanks. ___ Containers mailing list [EMAIL PROTECTED] https://lists

[Devel] Re: [PATCH 06/33] netns ct: per-netns unconfirmed list

2008-09-08 Thread Patrick McHardy
Alexey Dobriyan wrote: > What is confirmed connection in one netns can very well be unconfirmed > in another one. Applied, thanks. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _

[Devel] Re: [PATCH 05/33] netns ct: per-netns expectations

2008-09-08 Thread Patrick McHardy
Alexey Dobriyan wrote: > Make per-netns a) expectation hash and b) expectations count. > > Expectations always belongs to netns to which it's master conntrack belong. > This is natural and doesn't bloat expectation. > > Proc files and leaf users are stubbed to init_net, this is temporary. Looks

[Devel] Re: [PATCH 04/33] Fix {ip,6}_route_me_harder() in netns

2008-09-08 Thread Patrick McHardy
Alexey Dobriyan wrote: > Take netns from skb->dst->dev. It should be safe because, they are called > from LOCAL_OUT hook where dst is valid (though, I'm not exactly sure about > IPVS and queueing packets to userspace). Its safe in all cases since they already expect to only get called when skb->ds

[Devel] Re: [PATCH 03/33] nf_conntrack_gre: nf_ct_gre_keymap_flush() fixlet

2008-09-08 Thread Patrick McHardy
Alexey Dobriyan wrote: > It does "kfree(list_head)" which looks wrong because entity that was > allocated is definitely not list_head. > > However, this all works because list_head is first item in > struct nf_ct_gre_keymap . The first three patches are already in Linus' tree. ___

[Devel] Re: [PATCH 20/38] netns ct: NOTRACK in netns

2008-09-05 Thread Patrick McHardy
Jan Engelhardt wrote: > On Friday 2008-09-05 08:25, Patrick McHardy wrote: >>>> I hope so :) A different possiblity suggest by Pablo some time ago >>>> would be to mark untracked packets in skb->nfctinfo and not >>>> attach a conntrack at all. >>&g

[Devel] Re: [PATCH 20/38] netns ct: NOTRACK in netns

2008-09-05 Thread Patrick McHardy
Pablo Neira Ayuso wrote: > Patrick McHardy wrote: >>>> I think you could avoid this mess by using a struct nf_conntrack >>>> for the untracked conntrack instead of struct nf_conn. It shouldn't >>>> make any difference since its ignored anyways.

[Devel] Re: [PATCH 20/38] netns ct: NOTRACK in netns

2008-09-05 Thread Patrick McHardy
Alexey Dobriyan wrote: > On Thu, Sep 04, 2008 at 06:54:16PM +0200, Patrick McHardy wrote: >> [EMAIL PROTECTED] wrote: >>> Make untracked conntrack per-netns. Compare conntracks with relevant >>> untracked one. >>> >>> The following code you'll sta

[Devel] Re: [PATCH 21/25] netns ct: per-netns event cache

2008-09-05 Thread Patrick McHardy
Alexey Dobriyan wrote: > On Thu, Sep 04, 2008 at 06:58:38PM +0200, Patrick McHardy wrote: >> [EMAIL PROTECTED] wrote: >>> static inline void >>> -nf_conntrack_event_cache(enum ip_conntrack_events event, >>> +nf_conntrack_event_cache(struct net

[Devel] Re: [PATCH 25/38] netns ct: honest net.netfilter.nf_conntrack_count

2008-09-04 Thread Patrick McHardy
[EMAIL PROTECTED] wrote: > Note, sysctl table is always duplicated, this is simpler, less special-cased, > less mistakes (and did one mistake in first version of this patch). This also doesn't explain what the patch is doing at all. ___ Containers mailin

[Devel] Re: [PATCH 21/25] netns ct: per-netns event cache

2008-09-04 Thread Patrick McHardy
[EMAIL PROTECTED] wrote: > static inline void > -nf_conntrack_event_cache(enum ip_conntrack_events event, > +nf_conntrack_event_cache(struct net *net, enum ip_conntrack_events event, >const struct sk_buff *skb) > { Passing the conntrack instead of the struct net and the s

[Devel] Re: [PATCH 24/38] netns ct: per-netns statistics in proc

2008-09-04 Thread Patrick McHardy
[EMAIL PROTECTED] wrote: > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Changelog please, I was wondering whether this was a resend of the last one. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/c

[Devel] Re: [PATCH 20/38] netns ct: NOTRACK in netns

2008-09-04 Thread Patrick McHardy
[EMAIL PROTECTED] wrote: > Make untracked conntrack per-netns. Compare conntracks with relevant > untracked one. > > The following code you'll start laughing at this code: > > if (ct == ct->ct_net->ct.untracked) > ... > > let me remind you that ->ct_net is set in only one pla

[Devel] Re: [PATCH 10/38] netns ct: per-netns expectations

2008-09-04 Thread Patrick McHardy
[EMAIL PROTECTED] wrote: > Make per-netns expectation hash and expectation count. > > Expectation always belongs to netns to which it's master conntrack belongs. > This is natural and allows to not bloat expectations. > > Proc files and leaf users in protocol modules are stubbed to init_net, > th

[Devel] Re: [PATCH 11/38] netns ct: per-netns unconfirmed hash

2008-09-04 Thread Patrick McHardy
[EMAIL PROTECTED] wrote: > What is unconfirmed connection in one netns can very well be confirmed > in another. > > @@ -10,5 +11,6 @@ struct netns_ct { > unsigned intexpect_count; > struct hlist_head *expect_hash; > int expect_vmalloc; > +

[Devel] Re: [PATCH 09/38] netns ct: per-netns conntrack hash

2008-09-04 Thread Patrick McHardy
[EMAIL PROTECTED] wrote: > * make per-netns conntrack hash > > Other solution is to add ->ct_net pointer to tuplehashes and still has one > hash, I tried that it's ugly and requires more code deep down in protocol > modules et al. > > * propagate netns pointer to where needed, e. g. to conn

[Devel] Re: [PATCH 08/38] netns ct: per-netns conntrack count

2008-09-04 Thread Patrick McHardy
[EMAIL PROTECTED] wrote: > Sysctls and proc files are stubbed to init_net's one. This is temporary. Applied, thanks. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers ___

[Devel] Re: [PATCH 07/38] netns ct: add ->ct_net -- pointer from conntrack to netns

2008-09-04 Thread Patrick McHardy
[EMAIL PROTECTED] wrote: > Conntrack (struct nf_conn) gets pointer to netns: ->ct_net -- netns in which > it was created. It comes from netdevice. > > ->ct_net is write-once field. > > Every conntrack in system has ->ct_net initialized, no exceptions. > > ->ct_net doesn't pin netns: conntracks a

[Devel] Re: [PATCH 05/38] Fix ip{,6}_route_me_harder() in netns

2008-09-04 Thread Patrick McHardy
[EMAIL PROTECTED] wrote: > ip_route_me_harder() is called on output codepaths: > 1) IPVS: honestly, not sure, looks like it can be called during forwarding > 2) IPv4 REJECT: refreshing comment re skb->dst is valid and assigment of >skb->dst right before call :^) > 3) NAT: called in LOCAL_OUT ho

[Devel] Re: [PATCH 06/37] netns ct: add netns boilerplate

2008-09-04 Thread Patrick McHardy
[EMAIL PROTECTED] wrote: > One comment: #ifdefs around #include is necessary to overcome amazing compile > breakages in NOTRACK-in-netns patch (see below). I guess thats because of the net/netfilter/nf_conntrack.h inclusion. We should fix that, its spreading to too many places. Anyways, applied.

[Devel] Re: [PATCH 03/38] netns nf: ip6table_mangle in netns for real

2008-09-04 Thread Patrick McHardy
[EMAIL PROTECTED] wrote: > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied, thanks. > @@ -108,7 +120,7 @@ ip6t_local_hook(unsigned int hook, > /* flowlabel and prio (includes version, which shouldn't change either > */ > flowlabel = *((u_int32_t *)ipv6_hdr(skb)); > > -

[Devel] Re: [PATCH 04/38] netns nf: ip6t_REJECT in netns for real

2008-09-04 Thread Patrick McHardy
[EMAIL PROTECTED] wrote: > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied, thanks. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers ___ D

[Devel] Re: [PATCH 02/38] netns nf: ip6table_raw in netns for real

2008-09-04 Thread Patrick McHardy
[EMAIL PROTECTED] wrote: > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied, thanks. ___ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers ___ D

[Devel] Re: [PATCH 01/38] netns nf: remove nf_*_net() wrappers

2008-09-04 Thread Patrick McHardy
[EMAIL PROTECTED] wrote: > Now that dev_net() exists, the usefullness of them is even less. Also they're > a big problem in resolving circular header dependencies necessary for > NOTRACK-in-netns patch. See below. Applied, thanks. ___ Containers mailing

[Devel] Re: unlock iptables in netns

2008-06-21 Thread Patrick McHardy
Alexey Dobriyan wrote: On Mon, Jun 16, 2008 at 01:16:00PM +0200, Patrick McHardy wrote: Alexey Dobriyan wrote: On Mon, Jun 16, 2008 at 12:26:03PM +0200, Patrick McHardy wrote: By the way, is there already work done for conntrack/NAT namespace support? I have this patch that uses marks for

[Devel] Re: unlock iptables in netns

2008-06-16 Thread Patrick McHardy
Pavel Emelyanov wrote: Patrick McHardy wrote: Alexey Dobriyan wrote: On Mon, Jun 16, 2008 at 12:26:03PM +0200, Patrick McHardy wrote: By the way, is there already work done for conntrack/NAT namespace support? I have this patch that uses marks for something very similar that should be easy to

[Devel] Re: unlock iptables in netns

2008-06-16 Thread Patrick McHardy
Alexey Dobriyan wrote: On Mon, Jun 16, 2008 at 12:26:03PM +0200, Patrick McHardy wrote: By the way, is there already work done for conntrack/NAT namespace support? I have this patch that uses marks for something very similar that should be easy to adjust. Yes, right now I'm fig

[Devel] Re: unlock iptables in netns

2008-06-16 Thread Patrick McHardy
Patrick McHardy wrote: Alexey Dobriyan wrote: Hi, Den basically banned iptables in netns via this patch --- a/net/netfilter/core.c +++ b/net/netfilter/core.c ... , however, at least some of netfilter pieces are ready for usage in netns and it would be nice to unlock them before release. If

[Devel] Re: unlock iptables in netns

2008-06-10 Thread Patrick McHardy
Alexey Dobriyan wrote: Hi, Den basically banned iptables in netns via this patch --- a/net/netfilter/core.c +++ b/net/netfilter/core.c ... , however, at least some of netfilter pieces are ready for usage in netns and it would be nice to unlock them before release. If I'm deciphering chengelog

[Devel] Re: [PATCH] nf_conntrack: fix error path unwind in nf_conntrack_expect_init()

2008-05-22 Thread Patrick McHardy
Alexey Dobriyan wrote: Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- net/netfilter/nf_conntrack_expect.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks Alexey. I'll also push this to -stable. ___ Devel mailing

[Devel] Re: [PATCH 6/14][RTNL]: Introduce the rtnl_kill_links call.

2008-04-11 Thread Patrick McHardy
Pavel Emelyanov wrote: >>> for_each_net(net) { >>> -restart: >>> - for_each_netdev_safe(net, dev, n) { >>> - if (dev->rtnl_link_ops == ops) { >>> - ops->dellink(dev); >>> - goto restart; >>> - } >>

[Devel] Re: [PATCH][VLAN]: Fix egress priority mappings leak.

2008-04-04 Thread Patrick McHardy
d during testing vlan netnsization patchset. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Good catch, thanks. Acked-by: Patrick McHardy <[EMAIL PROTECTED]> ___ Devel mailing list Devel@openvz.org https://openvz.org/mailman/listinfo/devel

[Devel] Re: [PATCH][VLAN]: Proc entry is not renamed when vlan device name changes.

2008-03-31 Thread Patrick McHardy
Pavel Emelyanov wrote: This may lead to situations, when each of two proc entries produce data for the other's device. Looks like a BUG, so this patch is for net-2.6. It will not apply to net-2.6.26 since dev->nd_net access is replaced with dev_net(dev) one. Should I rework the patch to fit 2.

[Devel] Re: [PATCH] NETFILTER: per-netns FILTER/MANGLE/RAW tables for real

2008-03-20 Thread Patrick McHardy
Alexey Dobriyan wrote: Commit 9335f047fe61587ec82ff12fbb1220bcfdd32006 aka "[NETFILTER]: ip_tables: per-netns FILTER, MANGLE, RAW" added per-netns _view_ of iptables rules. They were shown to user, but ignored by filtering code. Now that it's possible to at least ping loopback, per-netns tables c

[Devel] Re: [PATCH] Don't limit the number of tunnels with generic name explicitly.

2008-02-21 Thread Patrick McHardy
Pavel Emelyanov wrote: Patrick McHardy wrote: Pavel Emelyanov wrote: Patrick McHardy wrote: It would be nicer to replace the entire hand-made name allocation to remove the 100 device limit. Actually, I thought the same, but fixing % in names looks like a BUG-fix for 2.6.25, while removing

[Devel] Re: [PATCH] Don't create tunnels with '%' in name.

2008-02-21 Thread Patrick McHardy
Pavel Emelyanov wrote: Patrick McHardy wrote: It would be nicer to replace the entire hand-made name allocation to remove the 100 device limit. Actually, I thought the same, but fixing % in names looks like a BUG-fix for 2.6.25, while removing the hand-made name allocation looks like an

[Devel] Re: [PATCH] Don't create tunnels with '%' in name.

2008-02-21 Thread Patrick McHardy
Pavel Emelyanov wrote: Four tunnel drivers (ip_gre, ipip, ip6_tunnel and sit) can receive a pre-defined name for a device from the userspace. Since these drivers call the register_netdevice() after this (rtnl_lock is held), the device's name may contain a '%' character. Not sure how bad is th

[Devel] Re: [PATCH 3/17 net-2.6.26] [NETFILTER]: Consolidate masq_inet_event and masq_device_event.

2008-02-19 Thread Patrick McHardy
Denis V. Lunev wrote: They do exactly the same job. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/netfilter/ipt_MASQUERADE.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) Looks fine. ___ Devel mailing lis

[Devel] Re: [PATCH 2/3] netns netfilter: netns propagation for /proc/net/*_tables_names

2008-01-30 Thread Patrick McHardy
Alexey Dobriyan wrote: Propagate netns together with AF down to ->start/->next/->stop iterators. Choose table based on netns and AF for showing. Applied. ___ Devel mailing list Devel@openvz.org https://openvz.org/mailman/listinfo/devel

[Devel] Re: [PATCH 3/3] netns netfilter: create per-netns /proc/net/*_tables_*

2008-01-30 Thread Patrick McHardy
Alexey Dobriyan wrote: Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- include/linux/netfilter/x_tables.h |4 ++-- net/ipv4/netfilter/arp_tables.c| 21 ++--- net/ipv4/netfilter/ip_tables.c | 21 ++--- net/ipv6/netfilter/ip6_tables.c|

[Devel] Re: [PATCH 1/3] netns netfilter: semi-rewrite of /proc/net/foo_tables_*

2008-01-30 Thread Patrick McHardy
Alexey Dobriyan wrote: Argh, there are many small but still wrong things with /proc/net/*_tables_* so I decided to do overhaul simultaneously making it more suitable for per-netns /proc/net/*_tables_* implementation. Fix a) xt_get_idx() duplicating now standard seq_list_start/seq_list_next it

[Devel] Re: [PATCH 5/5] netns netfilter: put table module on netns stop

2008-01-24 Thread Patrick McHardy
Alexey Dobriyan wrote: When number of entries exceeds number of initial entries, foo-tables code will pin table module. But during table unregister on netns stop, that additional pin was forgotten. Applied, thanks. ___ Devel mailing list Devel@openv

  1   2   >