Re: [PATCH 00/26] leon: various fixes and TN0018 errata workaround

Hello, I added two tickets for the errata fixes: https://devel.rtems.org/ticket/4155 https://devel.rtems.org/ticket/4156 -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail :

Re: [PATCH 01/26] sparc: Remove sequences that the B2BST scan script warns about

On 29/06/2020 13:27, Daniel Hellstrom wrote: From: Daniel Cederman --- cpukit/score/cpu/sparc/cpu_asm.S | 6 -- cpukit/score/cpu/sparc/syscall.S | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/cpukit/score/cpu/sparc/cpu_asm.S b/cpukit/score/cpu/sparc/cpu_asm.S

Re: [PATCH 08/26] leon, can: introduce common CAN baud-rate calculation function

Hello Daniel, On 29/06/2020 14:27, Sebastian Huber wrote: On 29/06/2020 14:22, Daniel Hellstrom wrote: On 2020-06-29 13:48, Sebastian Huber wrote: On 29/06/2020 13:27, Daniel Hellstrom wrote: +/* + *  COPYRIGHT (c) 2019. + *  Cobham Gaisler AB. + * + *  The license and distribution terms

Re: [PATCH 26/26] leon,tn-0018: work around GRLIB-TN-0018 errata

On 23/09/2020 12:24, Daniel Hellstrom wrote: >> Command line defines are discouraged and in cpukit only multilib >> defined defines should be used. Can't you the existing >> __FIX_LEON3FT_B2BST define to enable the errata workarounds? > > For UT700, for example, it is true

Re: [rtems commit] rtems-fdt / shell - Fix string truncation warning

On 16/10/20 3:47 pm, Sebastian Huber wrote: > On 16/10/2020 06:38, Chris Johns wrote: >>> * has no tests, >> And all the other commands have tests? > > No, so this is admittedly not a very strong argument. > > It is a general problem that the shell code has little to no test coverage. > Fixing

Re: [rtems commit] rtems-fdt / shell - Fix string truncation warning

On 16/10/2020 06:38, Chris Johns wrote: * has no tests, And all the other commands have tests? No, so this is admittedly not a very strong argument. It is a general problem that the shell code has little to no test coverage. Fixing bugs and warnings in this area is always a bit risky. Most

Re: set_vector() on SPARC

On 16/10/20 3:30 pm, Sebastian Huber wrote: > On 16/10/2020 03:09, Chris Johns wrote: >> On 16/10/20 4:57 am, Sebastian Huber wrote: >>> I suggest to remove this function and replace it with >>> rtems_interrupt_catch() >>> and add the interrupt enable to rtems_interrupt_catch(). >> Which BSPs

Re: [rtems commit] rtems-fdt / shell - Fix string truncation warning

On 16/10/20 3:28 pm, Sebastian Huber wrote: > On 16/10/2020 01:36, Chris Johns wrote: >> On 16/10/20 4:23 am, Sebastian Huber wrote: >>> >>> rtems-fdt.c, rtems-fdt-shell.c and cpukit/include/rtems/rtems-fdt.h >>> seem to be dead code. They implement a shell command `fdt` but that >>> command is

Re: set_vector() on SPARC

On 16/10/2020 03:09, Chris Johns wrote: On 16/10/20 4:57 am, Sebastian Huber wrote: I suggest to remove this function and replace it with rtems_interrupt_catch() and add the interrupt enable to rtems_interrupt_catch(). Which BSPs will this effect? All SPARC BSPs. What testing on real

Re: [rtems commit] rtems-fdt / shell - Fix string truncation warning

On 16/10/2020 01:36, Chris Johns wrote: On 16/10/20 4:23 am, Sebastian Huber wrote: rtems-fdt.c, rtems-fdt-shell.c and cpukit/include/rtems/rtems-fdt.h seem to be dead code. They implement a shell command `fdt` but that command is not part of the shell nor of any macro in

Re: Need help debugging sp16.exe

> > Your scheduler is a unique piece of software. It may be making assumptions > that are not checked in the generic scheduler code. And checks in other > schedulers are of no use to you. > There may not be any but this is something to consider. There are existing > checks scattered throughout the

Re: set_vector() on SPARC

On 16/10/20 4:57 am, Sebastian Huber wrote: > I suggest to remove this function and replace it with rtems_interrupt_catch() > and add the interrupt enable to rtems_interrupt_catch(). Which BSPs will this effect? What testing on real hardware will there be? Chris

Re: [rtems commit] rtems-fdt / shell - Fix string truncation warning

On 16/10/20 4:23 am, Sebastian Huber wrote: > > rtems-fdt.c, rtems-fdt-shell.c and cpukit/include/rtems/rtems-fdt.h > seem to be dead code. They implement a shell command `fdt` but that > command is not part of the shell nor of any macro in > cpukit/include/rtems/shellconfig.h. This comment is

Re: [PATCH] rtems-fdt / shell - Fix string truncation warning

On 16/10/20 7:24 am, Joel Sherrill wrote: > On Thu, Oct 15, 2020 at 2:13 PM Chris Johns > wrote: > On 15/10/20 10:27 pm, Frank Kuehndel wrote: > > From: Frank Kühndel > > > > > The compiler warning was: >

Re: [PATCH] rtems-fdt / shell - Fix string truncation warning

On Thu, Oct 15, 2020 at 2:13 PM Chris Johns wrote: > On 15/10/20 10:27 pm, Frank Kuehndel wrote: > > From: Frank Kühndel > > > > The compiler warning was: > > > > ../../../cpukit/libmisc/rtems-fdt/rtems-fdt.c:267:5: warning: > > 'strncpy' specified bound depends on the length of the source

Re: RTEMS 5.1 pc686 BSP malloc_info problem?

On 16/10/20 6:16 am, Alan Cudmore wrote: > On Thu, Oct 15, 2020 at 3:03 PM Chris Johns wrote: >> The number of bits needs to align to a value that fits the whole 32 bit mask >> so >> the last is used to trigger the bug. > > How can I calculate this? The number of bits in a bitmap is the

Re: RTEMS 5.1 pc686 BSP malloc_info problem?

On Thu, Oct 15, 2020 at 3:03 PM Chris Johns wrote: > > On 16/10/20 5:22 am, Alan Cudmore wrote: > > On Thu, Oct 15, 2020 at 11:19 AM Gedare Bloom wrote: > >> > >> On Thu, Oct 15, 2020 at 6:35 AM Joel Sherrill wrote: > >>> > >>> > >>> > >>> On Thu, Oct 15, 2020, 7:15 AM Alan Cudmore wrote: >

Re: [PATCH] rtems-fdt / shell - Fix string truncation warning

On 15/10/20 10:27 pm, Frank Kuehndel wrote: > From: Frank Kühndel > > The compiler warning was: > > ../../../cpukit/libmisc/rtems-fdt/rtems-fdt.c:267:5: warning: > 'strncpy' specified bound depends on the length of the source argument > 267 | strncpy(path, name, namelen); > |

Re: [PATCH 5] libfs/rfs: Check search bit map end on last bit

On 16/10/20 12:00 am, Joel Sherrill wrote: > Does this need to go on 4.11 as well? Please raise a ticket. > I can't imaging this code has changed. It is testing that takes the time. > May even be the same in 4.10. Please raise a ticket. Thanks Chris

Re: RTEMS 5.1 pc686 BSP malloc_info problem?

On 16/10/20 5:22 am, Alan Cudmore wrote: > On Thu, Oct 15, 2020 at 11:19 AM Gedare Bloom wrote: >> >> On Thu, Oct 15, 2020 at 6:35 AM Joel Sherrill wrote: >>> >>> >>> >>> On Thu, Oct 15, 2020, 7:15 AM Alan Cudmore wrote: Thanks for all of the help, and thanks for the patch Chris! I

Re: RTEMS 5.1 pc686 BSP malloc_info problem?

On Thu, Oct 15, 2020 at 11:19 AM Gedare Bloom wrote: > > On Thu, Oct 15, 2020 at 6:35 AM Joel Sherrill wrote: > > > > > > > > On Thu, Oct 15, 2020, 7:15 AM Alan Cudmore wrote: > >> > >> Thanks for all of the help, and thanks for the patch Chris! I was > >> hoping to submit a patch this weekend,

set_vector() on SPARC

Hello, the set_vector() function yields this warning on SPARC: [ 107/4376] Compiling bsps/sparc/leon3/start/setvec.c ../../../bsps/sparc/leon3/start/setvec.c: In function 'set_vector': ../../../bsps/sparc/leon3/start/setvec.c:51:43: warning: passing argument 2 of '_CPU_ISR_install_raw_handler'

Re: [PATCH] rtems-fdt / shell - Fix string truncation warning

On Thu, Oct 15, 2020 at 12:24 PM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 15/10/2020 15:06, Frank Kühndel wrote: > > > On 10/15/20 2:09 PM, Sebastian Huber wrote: > >>> From: Frank Kühndel > >>> > >>> The compiler warning was: > >>> > >>>

Re: [PATCH] rtems-fdt / shell - Fix string truncation warning

On 15/10/2020 15:06, Frank Kühndel wrote: On 10/15/20 2:09 PM, Sebastian Huber wrote: From: Frank Kühndel The compiler warning was: ../../../cpukit/libmisc/rtems-fdt/rtems-fdt.c:267:5: warning: 'strncpy' specified bound depends on the length of the source argument    267 | strncpy(path,

Re: RTEMS 5.1 pc686 BSP malloc_info problem?

On Thu, Oct 15, 2020 at 6:35 AM Joel Sherrill wrote: > > > > On Thu, Oct 15, 2020, 7:15 AM Alan Cudmore wrote: >> >> Thanks for all of the help, and thanks for the patch Chris! I was >> hoping to submit a patch this weekend, so you just gave me back some >> time :) > > > Glad you found this! > >

Re: Uncrustify

On Wed, Oct 14, 2020 at 8:16 PM Joel Sherrill wrote: > > > > On Wed, Oct 14, 2020, 6:03 PM Chris Johns wrote: >> >> On 15/10/20 5:04 am, Joel Sherrill wrote: >> > On Wed, Oct 14, 2020 at 12:11 PM Sebastian Huber >> > > > > >> > wrote: >> > Hello, >>

Re: [PATCH] rtems-fdt / shell - Fix string truncation warning

On 10/15/20 2:09 PM, Sebastian Huber wrote: > >> From: Frank Kühndel >> >> The compiler warning was: >> >> ../../../cpukit/libmisc/rtems-fdt/rtems-fdt.c:267:5: warning: >> 'strncpy' specified bound depends on the length of the source argument >>    267 | strncpy(path, name, namelen); >>   

Re: [PATCH 5] libfs/rfs: Check search bit map end on last bit

Does this need to go on 4.11 as well? I can't imaging this code has changed. May even be the same in 4.10. On Thu, Oct 15, 2020 at 1:40 AM wrote: > From: Chris Johns > > - Do not write past the last location of the search bit map > whe nit is being created. > > Closes #4149 > --- >

Re: RTEMS 5.1 pc686 BSP malloc_info problem?

On Thu, Oct 15, 2020, 7:15 AM Alan Cudmore wrote: > Thanks for all of the help, and thanks for the patch Chris! I was > hoping to submit a patch this weekend, so you just gave me back some > time :) > Glad you found this! The RFS was new in 4.10 as I recall. You guys have missions using this.

Re: RTEMS 5.1 pc686 BSP malloc_info problem?

Thanks for all of the help, and thanks for the patch Chris! I was hoping to submit a patch this weekend, so you just gave me back some time :) Alan On Thu, Oct 15, 2020 at 2:08 AM Chris Johns wrote: > > On 13/10/20 4:13 am, Joel Sherrill wrote: > > On Mon, Oct 12, 2020 at 11:15 AM Alan Cudmore

Re: Fwd: [rtems-bsp-builder] 2020-10-13 09:15:22: Profile(s): everything

On 15/10/2020 08:45, Chris Johns wrote: It uses an item cache in pickle format. If you start with an empty cache it needs a couple of seconds. Once the cache is set up it loads in less than half a second. Oh nice, that functionality is part of this code? I had (incorrectly it seems) assumed

Re: [PATCH] rtems-fdt / shell - Fix string truncation warning

On 15/10/2020 13:27, Frank Kuehndel wrote: From: Frank Kühndel The compiler warning was: ../../../cpukit/libmisc/rtems-fdt/rtems-fdt.c:267:5: warning: 'strncpy' specified bound depends on the length of the source argument 267 | strncpy(path, name, namelen); |

[PATCH] rtems-fdt / shell - Fix string truncation warning

From: Frank Kühndel The compiler warning was: ../../../cpukit/libmisc/rtems-fdt/rtems-fdt.c:267:5: warning: 'strncpy' specified bound depends on the length of the source argument 267 | strncpy(path, name, namelen); | ^~~~ It turns out that the

Re: Fwd: [rtems-bsp-builder] 2020-10-13 09:15:22: Profile(s): everything

On 15/10/20 5:43 pm, Sebastian Huber wrote: > On 15/10/2020 08:41, Chris Johns wrote: > >> On 15/10/20 5:34 pm, Sebastian Huber wrote: >>> On 15/10/2020 08:30, Chris Johns wrote: >>> On 15/10/20 5:26 pm, Sebastian Huber wrote: > On 15/10/2020 08:23, Chris Johns wrote: > >> On

Re: Fwd: [rtems-bsp-builder] 2020-10-13 09:15:22: Profile(s): everything

On 15/10/2020 08:41, Chris Johns wrote: On 15/10/20 5:34 pm, Sebastian Huber wrote: On 15/10/2020 08:30, Chris Johns wrote: On 15/10/20 5:26 pm, Sebastian Huber wrote: On 15/10/2020 08:23, Chris Johns wrote: On 15/10/20 5:15 pm, Sebastian Huber wrote: On 15/10/2020 08:05, Chris Johns

Re: Fwd: [rtems-bsp-builder] 2020-10-13 09:15:22: Profile(s): everything

On 15/10/20 5:34 pm, Sebastian Huber wrote: > On 15/10/2020 08:30, Chris Johns wrote: > >> On 15/10/20 5:26 pm, Sebastian Huber wrote: >>> On 15/10/2020 08:23, Chris Johns wrote: >>> On 15/10/20 5:15 pm, Sebastian Huber wrote: > On 15/10/2020 08:05, Chris Johns wrote: > >> On

[PATCH 5] libfs/rfs: Check search bit map end on last bit

From: Chris Johns - Do not write past the last location of the search bit map whe nit is being created. Closes #4149 --- cpukit/libfs/src/rfs/rtems-rfs-bitmaps.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/cpukit/libfs/src/rfs/rtems-rfs-bitmaps.c

Re: Fwd: [rtems-bsp-builder] 2020-10-13 09:15:22: Profile(s): everything

On 15/10/2020 08:30, Chris Johns wrote: On 15/10/20 5:26 pm, Sebastian Huber wrote: On 15/10/2020 08:23, Chris Johns wrote: On 15/10/20 5:15 pm, Sebastian Huber wrote: On 15/10/2020 08:05, Chris Johns wrote: On 15/10/20 4:35 pm, Sebastian Huber wrote: On 15/10/2020 00:48, Chris Johns

Re: Fwd: [rtems-bsp-builder] 2020-10-13 09:15:22: Profile(s): everything

On 15/10/20 5:26 pm, Sebastian Huber wrote: > On 15/10/2020 08:23, Chris Johns wrote: > >> On 15/10/20 5:15 pm, Sebastian Huber wrote: >>> On 15/10/2020 08:05, Chris Johns wrote: >>> On 15/10/20 4:35 pm, Sebastian Huber wrote: > On 15/10/2020 00:48, Chris Johns wrote: > >> On

Re: Fwd: [rtems-bsp-builder] 2020-10-13 09:15:22: Profile(s): everything

On 15/10/2020 08:23, Chris Johns wrote: On 15/10/20 5:15 pm, Sebastian Huber wrote: On 15/10/2020 08:05, Chris Johns wrote: On 15/10/20 4:35 pm, Sebastian Huber wrote: On 15/10/2020 00:48, Chris Johns wrote: On 15/10/20 2:27 am, Joel Sherrill wrote: On Wed, Oct 14, 2020 at 10:20 AM

Re: Fwd: [rtems-bsp-builder] 2020-10-13 09:15:22: Profile(s): everything

On 15/10/20 5:15 pm, Sebastian Huber wrote: > On 15/10/2020 08:05, Chris Johns wrote: > >> On 15/10/20 4:35 pm, Sebastian Huber wrote: >>> On 15/10/2020 00:48, Chris Johns wrote: >>> On 15/10/20 2:27 am, Joel Sherrill wrote: > On Wed, Oct 14, 2020 at 10:20 AM Sebastian Huber >

[PATCH] libfs/rfs: Check search bit map end on last bit

From: Chris Johns - Do not write past the last location of the search bit map whe nit is being created. Closes #4148 --- cpukit/libfs/src/rfs/rtems-rfs-bitmaps.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/cpukit/libfs/src/rfs/rtems-rfs-bitmaps.c

Re: Fwd: [rtems-bsp-builder] 2020-10-13 09:15:22: Profile(s): everything

On 15/10/2020 08:05, Chris Johns wrote: On 15/10/20 4:35 pm, Sebastian Huber wrote: On 15/10/2020 00:48, Chris Johns wrote: On 15/10/20 2:27 am, Joel Sherrill wrote: On Wed, Oct 14, 2020 at 10:20 AM Sebastian Huber mailto:sebastian.hu...@embedded-brains.de>> wrote: On 14/10/2020

Re: RTEMS 5.1 pc686 BSP malloc_info problem?

On 13/10/20 4:13 am, Joel Sherrill wrote: > On Mon, Oct 12, 2020 at 11:15 AM Alan Cudmore > wrote: > > Hi Chris, > I'm not sure that I can easily create a test to show that this > condition exists. I think the rtems_rfs_bitmap_create_search function >

Re: Fwd: [rtems-bsp-builder] 2020-10-13 09:15:22: Profile(s): everything

On 15/10/20 4:35 pm, Sebastian Huber wrote: > On 15/10/2020 00:48, Chris Johns wrote: > >> On 15/10/20 2:27 am, Joel Sherrill wrote: >>> On Wed, Oct 14, 2020 at 10:20 AM Sebastian Huber >>> >> > >>> wrote: >>> On 14/10/2020 17:17, Joel Sherrill