[PATCH] c-user: Reformat configuration option constraints

2021-04-28 Thread Sebastian Huber
If only one constraint is present, then use a single sentence, otherwise use a list for the constraints. Format the constraints so that the line length limit is maintained. --- c-user/config/bdbuf.rst | 94 ++- c-user/config/bsp-related.rst | 22 ++--

Re: [PATCH] bsps/shared/ofw: Fix coverity defects

2021-04-28 Thread Niteesh G. S.
On Thu, Apr 29, 2021 at 12:50 AM Gedare Bloom wrote: > On Wed, Apr 28, 2021 at 11:30 AM G S Niteesh Babu > wrote: > > > > This patch adds asserts to fix coverity defects > > 1) CID 1474437 (Out-of-bounds access) > > 2) CID 1474436 (Out-of-bounds access) > > > > From manual inspection, out of

Re: [PATCH] pwdgrp.c: Removed unused variable

2021-04-28 Thread Gedare Bloom
ok On Wed, Apr 28, 2021 at 2:25 PM Ryan Long wrote: > > The 'sc' variable was originally storing the return value of mkdir(). > This was causing an issue, so it was changed to make it to where we > ignored the return value with (void). The 'sc' variable was left in > by mistake. > --- >

Re: tcpreplay for testing network stacks

2021-04-28 Thread Vijay Kumar Banerjee
On Wed, Apr 28, 2021 at 3:27 PM Chris Johns wrote: > > > > On 29/4/21 3:00 am, Vijay Kumar Banerjee wrote: > > On Wed, Apr 28, 2021 at 10:49 AM Christian Mauderer > > wrote: > >> > >> Hello Vijay, > >> > >> On 28/04/2021 18:25, Vijay Kumar Banerjee wrote: > >>> On Wed, Apr 28, 2021 at 12:41 AM

Re: tcpreplay for testing network stacks

2021-04-28 Thread Vijay Kumar Banerjee
On Wed, Apr 28, 2021 at 3:26 PM Chris Johns wrote: > > On 29/4/21 2:31 am, Vijay Kumar Banerjee wrote: > > On Wed, Apr 28, 2021 at 12:45 AM Chris Johns wrote: > >> > >> On 28/4/21 2:48 am, Vijay Kumar Banerjee wrote: > >>> I came across the tcpreplay tool and it looks like a nice tool for > >>>

Re: tcpreplay for testing network stacks

2021-04-28 Thread Chris Johns
On 29/4/21 3:00 am, Vijay Kumar Banerjee wrote: > On Wed, Apr 28, 2021 at 10:49 AM Christian Mauderer > wrote: >> >> Hello Vijay, >> >> On 28/04/2021 18:25, Vijay Kumar Banerjee wrote: >>> On Wed, Apr 28, 2021 at 12:41 AM Christian MAUDERER >>> wrote: Hello Vijay, Am

Re: tcpreplay for testing network stacks

2021-04-28 Thread Chris Johns
On 29/4/21 2:31 am, Vijay Kumar Banerjee wrote: > On Wed, Apr 28, 2021 at 12:45 AM Chris Johns wrote: >> >> On 28/4/21 2:48 am, Vijay Kumar Banerjee wrote: >>> I came across the tcpreplay tool and it looks like a nice tool for testing >>> the >>> network stacks. It can be used to capture network

Re: Issues with rtems_waf on Windows 10 with gccdeps module

2021-04-28 Thread Chris Johns
On 28/4/21 7:59 pm, Robin Müller wrote: > I think the following commit in rtems_waf breaks the waf build on Windows 10: > > commit 096372fc4504730e50b51b952ce47ca603b35f01 > Author: Chris Johns mailto:chr...@rtems.org>> > Date:   Thu Oct 10 17:43:11 2019 +1100 > >     Use gccdeps for dependency

[PATCH] pwdgrp.c: Removed unused variable

2021-04-28 Thread Ryan Long
The 'sc' variable was originally storing the return value of mkdir(). This was causing an issue, so it was changed to make it to where we ignored the return value with (void). The 'sc' variable was left in by mistake. --- cpukit/libcsupport/src/pwdgrp.c | 2 -- 1 file changed, 2 deletions(-)

Re: [PATCH] bsps/shared/ofw: Fix coverity defects

2021-04-28 Thread Gedare Bloom
On Wed, Apr 28, 2021 at 11:30 AM G S Niteesh Babu wrote: > > This patch adds asserts to fix coverity defects > 1) CID 1474437 (Out-of-bounds access) > 2) CID 1474436 (Out-of-bounds access) > > From manual inspection, out of bounds access cannot occur due to > bounds checking but coverity fails to

Re: Write the BSP for ARM Versatile Express device

2021-04-28 Thread Đức Anh
Hi, Do you have any executables from anywhere that run on the simulator in the > configuration you intend for RTEMS to use? Sorry, I forgot to answer your question. Actually, my goal is just to make Rtems up and run in the Gem5 simulator. And then I will study the task preemption part of Rtems,

[PATCH rtems-lwip v2] STM32 lwIP addition

2021-04-28 Thread Robin Mueller
This patch adds the STM32H7 / NUCLEO-H743ZI lwIP port. It also improves the architecture to make integration of new BSPs easier. The patch continues the wscript file to allow installing the lwIP support similar to how a RTEMS BSP is installed. https://github.com/rmspacefish/rtems-stm32-lwip is a

[PATCH] bsps/shared/ofw: Fix coverity defects

2021-04-28 Thread G S Niteesh Babu
This patch adds asserts to fix coverity defects 1) CID 1474437 (Out-of-bounds access) 2) CID 1474436 (Out-of-bounds access) >From manual inspection, out of bounds access cannot occur due to bounds checking but coverity fails to detect the checks. We are adding asserts as a secondary check. ---

Re: tcpreplay for testing network stacks

2021-04-28 Thread Vijay Kumar Banerjee
On Wed, Apr 28, 2021 at 10:49 AM Christian Mauderer wrote: > > Hello Vijay, > > On 28/04/2021 18:25, Vijay Kumar Banerjee wrote: > > On Wed, Apr 28, 2021 at 12:41 AM Christian MAUDERER > > wrote: > >> > >> Hello Vijay, > >> > >> Am 27.04.21 um 18:48 schrieb Vijay Kumar Banerjee: > >>> Hi, > >>>

Re: tcpreplay for testing network stacks

2021-04-28 Thread Christian Mauderer
Hello Vijay, On 28/04/2021 18:25, Vijay Kumar Banerjee wrote: On Wed, Apr 28, 2021 at 12:41 AM Christian MAUDERER wrote: Hello Vijay, Am 27.04.21 um 18:48 schrieb Vijay Kumar Banerjee: Hi, I came across the tcpreplay tool and it looks like a nice tool for testing the network stacks. It

Re: tcpreplay for testing network stacks

2021-04-28 Thread Joel Sherrill
On Wed, Apr 28, 2021 at 11:25 AM Vijay Kumar Banerjee wrote: > On Wed, Apr 28, 2021 at 12:41 AM Christian MAUDERER > wrote: > > > > Hello Vijay, > > > > Am 27.04.21 um 18:48 schrieb Vijay Kumar Banerjee: > > > Hi, > > > > > > I came across the tcpreplay tool and it looks like a nice tool for >

Re: tcpreplay for testing network stacks

2021-04-28 Thread Vijay Kumar Banerjee
On Wed, Apr 28, 2021 at 12:45 AM Chris Johns wrote: > > On 28/4/21 2:48 am, Vijay Kumar Banerjee wrote: > > I came across the tcpreplay tool and it looks like a nice tool for testing > > the > > network stacks. It can be used to capture network traffic and then play it > > back, > > this will

Re: tcpreplay for testing network stacks

2021-04-28 Thread Vijay Kumar Banerjee
On Wed, Apr 28, 2021 at 12:41 AM Christian MAUDERER wrote: > > Hello Vijay, > > Am 27.04.21 um 18:48 schrieb Vijay Kumar Banerjee: > > Hi, > > > > I came across the tcpreplay tool and it looks like a nice tool for > > testing the network stacks. It can be used to capture network traffic > > and

Re: [PATCH] STM32 lwIP addition

2021-04-28 Thread Gedare Bloom
Squash, and send with -v2 https://docs.rtems.org/branches/master/eng/vc-users.html#creating-a-patch Use --subject-prefix="PATCH rtems-lwip" We expect there will be things installed. It is expected only one network stack will be installed in a given PREFIX. We haven't quite gotten to the point

Re: [PATCH] STM32 lwIP addition

2021-04-28 Thread Robin Müller
I integrated most of your points and added waf support. The lwIP support can now be installed like the RTEMS BSP with waf so the PKG Config generated by the BSP installation can be reused. It puts some folders like lwip / netif / compat into the include path, I hope this is not problematic. I'll

[PATCH] riscv/start: Startup sequence update.

2021-04-28 Thread Somesh Deshmukh
- The current startup sequence performs the call to the bsp_fdt_copy() and then performs memset to the BSS region. In bsp_fdt_copy(), RTEMS allocates memory for bsp_fdt_blob into BSS region which is yet to initialize. With current startup sequence, the bsp_fdt_blob is getting erased after

[PATCH] riscv/console: Updated the console-config.c file

2021-04-28 Thread Somesh Deshmukh
- Parsing the sub-node should be available generic not specific to Freedom Arty310 board. If we remove the Freedom Arty macro now, it will lose backward compatibility.The proposed change will retain the backward compatibility and also adds the necessary fix for parsing sub-node. - Line 234

Re: [PATCH] posix: Use alias for pthread_self()

2021-04-28 Thread Joel Sherrill
On Wed, Apr 28, 2021 at 12:04 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > > On 28/04/2021 00:28, Joel Sherrill wrote: > > > > > > On Tue, Apr 27, 2021, 11:24 AM Sebastian Huber > > > > wrote: > > > > On 27/04/2021 18:23, Gedare

Re: [PATCH] STM32 lwIP addition

2021-04-28 Thread Robin Müller
Small correction: I changed the ethernetif.c file to be usable by all three major APIs. Kind Regards Robin On Wed, 28 Apr 2021 at 11:55, Robin Müller wrote: > Should I provide the changes for the code review as a separate patch or > should I squash them again? > > Using the upstream unchanged

Issues with rtems_waf on Windows 10 with gccdeps module

2021-04-28 Thread Robin Müller
Hi, I think the following commit in rtems_waf breaks the waf build on Windows 10: commit 096372fc4504730e50b51b952ce47ca603b35f01 Author: Chris Johns Date: Thu Oct 10 17:43:11 2019 +1100 Use gccdeps for dependency scanning. I get the error that RTEMS is not able to find the rtems.h file

Re: [PATCH] STM32 lwIP addition

2021-04-28 Thread Robin Müller
Should I provide the changes for the code review as a separate patch or should I squash them again? Using the upstream unchanged is tricky because the code was taken from the examples and these examples are always targeted towards a specific API. I changed the version to be usable by both APIs. I

Re: tcpreplay for testing network stacks

2021-04-28 Thread Chris Johns
On 28/4/21 2:48 am, Vijay Kumar Banerjee wrote: > I came across the tcpreplay tool and it looks like a nice tool for testing the > network stacks. It can be used to capture network traffic and then play it > back, > this will help with testing the network packets from different network stacks. >

Re: tcpreplay for testing network stacks

2021-04-28 Thread Christian MAUDERER
Hello Vijay, Am 27.04.21 um 18:48 schrieb Vijay Kumar Banerjee: Hi, I came across the tcpreplay tool and it looks like a nice tool for testing the network stacks. It can be used to capture network traffic and then play it back, this will help with testing the network packets from different