Re: [rtems-source-builder PATCH] rtems: Update tools, kernel and legacy network packages

2023-04-14 Thread Vijay Kumar Banerjee
Hi Chris, The updates look good to me. Thanks. On Fri, Apr 14, 2023 at 7:10 PM wrote: > > From: Chris Johns > > - Tools picks up the stm32h7-stlink to handle SIGTRAP fix. > > - RTEMS picks up the motorola_powerpc updates including the mvme2700 > BSP and Makefile.inc fixes for building EPICS.

[rtems-source-builder PATCH] rtems: Update tools, kernel and legacy network packages

2023-04-14 Thread chrisj
From: Chris Johns - Tools picks up the stm32h7-stlink to handle SIGTRAP fix. - RTEMS picks up the motorola_powerpc updates including the mvme2700 BSP and Makefile.inc fixes for building EPICS. - Legacy networking picks up a number of build system fixes, network configuration changes and

Re: FreeBSD libefi import -- how to proceed?

2023-04-14 Thread Joel Sherrill
On Fri, Apr 14, 2023, 3:00 PM Gedare Bloom wrote: > On Tue, Mar 28, 2023 at 4:27 AM Karel Gardas > wrote: > > > > > >Folks, > > > > I'm using FreeBSD's libefi on my hacked multiboot2 based amd64 BSP which > > I'd like to push for review (at least). > > > > Now, I'd like to prepare libefi

Re: [rtems-source-builder PATCH] rtems: Add back gsed that was remove by mistake

2023-04-14 Thread Joel Sherrill
Sure. Obviously needed. Push it On Fri, Apr 14, 2023, 5:56 PM wrote: > From: Chris Johns > > - Build GNU sed for hosts that it is not installed on for the MIPS > tools. > --- > rtems/config/tools/rtems-default-tools.bset | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff

[rtems-source-builder PATCH] rtems: Add back gsed that was remove by mistake

2023-04-14 Thread chrisj
From: Chris Johns - Build GNU sed for hosts that it is not installed on for the MIPS tools. --- rtems/config/tools/rtems-default-tools.bset | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rtems/config/tools/rtems-default-tools.bset

Re: FreeBSD libefi import -- how to proceed?

2023-04-14 Thread Gedare Bloom
On Tue, Mar 28, 2023 at 4:27 AM Karel Gardas wrote: > > >Folks, > > I'm using FreeBSD's libefi on my hacked multiboot2 based amd64 BSP which > I'd like to push for review (at least). > > Now, I'd like to prepare libefi for import but I'm still in doubts if to > do that in: > > - as intact

Re: [PATCH v2] eng: Add register block specification types

2023-04-14 Thread Gedare Bloom
I read this discussion, and it's pretty fascinating. I just want to point out that "linear address" and "linear address space" are both terms defined in Intel documentation for the address you get after doing segmentation but before paging. Just to further complicate the choice of terminology. :)

Re: [PATCH 0/3] bsp-howto/console: Remove obsolete references / Fix typos

2023-04-14 Thread Gedare Bloom
These look fine. On Thu, Mar 30, 2023 at 6:51 AM Matthew Joyce wrote: > > From: Matt Joyce > > Hello, > > Please find the following edits to bsp-howto/console attached. > > Thanks very much! > > Sincerely, > Matt > > Matt Joyce (3): > bsp-howto/console: Remove reference to old build system >

Re: [PATCH 2/2] user/microblaze: Document device tree support

2023-04-14 Thread Gedare Bloom
these doc patches ok. please use --subject-prefix to add repo tags in future. https://docs.rtems.org/branches/master/eng/vc-users.html#creating-a-patch On Tue, Apr 4, 2023 at 9:01 AM Alex White wrote: > > --- > user/bsps/bsps-microblaze.rst | 29 - > 1 file changed,

Re: [lwip 0/6] Add basic support for TMS570LC4357

2023-04-14 Thread Gedare Bloom
These patches look good. If time permits, https://docs.rtems.org/branches/master/user/bsps/arm/tms570.html could be improved. On Tue, Apr 4, 2023 at 8:55 AM Sebastian Huber wrote: > > In general, the lwIP stack lacks a generic MDIO/Phy framework. > > Sebastian Huber (6): > Generalize MDIO

Re: [PATCH 7/8] bsp/tms570: Add TMS570_VARIANT

2023-04-14 Thread Gedare Bloom
nit: would it make sense to include the LS/LC prefixes? On Tue, Apr 4, 2023 at 8:53 AM Sebastian Huber wrote: > > --- > spec/build/bsps/arm/tms570/grp.yml| 2 ++ > spec/build/bsps/arm/tms570/optvariant.yml | 21 + > 2 files changed, 23 insertions(+) > create mode

Re: [rtems-net-legacy PATCH] bsd: Add iface calls to help user manage the iface state

2023-04-14 Thread Chris Johns
On 15/4/2023 12:14 am, Gedare Bloom wrote: > two nits below Thanks for the review. I appreciate you doing it. I will clean these up and push the result. Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

Re: [rtems-net-legacy commit] waf: Generate a version header called rtems-net-legacy.h

2023-04-14 Thread Chris Johns
On 15/4/2023 12:06 am, Gedare Bloom wrote: > On Thu, Apr 13, 2023 at 11:59 PM Chris Johns wrote: >> +#ifndef _RTEMS_NET_LGEACY_H_ > typo in the header guard Nice catch. Thanks. I will fix this. Chris ___ devel mailing list devel@rtems.org

Re: [PATCH v2 1/3] cpukit/flash: Add API for Flash devices

2023-04-14 Thread Gedare Bloom
I focused my review on the API. See below. On Thu, Apr 6, 2023 at 1:08 AM wrote: > > From: Aaron Nyholm > [...] > diff --git a/cpukit/include/dev/flash/flashdev.h > b/cpukit/include/dev/flash/flashdev.h > new file mode 100644 > index 00..5d53ea7b97 > --- /dev/null > +++

Re: [PATCH 0/1] Improve coherence of user/start docs

2023-04-14 Thread Gedare Bloom
Merged, thank you. On Thu, Apr 6, 2023 at 5:45 PM Utkarsh Verma wrote: > > Hi, > > This is just a gentle reminder for this patch. Please let me know if I could > improve anything. > > Regards, > Utkarsh > > On Wed, Mar 29, 2023 at 6:08 AM Utkarsh Verma wrote: >> >> This patch improves

Re: [PATCH] README for raspberry pi 4 AArch64 BSP

2023-04-14 Thread Noor Aman
Thanks, for the confirmation. I'll add it to the docs. On Fri, 14 Apr 2023 at 19:52, Gedare Bloom wrote: > On Mon, Apr 10, 2023 at 4:05 AM Noor Aman wrote: > > > > Thanks for the suggestions, > > > > I'll wait for a few days to receive a confirmation or so and after that, > I'll update the

Re: [PATCH] README for raspberry pi 4 AArch64 BSP

2023-04-14 Thread Gedare Bloom
On Mon, Apr 10, 2023 at 4:05 AM Noor Aman wrote: > > Thanks for the suggestions, > > I'll wait for a few days to receive a confirmation or so and after that, I'll > update the documentation instead of adding a README to RTEMS if required. > Yes, it is preferred to put this information to the

Re: [rtems-net-legacy PATCH] bsd: Add iface calls to help user manage the iface state

2023-04-14 Thread Gedare Bloom
two nits below On Wed, Apr 12, 2023 at 8:17 PM wrote: > > From: Chris Johns > > --- > include/rtems/bsd/iface.h | 62 +++ > netsources.py | 26 +++ > rtems/rtems-bsd-iface.c | 154 ++ > testsuites/wscript| 8 ++ >

Re: [rtems-net-legacy commit] waf: Generate a version header called rtems-net-legacy.h

2023-04-14 Thread Gedare Bloom
On Thu, Apr 13, 2023 at 11:59 PM Chris Johns wrote: > > Module:rtems-net-legacy > Branch:main > Commit:bef50b9ff76d3f6231e3c92bb35d47ee5bc7f0cb > Changeset: > http://git.rtems.org/rtems-net-legacy/commit/?id=bef50b9ff76d3f6231e3c92bb35d47ee5bc7f0cb > > Author:Chris Johns > Date:

Re: AW: [PATCH 02/18] ptpd: Add VERSION file

2023-04-14 Thread Sebastian Huber
On 13.04.23 12:20, gabriel.moy...@dlr.de wrote: But before submitting the patches again, is there any other change suggested? Not from my side. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 -