Re: [PATCH 2/2] bsps: Remove uses of BSP-specific interrupt API

On 16/6/2023 3:36 pm, Sebastian Huber wrote: > On 16.06.23 07:04, Chris Johns wrote: >> On 16/6/2023 2:51 pm, Sebastian Huber wrote: >>> On 16.06.23 03:49, Chris Johns wrote: > diff --git a/bsps/shared/grlib/drvmgr/ambapp_bus_grlib.c > b/bsps/shared/grlib/drvmgr/ambapp_bus_grlib.c >

Re: [PATCH v2 1/3] pci: Do not use BSP-specific interrupt API

Look good. Thanks Chris On 16/6/2023 3:34 pm, Sebastian Huber wrote: > Update #3269. > --- > cpukit/include/pci/irq.h | 17 - > 1 file changed, 4 insertions(+), 13 deletions(-) > > diff --git a/cpukit/include/pci/irq.h b/cpukit/include/pci/irq.h > index 4069f1ffa8..8617dd1680

Re: [PATCH 2/2] bsps: Remove uses of BSP-specific interrupt API

On 16.06.23 07:04, Chris Johns wrote: On 16/6/2023 2:51 pm, Sebastian Huber wrote: On 16.06.23 03:49, Chris Johns wrote: diff --git a/bsps/shared/grlib/drvmgr/ambapp_bus_grlib.c b/bsps/shared/grlib/drvmgr/ambapp_bus_grlib.c index 96b77907a6..bc211e37b6 100644 ---

[PATCH v2 3/3] bsps/sparc: Deprecate BSP-specific interrupt API

Update #3269. --- bsps/sparc/erc32/include/bsp.h | 10 +- bsps/sparc/leon2/include/bsp.h | 10 +- bsps/sparc/leon3/include/bsp.h | 10 +- 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/bsps/sparc/erc32/include/bsp.h b/bsps/sparc/erc32/include/bsp.h index

[PATCH v2 1/3] pci: Do not use BSP-specific interrupt API

Update #3269. --- cpukit/include/pci/irq.h | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/cpukit/include/pci/irq.h b/cpukit/include/pci/irq.h index 4069f1ffa8..8617dd1680 100644 --- a/cpukit/include/pci/irq.h +++ b/cpukit/include/pci/irq.h @@ -38,18 +38,9

[PATCH v2 2/3] bsps: Remove uses of BSP-specific interrupt API

Update #3269. --- bsps/riscv/griscv/include/bsp.h | 6 - bsps/shared/grlib/drvmgr/ambapp_bus_grlib.c | 17 +--- bsps/sparc/erc32/include/bsp.h | 15 --- bsps/sparc/leon2/include/bsp.h | 15 --- bsps/sparc/leon3/include/bsp.h

Re: bsps/xilinx-zynqmp : Add BSP for RPU

On 15/6/2023 6:16 pm, Philip Kirkpatrick wrote: > Thanks for all the good feedback. > > RE Joel: > I'll fix my sloppy formatting that you caught and submit a revised patch.  If > I'm realistic about my schedule, I probably won't be able to get to it until > next week. > For xttcps_hw.h, there

[PATCH v2] eng: Add guidelines for validation tests

Update #3717. --- v2: * Mention that file name should be unique. * Clarify file name parts. * Add examples for enabled-by expressions. eng/req/howto.rst | 80 +++ 1 file changed, 80 insertions(+) diff --git a/eng/req/howto.rst b/eng/req/howto.rst

Re: [PATCH 2/2] bsps: Remove uses of BSP-specific interrupt API

On 16/6/2023 2:51 pm, Sebastian Huber wrote: > On 16.06.23 03:49, Chris Johns wrote: >>> diff --git a/bsps/shared/grlib/drvmgr/ambapp_bus_grlib.c >>> b/bsps/shared/grlib/drvmgr/ambapp_bus_grlib.c >>> index 96b77907a6..bc211e37b6 100644 >>> --- a/bsps/shared/grlib/drvmgr/ambapp_bus_grlib.c >>> +++

Re: BSP-Specific Testing was: [PATCH 00/34] Integrate pre-qualified LEON3 BSP

On 16.06.23 06:53, Chris Johns wrote: On 16/6/2023 2:41 pm, Sebastian Huber wrote: On 16.06.23 00:07, Chris Johns wrote: On 16/6/2023 12:54 am, Sebastian Huber wrote: The test framework prints out the location of events using the file name and the line number. So, it would be good if the file

Re: BSP-Specific Testing was: [PATCH 00/34] Integrate pre-qualified LEON3 BSP

On 16/6/2023 2:41 pm, Sebastian Huber wrote: > On 16.06.23 00:07, Chris Johns wrote: >> On 16/6/2023 12:54 am, Sebastian Huber wrote: >>> The test framework prints out the location of events using the file name >>> and the >>> line number. So, it would be good if the file names are unique and

Re: [PATCH 2/2] bsps: Remove uses of BSP-specific interrupt API

On 16.06.23 03:49, Chris Johns wrote: diff --git a/bsps/shared/grlib/drvmgr/ambapp_bus_grlib.c b/bsps/shared/grlib/drvmgr/ambapp_bus_grlib.c index 96b77907a6..bc211e37b6 100644 --- a/bsps/shared/grlib/drvmgr/ambapp_bus_grlib.c +++ b/bsps/shared/grlib/drvmgr/ambapp_bus_grlib.c @@ -41,7 +41,7 @@

Re: BSP-Specific Testing was: [PATCH 00/34] Integrate pre-qualified LEON3 BSP

On 16.06.23 00:07, Chris Johns wrote: On 16/6/2023 12:54 am, Sebastian Huber wrote: The test framework prints out the location of events using the file name and the line number. So, it would be good if the file names are unique and descriptive. This is why I like Gedare's proposal to just use

Re: BSP .inc files and .cfg files

On 16.06.23 06:35, Chris Johns wrote: On 16/6/2023 2:33 pm, Sebastian Huber wrote: On 16.06.23 03:46, Chris Johns wrote: On 16/6/2023 9:04 am, Joel Sherrill wrote: On Thu, Jun 15, 2023 at 5:41 PM Chris Johns mailto:chr...@rtems.org>> wrote: Hi, Reviewing the RPU patch I

Re: Doorstop YML file in repo

On 16/6/2023 2:34 pm, Sebastian Huber wrote: > On 16.06.23 00:33, Chris Johns wrote: >> Hi >> >> I spotted this today and I am wondering if it has accidental been added: >> >> https://git.rtems.org/rtems/tree/spec/build/bsps/arm/stm32h7/.doorstop.yml >> >> ? > > Sorry, this was a mistake. I

Re: BSP .inc files and .cfg files

On 16/6/2023 2:33 pm, Sebastian Huber wrote: > On 16.06.23 03:46, Chris Johns wrote: >> >> On 16/6/2023 9:04 am, Joel Sherrill wrote: >>> >>> On Thu, Jun 15, 2023 at 5:41 PM Chris Johns >> > wrote: >>> >>> Hi, >>> >>> Reviewing the RPU patch I noticed a .inc file

Re: Doorstop YML file in repo

On 16.06.23 00:33, Chris Johns wrote: Hi I spotted this today and I am wondering if it has accidental been added: https://git.rtems.org/rtems/tree/spec/build/bsps/arm/stm32h7/.doorstop.yml ? Sorry, this was a mistake. I removed the file. -- embedded brains GmbH Herr Sebastian HUBER

Re: BSP .inc files and .cfg files

On 16.06.23 03:46, Chris Johns wrote: On 16/6/2023 9:04 am, Joel Sherrill wrote: On Thu, Jun 15, 2023 at 5:41 PM Chris Johns mailto:chr...@rtems.org>> wrote: Hi, Reviewing the RPU patch I noticed a .inc file being added and I wondered why so I checked the sources and to my

unit test framework

was reading through https://docs.rtems.org/branches/master/eng/test-framework.html#test-framework-requirements-for-rtems t.h I think needs changed to test.h or rtems/test.h Was trying to stand up a test framework for my board. Wanted command line arg support though so switched to trying

Re: [PATCH 2/2] bsps: Remove uses of BSP-specific interrupt API

On 15/6/2023 10:46 pm, Sebastian Huber wrote: > Update #3269. > --- > bsps/riscv/griscv/include/bsp.h | 4 --- > bsps/shared/grlib/drvmgr/ambapp_bus_grlib.c | 8 +++--- > bsps/sparc/erc32/include/bsp.h | 15 --- > bsps/sparc/leon2/include/bsp.h | 15

Re: BSP .inc files and .cfg files

On 16/6/2023 9:04 am, Joel Sherrill wrote: > > > On Thu, Jun 15, 2023 at 5:41 PM Chris Johns > wrote: > > Hi, > > Reviewing the RPU patch I noticed a .inc file being added and I wondered > why so > I checked the sources and to my surprise found: > >

rtems-docs [PATCH] README: Fixing spelling and grammar errors

Hello, RTEMS Devs! Please find attached a patch for rtems-docs/README.txt that fixes some grammatical and spelling errors. Since this is my first submission, I went through the Checklist for Patches . I

Re: BSP .inc files and .cfg files

On Thu, Jun 15, 2023 at 5:41 PM Chris Johns wrote: > Hi, > > Reviewing the RPU patch I noticed a .inc file being added and I wondered > why so > I checked the sources and to my surprise found: > > rtems.git $ find bsps -name \*.inc > bsps/v850/gdbv850sim/config/v850sim.inc >

BSP .inc files and .cfg files

Hi, Reviewing the RPU patch I noticed a .inc file being added and I wondered why so I checked the sources and to my surprise found: rtems.git $ find bsps -name \*.inc bsps/v850/gdbv850sim/config/v850sim.inc bsps/m68k/genmcf548x/config/genmcf548x.inc bsps/m68k/gen68340/include/m68340.inc

Doorstop YML file in repo

Hi I spotted this today and I am wondering if it has accidental been added: https://git.rtems.org/rtems/tree/spec/build/bsps/arm/stm32h7/.doorstop.yml ? Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

Re: BSP-Specific Testing was: [PATCH 00/34] Integrate pre-qualified LEON3 BSP

On 16/6/2023 12:54 am, Sebastian Huber wrote: > The test framework prints out the location of events using the file name and > the > line number. So, it would be good if the file names are unique and > descriptive. > This is why I like Gedare's proposal to just use "bsps". Is only the basename

Re: [PATCH rtems-source-builder] qemu-5-1: Add patch for ZynqMP/Versal CGEMs

OK Thanks Chris On 16/6/2023 1:53 am, Kinsey Moore wrote: > This temporarily adds a patch to fix badly behaving CGEM peripherals > under QEMU. The referenced patch has been submitted for inclusion in > the upstream QEMU repository. > > Updates #4919 > --- > source-builder/config/qemu-5-1.cfg |

Re: [PATCH] eng: Add guidelines for validation tests

LGTM On Thu, Jun 15, 2023 at 4:06 AM Sebastian Huber wrote: > > On 15.06.23 11:28, Frank Kühndel wrote: > > > >> + > >> +* Tests for fatal errors shall have ``fatal`` as the most general > >> file part, > >> + for example ``ts-fatal-too-large-tls-size.c``. > >> + > >> +* Validation test suites

[PATCH rtems-source-builder] qemu-5-1: Add patch for ZynqMP/Versal CGEMs

This temporarily adds a patch to fix badly behaving CGEM peripherals under QEMU. The referenced patch has been submitted for inclusion in the upstream QEMU repository. Updates #4919 --- source-builder/config/qemu-5-1.cfg | 4 1 file changed, 4 insertions(+) diff --git

Re: BSP-Specific Testing was: [PATCH 00/34] Integrate pre-qualified LEON3 BSP

On 15.06.23 15:51, Joel Sherrill wrote: On Mon, Jun 12, 2023 at 10:58 AM Gedare Bloom > wrote: On Mon, Jun 12, 2023 at 12:56 AM Sebastian Huber mailto:sebastian.hu...@embedded-brains.de>> wrote: > > > > On 01.06.23 22:06, Gedare Bloom

Re: BSP-Specific Testing was: [PATCH 00/34] Integrate pre-qualified LEON3 BSP

On Mon, Jun 12, 2023 at 10:58 AM Gedare Bloom wrote: > On Mon, Jun 12, 2023 at 12:56 AM Sebastian Huber > wrote: > > > > > > > > On 01.06.23 22:06, Gedare Bloom wrote: > > > On Thu, Jun 1, 2023 at 2:00 PM Gedare Bloom wrote: > > >> -- Forwarded message - > > >> From: Sebastian

[PATCH] bsps/sparc: Deprecate BSP-specific interrupt API

Update #3269. --- bsps/sparc/erc32/include/bsp.h | 10 +- bsps/sparc/leon2/include/bsp.h | 10 +- bsps/sparc/leon3/include/bsp.h | 10 +- 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/bsps/sparc/erc32/include/bsp.h b/bsps/sparc/erc32/include/bsp.h index

[PATCH 1/2] pci: Do not use BSP-specific interrupt API

Update #3269. --- cpukit/include/pci/irq.h | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/cpukit/include/pci/irq.h b/cpukit/include/pci/irq.h index 4069f1ffa8..8617dd1680 100644 --- a/cpukit/include/pci/irq.h +++ b/cpukit/include/pci/irq.h @@ -38,18 +38,9

[PATCH 2/2] bsps: Remove uses of BSP-specific interrupt API

Update #3269. --- bsps/riscv/griscv/include/bsp.h | 4 --- bsps/shared/grlib/drvmgr/ambapp_bus_grlib.c | 8 +++--- bsps/sparc/erc32/include/bsp.h | 15 --- bsps/sparc/leon2/include/bsp.h | 15 --- bsps/sparc/leon3/include/bsp.h

Re: [PATCH] rtemsbsd/versal_slcr: Fix Versal GEM clock set

This looks good as far as the functional content is concerned. As a nit, it looks like some unnecessary newlines were added in cgem_set_ref_clk() and the added if() conditional braces are inconsistent in their formatting so feel free to tweak those before commit. On Thu, Jun 15, 2023 at 12:48 AM

Re: [PATCH] eng: Add guidelines for validation tests

On 15.06.23 11:28, Frank Kühndel wrote: + +* Tests for fatal errors shall have ``fatal`` as the most general file part, +  for example ``ts-fatal-too-large-tls-size.c``. + +* Validation test suites shall have ``validation`` as the most general file +  part, for example

Re: [PATCH] eng: Add guidelines for validation tests

On 6/15/23 09:33, Sebastian Huber wrote: Subject: [PATCH] eng: Add guidelines for validation tests From: Sebastian Huber Date: 6/15/23, 09:33 To: devel@rtems.org Update #3717. --- eng/req/howto.rst | 59 +++ 1 file changed, 59 insertions(+)

Re: bsps/xilinx-zynqmp : Add BSP for RPU

Thanks for all the good feedback. RE Joel: I'll fix my sloppy formatting that you caught and submit a revised patch. If I'm realistic about my schedule, I probably won't be able to get to it until next week. For xttcps_hw.h, there already is one #ifndef __rtems__ around the #includes, but on

[PATCH] eng: Add guidelines for validation tests

Update #3717. --- eng/req/howto.rst | 59 +++ 1 file changed, 59 insertions(+) diff --git a/eng/req/howto.rst b/eng/req/howto.rst index 0de3c01..688f693 100644 --- a/eng/req/howto.rst +++ b/eng/req/howto.rst @@ -1127,6 +1127,65 @@ the following

Re: bsps/xilinx-zynqmp : Add BSP for RPU

This looks exciting. As for Versal support from Xilinx's Docs "RPU The real-time processing unit (RPU) Arm Cortex-R5F processor has faster clocking frequencies than the Zynq UltraScale+ MPSoC. The Versal Arm Cortex-R5F processor supports Vector Floating-Point v3 (VFPv3) whereas the Zynq