[PATCH] build: Remove enabled-by special case

2023-09-18 Thread Sebastian Huber
Doing the enabled-by processing just for the ldflags and just for the link custom commands is confusing. Use an option instead which is intended to be used for such use cases. --- spec/build/testsuites/libtests/dl07.yml | 4 +--- spec/build/testsuites/libtests/dl08.yml | 4 +--- spe

Re: [rtems commit] libdl: Add support to import base image TLS symbols

2023-09-18 Thread Sebastian Huber
On 17.09.23 00:58, Chris Johns wrote: There are also no test cases for this function. Without test cases it is easy to break something without knowing it. The libdl test cases have been updated to reference TLS newlib variables to test this. Is that enough? If not what would you like to see? T

Re: [rtems commit] libdl: Add support to import base image TLS symbols

2023-09-18 Thread Chris Johns
On 18/9/2023 10:09 pm, Sebastian Huber wrote: > On 17.09.23 00:58, Chris Johns wrote: >>> There are also no test cases for this function. >>> Without test cases it is easy to break something without knowing it. >> The libdl test cases have been updated to reference TLS newlib variables to >> test

Re: [PATCH] build: Remove enabled-by special case

2023-09-18 Thread Chris Johns
Looks good. Thanks Chris On 18/9/2023 8:26 pm, Sebastian Huber wrote: > Doing the enabled-by processing just for the ldflags and just for the > link custom commands is confusing. Use an option instead which is > intended to be used for such use cases. > --- > spec/build/testsuites/libtests/dl07