Re: [PATCH] Added Getentropy() support to beagle BSP

Hello Udit, Now I think you should re-send this patch as a separate submission. In this case, it would also be a good idea to tag it as "v2". You can use for this the "-v 2" command line argument to git-format-patch, and then git-send-email on the output file(s). Probably, you may want to resend

Re: [PATCH] Added Getentropy() support to beagle BSP

Patch for BBB: >From a6b3b58a38a6925bf26b6573f36fc652708f9f32 Mon Sep 17 00:00:00 2001 From: Udit agarwal Date: Fri, 16 Mar 2018 15:37:05 +0530 Subject: [PATCH] arm/beagle: add TRNG based getentropy implementation --- bsps/arm/include/libcpu/am335x.h |

Re: [PATCH] Added Getentropy() support to beagle BSP

Thanks for pointing that out, I have rectified the indentation errors. Here's the patch for atsam: >From 8e5e17525a76e68bc4d869d0af9700aaa5628483 Mon Sep 17 00:00:00 2001 From: Udit agarwal Date: Fri, 16 Mar 2018 14:54:53 +0530 Subject: [PATCH] arm/atsam: protect

Re: [PATCH] Added Getentropy() support to beagle BSP

On Thu, Mar 15, 2018 at 7:00 AM, Udit agarwal wrote: > > > On Thu, Mar 15, 2018 at 2:38 PM, Sebastian Huber > wrote: >> >> On 15/03/18 09:20, Udit agarwal wrote: >>> >>> Also, will it be ok to keep atsam_trng_mutex even after user has

Re: [PATCH] Added Getentropy() support to beagle BSP

On Thu, Mar 15, 2018 at 2:38 PM, Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 15/03/18 09:20, Udit agarwal wrote: > >> Also, will it be ok to keep atsam_trng_mutex even after user has finished >> using getentropy() i.e when we don't use destroy(_trng_mutex) at all? >> > > Why

Re: [PATCH] Added Getentropy() support to beagle BSP

On 15/03/18 09:20, Udit agarwal wrote: Also, will it be ok to keep atsam_trng_mutex even after user has finished using getentropy() i.e when we don't use destroy(_trng_mutex) at all? Why do you want to destroy the mutex? -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4,

Re: [PATCH] Added Getentropy() support to beagle BSP

On Thu, Mar 15, 2018 at 1:19 PM, Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 15/03/18 08:13, Udit agarwal wrote: > >> Oh yes, i think i misinterpreted your previous suggestion of surrounding >> the while loop by mutex, it should be the outer while loop. some thing like >>

Re: [PATCH] Added Getentropy() support to beagle BSP

On 15/03/18 08:13, Udit agarwal wrote: Oh yes, i think i misinterpreted your previous suggestion of surrounding the while loop by mutex, it should be the outer while loop. some thing like this?: while (n > 0) {         uint32_t random;         size_t copy;        

Re: [PATCH] Added Getentropy() support to beagle BSP

On Thu, Mar 15, 2018 at 11:34 AM, Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > > > On 15/03/18 05:56, Udit agarwal wrote: > >> +/* TRNG Register */ >> + >> +/* RNG base address */ >> > > Is the module name TRNG or RNG? > It's TRNG. I'll correct this. > > +#define RNG_BASE

Re: [PATCH] Added Getentropy() support to beagle BSP

On Thu, Mar 15, 2018 at 11:29 AM, Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > > > On 15/03/18 05:56, Udit agarwal wrote: > >> c/src/lib/libbsp/arm/atsam/startup/getentropy-trng.c | 6 ++ >> 1 file changed, 6 insertions(+) >> >> diff --git

Re: [PATCH] Added Getentropy() support to beagle BSP

On 15/03/18 05:56, Udit agarwal wrote: +/* TRNG Register */ + +/* RNG base address */ Is the module name TRNG or RNG? +#define RNG_BASE 0x4831 +/* RNG clock control */ +#define CM_PER_RNG_CLKCTRL (AM335X_CM_PER_ADDR | (9 << 4)) This define is probably not for the TRNG register block.

Re: [PATCH] Added Getentropy() support to beagle BSP

On 15/03/18 05:56, Udit agarwal wrote:  c/src/lib/libbsp/arm/atsam/startup/getentropy-trng.c | 6 ++  1 file changed, 6 insertions(+) diff --git a/c/src/lib/libbsp/arm/atsam/startup/getentropy-trng.c b/c/src/lib/libbsp/arm/atsam/startup/getentropy-trng.c index 11e24dc..b26b6a8 100644 ---

Re: [PATCH] Added Getentropy() support to beagle BSP

ep 17 00:00:00 2001 From: Udit agarwal <dev.mada...@gmail.com> Date: Thu, 15 Mar 2018 09:24:35 +0530 Subject: [PATCH] Added getentropy support to beagle BSP --- bsps/arm/include/libcpu/am335x.h | 33 ++ c/src/lib/libbsp/arm/beagle/Makefile.am | 4 +- c/src/lib/

Fwd: Re: [PATCH] Added Getentropy() support to beagle BSP

; > > > > > > > > > > On Mar 13, 2018 1:31 AM, "Sebastian Huber" > > <sebastian.hu...@embedded-brains.de> wrote: > > > > > > > > On 12/03/18 20:02, Udit agarwal wrote: > > > > So, It looks like here's the

Re: [PATCH] Added Getentropy() support to beagle BSP

c6081 Mon Sep 17 00:00:00 2001 From: Udit agarwal <dev.mada...@gmail.com <mailto:dev.mada...@gmail.com> <mailto:dev.mada...@gmail.com <mailto:dev.mada...@gmail.com>>> Date: Tue, 13 Mar 2018 00:20:28 +0530

Re: [PATCH] Added Getentropy() support to beagle BSP

> From: Udit agarwal <dev.mada...@gmail.com <mailto:dev.mada...@gmail.com>> >> >> Date: Tue, 13 Mar 2018 00:20:28 +0530 >> Subject: [PATCH] Added Getentropy() support to beagle BSP >> >> --- >> bsps/arm/include/libcpu/am335x.h | 37 +++

Re: [PATCH] Added Getentropy() support to beagle BSP

ts this > patch before pushing(Although i have done that once). > > Thanks, > Udit agarwal > > > From 454a8ff3e0ea3393818859874705a54b098c6081 Mon Sep 17 00:00:00 2001 > From: Udit agarwal <dev.mada...@gmail.com <mailto:dev.mada...@gmail.com>> > > Date: Tue

Re: [PATCH] Added Getentropy() support to beagle BSP

7b8e37330544b Mon Sep 17 00:00:00 2001 > From: Udit agarwal <dev.mada...@gmail.com <mailto:dev.mada...@gmail.com>> > Date: Tue, 13 Mar 2018 15:50:43 +0530 > Subject: [PATCH] Added getentropy support to Beagle BSP > > --- >  bsps/arm/include/libcpu/am335x.h | 

Re: [PATCH] Added Getentropy() support to beagle BSP

r 2018 15:50:43 +0530 Subject: [PATCH] Added getentropy support to Beagle BSP --- bsps/arm/include/libcpu/am335x.h | 33 +++ c/src/lib/libbsp/arm/beagle/Makefile.am | 4 +- c/src/lib/libbsp/arm/beagle/dev/bbb_getentropy.c | 117 +++ 3 files cha

[PATCH] Added Getentropy() support to beagle BSP

001 From: Udit agarwal <dev.mada...@gmail.com> Date: Tue, 13 Mar 2018 00:20:28 +0530 Subject: [PATCH] Added Getentropy() support to beagle BSP --- bsps/arm/include/libcpu/am335x.h | 37 ++- c/src/lib/libbsp/arm/beagle/Makefile.am| 4 +- .../libbsp/a