答复: [PATCH] modify punitvara's works on BBB i2c, and now can read the eeprom info.

2017-03-22 Thread 赵 思晨
Ben Gras 抄送: devel@rtems.org 主题: Re: [PATCH] modify punitvara's works on BBB i2c, and now can read the eeprom info. On Tue, Mar 21, 2017 at 12:12 AM, Ben Gras wrote: > Dear all, > > SZ, great initiative. Gedare and Sebastian have commented. > > For my part, can I just check - th

Re: [PATCH] modify punitvara's works on BBB i2c, and now can read the eeprom info.

2017-03-21 Thread Gedare Bloom
On Tue, Mar 21, 2017 at 12:12 AM, Ben Gras wrote: > Dear all, > > SZ, great initiative. Gedare and Sebastian have commented. > > For my part, can I just check - the implementation is supposed to be > generic to i2c devices, correct? > > If so, can you explain what read_eeprom is for? Is it just as

答复: [PATCH] modify punitvara's works on BBB i2c, and now can read the eeprom info.

2017-03-20 Thread 赵 思晨
boutlook> 发件人: devel 代表 Ben Gras 发送时间: 2017年3月21日 12:12:42 收件人: devel@rtems.org; 1473996...@qq.com 主题: Re: [PATCH] modify punitvara's works on BBB i2c, and now can read the eeprom info. Dear all, SZ, great initiative. Gedare and Sebastian have commented. For my part, can I

Re: [PATCH] modify punitvara's works on BBB i2c, and now can read the eeprom info.

2017-03-20 Thread Ben Gras
Dear all, SZ, great initiative. Gedare and Sebastian have commented. For my part, can I just check - the implementation is supposed to be generic to i2c devices, correct? If so, can you explain what read_eeprom is for? Is it just as demo? Is the code generic otherwise? Cheers, Ben On 03/14/2

Re: [PATCH] modify punitvara's works on BBB i2c, and now can read the eeprom info.

2017-03-14 Thread Gedare Bloom
We eventually need all of the combined patches at once in order to merge. If this is functionally working, then it is time to focus on cleaning up. It would be good to separate the testsuite change from the others. I'm not sure the testsuite is mergeable. It would also be best to separate the eep

Re: [PATCH] modify punitvara's works on BBB i2c, and now can read the eeprom info.

2017-03-14 Thread Sebastian Huber
On 14/03/17 15:05, Sichen Zhao wrote: --- c/src/lib/libbsp/arm/beagle/i2c/bbb-i2c.c | 684 -- c/src/lib/libbsp/arm/beagle/include/i2c.h | 18 +- cpukit/dev/i2c/eeprom.c | 24 +- What is the problem with the generic EEPROM driver? testsuit

[PATCH] modify punitvara's works on BBB i2c, and now can read the eeprom info.

2017-03-14 Thread Sichen Zhao
--- c/src/lib/libbsp/arm/beagle/i2c/bbb-i2c.c | 684 -- c/src/lib/libbsp/arm/beagle/include/i2c.h | 18 +- cpukit/dev/i2c/eeprom.c | 24 +- testsuites/samples/i2c0/init.c| 98 - 4 files changed, 777 insertions(+), 47 deletions(-) di